)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"b85e2abcc7e2cc1eef5137e95b8ce55632e331f0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4bd7050f_ed798f55","updated":"2023-11-19 09:39:21.000000000","message":"Can you add something about the motivation to this commit message?","commit_id":"50fdb8e2aafc46d8a16f131e0972f5b8332e4ede"},{"author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"change_message_id":"7d461a2d959d40003c8316894752441498442c0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4ed020af_33230b6f","in_reply_to":"4bd7050f_ed798f55","updated":"2023-11-25 03:03:29.000000000","message":"Done","commit_id":"50fdb8e2aafc46d8a16f131e0972f5b8332e4ede"}],"tvix/eval/src/value/thunk.rs":[{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"b85e2abcc7e2cc1eef5137e95b8ce55632e331f0","unresolved":true,"context_lines":[{"line_number":79,"context_line":"        content_span: Option\u003cSpan\u003e,"},{"line_number":80,"context_line":"    },"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    // TODO(amjoseph): consider changing `Value` to `Rc\u003cValue\u003e` to avoid"},{"line_number":83,"context_line":"    // expensive clone()s in Thunk::force()."},{"line_number":84,"context_line":"    /// Fully evaluated thunk."},{"line_number":85,"context_line":"    Evaluated(Value),"},{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"ad7ce3a3_6fecc277","line":84,"range":{"start_line":82,"start_character":0,"end_line":84,"end_character":0},"updated":"2023-11-19 09:39:21.000000000","message":"or: do this after moving to mmtk, so that value clones are cheap (gc\u0027d) pointer copies","commit_id":"50fdb8e2aafc46d8a16f131e0972f5b8332e4ede"},{"author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"change_message_id":"8f0988a80739f5048987030b50bd355dbebb2b3c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        content_span: Option\u003cSpan\u003e,"},{"line_number":80,"context_line":"    },"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    // TODO(amjoseph): consider changing `Value` to `Rc\u003cValue\u003e` to avoid"},{"line_number":83,"context_line":"    // expensive clone()s in Thunk::force()."},{"line_number":84,"context_line":"    /// Fully evaluated thunk."},{"line_number":85,"context_line":"    Evaluated(Value),"},{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"94dee2a6_035df59b","line":84,"range":{"start_line":82,"start_character":0,"end_line":84,"end_character":0},"in_reply_to":"2ae66c08_629d9902","updated":"2023-11-25 05:57:03.000000000","message":"Acknowledged","commit_id":"50fdb8e2aafc46d8a16f131e0972f5b8332e4ede"},{"author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"change_message_id":"7d461a2d959d40003c8316894752441498442c0a","unresolved":true,"context_lines":[{"line_number":79,"context_line":"        content_span: Option\u003cSpan\u003e,"},{"line_number":80,"context_line":"    },"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    // TODO(amjoseph): consider changing `Value` to `Rc\u003cValue\u003e` to avoid"},{"line_number":83,"context_line":"    // expensive clone()s in Thunk::force()."},{"line_number":84,"context_line":"    /// Fully evaluated thunk."},{"line_number":85,"context_line":"    Evaluated(Value),"},{"line_number":86,"context_line":"}"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"2ae66c08_629d9902","line":84,"range":{"start_line":82,"start_character":0,"end_line":84,"end_character":0},"in_reply_to":"ad7ce3a3_6fecc277","updated":"2023-11-25 03:03:29.000000000","message":"Well, surely mmtk has its own Rc-like wrapper.\n\nI tried looking for the name of this trait/struct in the mmtk crate documentation but got lost in the maze.  Quite a complex piece of machinery.","commit_id":"50fdb8e2aafc46d8a16f131e0972f5b8332e4ede"}]}