)]}'
{"id":"depot~10087","triplet_id":"depot~canon~I3261bf0efe3480b5b315074efafcf5e47a6c5a65","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000005":{"account":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"last_update":"2023-11-19 09:53:10.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2023-11-19 09:42:45.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I3261bf0efe3480b5b315074efafcf5e47a6c5a65","subject":"fix(nix-compat/store_path): valid names ⊊ UTF-8","status":"MERGED","created":"2023-11-19 05:58:48.000000000","updated":"2023-11-19 09:53:10.000000000","submitted":"2023-11-19 09:53:10.000000000","submitter":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10089","meta_rev_id":"ee5e56889eaa4d1fc20637bf02eb7cbcadd672bd","_number":10087,"virtual_id_number":10087,"owner":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-11-19 09:53:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-11-19 09:53:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-19 09:53:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-19 05:58:48.000000000","updated_by":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2023-11-19 05:58:48.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-11-19 06:03:02.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-11-19 09:45:14.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"}],"messages":[{"id":"6937afca94ee82407dc05c3f3cf5bbb0504dc913","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2023-11-19 05:58:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b9cbbbf89911cd4783f729b9015b841d82f76ceb","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2023-11-19 05:58:48.000000000","message":"\u003cGERRIT_ACCOUNT_1000036\u003e, who was added as reviewer owns the following files:\n* `tvix/nix-compat/src/store_path/mod.rs`\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":1},{"id":"c8853986879659a7fa73c46ae971b6f4785018d8","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-11-19 05:58:48.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/28250","accounts_in_message":[],"_revision_number":1},{"id":"ce609f3e85f575fdb428852c9d828ce2e68607da","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-11-19 06:03:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/28250","accounts_in_message":[],"_revision_number":1},{"id":"7279f179e5f056238b7d624b4d010b81be762718","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-11-19 09:42:45.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"0ae97eaaf72ea526e6da1391ad624060d7d941e0","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-11-19 09:45:14.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ee5e56889eaa4d1fc20637bf02eb7cbcadd672bd","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2023-11-19 09:53:10.000000000","message":"Change has been successfully rebased and submitted as 2eaee1d48e59e2a2c75493289e5e09aa14726f17","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2eaee1d48e59e2a2c75493289e5e09aa14726f17","revisions":{"a3ec30bfd92ca59b07ea50636c31888099ace51e":{"kind":"REWORK","_number":1,"created":"2023-11-19 05:58:48.000000000","uploader":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"ref":"refs/changes/87/10087/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/87/10087/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/87/10087/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/87/10087/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/87/10087/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/87/10087/1"}}},"commit":{"parents":[{"commit":"8beb38b50c135991a15958716612463cc78b87ca","subject":"refactor(tvix/store/fs): simpllify read","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8beb38b50c135991a15958716612463cc78b87ca"}]}],"author":{"name":"edef","email":"edef@edef.eu","date":"2023-11-19 05:55:51.000000000","tz":0},"committer":{"name":"edef","email":"edef@edef.eu","date":"2023-11-19 05:58:37.000000000","tz":0},"subject":"fix(nix-compat/store_path): valid names ⊊ UTF-8","message":"fix(nix-compat/store_path): valid names ⊊ UTF-8\n\nWe don\u0027t need to validate UTF-8 separately, since valid names are\na strict subset of ASCII, and therefore a strict subset of UTF-8.\n\nChange-Id: I3261bf0efe3480b5b315074efafcf5e47a6c5a65\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da3ec30bfd92ca59b07ea50636c31888099ace51e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da3ec30bfd92ca59b07ea50636c31888099ace51e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8beb38b50c135991a15958716612463cc78b87ca","is_merged_in_target_branch":true,"change_id":"I0fbda74e4fb98ffeababae86a325233416029acf","change_number":10072,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"2eaee1d48e59e2a2c75493289e5e09aa14726f17":{"kind":"REWORK","_number":2,"created":"2023-11-19 09:53:10.000000000","uploader":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"ref":"refs/changes/87/10087/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/87/10087/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/87/10087/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/87/10087/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/87/10087/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/87/10087/2"}}},"commit":{"parents":[{"commit":"9ad7cc629e20e4cdb5420e20addae8909e83d610","subject":"fix(tvix): patch futures::AsyncBufReadExt::fill_buf","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9ad7cc629e20e4cdb5420e20addae8909e83d610"}]}],"author":{"name":"edef","email":"edef@edef.eu","date":"2023-11-19 05:55:51.000000000","tz":0},"committer":{"name":"edef","email":"edef@edef.eu","date":"2023-11-19 09:53:10.000000000","tz":0},"subject":"fix(nix-compat/store_path): valid names ⊊ UTF-8","message":"fix(nix-compat/store_path): valid names ⊊ UTF-8\n\nWe don\u0027t need to validate UTF-8 separately, since valid names are\na strict subset of ASCII, and therefore a strict subset of UTF-8.\n\nChange-Id: I3261bf0efe3480b5b315074efafcf5e47a6c5a65\nReviewed-on: https://cl.tvl.fyi/c/depot/+/10087\nTested-by: BuildkiteCI\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2eaee1d48e59e2a2c75493289e5e09aa14726f17"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2eaee1d48e59e2a2c75493289e5e09aa14726f17"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"9ad7cc629e20e4cdb5420e20addae8909e83d610","is_merged_in_target_branch":true,"change_id":"Ie98ca6a3e1de38500b0195e9b62511501acb1d2c","change_number":10086,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}
