)]}'
{"id":"depot~10088","triplet_id":"depot~canon~I7f65880a41b1d6b5e6bf2e52dfe47d4c49b34bcd","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000005":{"account":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"last_update":"2023-11-19 09:53:10.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2023-11-19 09:45:05.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I7f65880a41b1d6b5e6bf2e52dfe47d4c49b34bcd","subject":"fix(nix-compat/nar/reader): require BufRead","status":"MERGED","created":"2023-11-19 07:12:32.000000000","updated":"2023-11-19 09:53:10.000000000","submitted":"2023-11-19 09:53:10.000000000","submitter":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10089","meta_rev_id":"e8a9cce78ed424a9c4443efb12501846249f8bb4","_number":10088,"virtual_id_number":10088,"owner":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-11-19 09:53:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-19 09:53:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-19 07:12:32.000000000","updated_by":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2023-11-19 07:12:33.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-11-19 07:17:11.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"30062acc1827a4689ce8fa3adfe665c2818cdff7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2023-11-19 07:12:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"37adbb88f3af77d74576a5ff2cdb690cda967176","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2023-11-19 07:12:32.000000000","message":"\u003cGERRIT_ACCOUNT_1000036\u003e, who was added as reviewer owns the following files:\n* `tvix/nix-compat/src/nar/reader/mod.rs`\n* `tvix/store/src/nar/import.rs`\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":1},{"id":"52c8fe2db95c8c067663af97702ec6f1d3149269","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-11-19 07:12:33.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/28251","accounts_in_message":[],"_revision_number":1},{"id":"a08c1920594f7d207a86896375f03e499c26bc46","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-11-19 07:17:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/28251","accounts_in_message":[],"_revision_number":1},{"id":"42375ea2980fb922df76d01eee560b78987a1edc","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-11-19 09:45:05.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e8a9cce78ed424a9c4443efb12501846249f8bb4","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2023-11-19 09:53:10.000000000","message":"Change has been successfully rebased and submitted as 785ff80c8b8adad22927eee3a0c9c7aaa60072b3","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"785ff80c8b8adad22927eee3a0c9c7aaa60072b3","revisions":{"3ad821b201facf8a8c0e94606a665e0e4ef57e90":{"kind":"REWORK","_number":1,"created":"2023-11-19 07:12:32.000000000","uploader":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"ref":"refs/changes/88/10088/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/88/10088/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10088/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10088/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10088/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/88/10088/1"}}},"commit":{"parents":[{"commit":"a3ec30bfd92ca59b07ea50636c31888099ace51e","subject":"fix(nix-compat/store_path): valid names ⊊ UTF-8","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da3ec30bfd92ca59b07ea50636c31888099ace51e"}]}],"author":{"name":"edef","email":"edef@edef.eu","date":"2023-11-19 06:24:50.000000000","tz":0},"committer":{"name":"edef","email":"edef@edef.eu","date":"2023-11-19 07:08:09.000000000","tz":0},"subject":"fix(nix-compat/nar/reader): require BufRead","message":"fix(nix-compat/nar/reader): require BufRead\n\nWe rely on being able to make small reads cheaply, so this was already\nan implicit practical requirement. Requiring it explicitly removes a\nperformance footgun, and makes further optimisations possible.\n\nChange-Id: I7f65880a41b1d6b5e6bf2e52dfe47d4c49b34bcd\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3ad821b201facf8a8c0e94606a665e0e4ef57e90"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3ad821b201facf8a8c0e94606a665e0e4ef57e90"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a3ec30bfd92ca59b07ea50636c31888099ace51e","is_merged_in_target_branch":false,"change_id":"I3261bf0efe3480b5b315074efafcf5e47a6c5a65","change_number":10087,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"785ff80c8b8adad22927eee3a0c9c7aaa60072b3":{"kind":"REWORK","_number":2,"created":"2023-11-19 09:53:10.000000000","uploader":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"ref":"refs/changes/88/10088/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/88/10088/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10088/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10088/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10088/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/88/10088/2"}}},"commit":{"parents":[{"commit":"2eaee1d48e59e2a2c75493289e5e09aa14726f17","subject":"fix(nix-compat/store_path): valid names ⊊ UTF-8","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2eaee1d48e59e2a2c75493289e5e09aa14726f17"}]}],"author":{"name":"edef","email":"edef@edef.eu","date":"2023-11-19 06:24:50.000000000","tz":0},"committer":{"name":"edef","email":"edef@edef.eu","date":"2023-11-19 09:53:10.000000000","tz":0},"subject":"fix(nix-compat/nar/reader): require BufRead","message":"fix(nix-compat/nar/reader): require BufRead\n\nWe rely on being able to make small reads cheaply, so this was already\nan implicit practical requirement. Requiring it explicitly removes a\nperformance footgun, and makes further optimisations possible.\n\nChange-Id: I7f65880a41b1d6b5e6bf2e52dfe47d4c49b34bcd\nReviewed-on: https://cl.tvl.fyi/c/depot/+/10088\nTested-by: BuildkiteCI\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d785ff80c8b8adad22927eee3a0c9c7aaa60072b3"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d785ff80c8b8adad22927eee3a0c9c7aaa60072b3"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2eaee1d48e59e2a2c75493289e5e09aa14726f17","is_merged_in_target_branch":true,"change_id":"I3261bf0efe3480b5b315074efafcf5e47a6c5a65","change_number":10087,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}