)]}'
{"tvix/store/src/pathinfoservice/nix_http.rs":[{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"d403067f7b465f8c2c6a5a4bcf17eda9771e6d7d","unresolved":true,"context_lines":[{"line_number":186,"context_line":"            Ok((root_node, nar_hash, nar_size)) \u003d\u003e {"},{"line_number":187,"context_line":"                // ensure the ingested narhash and narsize do actually match."},{"line_number":188,"context_line":"                if narinfo.nar_size !\u003d nar_size {"},{"line_number":189,"context_line":"                    warn!("},{"line_number":190,"context_line":"                        narinfo.nar_size \u003d narinfo.nar_size,"},{"line_number":191,"context_line":"                        http.nar_size \u003d nar_size,"},{"line_number":192,"context_line":"                        \"NARSize mismatch\""},{"line_number":193,"context_line":"                    );"},{"line_number":194,"context_line":"                    Err(io::Error::new("},{"line_number":195,"context_line":"                        io::ErrorKind::InvalidData,"},{"line_number":196,"context_line":"                        \"NarSize mismatch\".to_string(),"},{"line_number":197,"context_line":"                    ))?;"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"ab80d2fa_adfb784e","line":194,"range":{"start_line":189,"start_character":0,"end_line":194,"end_character":0},"updated":"2023-11-28 15:04:23.000000000","message":"2 questions:\n\n- Are they warnings, or are they errors?\n- Can we log these somewhere more centrally instead of duplicating this noisily?","commit_id":"74c3bdd39d8aa757e58a5adeb961abdec7e314bc"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"2fa912e42c681b9a254e88fbdcb8da765cfad4ab","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            Ok((root_node, nar_hash, nar_size)) \u003d\u003e {"},{"line_number":187,"context_line":"                // ensure the ingested narhash and narsize do actually match."},{"line_number":188,"context_line":"                if narinfo.nar_size !\u003d nar_size {"},{"line_number":189,"context_line":"                    warn!("},{"line_number":190,"context_line":"                        narinfo.nar_size \u003d narinfo.nar_size,"},{"line_number":191,"context_line":"                        http.nar_size \u003d nar_size,"},{"line_number":192,"context_line":"                        \"NARSize mismatch\""},{"line_number":193,"context_line":"                    );"},{"line_number":194,"context_line":"                    Err(io::Error::new("},{"line_number":195,"context_line":"                        io::ErrorKind::InvalidData,"},{"line_number":196,"context_line":"                        \"NarSize mismatch\".to_string(),"},{"line_number":197,"context_line":"                    ))?;"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"fb44c533_160d24f1","line":194,"range":{"start_line":189,"start_character":0,"end_line":194,"end_character":0},"in_reply_to":"ab80d2fa_adfb784e","updated":"2023-11-28 16:01:17.000000000","message":"This is causing an erroneous reponse to a client, but it\u0027s not that went wrong /on this machine/. It encountered inconsistent data on the other side.\n\nI like to annotate some structured data, in this case actual nar_size (or nar_hash) in the error message logged to the console, but some of the structured fields might be more sensitive than others and should not be contained in returned error messages.\n\nError handling is a bit of a mess, I\u0027ve been starting to move some of these errors to io::Error, but it probably makes sense to have a followup discussion about the error system.","commit_id":"74c3bdd39d8aa757e58a5adeb961abdec7e314bc"}]}