)]}'
{"id":"depot~10148","triplet_id":"depot~canon~I68c60ecfaf0f9cd5edacea648437ecb0c9729251","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2023-11-28 15:04:23.000000000","reason":"removed on reply"},"1000005":{"account":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"last_update":"2023-11-28 16:08:59.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2023-11-28 16:01:17.000000000","reason":"\u003cGERRIT_ACCOUNT_1000036\u003e replied on the change","reason_account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2023-11-28 16:08:59.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I68c60ecfaf0f9cd5edacea648437ecb0c9729251","subject":"feat(tvix/store/pathinfosvc/nix_http): check Nar{Size,Hash} matches","status":"MERGED","created":"2023-11-27 18:54:00.000000000","updated":"2023-11-28 16:08:59.000000000","submitted":"2023-11-28 16:08:59.000000000","submitter":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10155","meta_rev_id":"80b43c1355c782c600ad77d13372c1c9110b169d","_number":10148,"virtual_id_number":10148,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-11-28 16:08:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-11-28 16:08:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-11-27 18:54:00.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"state":"REVIEWER"},{"updated":"2023-11-27 18:54:00.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2023-11-27 18:54:01.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-11-27 18:58:49.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-11-28 14:56:52.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"}],"messages":[{"id":"f8cd35868f5ea205c91cc7acfb42cc955bf5f279","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-11-27 18:54:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"71f7e21232fd298c85af93b1eee9a0b8c583fe4c","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-11-27 18:54:01.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/28410","accounts_in_message":[],"_revision_number":1},{"id":"2728a089223b4e69f7f3871f56a2ebd879005889","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-11-27 18:58:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/28410","accounts_in_message":[],"_revision_number":1},{"id":"3752c08bd2a304c7d670085117a809e470b6b7bc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-11-28 14:56:52.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"75c92bd283841a007b927afc65074f4b474d5b41","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-11-28 14:56:52.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* `tvix/store/src/pathinfoservice/nix_http.rs`\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":2},{"id":"a0414b59e6ed50da6d8a10793698311cf77dc34e","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-11-28 14:56:54.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/28436","accounts_in_message":[],"_revision_number":2},{"id":"cdd904ba10a9386a64f36c6b24ff07ae8acc8eb3","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-11-28 15:01:28.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/28436","accounts_in_message":[],"_revision_number":2},{"id":"d403067f7b465f8c2c6a5a4bcf17eda9771e6d7d","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-11-28 15:04:23.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2fa912e42c681b9a254e88fbdcb8da765cfad4ab","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-11-28 16:01:17.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"80b43c1355c782c600ad77d13372c1c9110b169d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-11-28 16:08:59.000000000","message":"Change has been successfully rebased and submitted as 7e8719be9146ed370038cb51a87c53ebea388ec3","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"7e8719be9146ed370038cb51a87c53ebea388ec3","revisions":{"e6174d237e14c6ee4bbb61e987921ac8d7c1bca2":{"kind":"REWORK","_number":1,"created":"2023-11-27 18:54:00.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/48/10148/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/48/10148/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/48/10148/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/48/10148/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/48/10148/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/48/10148/1"}}},"commit":{"parents":[{"commit":"0415bc6fd26ba5a20f81e2327305dc0ebfceb3b9","subject":"fix(nix-compat/narinfo/signature): validate name field","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0415bc6fd26ba5a20f81e2327305dc0ebfceb3b9"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-11-27 17:43:27.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-11-27 17:45:55.000000000","tz":120},"subject":"feat(tvix/store/pathinfosvc/nix_http): check Nar{Size,Hash} matches","message":"feat(tvix/store/pathinfosvc/nix_http): check Nar{Size,Hash} matches\n\nEnsure the initially communicated NarHash/NarSize from the NarInfo\nmatches what we read, and don\u0027t return a PathInfo message if there\u0027s\na mismatch.\n\nAlso move the buffering layer around a bit.\n\nChange-Id: I68c60ecfaf0f9cd5edacea648437ecb0c9729251\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de6174d237e14c6ee4bbb61e987921ac8d7c1bca2"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de6174d237e14c6ee4bbb61e987921ac8d7c1bca2"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"0415bc6fd26ba5a20f81e2327305dc0ebfceb3b9","is_merged_in_target_branch":true,"change_id":"I1357e79e553f2df2fa97792889f63f0f35d50ed5","change_number":10147,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"74c3bdd39d8aa757e58a5adeb961abdec7e314bc":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-11-28 14:56:52.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/48/10148/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/48/10148/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/48/10148/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/48/10148/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/48/10148/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/48/10148/2"}}},"commit":{"parents":[{"commit":"fce9c0e99ef219a97bd8ba14cf0eed6c998a1c80","subject":"fix(tvix/store/fs): don\u0027t panic on PathInfoService error","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfce9c0e99ef219a97bd8ba14cf0eed6c998a1c80"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-11-27 17:43:27.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-11-28 14:55:03.000000000","tz":120},"subject":"feat(tvix/store/pathinfosvc/nix_http): check Nar{Size,Hash} matches","message":"feat(tvix/store/pathinfosvc/nix_http): check Nar{Size,Hash} matches\n\nEnsure the initially communicated NarHash/NarSize from the NarInfo\nmatches what we read, and don\u0027t return a PathInfo message if there\u0027s\na mismatch.\n\nAlso move the buffering layer around a bit.\n\nChange-Id: I68c60ecfaf0f9cd5edacea648437ecb0c9729251\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d74c3bdd39d8aa757e58a5adeb961abdec7e314bc"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d74c3bdd39d8aa757e58a5adeb961abdec7e314bc"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"fce9c0e99ef219a97bd8ba14cf0eed6c998a1c80","is_merged_in_target_branch":true,"change_id":"I2daeae629e1627d06adcd7b82ddb76c50c602212","change_number":10154,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"7e8719be9146ed370038cb51a87c53ebea388ec3":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2023-11-28 16:08:59.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/48/10148/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/48/10148/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/48/10148/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/48/10148/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/48/10148/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/48/10148/3"}}},"commit":{"parents":[{"commit":"fce9c0e99ef219a97bd8ba14cf0eed6c998a1c80","subject":"fix(tvix/store/fs): don\u0027t panic on PathInfoService error","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfce9c0e99ef219a97bd8ba14cf0eed6c998a1c80"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-11-27 17:43:27.000000000","tz":120},"committer":{"name":"flokli","email":"flokli@flokli.de","date":"2023-11-28 16:08:59.000000000","tz":0},"subject":"feat(tvix/store/pathinfosvc/nix_http): check Nar{Size,Hash} matches","message":"feat(tvix/store/pathinfosvc/nix_http): check Nar{Size,Hash} matches\n\nEnsure the initially communicated NarHash/NarSize from the NarInfo\nmatches what we read, and don\u0027t return a PathInfo message if there\u0027s\na mismatch.\n\nAlso move the buffering layer around a bit.\n\nChange-Id: I68c60ecfaf0f9cd5edacea648437ecb0c9729251\nReviewed-on: https://cl.tvl.fyi/c/depot/+/10148\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7e8719be9146ed370038cb51a87c53ebea388ec3"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7e8719be9146ed370038cb51a87c53ebea388ec3"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"fce9c0e99ef219a97bd8ba14cf0eed6c998a1c80","is_merged_in_target_branch":true,"change_id":"I2daeae629e1627d06adcd7b82ddb76c50c602212","change_number":10154,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}