)]}'
{"id":"depot~10221","triplet_id":"depot~canon~I6b0283a40f228ecf9a6398d24c060bdacb1077cf","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000066":{"account":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"last_update":"2023-12-12 14:26:46.000000000","reason":"Change was submitted"},"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2023-12-12 14:26:46.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2023-12-09 11:34:14.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I6b0283a40f228ecf9a6398d24c060bdacb1077cf","subject":"fix(tvix/eval): preserve catchables in nix_cmp_ordering(), fix b/338","status":"MERGED","created":"2023-12-09 09:01:17.000000000","updated":"2023-12-12 14:26:46.000000000","submitted":"2023-12-12 14:26:46.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10221","meta_rev_id":"8079e77b296511e4a344d6ff98d81ec8e5f63da1","_number":10221,"virtual_id_number":10221,"owner":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-12-12 14:26:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-12-12 14:26:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-12-12 14:26:46.000000000","_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-12-09 09:01:22.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-12-09 09:03:29.000000000","updated_by":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"reviewer":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"state":"REVIEWER"},{"updated":"2023-12-09 09:03:29.000000000","updated_by":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2023-12-09 09:09:22.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-12-12 14:26:46.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"65f86127ec84c44bf48afadf824861f078930ed6","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-09 09:01:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"28e4918aab35932f323b785e20d795144b0daf4d","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-09 09:01:22.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/28650","accounts_in_message":[],"_revision_number":1},{"id":"e67e93769b6b2aff62e173311c8a662bd691d231","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-09 09:03:29.000000000","message":"Patch Set 1: Autosubmit+1\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":1},{"id":"780c6035de93e0397f44950e3930cf314d298eff","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-09 09:03:29.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* `tvix/eval/src/builtins/mod.rs`\n* `tvix/eval/src/tests/tvix_tests/eval-okay-compare-ordering-catchable.exp`\n* `tvix/eval/src/tests/tvix_tests/eval-okay-compare-ordering-catchable.nix`\n* `tvix/eval/src/tests/tvix_tests/notyetpassing/eval-okay-compare-ordering-catchable.exp`\n* `tvix/eval/src/tests/tvix_tests/notyetpassing/eval-okay-compare-ordering-catchable.nix`\n* `tvix/eval/src/value/mod.rs`\n* `tvix/eval/src/vm/macros.rs`\n\n\u003cGERRIT_ACCOUNT_1000034\u003e, who was added as reviewer owns the following files:\n* `tvix/eval/src/builtins/mod.rs`\n* `tvix/eval/src/tests/tvix_tests/eval-okay-compare-ordering-catchable.exp`\n* `tvix/eval/src/tests/tvix_tests/eval-okay-compare-ordering-catchable.nix`\n* `tvix/eval/src/tests/tvix_tests/notyetpassing/eval-okay-compare-ordering-catchable.exp`\n* `tvix/eval/src/tests/tvix_tests/notyetpassing/eval-okay-compare-ordering-catchable.nix`\n* `tvix/eval/src/value/mod.rs`\n* `tvix/eval/src/vm/macros.rs`\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}],"_revision_number":1},{"id":"503964ef5bfe4dc936b1399fa189d99bc7268566","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-09 09:09:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/28650","accounts_in_message":[],"_revision_number":1},{"id":"1ea8ca806ad1f4368287c155087d5e8d748324a7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-09 09:15:19.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"a099e175e7d12f2db57481570259c1dafa1c2b4e","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-09 09:15:22.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/28653","accounts_in_message":[],"_revision_number":2},{"id":"09064de58b23ab84a10a70e7ee87ee1b6e53dfd9","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-09 09:19:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/28653","accounts_in_message":[],"_revision_number":2},{"id":"6a94384cf819957b8f3c24c58d10fed7e595061a","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-12-09 11:34:14.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"3677b34339b58629204e052f655deaf393302da5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-11 10:18:14.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"b423a8e450610fa4c32eefd35b6f625a0771bfc2","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-11 10:18:18.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/28758","accounts_in_message":[],"_revision_number":3},{"id":"9e77924dbdbadd11978d11c63ff6973e652bb7b7","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-11 10:30:59.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/28758","accounts_in_message":[],"_revision_number":3},{"id":"7dc4acf3dd14f4c6e41bddbab6aac3d85ff32511","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-11 10:31:47.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"aea5a72e99c149a00ed44b779fc0fa200d52fb31","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-11 10:31:51.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/28771","accounts_in_message":[],"_revision_number":4},{"id":"d04e3368d4700e8d93f4240c84f7224bb17e5a48","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-11 10:43:56.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/28771","accounts_in_message":[],"_revision_number":4},{"id":"d26221c0525f4cef257e4a0c8c80530acf7f1d2c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-12 12:04:15.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"2e35cbd7607b7827d55f22d8319a334987be559f","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 12:04:25.000000000","message":"Patch Set 5:\n\nStarted build for patchset #5 on: https://buildkite.com/tvl/depot/builds/28902","accounts_in_message":[],"_revision_number":5},{"id":"59a15b8cffb478ef2b5c0cfda353c085c2419eb5","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 12:13:35.000000000","message":"Patch Set 5: Verified+1\n\nBuild of patchset 5 passed: https://buildkite.com/tvl/depot/builds/28902","accounts_in_message":[],"_revision_number":5},{"id":"8079e77b296511e4a344d6ff98d81ec8e5f63da1","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2023-12-12 14:26:46.000000000","message":"Change has been successfully rebased and submitted as ad566999ca81e5d584acb5107e327a1aec9fdd5a\n\n2 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"ad566999ca81e5d584acb5107e327a1aec9fdd5a","revisions":{"4b19d4528ece9ad6c48e4615f12652f7e7483c7b":{"kind":"REWORK","_number":1,"created":"2023-12-09 09:01:17.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/21/10221/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/21/10221/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/21/10221/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/21/10221/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/21/10221/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/21/10221/1"}}},"commit":{"parents":[{"commit":"b7b492933a7031ebbcc0c039abeed548fafd67c6","subject":"test(tvix/eval): test for b/338 catchable hygiene problem","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db7b492933a7031ebbcc0c039abeed548fafd67c6"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-09 08:58:30.000000000","tz":-480},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-09 09:01:10.000000000","tz":-480},"subject":"fix(tvix/eval): preserve catchables in nix_cmp_ordering(), fix b/338","message":"fix(tvix/eval): preserve catchables in nix_cmp_ordering(), fix b/338\n\nThis commit fixes b/338 by properly propagating catchables through\ncomparison operations.\n\nChange-Id: I6b0283a40f228ecf9a6398d24c060bdacb1077cf\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4b19d4528ece9ad6c48e4615f12652f7e7483c7b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4b19d4528ece9ad6c48e4615f12652f7e7483c7b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b7b492933a7031ebbcc0c039abeed548fafd67c6","is_merged_in_target_branch":false,"change_id":"I69c62ed9ea5c8f81870e8de5c5fe12dcde849763","change_number":10220,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"5e35fb4e89a1149762a52e830a0180185dce6091":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-12-09 09:15:19.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/21/10221/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/21/10221/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/21/10221/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/21/10221/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/21/10221/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/21/10221/2"}}},"commit":{"parents":[{"commit":"9bed8fffa8c658be5ceed185561ca9510d489ac2","subject":"test(tvix/eval): test for b/338 catchable hygiene problem","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9bed8fffa8c658be5ceed185561ca9510d489ac2"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-09 08:58:30.000000000","tz":-480},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-09 09:15:16.000000000","tz":-480},"subject":"fix(tvix/eval): preserve catchables in nix_cmp_ordering(), fix b/338","message":"fix(tvix/eval): preserve catchables in nix_cmp_ordering(), fix b/338\n\nThis commit fixes b/338 by properly propagating catchables through\ncomparison operations.\n\nChange-Id: I6b0283a40f228ecf9a6398d24c060bdacb1077cf\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5e35fb4e89a1149762a52e830a0180185dce6091"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5e35fb4e89a1149762a52e830a0180185dce6091"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"9bed8fffa8c658be5ceed185561ca9510d489ac2","is_merged_in_target_branch":false,"change_id":"I69c62ed9ea5c8f81870e8de5c5fe12dcde849763","change_number":10220,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"3b594ed4937d0cb530be97fdb7e491f3514d5d53":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-12-11 10:18:14.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/21/10221/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/21/10221/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/21/10221/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/21/10221/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/21/10221/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/21/10221/3"}}},"commit":{"parents":[{"commit":"abfe7e636290c1870d551dfb53af4d446c9fab4c","subject":"test(tvix/eval): test for b/338 catchable hygiene problem","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dabfe7e636290c1870d551dfb53af4d446c9fab4c"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-09 08:58:30.000000000","tz":-480},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-11 10:14:46.000000000","tz":-480},"subject":"fix(tvix/eval): preserve catchables in nix_cmp_ordering(), fix b/338","message":"fix(tvix/eval): preserve catchables in nix_cmp_ordering(), fix b/338\n\nThis commit fixes b/338 by properly propagating catchables through\ncomparison operations.\n\nChange-Id: I6b0283a40f228ecf9a6398d24c060bdacb1077cf\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3b594ed4937d0cb530be97fdb7e491f3514d5d53"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3b594ed4937d0cb530be97fdb7e491f3514d5d53"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"abfe7e636290c1870d551dfb53af4d446c9fab4c","is_merged_in_target_branch":false,"change_id":"I69c62ed9ea5c8f81870e8de5c5fe12dcde849763","change_number":10220,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"31c3847a7a07dd3704e67070c097408f2eb6217d":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2023-12-11 10:31:47.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/21/10221/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/21/10221/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/21/10221/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/21/10221/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/21/10221/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/21/10221/4"}}},"commit":{"parents":[{"commit":"15afc064bbe3e5e431aa470aa26c452d0711c26e","subject":"test(tvix/eval): test for b/338 catchable hygiene problem","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d15afc064bbe3e5e431aa470aa26c452d0711c26e"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-09 08:58:30.000000000","tz":-480},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-11 10:31:56.000000000","tz":-480},"subject":"fix(tvix/eval): preserve catchables in nix_cmp_ordering(), fix b/338","message":"fix(tvix/eval): preserve catchables in nix_cmp_ordering(), fix b/338\n\nThis commit fixes b/338 by properly propagating catchables through\ncomparison operations.\n\nChange-Id: I6b0283a40f228ecf9a6398d24c060bdacb1077cf\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d31c3847a7a07dd3704e67070c097408f2eb6217d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d31c3847a7a07dd3704e67070c097408f2eb6217d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"15afc064bbe3e5e431aa470aa26c452d0711c26e","is_merged_in_target_branch":false,"change_id":"I69c62ed9ea5c8f81870e8de5c5fe12dcde849763","change_number":10220,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"819e0324e7303788de7b4fbef75e23e1fb60c108":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2023-12-12 12:04:15.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/21/10221/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/21/10221/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/21/10221/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/21/10221/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/21/10221/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/21/10221/5"}}},"commit":{"parents":[{"commit":"8b933fdabf96f445746b8873bb3a454789df3d6f","subject":"test(tvix/eval): test for b/338 catchable hygiene problem","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8b933fdabf96f445746b8873bb3a454789df3d6f"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-09 08:58:30.000000000","tz":-480},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 12:04:30.000000000","tz":-480},"subject":"fix(tvix/eval): preserve catchables in nix_cmp_ordering(), fix b/338","message":"fix(tvix/eval): preserve catchables in nix_cmp_ordering(), fix b/338\n\nThis commit fixes b/338 by properly propagating catchables through\ncomparison operations.\n\nChange-Id: I6b0283a40f228ecf9a6398d24c060bdacb1077cf\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d819e0324e7303788de7b4fbef75e23e1fb60c108"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d819e0324e7303788de7b4fbef75e23e1fb60c108"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8b933fdabf96f445746b8873bb3a454789df3d6f","is_merged_in_target_branch":false,"change_id":"I69c62ed9ea5c8f81870e8de5c5fe12dcde849763","change_number":10220,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"ad566999ca81e5d584acb5107e327a1aec9fdd5a":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2023-12-12 14:26:46.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/21/10221/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/21/10221/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/21/10221/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/21/10221/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/21/10221/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/21/10221/6"}}},"commit":{"parents":[{"commit":"ae28dc3ca64eb09d0ed792f0145576c17920ede5","subject":"test(tvix/eval): test for b/338 catchable hygiene problem","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dae28dc3ca64eb09d0ed792f0145576c17920ede5"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-09 08:58:30.000000000","tz":-480},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2023-12-12 14:26:46.000000000","tz":0},"subject":"fix(tvix/eval): preserve catchables in nix_cmp_ordering(), fix b/338","message":"fix(tvix/eval): preserve catchables in nix_cmp_ordering(), fix b/338\n\nThis commit fixes b/338 by properly propagating catchables through\ncomparison operations.\n\nChange-Id: I6b0283a40f228ecf9a6398d24c060bdacb1077cf\nReviewed-on: https://cl.tvl.fyi/c/depot/+/10221\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\nTested-by: BuildkiteCI\nAutosubmit: Adam Joseph \u003cadam@westernsemico.com\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dad566999ca81e5d584acb5107e327a1aec9fdd5a"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dad566999ca81e5d584acb5107e327a1aec9fdd5a"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ae28dc3ca64eb09d0ed792f0145576c17920ede5","is_merged_in_target_branch":true,"change_id":"I69c62ed9ea5c8f81870e8de5c5fe12dcde849763","change_number":10220,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}