)]}'
{"id":"depot~10245","triplet_id":"depot~canon~I91656a308887baa1d459ed54d58baae919a4aaf2","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000066":{"account":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"last_update":"2023-12-12 10:27:51.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2023-12-12 10:27:51.000000000","reason":"Change was submitted"},"1000005":{"account":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"last_update":"2023-12-12 10:27:51.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2023-12-12 09:16:21.000000000","reason":"\u003cGERRIT_ACCOUNT_1000036\u003e replied on the change","reason_account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2023-12-12 10:27:51.000000000","reason":"Change was submitted"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2023-12-12 10:27:51.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I91656a308887baa1d459ed54d58baae919a4aaf2","subject":"feat(tvix/glue): add nixpkgs eval benchmark","status":"MERGED","created":"2023-12-09 18:10:44.000000000","updated":"2023-12-12 10:27:51.000000000","submitted":"2023-12-12 10:27:51.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":13,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10245","meta_rev_id":"db9447725cb4d12ee26e16178514ce96b72c0cab","_number":10245,"virtual_id_number":10245,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-12-12 10:27:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-12-12 10:27:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-12-12 10:27:51.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-12-09 18:10:44.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"state":"REVIEWER"},{"updated":"2023-12-09 18:10:44.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2023-12-09 18:10:46.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-12-09 18:16:53.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-12-11 03:58:46.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2023-12-11 22:37:10.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2023-12-11 22:47:02.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"state":"REVIEWER"},{"updated":"2023-12-12 10:27:51.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ac16836127aa3421af4d0c237e322c682b594247","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-12-09 18:10:44.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"be989fc5ccfc1390b53c6b6e6a54e61acea7a011","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-12-09 18:10:44.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* `tvix/Cargo.lock`\n* `tvix/Cargo.nix`\n* `tvix/glue/Cargo.toml`\n* `tvix/glue/benches/eval.rs`\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":1},{"id":"b26985217f967a196e594daf7a65703b38a3c430","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-09 18:10:46.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/28722","accounts_in_message":[],"_revision_number":1},{"id":"aaef1106422010085d9248dd25af42e5ea0227e9","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-09 18:16:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/28722","accounts_in_message":[],"_revision_number":1},{"id":"e7f19d8164655b12542eea4c503c56fe4e024a17","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2023-12-11 03:58:46.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a92d1fce7613428599eeb628cd3a6aaca7d9539d","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2023-12-11 03:59:07.000000000","message":"Patch Set 1: -Code-Review","accounts_in_message":[],"_revision_number":1},{"id":"65348b97eb94416b7a9f9e32bf35d165a014320a","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2023-12-11 04:01:27.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e8c0d7d842c8fdc11200abef25e6de02f9ac3ca6","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-11 10:28:17.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"92976e4389a342c71c6d0f33494fc9d5835f8210","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-12-11 11:19:49.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Code-Review-1 (copy condition: \"((**is:ANY** AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"0d1720228ccaf4d3a95022915a017d15fa93de91","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-12-11 11:19:49.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f2e1a71769561279bc76f8e38f9e5c5e95fc300c","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-11 11:19:50.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/28784","accounts_in_message":[],"_revision_number":2},{"id":"a492a18c71cae94502f49f1ff151d18296c2c05c","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-11 11:24:29.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/28784","accounts_in_message":[],"_revision_number":2},{"id":"45fb96eeec834b29ddba64f101f2a2118c983a10","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-11 13:10:55.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c13d7002cee98f1b9ed9dde4d0e839105b706683","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-12-11 14:14:57.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c47dc0efa2c7f146d41b2057c24e17d53da59486","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-12-11 22:47:02.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"6ccbe9ab43609f16c3806cb9712f73e6015efd3e","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-11 22:47:04.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/28818","accounts_in_message":[],"_revision_number":3},{"id":"7eaef20ed5bf0bd3ac86683d52904ecc017ca8ac","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-11 22:54:44.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/28818","accounts_in_message":[],"_revision_number":3},{"id":"cddc0039324e63de14cd7d922d2630678b4bdb31","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-12 05:53:09.000000000","message":"Patch Set 4: Commit message was updated.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Verified+1 (copy condition: \"(**is:ANY** AND **changekind:NO_CODE_CHANGE**) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"01ddd2f81ea41a9401d16742986ce96bf728e4f0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-12 05:54:14.000000000","message":"Patch Set 5: Commit message was updated.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Verified+1 (copy condition: \"(**is:ANY** AND **changekind:NO_CODE_CHANGE**) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"9927ec6eccdb2420b0f44628d86f0a298c11bee5","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-12 05:57:51.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"117592c8b4834e396d7d9f04e6b55a3873422923","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-12-12 08:36:45.000000000","message":"Patch Set 5:\n\n(2 comments)","accounts_in_message":[],"_revision_number":5},{"id":"262f6381b8c2383d6609ce5724ac8d4c64ff3d98","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-12-12 09:04:59.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"33b6ca55c3869b31271a838482a2c71c137f66e1","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-12-12 09:09:11.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"c1e617f6ef61257370087fc5683610c1fe6d0109","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-12-12 09:09:14.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"c433720430cd1521a535915c264558ab17e1b137","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-12-12 09:16:21.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"e9c21ff19e90218f9bd4949aa7ada274023564c1","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-12-12 10:27:49.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"db9447725cb4d12ee26e16178514ce96b72c0cab","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2023-12-12 10:27:51.000000000","message":"Change has been successfully rebased and submitted as 8018313b6880d9fae71ba189a476502b68a26d25","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"8018313b6880d9fae71ba189a476502b68a26d25","revisions":{"f89d0fe4c17a2114ec903fae54d0e93cf29e24d5":{"kind":"REWORK","_number":1,"created":"2023-12-09 18:10:44.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/45/10245/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/45/10245/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/45/10245/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/45/10245/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/45/10245/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/45/10245/1"}}},"commit":{"parents":[{"commit":"5c85dbd4da5be7f5826c5497c0f2ebfb4dfddcb4","subject":"chore(tvix): bump criterion to 0.5","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5c85dbd4da5be7f5826c5497c0f2ebfb4dfddcb4"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-12-09 16:45:39.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-12-09 18:08:39.000000000","tz":120},"subject":"feat(tvix/glue): add nixpkgs eval benchmark","message":"feat(tvix/glue): add nixpkgs eval benchmark\n\nThis adds a criterion.rs-based testbench into tvix-glue.\n\nIt can be invoked by running `cargo bench` from inside the `tvix-glue`\ncrate.\n`target/criterion/report/index.html` contains nice graphs.\nIt\u0027s able to diff against the previous run, so you can invoke `cargo\nbench` before and after a certain change to reason about the impact in\nevaluation performance.\n\nCurrently, we need to create a bunch of Evaluator resources inside the\nbenchmark loop itself, which is a bit annoying, as it leaks into the\nthings we benchmark.\n\nThis should become better with b/262.\n\nFixes b/322.\n\nChange-Id: I91656a308887baa1d459ed54d58baae919a4aaf2\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df89d0fe4c17a2114ec903fae54d0e93cf29e24d5"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df89d0fe4c17a2114ec903fae54d0e93cf29e24d5"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"5c85dbd4da5be7f5826c5497c0f2ebfb4dfddcb4","is_merged_in_target_branch":false,"change_id":"I28904ca23437b4bb745c0eb1f4eb9ae33e09eb5a","change_number":10244,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"0851f9640b5ee962635ae0ac8384c6a0bb563549":{"kind":"REWORK","_number":2,"created":"2023-12-11 11:19:49.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/45/10245/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/45/10245/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/45/10245/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/45/10245/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/45/10245/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/45/10245/2"}}},"commit":{"parents":[{"commit":"3c0a9a949ab71545de23102a8309ad0bea591c1f","subject":"chore(tvix/store/protof): buf format","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3c0a9a949ab71545de23102a8309ad0bea591c1f"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-12-09 16:45:39.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-12-11 11:17:30.000000000","tz":120},"subject":"feat(tvix/glue): add nixpkgs eval benchmark","message":"feat(tvix/glue): add nixpkgs eval benchmark\n\nThis adds a criterion.rs-based testbench into tvix-glue.\n\nIt can be invoked by running `cargo bench` from inside the `tvix-glue`\ncrate.\n`target/criterion/report/index.html` contains nice graphs.\nIt\u0027s able to diff against the previous run, so you can invoke `cargo\nbench` before and after a certain change to reason about the impact in\nevaluation performance.\n\nCurrently, we need to create a bunch of Evaluator resources inside the\nbenchmark loop itself, which is a bit annoying, as it leaks into the\nthings we benchmark.\n\nThis should become better with b/262.\n\nFixes b/322.\n\nChange-Id: I91656a308887baa1d459ed54d58baae919a4aaf2\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0851f9640b5ee962635ae0ac8384c6a0bb563549"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0851f9640b5ee962635ae0ac8384c6a0bb563549"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3c0a9a949ab71545de23102a8309ad0bea591c1f","is_merged_in_target_branch":true,"change_id":"I29b0fb62aa849ee01860dc7fe3dbba9b941ca172","change_number":10238,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"6db2fb3204596e58a43d281d911b29655a28b455":{"kind":"REWORK","_number":3,"created":"2023-12-11 22:47:02.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/45/10245/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/45/10245/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/45/10245/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/45/10245/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/45/10245/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/45/10245/3"}}},"commit":{"parents":[{"commit":"ccaf10b4a6f7768294e41fcb6fbcd768a1e1c143","subject":"refactor(tvix/*store/sled): make ::new() more generic","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dccaf10b4a6f7768294e41fcb6fbcd768a1e1c143"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-12-09 16:45:39.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-12-11 22:46:57.000000000","tz":120},"subject":"feat(tvix/glue): add nixpkgs eval benchmark","message":"feat(tvix/glue): add nixpkgs eval benchmark\n\nThis adds a criterion.rs-based testbench into tvix-glue.\n\nIt can be invoked by running `cargo bench` from inside the `tvix-glue`\ncrate.\n`target/criterion/report/index.html` contains nice graphs.\nIt\u0027s able to diff against the previous run, so you can invoke `cargo\nbench` before and after a certain change to reason about the impact in\nevaluation performance.\n\nCurrently, we need to create a bunch of Evaluator resources inside the\nbenchmark loop itself, which is a bit annoying, as it leaks into the\nthings we benchmark.\n\nThis should become better with b/262.\n\nFixes b/322.\n\nChange-Id: I91656a308887baa1d459ed54d58baae919a4aaf2\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6db2fb3204596e58a43d281d911b29655a28b455"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6db2fb3204596e58a43d281d911b29655a28b455"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ccaf10b4a6f7768294e41fcb6fbcd768a1e1c143","is_merged_in_target_branch":true,"change_id":"I38d536dbaf0b44421e41f211a9ad2b13605179e9","change_number":10258,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f61cd00c9b81d48a5fd39c64cdf2feec05d4bc84":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2023-12-12 05:53:09.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/45/10245/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/45/10245/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/45/10245/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/45/10245/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/45/10245/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/45/10245/4"}}},"commit":{"parents":[{"commit":"ccaf10b4a6f7768294e41fcb6fbcd768a1e1c143","subject":"refactor(tvix/*store/sled): make ::new() more generic","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dccaf10b4a6f7768294e41fcb6fbcd768a1e1c143"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-12-09 16:45:39.000000000","tz":120},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 05:53:09.000000000","tz":0},"subject":"feat(tvix/glue): add nixpkgs eval microbenchmark","message":"feat(tvix/glue): add nixpkgs eval microbenchmark\n\nThis adds a criterion.rs-based testbench into tvix-glue.\n\nIt can be invoked by running `cargo bench` from inside the `tvix-glue`\ncrate.\n`target/criterion/report/index.html` contains nice graphs.\nIt\u0027s able to diff against the previous run, so you can invoke `cargo\nbench` before and after a certain change to reason about the impact in\nevaluation performance.\n\nCurrently, we need to create a bunch of Evaluator resources inside the\nbenchmark loop itself, which is a bit annoying, as it leaks into the\nthings we benchmark.\n\nThis should become better with b/262.\n\nFixes b/322.\n\nChange-Id: I91656a308887baa1d459ed54d58baae919a4aaf2\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df61cd00c9b81d48a5fd39c64cdf2feec05d4bc84"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df61cd00c9b81d48a5fd39c64cdf2feec05d4bc84"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ccaf10b4a6f7768294e41fcb6fbcd768a1e1c143","is_merged_in_target_branch":true,"change_id":"I38d536dbaf0b44421e41f211a9ad2b13605179e9","change_number":10258,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Edit commit message"},"5d5e53ae9d49e1b4afbad97a3dd5f2cd9b1ee182":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2023-12-12 05:54:14.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/45/10245/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/45/10245/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/45/10245/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/45/10245/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/45/10245/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/45/10245/5"}}},"commit":{"parents":[{"commit":"ccaf10b4a6f7768294e41fcb6fbcd768a1e1c143","subject":"refactor(tvix/*store/sled): make ::new() more generic","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dccaf10b4a6f7768294e41fcb6fbcd768a1e1c143"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-12-09 16:45:39.000000000","tz":120},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 05:54:14.000000000","tz":0},"subject":"feat(tvix/glue): add nixpkgs eval benchmark","message":"feat(tvix/glue): add nixpkgs eval benchmark\n\nThis adds a criterion.rs-based testbench into tvix-glue.\n\nIt can be invoked by running `cargo bench` from inside the `tvix-glue`\ncrate.\n`target/criterion/report/index.html` contains nice graphs.\nIt\u0027s able to diff against the previous run, so you can invoke `cargo\nbench` before and after a certain change to reason about the impact in\nevaluation performance.\n\nCurrently, we need to create a bunch of Evaluator resources inside the\nbenchmark loop itself, which is a bit annoying, as it leaks into the\nthings we benchmark.\n\nThis should become better with b/262.\n\nFixes b/322.\n\nChange-Id: I91656a308887baa1d459ed54d58baae919a4aaf2\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5d5e53ae9d49e1b4afbad97a3dd5f2cd9b1ee182"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5d5e53ae9d49e1b4afbad97a3dd5f2cd9b1ee182"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"ccaf10b4a6f7768294e41fcb6fbcd768a1e1c143","is_merged_in_target_branch":true,"change_id":"I38d536dbaf0b44421e41f211a9ad2b13605179e9","change_number":10258,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Edit commit message"},"8018313b6880d9fae71ba189a476502b68a26d25":{"kind":"REWORK","_number":6,"created":"2023-12-12 10:27:51.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/45/10245/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/45/10245/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/45/10245/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/45/10245/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/45/10245/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/45/10245/6"}}},"commit":{"parents":[{"commit":"6c87ab960dcfdaa9727d692dabd4196851ecef95","subject":"chore(tvix/glue): allow unused_variables","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6c87ab960dcfdaa9727d692dabd4196851ecef95"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-12-09 16:45:39.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2023-12-12 10:27:51.000000000","tz":0},"subject":"feat(tvix/glue): add nixpkgs eval benchmark","message":"feat(tvix/glue): add nixpkgs eval benchmark\n\nThis adds a criterion.rs-based testbench into tvix-glue.\n\nIt can be invoked by running `cargo bench` from inside the `tvix-glue`\ncrate.\n`target/criterion/report/index.html` contains nice graphs.\nIt\u0027s able to diff against the previous run, so you can invoke `cargo\nbench` before and after a certain change to reason about the impact in\nevaluation performance.\n\nCurrently, we need to create a bunch of Evaluator resources inside the\nbenchmark loop itself, which is a bit annoying, as it leaks into the\nthings we benchmark.\n\nThis should become better with b/262.\n\nFixes b/322.\n\nChange-Id: I91656a308887baa1d459ed54d58baae919a4aaf2\nReviewed-on: https://cl.tvl.fyi/c/depot/+/10245\nAutosubmit: flokli \u003cflokli@flokli.de\u003e\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8018313b6880d9fae71ba189a476502b68a26d25"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8018313b6880d9fae71ba189a476502b68a26d25"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6c87ab960dcfdaa9727d692dabd4196851ecef95","is_merged_in_target_branch":true,"change_id":"Ia82082a58543f0fdd32866fdfcd37d0a5fdfda9c","change_number":10261,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}
