)]}'
{"id":"depot~10257","triplet_id":"depot~canon~I0e4892d29e41c76653272dc1a3625180da6fee12","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2023-12-11 22:46:50.000000000","reason":"Change was submitted"},"1000005":{"account":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"last_update":"2023-12-11 22:46:50.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2023-12-11 22:36:23.000000000","reason":"removed on reply"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2023-12-11 22:46:50.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I0e4892d29e41c76653272dc1a3625180da6fee12","subject":"chore(tvix): drop sled compression support","status":"MERGED","created":"2023-12-11 19:30:56.000000000","updated":"2023-12-11 22:46:50.000000000","submitted":"2023-12-11 22:46:50.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10258","meta_rev_id":"04401eeac9c1dd1f5d4b35c56d511eb9b51a4112","_number":10257,"virtual_id_number":10257,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-12-11 22:46:50.000000000","_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-12-11 22:46:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-12-11 22:46:50.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-12-11 19:30:56.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"state":"REVIEWER"},{"updated":"2023-12-11 19:30:56.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2023-12-11 19:30:56.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2023-12-11 19:30:56.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-12-11 19:36:47.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-12-11 22:46:50.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"923f3674b66e8544194a9c1c712303d8690176e1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-12-11 19:30:56.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"6a713527d6636d5758cba09e744a16d165cf52b6","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-12-11 19:30:56.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* `tvix/Cargo.lock`\n* `tvix/Cargo.nix`\n* `tvix/castore/Cargo.toml`\n* `tvix/castore/src/blobservice/from_addr.rs`\n* `tvix/castore/src/blobservice/sled.rs`\n* `tvix/store/Cargo.toml`\n* `tvix/store/src/pathinfoservice/from_addr.rs`\n* `tvix/store/src/pathinfoservice/sled.rs`\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":1},{"id":"6ea645805af991b0a28604f05b996c830268a019","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-11 19:30:56.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/28793","accounts_in_message":[],"_revision_number":1},{"id":"9078ef2400cd7e89badaf859ad4711b23728c4da","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-11 19:36:47.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/28793","accounts_in_message":[],"_revision_number":1},{"id":"f7a06dca0567a0f25b91bd4f4affa5427462fd5d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-12-11 20:07:43.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"1d5592de6a4724cbfb6ebd54f174bfa273720c48","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-11 20:07:44.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/28794","accounts_in_message":[],"_revision_number":2},{"id":"f978685aa9fc1828eb33156709207e9196effd00","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-11 20:12:39.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/28794","accounts_in_message":[],"_revision_number":2},{"id":"338687d1544412595a7690f84c7657ccc1a473f6","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2023-12-11 21:57:31.000000000","message":"Patch Set 2: Code-Review+2\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"1cefc7fbbbf13f93ccb1486e86e66c8164440eb1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-12-11 22:36:23.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"103c8f53d0d757bc9da19a1a3258013a1f29134c","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2023-12-11 22:36:23.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"f4b129c57751a30614ee891ca704eabee968d747","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-11 22:36:26.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/28814","accounts_in_message":[],"_revision_number":3},{"id":"2bbf1b3ac3366543d8211dacc90c77abe3854887","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-11 22:46:43.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/28814","accounts_in_message":[],"_revision_number":3},{"id":"04401eeac9c1dd1f5d4b35c56d511eb9b51a4112","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2023-12-11 22:46:50.000000000","message":"Change has been successfully rebased and submitted as 9748543f1c3edd88e8b05f6a772d6e9be18a7be9\n\n2 is the latest approved patch-set.\nThe change was submitted with unreviewed changes in the following files:\n\n```\nThe name of the file: tvix/castore/src/blobservice/sled.rs\nInsertions: 3, Deletions: 1.\n\n@@ -15,7 +15,9 @@\n \n impl SledBlobService {\n     pub fn new(p: PathBuf) -\u003e Result\u003cSelf, sled::Error\u003e {\n-        let config \u003d sled::Config::default().use_compression(false).path(p);\n+        let config \u003d sled::Config::default()\n+            .use_compression(false) // is a required parameter\n+            .path(p);\n         let db \u003d config.open()?;\n \n         Ok(Self { db })\n```\n```\nThe name of the file: tvix/store/src/pathinfoservice/sled.rs\nInsertions: 3, Deletions: 1.\n\n@@ -26,7 +26,9 @@\n         blob_service: Arc\u003cdyn BlobService\u003e,\n         directory_service: Arc\u003cdyn DirectoryService\u003e,\n     ) -\u003e Result\u003cSelf, sled::Error\u003e {\n-        let config \u003d sled::Config::default().use_compression(false).path(p);\n+        let config \u003d sled::Config::default()\n+            .use_compression(false) // is a required parameter\n+            .path(p);\n         let db \u003d config.open()?;\n \n         Ok(Self {\n```\n```\nThe name of the file: tvix/castore/src/directoryservice/sled.rs\nInsertions: 3, Deletions: 1.\n\n@@ -18,7 +18,9 @@\n \n impl SledDirectoryService {\n     pub fn new(p: PathBuf) -\u003e Result\u003cSelf, sled::Error\u003e {\n-        let config \u003d sled::Config::default().use_compression(false).path(p);\n+        let config \u003d sled::Config::default()\n+            .use_compression(false) // is a required parameter\n+            .path(p);\n         let db \u003d config.open()?;\n \n         Ok(Self { db })\n```\n","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"9748543f1c3edd88e8b05f6a772d6e9be18a7be9","revisions":{"92cebfd5a2ceebd26475ec722bd6c5d41433a2e2":{"kind":"REWORK","_number":1,"created":"2023-12-11 19:30:56.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/57/10257/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/57/10257/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/57/10257/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/57/10257/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/57/10257/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/57/10257/1"}}},"commit":{"parents":[{"commit":"3c0a9a949ab71545de23102a8309ad0bea591c1f","subject":"chore(tvix/store/protof): buf format","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3c0a9a949ab71545de23102a8309ad0bea591c1f"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-12-11 19:25:34.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-12-11 19:30:15.000000000","tz":120},"subject":"chore(tvix): drop sled compression support","message":"chore(tvix): drop sled compression support\n\nIt\u0027s been a while since the last sled release, and that one binds to a\npretty old version of zstd, requiring workarounds like cl/10090.\n\nUpstream sled main branch currently has zstd halfway patched out (it\u0027s\na no-op, but the feature flag and options are still there), and it\u0027s in\nthat state for a year.\n\nRather than maintaining our own fork of sled, let\u0027s just stop using the\ncompression feature in sled, dropping the version pin to zstd that way,\nremoving the need for cl/10090.\n\nThis doesn\u0027t mean we won\u0027t reintroduce per-blob compression - but we\nprobably just won\u0027t let sled take care of the compression, but do it\nourselves - which is necessary for more chunked blob storage anyways.\n\nChange-Id: I0e4892d29e41c76653272dc1a3625180da6fee12\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d92cebfd5a2ceebd26475ec722bd6c5d41433a2e2"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d92cebfd5a2ceebd26475ec722bd6c5d41433a2e2"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3c0a9a949ab71545de23102a8309ad0bea591c1f","is_merged_in_target_branch":true,"change_id":"I29b0fb62aa849ee01860dc7fe3dbba9b941ca172","change_number":10238,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"0c8c04cffacbddfb6ad38ebe61f8e8fdbcc17fc1":{"kind":"REWORK","_number":2,"created":"2023-12-11 20:07:43.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/57/10257/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/57/10257/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/57/10257/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/57/10257/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/57/10257/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/57/10257/2"}}},"commit":{"parents":[{"commit":"3c0a9a949ab71545de23102a8309ad0bea591c1f","subject":"chore(tvix/store/protof): buf format","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3c0a9a949ab71545de23102a8309ad0bea591c1f"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-12-11 19:25:34.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-12-11 20:06:58.000000000","tz":120},"subject":"chore(tvix): drop sled compression support","message":"chore(tvix): drop sled compression support\n\nIt\u0027s been a while since the last sled release, and that one binds to a\npretty old version of zstd, requiring workarounds like cl/10090.\n\nUpstream sled main branch currently has zstd halfway patched out (it\u0027s\na no-op, but the feature flag and options are still there), and it\u0027s in\nthat state for a year.\n\nRather than maintaining our own fork of sled, let\u0027s just stop using the\ncompression feature in sled, dropping the version pin to zstd that way,\nremoving the need for cl/10090.\n\nThis doesn\u0027t mean we won\u0027t reintroduce per-blob compression - but we\nprobably just won\u0027t let sled take care of the compression, but do it\nourselves - which is necessary for more chunked blob storage anyways.\n\nEven though we do drop the feature flag, we still need to explicitly use\nuse_compression(false).\n\nChange-Id: I0e4892d29e41c76653272dc1a3625180da6fee12\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0c8c04cffacbddfb6ad38ebe61f8e8fdbcc17fc1"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0c8c04cffacbddfb6ad38ebe61f8e8fdbcc17fc1"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3c0a9a949ab71545de23102a8309ad0bea591c1f","is_merged_in_target_branch":true,"change_id":"I29b0fb62aa849ee01860dc7fe3dbba9b941ca172","change_number":10238,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"45c52d8b795d282bc5220eed843df1b48b3786d7":{"kind":"REWORK","_number":3,"created":"2023-12-11 22:36:23.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/57/10257/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/57/10257/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/57/10257/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/57/10257/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/57/10257/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/57/10257/3"}}},"commit":{"parents":[{"commit":"92bd69aef23126412a15649e441339c96e001212","subject":"docs(tvix/*store-go): fix README invocation","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d92bd69aef23126412a15649e441339c96e001212"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-12-11 19:25:34.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-12-11 22:34:37.000000000","tz":120},"subject":"chore(tvix): drop sled compression support","message":"chore(tvix): drop sled compression support\n\nIt\u0027s been a while since the last sled release, and that one binds to a\npretty old version of zstd, requiring workarounds like cl/10090.\n\nUpstream sled main branch currently has zstd halfway patched out (it\u0027s\na no-op, but the feature flag and options are still there), and it\u0027s in\nthat state for a year.\n\nRather than maintaining our own fork of sled, let\u0027s just stop using the\ncompression feature in sled, dropping the version pin to zstd that way,\nremoving the need for cl/10090.\n\nThis doesn\u0027t mean we won\u0027t reintroduce per-blob compression - but we\nprobably just won\u0027t let sled take care of the compression, but do it\nourselves - which is necessary for more chunked blob storage anyways.\n\nEven though we do drop the feature flag, we still need to explicitly use\nuse_compression(false).\n\nChange-Id: I0e4892d29e41c76653272dc1a3625180da6fee12\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d45c52d8b795d282bc5220eed843df1b48b3786d7"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d45c52d8b795d282bc5220eed843df1b48b3786d7"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"92bd69aef23126412a15649e441339c96e001212","is_merged_in_target_branch":true,"change_id":"I18075042ebd461e4dd0718a936e6bbe738a144d5","change_number":10259,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"9748543f1c3edd88e8b05f6a772d6e9be18a7be9":{"kind":"REWORK","_number":4,"created":"2023-12-11 22:46:50.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/57/10257/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/57/10257/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/57/10257/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/57/10257/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/57/10257/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/57/10257/4"}}},"commit":{"parents":[{"commit":"6025be423a3dd97e29f536d39ca99528f58e5fb3","subject":"chore(tvix/proto): drop evaluator.proto","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6025be423a3dd97e29f536d39ca99528f58e5fb3"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2023-12-11 19:25:34.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2023-12-11 22:46:50.000000000","tz":0},"subject":"chore(tvix): drop sled compression support","message":"chore(tvix): drop sled compression support\n\nIt\u0027s been a while since the last sled release, and that one binds to a\npretty old version of zstd, requiring workarounds like cl/10090.\n\nUpstream sled main branch currently has zstd halfway patched out (it\u0027s\na no-op, but the feature flag and options are still there), and it\u0027s in\nthat state for a year.\n\nRather than maintaining our own fork of sled, let\u0027s just stop using the\ncompression feature in sled, dropping the version pin to zstd that way,\nremoving the need for cl/10090.\n\nThis doesn\u0027t mean we won\u0027t reintroduce per-blob compression - but we\nprobably just won\u0027t let sled take care of the compression, but do it\nourselves - which is necessary for more chunked blob storage anyways.\n\nEven though we do drop the feature flag, we still need to explicitly use\nuse_compression(false).\n\nChange-Id: I0e4892d29e41c76653272dc1a3625180da6fee12\nReviewed-on: https://cl.tvl.fyi/c/depot/+/10257\nAutosubmit: flokli \u003cflokli@flokli.de\u003e\nReviewed-by: raitobezarius \u003ctvl@lahfa.xyz\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9748543f1c3edd88e8b05f6a772d6e9be18a7be9"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9748543f1c3edd88e8b05f6a772d6e9be18a7be9"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6025be423a3dd97e29f536d39ca99528f58e5fb3","is_merged_in_target_branch":true,"change_id":"I2196aade55221660330dfd32dc3e52c39ec6ed43","change_number":10241,"patch_set_number":10,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}