)]}'
{"id":"depot~10288","triplet_id":"depot~canon~I48de3010014c0bbeba15d34fc0d4800e0bb5a1ef","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000066":{"account":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"last_update":"2023-12-12 14:55:48.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2023-12-12 14:51:15.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I48de3010014c0bbeba15d34fc0d4800e0bb5a1ef","subject":"fix(tvix/eval): fix branching on catchable defaults (b/343)","status":"MERGED","created":"2023-12-12 05:50:13.000000000","updated":"2023-12-12 14:55:48.000000000","submitted":"2023-12-12 14:55:48.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10288","meta_rev_id":"0c6e965351cc680fe8e4dc5564be1eef245f4995","_number":10288,"virtual_id_number":10288,"owner":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-12-12 14:55:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-12-12 14:55:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-12-12 14:55:48.000000000","_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-12-12 05:50:16.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-12-12 05:50:57.000000000","updated_by":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2023-12-12 05:56:48.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-12-12 14:55:48.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1b35b6637f4b560b94b7d3090e9f4dd6fcd9a509","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-12 05:50:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"69e30f9f7cfe6e247ef264b2857d1a4e74adf4ec","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 05:50:16.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/28830","accounts_in_message":[],"_revision_number":1},{"id":"3c97d7cf774e03ef0f7dccdd90b442f1fec5b493","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-12 05:50:57.000000000","message":"Patch Set 1: Autosubmit+1\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":1},{"id":"6e6f1f336396adcc597cdcabe48c34e93caaee06","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-12 05:50:57.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* `tvix/eval/src/compiler/mod.rs`\n* `tvix/eval/src/opcode.rs`\n* `tvix/eval/src/tests/tvix_tests/eval-okay-test-catchables-in-default-args.exp`\n* `tvix/eval/src/tests/tvix_tests/eval-okay-test-catchables-in-default-args.nix`\n* `tvix/eval/src/tests/tvix_tests/notyetpassing/eval-okay-test-catchables-in-default-args.exp`\n* `tvix/eval/src/tests/tvix_tests/notyetpassing/eval-okay-test-catchables-in-default-args.nix`\n* `tvix/eval/src/value/mod.rs`\n* `tvix/eval/src/vm/mod.rs`\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":1},{"id":"7beabe14bd13c04d183b0b181332bb8094cb4680","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 05:56:48.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/28830","accounts_in_message":[],"_revision_number":1},{"id":"b080ce4f5605d25e2819cf9a208535d490f0dda4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-12 06:05:07.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"ad25cee8489cd1db1417c7e4c0e760b56ec9851e","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 06:05:09.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/28832","accounts_in_message":[],"_revision_number":2},{"id":"4bb89242a6fe3c498b6d820b03f39b960c403592","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 06:11:12.000000000","message":"Patch Set 2: Verified-1\n\nBuild of patchset 2 failed: https://buildkite.com/tvl/depot/builds/28832","accounts_in_message":[],"_revision_number":2},{"id":"52ec1dce70f67e7fcdbb69e2e5a7c30a06b47e63","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-12 06:16:16.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"424877d6371905277eaa6425ba7812730d0ed740","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 06:16:21.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/28838","accounts_in_message":[],"_revision_number":3},{"id":"df4611b08169e70c1696abaa92ec8aafce56d4d2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-12 06:20:55.000000000","message":"Uploaded patch set 4.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n","accounts_in_message":[],"_revision_number":4},{"id":"0bf0d5e2b86772daeb71e9dc1e491d4e214fe316","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 06:20:56.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/28839","accounts_in_message":[],"_revision_number":4},{"id":"1be886b1c6579cd9aeab8dffb7b66874818f1852","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 06:21:56.000000000","message":"Patch Set 3: Verified-1\n\nBuild of patchset 3 failed: https://buildkite.com/tvl/depot/builds/28838","accounts_in_message":[],"_revision_number":3},{"id":"2bfe3c7d42a36522dc204a262c7a355d192316e6","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 06:25:35.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/28839","accounts_in_message":[],"_revision_number":4},{"id":"23d039dfcdc004c10dac5447561cae61139571c4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-12 06:39:56.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"3c9450da5996f5caf7ae706d50d373153a2e3da9","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 06:39:58.000000000","message":"Patch Set 5:\n\nStarted build for patchset #5 on: https://buildkite.com/tvl/depot/builds/28841","accounts_in_message":[],"_revision_number":5},{"id":"d913fc7dcbe2be03d9065fa357e0abb0ce89cbd7","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 06:45:28.000000000","message":"Patch Set 5: Verified-1\n\nBuild of patchset 5 failed: https://buildkite.com/tvl/depot/builds/28841","accounts_in_message":[],"_revision_number":5},{"id":"e20bc322dc180f53f30c2a0a0186247ace57e82a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-12 06:51:09.000000000","message":"Uploaded patch set 6: Commit message was updated.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Verified-1 (copy condition: \"(**is:ANY** AND **changekind:NO_CODE_CHANGE**) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":6},{"id":"505e87ffe0f6e5c48490ccfbe48ad546a1638ecc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-12 06:51:58.000000000","message":"Uploaded patch set 7.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":7},{"id":"424df1e7dad9f64984aab706e61a39dadc3174f8","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 06:52:00.000000000","message":"Patch Set 7:\n\nStarted build for patchset #7 on: https://buildkite.com/tvl/depot/builds/28848","accounts_in_message":[],"_revision_number":7},{"id":"6f28a2d7c95afbfef20ab25e87162bb05d919286","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 06:58:16.000000000","message":"Patch Set 7: Verified+1\n\nBuild of patchset 7 passed: https://buildkite.com/tvl/depot/builds/28848","accounts_in_message":[],"_revision_number":7},{"id":"aeaede74082e82323c284aa03bd3ffc461125d2f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-12 12:04:15.000000000","message":"Uploaded patch set 8: Patch Set 7 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":8},{"id":"6a3ccdad3a78a828024645a8a781f2d91e865019","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 12:04:30.000000000","message":"Patch Set 8:\n\nStarted build for patchset #8 on: https://buildkite.com/tvl/depot/builds/28910","accounts_in_message":[],"_revision_number":8},{"id":"0e6cd44ec560109b50cb1b4167b3ecfcd94dc663","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 12:18:44.000000000","message":"Patch Set 8: Verified+1\n\nBuild of patchset 8 passed: https://buildkite.com/tvl/depot/builds/28910","accounts_in_message":[],"_revision_number":8},{"id":"0852fecbd9d7f00447bb202e267c4c0957e1051e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-12-12 14:47:15.000000000","message":"Uploaded patch set 9.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":9},{"id":"ad07268ad89444c818e09f6fdb0712e9eba48c45","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 14:47:27.000000000","message":"Patch Set 9:\n\nStarted build for patchset #9 on: https://buildkite.com/tvl/depot/builds/28971","accounts_in_message":[],"_revision_number":9},{"id":"a62227299bb8062379ecb4ea098b90c270fc45da","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-12-12 14:51:15.000000000","message":"Patch Set 9: Code-Review+2","accounts_in_message":[],"_revision_number":9},{"id":"db29dd38ec16ac71c9a57c6d6e573ca779d0e42b","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 14:55:41.000000000","message":"Patch Set 9: Verified+1\n\nBuild of patchset 9 passed: https://buildkite.com/tvl/depot/builds/28971","accounts_in_message":[],"_revision_number":9},{"id":"0c6e965351cc680fe8e4dc5564be1eef245f4995","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2023-12-12 14:55:48.000000000","message":"Change has been successfully rebased and submitted as 9792920f8cdec92aa2c650de8cfd0a85fa7dce52","accounts_in_message":[],"_revision_number":10}],"current_revision_number":10,"current_revision":"9792920f8cdec92aa2c650de8cfd0a85fa7dce52","revisions":{"4011d0fb8da87fb14eb383b599eca489804ea244":{"kind":"REWORK","_number":1,"created":"2023-12-12 05:50:13.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/88/10288/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/88/10288/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/88/10288/1"}}},"commit":{"parents":[{"commit":"eff45bb3ae5da76afd44c6b86bac730e7114b722","subject":"test(tvix/eval): test for b/343","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003deff45bb3ae5da76afd44c6b86bac730e7114b722"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 05:17:22.000000000","tz":-480},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 05:50:14.000000000","tz":-480},"subject":"test(tvix/eval): fix b/343","message":"test(tvix/eval): fix b/343\n\nThis commit adds Opcode::OpJumpAndPopIfCatchable, which can be\ninserted ahead of most VM operations which expect a boolean on the\nstack, in order to handle catchables in branching position properly.\n\nOther than remembering to patch the jump, no other changes should be\nrequired -- this is the reason for the somewhat odd JumpAndPop behavior.\n\nThis commit also fixes b/343 by emitting this new opcode when\ncompiling if-then-else.  There are probably other\nyet-to-be-discovered places where we need to do the same thing.\n\nChange-Id: I48de3010014c0bbeba15d34fc0d4800e0bb5a1ef\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4011d0fb8da87fb14eb383b599eca489804ea244"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4011d0fb8da87fb14eb383b599eca489804ea244"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"eff45bb3ae5da76afd44c6b86bac730e7114b722","is_merged_in_target_branch":false,"change_id":"I891ca825e39ad14dda9f220f06d9591874fcd45d","change_number":10287,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"5ebde5cc8775e71ab1f655c920d9f1f9b9c1a857":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-12-12 06:05:07.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/88/10288/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/88/10288/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/88/10288/2"}}},"commit":{"parents":[{"commit":"72acfea9f3e0d3ee221071e146a6bb88e93ea96d","subject":"test(tvix/eval): test for b/343","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d72acfea9f3e0d3ee221071e146a6bb88e93ea96d"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 05:17:22.000000000","tz":-480},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 06:05:23.000000000","tz":-480},"subject":"test(tvix/eval): fix b/343","message":"test(tvix/eval): fix b/343\n\nThis commit adds Opcode::OpJumpAndPopIfCatchable, which can be\ninserted ahead of most VM operations which expect a boolean on the\nstack, in order to handle catchables in branching position properly.\n\nOther than remembering to patch the jump, no other changes should be\nrequired -- this is the reason for the somewhat odd JumpAndPop behavior.\n\nThis commit also fixes b/343 by emitting this new opcode when\ncompiling if-then-else.  There are probably other\nyet-to-be-discovered places where we need to do the same thing.\n\nChange-Id: I48de3010014c0bbeba15d34fc0d4800e0bb5a1ef\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5ebde5cc8775e71ab1f655c920d9f1f9b9c1a857"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5ebde5cc8775e71ab1f655c920d9f1f9b9c1a857"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"72acfea9f3e0d3ee221071e146a6bb88e93ea96d","is_merged_in_target_branch":false,"change_id":"I891ca825e39ad14dda9f220f06d9591874fcd45d","change_number":10287,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"225b734d10df4ea6bf82dc6b432c3d3ebdf3ac9c":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-12-12 06:16:16.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/88/10288/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/88/10288/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/88/10288/3"}}},"commit":{"parents":[{"commit":"1cfe29d338acb6960448f77c8bc64ff825e36ce5","subject":"test(tvix/eval): test for b/343","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1cfe29d338acb6960448f77c8bc64ff825e36ce5"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 05:17:22.000000000","tz":-480},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 06:16:31.000000000","tz":-480},"subject":"test(tvix/eval): fix b/343","message":"test(tvix/eval): fix b/343\n\nThis commit adds Opcode::OpJumpAndPopIfCatchable, which can be\ninserted ahead of most VM operations which expect a boolean on the\nstack, in order to handle catchables in branching position properly.\n\nOther than remembering to patch the jump, no other changes should be\nrequired -- this is the reason for the somewhat odd JumpAndPop behavior.\n\nThis commit also fixes b/343 by emitting this new opcode when\ncompiling if-then-else.  There are probably other\nyet-to-be-discovered places where we need to do the same thing.\n\nChange-Id: I48de3010014c0bbeba15d34fc0d4800e0bb5a1ef\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d225b734d10df4ea6bf82dc6b432c3d3ebdf3ac9c"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d225b734d10df4ea6bf82dc6b432c3d3ebdf3ac9c"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1cfe29d338acb6960448f77c8bc64ff825e36ce5","is_merged_in_target_branch":false,"change_id":"I891ca825e39ad14dda9f220f06d9591874fcd45d","change_number":10287,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"bd6221dd4dd4ecea4518f574dbabf34d18366581":{"kind":"REWORK","_number":4,"created":"2023-12-12 06:20:55.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/88/10288/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/88/10288/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/88/10288/4"}}},"commit":{"parents":[{"commit":"1cfe29d338acb6960448f77c8bc64ff825e36ce5","subject":"test(tvix/eval): test for b/343","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1cfe29d338acb6960448f77c8bc64ff825e36ce5"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 05:17:22.000000000","tz":-480},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 06:20:36.000000000","tz":-480},"subject":"test(tvix/eval): fix b/343","message":"test(tvix/eval): fix b/343\n\nThis commit adds Opcode::OpJumpIfCatchable, which can be inserted\nahead of most VM operations which expect a boolean on the stack, in\norder to handle catchables in branching position properly.\n\nOther than remembering to patch the jump, no other changes should be\nrequired.\n\nThis commit also fixes b/343 by emitting this new opcode when\ncompiling if-then-else.  There are probably other\nyet-to-be-discovered places where we need to do the same thing.\n\nChange-Id: I48de3010014c0bbeba15d34fc0d4800e0bb5a1ef\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbd6221dd4dd4ecea4518f574dbabf34d18366581"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbd6221dd4dd4ecea4518f574dbabf34d18366581"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1cfe29d338acb6960448f77c8bc64ff825e36ce5","is_merged_in_target_branch":false,"change_id":"I891ca825e39ad14dda9f220f06d9591874fcd45d","change_number":10287,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f8a1a3f53c76f30d55cb6d0a54fe97ef5b01460a":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2023-12-12 06:39:56.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/88/10288/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/88/10288/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/88/10288/5"}}},"commit":{"parents":[{"commit":"5f8cb910fbdd55e1c9be7a2b55c37addfbeb332f","subject":"test(tvix/eval): test for b/343","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5f8cb910fbdd55e1c9be7a2b55c37addfbeb332f"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 05:17:22.000000000","tz":-480},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 06:23:25.000000000","tz":-480},"subject":"test(tvix/eval): fix b/343","message":"test(tvix/eval): fix b/343\n\nThis commit adds Opcode::OpJumpIfCatchable, which can be inserted\nahead of most VM operations which expect a boolean on the stack, in\norder to handle catchables in branching position properly.\n\nOther than remembering to patch the jump, no other changes should be\nrequired.\n\nThis commit also fixes b/343 by emitting this new opcode when\ncompiling if-then-else.  There are probably other\nyet-to-be-discovered places where we need to do the same thing.\n\nChange-Id: I48de3010014c0bbeba15d34fc0d4800e0bb5a1ef\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df8a1a3f53c76f30d55cb6d0a54fe97ef5b01460a"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df8a1a3f53c76f30d55cb6d0a54fe97ef5b01460a"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"5f8cb910fbdd55e1c9be7a2b55c37addfbeb332f","is_merged_in_target_branch":false,"change_id":"I891ca825e39ad14dda9f220f06d9591874fcd45d","change_number":10287,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"71607e776fb5ade3765764bdd56b5556f7225425":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2023-12-12 06:51:09.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/88/10288/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/88/10288/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/88/10288/6"}}},"commit":{"parents":[{"commit":"5f8cb910fbdd55e1c9be7a2b55c37addfbeb332f","subject":"test(tvix/eval): test for b/343","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5f8cb910fbdd55e1c9be7a2b55c37addfbeb332f"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 05:17:22.000000000","tz":-480},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 06:51:13.000000000","tz":-480},"subject":"test(tvix/eval): fix b/343","message":"test(tvix/eval): fix b/343\n\nThis commit adds Opcode::OpJumpIfCatchable, which can be inserted\nahead of most VM operations which expect a boolean on the stack, in\norder to handle catchables in branching position properly.\n\nOther than remembering to patch the jump, no other changes should be\nrequired.\n\nThis commit also fixes b/343 by emitting this new opcode when\ncompiling if-then-else.  There are probably other places where we\nneed to do the same thing.\n\nChange-Id: I48de3010014c0bbeba15d34fc0d4800e0bb5a1ef\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d71607e776fb5ade3765764bdd56b5556f7225425"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d71607e776fb5ade3765764bdd56b5556f7225425"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"5f8cb910fbdd55e1c9be7a2b55c37addfbeb332f","is_merged_in_target_branch":false,"change_id":"I891ca825e39ad14dda9f220f06d9591874fcd45d","change_number":10287,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"52396d558a82d4d7b0bfbfd82e2d69bd4a60177b":{"kind":"REWORK","_number":7,"created":"2023-12-12 06:51:58.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/88/10288/7","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/88/10288/7","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/88/10288/7"}}},"commit":{"parents":[{"commit":"5f8cb910fbdd55e1c9be7a2b55c37addfbeb332f","subject":"test(tvix/eval): test for b/343","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5f8cb910fbdd55e1c9be7a2b55c37addfbeb332f"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 05:17:22.000000000","tz":-480},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 06:52:10.000000000","tz":-480},"subject":"test(tvix/eval): fix b/343","message":"test(tvix/eval): fix b/343\n\nThis commit adds Opcode::OpJumpIfCatchable, which can be inserted\nahead of most VM operations which expect a boolean on the stack, in\norder to handle catchables in branching position properly.\n\nOther than remembering to patch the jump, no other changes should be\nrequired.\n\nThis commit also fixes b/343 by emitting this new opcode when\ncompiling if-then-else.  There are probably other places where we\nneed to do the same thing.\n\nChange-Id: I48de3010014c0bbeba15d34fc0d4800e0bb5a1ef\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d52396d558a82d4d7b0bfbfd82e2d69bd4a60177b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d52396d558a82d4d7b0bfbfd82e2d69bd4a60177b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"5f8cb910fbdd55e1c9be7a2b55c37addfbeb332f","is_merged_in_target_branch":false,"change_id":"I891ca825e39ad14dda9f220f06d9591874fcd45d","change_number":10287,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"540383dbb3307c8649c17d4fdcd20cb3deb1600b":{"kind":"TRIVIAL_REBASE","_number":8,"created":"2023-12-12 12:04:15.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/88/10288/8","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/88/10288/8","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/88/10288/8"}}},"commit":{"parents":[{"commit":"c987e5b6d7e71472d2d32ddf9c1d4667fe04707a","subject":"test(tvix/eval): test for b/343","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc987e5b6d7e71472d2d32ddf9c1d4667fe04707a"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 05:17:22.000000000","tz":-480},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 12:04:31.000000000","tz":-480},"subject":"test(tvix/eval): fix b/343","message":"test(tvix/eval): fix b/343\n\nThis commit adds Opcode::OpJumpIfCatchable, which can be inserted\nahead of most VM operations which expect a boolean on the stack, in\norder to handle catchables in branching position properly.\n\nOther than remembering to patch the jump, no other changes should be\nrequired.\n\nThis commit also fixes b/343 by emitting this new opcode when\ncompiling if-then-else.  There are probably other places where we\nneed to do the same thing.\n\nChange-Id: I48de3010014c0bbeba15d34fc0d4800e0bb5a1ef\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d540383dbb3307c8649c17d4fdcd20cb3deb1600b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d540383dbb3307c8649c17d4fdcd20cb3deb1600b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c987e5b6d7e71472d2d32ddf9c1d4667fe04707a","is_merged_in_target_branch":false,"change_id":"I891ca825e39ad14dda9f220f06d9591874fcd45d","change_number":10287,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"3ef323552adc10c8d222fe1340641be4c53c401b":{"kind":"REWORK","_number":9,"created":"2023-12-12 14:47:15.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/88/10288/9","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/88/10288/9","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/88/10288/9"}}},"commit":{"parents":[{"commit":"882ed76a792a18fa8e0a51bf35e6da8bb1764842","subject":"test(tvix/eval): test branching on catchable defaults (b/343)","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d882ed76a792a18fa8e0a51bf35e6da8bb1764842"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 05:17:22.000000000","tz":-480},"committer":{"name":"Vincent Ambo","email":"tazjin@tvl.su","date":"2023-12-12 14:39:59.000000000","tz":180},"subject":"fix(tvix/eval): fix branching on catchable defaults (b/343)","message":"fix(tvix/eval): fix branching on catchable defaults (b/343)\n\nThis commit adds Opcode::OpJumpIfCatchable, which can be inserted\nahead of most VM operations which expect a boolean on the stack, in\norder to handle catchables in branching position properly.\n\nOther than remembering to patch the jump, no other changes should be\nrequired.\n\nThis commit also fixes b/343 by emitting this new opcode when\ncompiling if-then-else.  There are probably other places where we\nneed to do the same thing.\n\nChange-Id: I48de3010014c0bbeba15d34fc0d4800e0bb5a1ef\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3ef323552adc10c8d222fe1340641be4c53c401b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3ef323552adc10c8d222fe1340641be4c53c401b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"882ed76a792a18fa8e0a51bf35e6da8bb1764842","is_merged_in_target_branch":false,"change_id":"I891ca825e39ad14dda9f220f06d9591874fcd45d","change_number":10287,"patch_set_number":8,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"9792920f8cdec92aa2c650de8cfd0a85fa7dce52":{"kind":"NO_CODE_CHANGE","_number":10,"created":"2023-12-12 14:55:48.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/88/10288/10","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/88/10288/10","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/88/10288/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/88/10288/10"}}},"commit":{"parents":[{"commit":"e54eeda0ff4b777899491e2a753481e9c73af7df","subject":"test(tvix/eval): test branching on catchable defaults (b/343)","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de54eeda0ff4b777899491e2a753481e9c73af7df"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 05:17:22.000000000","tz":-480},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2023-12-12 14:55:48.000000000","tz":0},"subject":"fix(tvix/eval): fix branching on catchable defaults (b/343)","message":"fix(tvix/eval): fix branching on catchable defaults (b/343)\n\nThis commit adds Opcode::OpJumpIfCatchable, which can be inserted\nahead of most VM operations which expect a boolean on the stack, in\norder to handle catchables in branching position properly.\n\nOther than remembering to patch the jump, no other changes should be\nrequired.\n\nThis commit also fixes b/343 by emitting this new opcode when\ncompiling if-then-else.  There are probably other places where we\nneed to do the same thing.\n\nChange-Id: I48de3010014c0bbeba15d34fc0d4800e0bb5a1ef\nReviewed-on: https://cl.tvl.fyi/c/depot/+/10288\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\nAutosubmit: Adam Joseph \u003cadam@westernsemico.com\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9792920f8cdec92aa2c650de8cfd0a85fa7dce52"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9792920f8cdec92aa2c650de8cfd0a85fa7dce52"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e54eeda0ff4b777899491e2a753481e9c73af7df","is_merged_in_target_branch":true,"change_id":"I891ca825e39ad14dda9f220f06d9591874fcd45d","change_number":10287,"patch_set_number":9,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}