)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"08ef8085821a9fceb6f6b152c7779d277a3bcc63","unresolved":true,"context_lines":[{"line_number":10,"context_line":"builtins.filterSource.  These are not implemented; forcing them will"},{"line_number":11,"context_line":"produce the same result as `throw \"message\"`."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Unfortunately these two post-2.3 features are used throughout"},{"line_number":14,"context_line":"nixpkgs.  Since an unresolved indentifier is a catchable error, this"},{"line_number":15,"context_line":"breaks the entire release eval.  With this commit, it simply causes"},{"line_number":16,"context_line":"those broken packages that use these features to appear as they are:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"96b3b65b_a2020a24","line":13,"updated":"2023-12-12 08:06:26.000000000","message":"https://cs.tvl.fyi/depot/-/blob/tvix/eval/docs/builtins.md states filterSource as not post-2.3. I didn\u0027t check the Nix source code yet, but either this commit message or the listing are wrong then.","commit_id":"c7c41938e575184e6ddc892a815e75c6b9664e68"},{"author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"change_message_id":"b4b16e74dea8ebbd3a717bbb84e6cca80f257d3f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"builtins.filterSource.  These are not implemented; forcing them will"},{"line_number":11,"context_line":"produce the same result as `throw \"message\"`."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Unfortunately these two post-2.3 features are used throughout"},{"line_number":14,"context_line":"nixpkgs.  Since an unresolved indentifier is a catchable error, this"},{"line_number":15,"context_line":"breaks the entire release eval.  With this commit, it simply causes"},{"line_number":16,"context_line":"those broken packages that use these features to appear as they are:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ac4441db_6697bf08","line":13,"in_reply_to":"15320a87_24516b68","updated":"2023-12-12 09:08:37.000000000","message":"Acknowledged","commit_id":"c7c41938e575184e6ddc892a815e75c6b9664e68"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"fed5d758e4a27cc62760b496d315d5d956c229c9","unresolved":true,"context_lines":[{"line_number":10,"context_line":"builtins.filterSource.  These are not implemented; forcing them will"},{"line_number":11,"context_line":"produce the same result as `throw \"message\"`."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Unfortunately these two post-2.3 features are used throughout"},{"line_number":14,"context_line":"nixpkgs.  Since an unresolved indentifier is a catchable error, this"},{"line_number":15,"context_line":"breaks the entire release eval.  With this commit, it simply causes"},{"line_number":16,"context_line":"those broken packages that use these features to appear as they are:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"15320a87_24516b68","line":13,"in_reply_to":"96b3b65b_a2020a24","updated":"2023-12-12 08:41:14.000000000","message":"builtins.filterSource is part of 2.3, we just didn\u0027t get to write it yet, because it might require changes in EvalIO, to allow filter down the list of things to import in the store code.","commit_id":"c7c41938e575184e6ddc892a815e75c6b9664e68"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"f598dee56e4da9401cf156c2e42a3f8eb9a6e287","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fd63eff2_30e15a29","updated":"2023-12-12 08:58:48.000000000","message":"I think both are not post-2.3, we just haven\u0027t implemented them.","commit_id":"c7c41938e575184e6ddc892a815e75c6b9664e68"},{"author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"change_message_id":"b4b16e74dea8ebbd3a717bbb84e6cca80f257d3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3362b3b4_f300905a","in_reply_to":"fd63eff2_30e15a29","updated":"2023-12-12 09:08:37.000000000","message":"Acknowledged","commit_id":"c7c41938e575184e6ddc892a815e75c6b9664e68"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"0e134e15c16e3fc68bf42a58671f472412d6c9e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2f0216d9_a219f79a","updated":"2023-12-12 17:16:16.000000000","message":"I addressed the incorrect comments about what is/isn\u0027t 2.3, and am going ahead with merging this. We can move it around to somewhere else if required (or, better yet, actually implement these things!)","commit_id":"741e03dcbc9babab9ad03ce2937bd98b2cea4bf0"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"c1ef0dc49bd33f6867ecbb311cb9b44a8a9d8a02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7629f47b_4762127a","in_reply_to":"2f0216d9_a219f79a","updated":"2023-12-12 20:38:25.000000000","message":"The commit message unfortunately also mentions 2.3, but well, it\u0027s now merged, so whatever.","commit_id":"741e03dcbc9babab9ad03ce2937bd98b2cea4bf0"}],"tvix/eval/src/builtins/mod.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"fed5d758e4a27cc62760b496d315d5d956c229c9","unresolved":true,"context_lines":[{"line_number":377,"context_line":"        toml::from_str(\u0026toml_str).map_err(|err| err.into())"},{"line_number":378,"context_line":"    }"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    // This post-2.3 feature is used in several places in nixpkgs in"},{"line_number":381,"context_line":"    // spite of lib/minver.nix; throwing an error instead of"},{"line_number":382,"context_line":"    // omitting the attribute allows us to eval the release"},{"line_number":383,"context_line":"    // packageset."}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"d9018f12_6f10e06d","line":380,"updated":"2023-12-12 08:41:14.000000000","message":"not post-2.3.","commit_id":"c7c41938e575184e6ddc892a815e75c6b9664e68"},{"author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"change_message_id":"b4b16e74dea8ebbd3a717bbb84e6cca80f257d3f","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        toml::from_str(\u0026toml_str).map_err(|err| err.into())"},{"line_number":378,"context_line":"    }"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    // This post-2.3 feature is used in several places in nixpkgs in"},{"line_number":381,"context_line":"    // spite of lib/minver.nix; throwing an error instead of"},{"line_number":382,"context_line":"    // omitting the attribute allows us to eval the release"},{"line_number":383,"context_line":"    // packageset."}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"7620d908_36ef86fc","line":380,"in_reply_to":"d9018f12_6f10e06d","updated":"2023-12-12 09:08:37.000000000","message":"Acknowledged","commit_id":"c7c41938e575184e6ddc892a815e75c6b9664e68"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"fed5d758e4a27cc62760b496d315d5d956c229c9","unresolved":true,"context_lines":[{"line_number":384,"context_line":"    #[builtin(\"filterSource\")]"},{"line_number":385,"context_line":"    #[allow(non_snake_case)]"},{"line_number":386,"context_line":"    async fn builtin_filterSource(_co: GenCo, #[lazy] _e: Value) -\u003e Result\u003cValue, ErrorKind\u003e {"},{"line_number":387,"context_line":"        Ok(Value::Catchable(CatchableErrorKind::UnimplementedFeature("},{"line_number":388,"context_line":"            \"filterSource\".to_string(),"},{"line_number":389,"context_line":"        )))"},{"line_number":390,"context_line":"    }"}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"cc0dcff9_9397c81a","line":387,"updated":"2023-12-12 08:41:14.000000000","message":"Shouldn\u0027t handling of non-existent builtins be the same across not yet implemented features? Manually having to list them here sounds odd.","commit_id":"c7c41938e575184e6ddc892a815e75c6b9664e68"},{"author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"change_message_id":"b4b16e74dea8ebbd3a717bbb84e6cca80f257d3f","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    #[builtin(\"filterSource\")]"},{"line_number":385,"context_line":"    #[allow(non_snake_case)]"},{"line_number":386,"context_line":"    async fn builtin_filterSource(_co: GenCo, #[lazy] _e: Value) -\u003e Result\u003cValue, ErrorKind\u003e {"},{"line_number":387,"context_line":"        Ok(Value::Catchable(CatchableErrorKind::UnimplementedFeature("},{"line_number":388,"context_line":"            \"filterSource\".to_string(),"},{"line_number":389,"context_line":"        )))"},{"line_number":390,"context_line":"    }"}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"0de5ae88_bd9af86f","line":387,"in_reply_to":"cc0dcff9_9397c81a","updated":"2023-12-12 09:08:37.000000000","message":"Acknowledged","commit_id":"c7c41938e575184e6ddc892a815e75c6b9664e68"}]}