)]}'
{"id":"depot~10300","triplet_id":"depot~canon~Ibf763a08753e541843626182ff59fdbf15ea2959","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000066":{"account":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"last_update":"2023-12-12 16:09:15.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ibf763a08753e541843626182ff59fdbf15ea2959","subject":"fix(tvix/eval): calling a catchable is catchable","status":"MERGED","created":"2023-12-12 09:56:44.000000000","updated":"2023-12-12 16:09:15.000000000","submitted":"2023-12-12 16:09:15.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10300","meta_rev_id":"f362dd591e42a017bd87776df78f8f0d18f493e6","_number":10300,"virtual_id_number":10300,"owner":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-12-12 16:09:15.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-12-12 16:09:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-12-12 16:09:15.000000000","_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-12-12 09:56:44.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-12-12 10:01:30.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-12-12 16:05:10.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2023-12-12 16:09:15.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7adecd8b368ff1a09a13bc7452746cc973833832","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-12 09:56:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f13dc79f865cc17a15a2a74fd9852cbe4be6756c","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 09:56:44.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/28867","accounts_in_message":[],"_revision_number":1},{"id":"a99c0de84a57f829fb67fd04794c11bfdb020838","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 10:01:30.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/28867","accounts_in_message":[],"_revision_number":1},{"id":"eb2e9dd7e44988efad0e6eac8635630638365f3b","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-12 10:02:14.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"2593fa8b54fc69cbeef26d54c08e5a91bc3303c0","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 10:02:17.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/28870","accounts_in_message":[],"_revision_number":2},{"id":"8627c789eec81c6a13471ae705890ce54096daa6","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 10:07:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/28870","accounts_in_message":[],"_revision_number":2},{"id":"86efa8ddee8d9b67ed360a9f4bbb7ab68388ee58","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-12 10:56:49.000000000","message":"Patch Set 2: Autosubmit+1\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":2},{"id":"381ea851e56675659def3b6cfcb607c8e2bb3579","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-12 12:04:15.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"366bd8b6211151a4bd1c7b64ac4f1f9cbef763a1","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 12:04:39.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/28924","accounts_in_message":[],"_revision_number":3},{"id":"43cfa5be34e08fd6e6c87ff8a461dbc5fa1bf0d1","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 12:32:17.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/28924","accounts_in_message":[],"_revision_number":3},{"id":"04b44b443b683146ed5f3079768635a6a5867f4d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-12-12 14:47:15.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"abb5a01b8b4838c842785bd42322b9b40805d53e","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 14:47:37.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/28985","accounts_in_message":[],"_revision_number":4},{"id":"5fb04994e67cc6be6948fddadb5b25946bacb0c8","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 15:12:20.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/28985","accounts_in_message":[],"_revision_number":4},{"id":"4db036f74c7ef578f9e0677dafb106c5b7085c93","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-12-12 16:02:30.000000000","message":"Uploaded patch set 5.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"813b8f7ae7966266f4a6b75635598d4f97d82208","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 16:02:32.000000000","message":"Patch Set 5:\n\nStarted build for patchset #5 on: https://buildkite.com/tvl/depot/builds/29032","accounts_in_message":[],"_revision_number":5},{"id":"4e901ac0b033db1a68cb8ca6663bfd123832a92a","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-12-12 16:05:10.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"7f3e2eacb43d4f704ea70ec73bdf35046ff023d3","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-12 16:09:06.000000000","message":"Patch Set 5: Verified+1\n\nBuild of patchset 5 passed: https://buildkite.com/tvl/depot/builds/29032","accounts_in_message":[],"_revision_number":5},{"id":"f362dd591e42a017bd87776df78f8f0d18f493e6","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2023-12-12 16:09:15.000000000","message":"Change has been successfully rebased and submitted as 2949ee08f10f11a79af9b90933022ea40039462a","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"2949ee08f10f11a79af9b90933022ea40039462a","revisions":{"33ee1b7534ede9766d0051f2fb63af12dcc54c48":{"kind":"REWORK","_number":1,"created":"2023-12-12 09:56:44.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/00/10300/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/00/10300/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/00/10300/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/00/10300/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/00/10300/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/00/10300/1"}}},"commit":{"parents":[{"commit":"331d82b6bed29420c634d31b8855dd78fa9364c6","subject":"test(tvix/eval): test case for b/351","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d331d82b6bed29420c634d31b8855dd78fa9364c6"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 09:55:24.000000000","tz":-480},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 09:55:24.000000000","tz":-480},"subject":"fix(tvix/eval): calling a catchable is catchable (b/351)","message":"fix(tvix/eval): calling a catchable is catchable (b/351)\n\nWhen attempting to call a Value, if it is a Value::Catchable we must\nnot cause an uncatchable failure.  This commit simply reuses the\nValue::Catchable as the result of attempting to call it.  This is\nsafe because nix is designed so that nix code cannot distinguish\nbetween different catchable failures -- they all look the same to\nthe interpreted code.\n\nChange-Id: Ibf763a08753e541843626182ff59fdbf15ea2959\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d33ee1b7534ede9766d0051f2fb63af12dcc54c48"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d33ee1b7534ede9766d0051f2fb63af12dcc54c48"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"331d82b6bed29420c634d31b8855dd78fa9364c6","is_merged_in_target_branch":false,"change_id":"Ia372230c5193b1ffda0584567bde788910376354","change_number":10299,"patch_set_number":1,"change_status":"ABANDONED"}],"branch":"refs/heads/canon"},"c5f906c08450e0b100a2826955bc2268eca8d4c3":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2023-12-12 10:02:14.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/00/10300/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/00/10300/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/00/10300/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/00/10300/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/00/10300/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/00/10300/2"}}},"commit":{"parents":[{"commit":"0ee1a20cc862a6c7415de34ea1e49fa6464d16e2","subject":"test(tvix/eval): test case for b/351","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0ee1a20cc862a6c7415de34ea1e49fa6464d16e2"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 09:55:24.000000000","tz":-480},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 10:02:29.000000000","tz":-480},"subject":"fix(tvix/eval): calling a catchable is catchable (b/351)","message":"fix(tvix/eval): calling a catchable is catchable (b/351)\n\nWhen attempting to call a Value, if it is a Value::Catchable we must\nnot cause an uncatchable failure.  This commit simply reuses the\nValue::Catchable as the result of attempting to call it.  This is\nsafe because nix is designed so that nix code cannot distinguish\nbetween different catchable failures -- they all look the same to\nthe interpreted code.\n\nChange-Id: Ibf763a08753e541843626182ff59fdbf15ea2959\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc5f906c08450e0b100a2826955bc2268eca8d4c3"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc5f906c08450e0b100a2826955bc2268eca8d4c3"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"0ee1a20cc862a6c7415de34ea1e49fa6464d16e2","is_merged_in_target_branch":false,"change_id":"Ia372230c5193b1ffda0584567bde788910376354","change_number":10299,"patch_set_number":2,"change_status":"ABANDONED"}],"branch":"refs/heads/canon"},"7a2baae2cc88d77d10c8a88986a062b00e4476cf":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2023-12-12 12:04:15.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/00/10300/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/00/10300/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/00/10300/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/00/10300/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/00/10300/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/00/10300/3"}}},"commit":{"parents":[{"commit":"5ca42e14477ef273a6ac16e56c60c3a2d0e8f9bc","subject":"test(tvix/eval): test case for b/351","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5ca42e14477ef273a6ac16e56c60c3a2d0e8f9bc"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 09:55:24.000000000","tz":-480},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 12:04:31.000000000","tz":-480},"subject":"fix(tvix/eval): calling a catchable is catchable (b/351)","message":"fix(tvix/eval): calling a catchable is catchable (b/351)\n\nWhen attempting to call a Value, if it is a Value::Catchable we must\nnot cause an uncatchable failure.  This commit simply reuses the\nValue::Catchable as the result of attempting to call it.  This is\nsafe because nix is designed so that nix code cannot distinguish\nbetween different catchable failures -- they all look the same to\nthe interpreted code.\n\nChange-Id: Ibf763a08753e541843626182ff59fdbf15ea2959\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7a2baae2cc88d77d10c8a88986a062b00e4476cf"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7a2baae2cc88d77d10c8a88986a062b00e4476cf"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"5ca42e14477ef273a6ac16e56c60c3a2d0e8f9bc","is_merged_in_target_branch":false,"change_id":"Ia372230c5193b1ffda0584567bde788910376354","change_number":10299,"patch_set_number":3,"change_status":"ABANDONED"}],"branch":"refs/heads/canon"},"0e7fd2a82293527dff7e798014354f3e58aeece3":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2023-12-12 14:47:15.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/00/10300/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/00/10300/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/00/10300/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/00/10300/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/00/10300/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/00/10300/4"}}},"commit":{"parents":[{"commit":"82584cfa4be856a252ae553dd7c1ecb5f0b90eb0","subject":"test(tvix/eval): test error when attempting to call catchable","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d82584cfa4be856a252ae553dd7c1ecb5f0b90eb0"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 09:55:24.000000000","tz":-480},"committer":{"name":"Vincent Ambo","email":"tazjin@tvl.su","date":"2023-12-12 14:46:47.000000000","tz":180},"subject":"fix(tvix/eval): calling a catchable is catchable (b/351)","message":"fix(tvix/eval): calling a catchable is catchable (b/351)\n\nWhen attempting to call a Value, if it is a Value::Catchable we must\nnot cause an uncatchable failure.  This commit simply reuses the\nValue::Catchable as the result of attempting to call it.  This is\nsafe because nix is designed so that nix code cannot distinguish\nbetween different catchable failures -- they all look the same to\nthe interpreted code.\n\nChange-Id: Ibf763a08753e541843626182ff59fdbf15ea2959\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0e7fd2a82293527dff7e798014354f3e58aeece3"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0e7fd2a82293527dff7e798014354f3e58aeece3"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"82584cfa4be856a252ae553dd7c1ecb5f0b90eb0","is_merged_in_target_branch":false,"change_id":"Ia372230c5193b1ffda0584567bde788910376354","change_number":10299,"patch_set_number":4,"change_status":"ABANDONED"}],"branch":"refs/heads/canon"},"948964355f9126c4c8bc17c3527d2be4e35aa577":{"kind":"REWORK","_number":5,"created":"2023-12-12 16:02:30.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/00/10300/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/00/10300/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/00/10300/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/00/10300/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/00/10300/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/00/10300/5"}}},"commit":{"parents":[{"commit":"52b68c053987c1567bacb6f14dad8ba92cd01afe","subject":"fix(tvix/eval): fix catchables in named formals","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d52b68c053987c1567bacb6f14dad8ba92cd01afe"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 09:52:39.000000000","tz":-480},"committer":{"name":"Vincent Ambo","email":"tazjin@tvl.su","date":"2023-12-12 16:01:39.000000000","tz":180},"subject":"fix(tvix/eval): calling a catchable is catchable","message":"fix(tvix/eval): calling a catchable is catchable\n\nWhen attempting to call a Value, if it is a Value::Catchable we must\nnot cause an uncatchable failure.  This commit simply reuses the\nValue::Catchable as the result of attempting to call it.  This is\nsafe because nix is designed so that nix code cannot distinguish\nbetween different catchable failures -- they all look the same to\nthe interpreted code.\n\nThis fixes b/351.\n\nChange-Id: Ibf763a08753e541843626182ff59fdbf15ea2959\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d948964355f9126c4c8bc17c3527d2be4e35aa577"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d948964355f9126c4c8bc17c3527d2be4e35aa577"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"52b68c053987c1567bacb6f14dad8ba92cd01afe","is_merged_in_target_branch":true,"change_id":"I5e8d56b5fd26a19eac32ec5e11baf93765691dc8","change_number":10296,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"2949ee08f10f11a79af9b90933022ea40039462a":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2023-12-12 16:09:15.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/00/10300/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/00/10300/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/00/10300/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/00/10300/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/00/10300/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/00/10300/6"}}},"commit":{"parents":[{"commit":"52b68c053987c1567bacb6f14dad8ba92cd01afe","subject":"fix(tvix/eval): fix catchables in named formals","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d52b68c053987c1567bacb6f14dad8ba92cd01afe"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-12 09:52:39.000000000","tz":-480},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2023-12-12 16:09:15.000000000","tz":0},"subject":"fix(tvix/eval): calling a catchable is catchable","message":"fix(tvix/eval): calling a catchable is catchable\n\nWhen attempting to call a Value, if it is a Value::Catchable we must\nnot cause an uncatchable failure.  This commit simply reuses the\nValue::Catchable as the result of attempting to call it.  This is\nsafe because nix is designed so that nix code cannot distinguish\nbetween different catchable failures -- they all look the same to\nthe interpreted code.\n\nThis fixes b/351.\n\nChange-Id: Ibf763a08753e541843626182ff59fdbf15ea2959\nReviewed-on: https://cl.tvl.fyi/c/depot/+/10300\nAutosubmit: Adam Joseph \u003cadam@westernsemico.com\u003e\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2949ee08f10f11a79af9b90933022ea40039462a"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2949ee08f10f11a79af9b90933022ea40039462a"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"52b68c053987c1567bacb6f14dad8ba92cd01afe","is_merged_in_target_branch":true,"change_id":"I5e8d56b5fd26a19eac32ec5e11baf93765691dc8","change_number":10296,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}
