)]}'
{"tvix/castore/src/import.rs":[{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"82b4ff8c2dc9bc0252f5ad5d956542f08366e5f7","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    {"},{"line_number":167,"context_line":"        // Entry could be a NotFound, if the root path specified does not exist."},{"line_number":168,"context_line":"        let entry \u003d entry.map_err(|e| {"},{"line_number":169,"context_line":"            Error::UnableToOpen(PathBuf::from(p.as_ref()), e.into_io_error().unwrap())"},{"line_number":170,"context_line":"        })?;"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        // process_entry wants an Option\u003cDirectory\u003e in case the entry points to a directory."}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"4760effe_aeb2605f","line":169,"updated":"2023-12-12 14:22:01.000000000","message":"Can you elaborate on the failure conditions of the unwrap here?","commit_id":"88fcc1b121b3895db12c338c5ac29aace386ca2d"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"19f51cc1968319da23a046268af72a2b94cfaffc","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    {"},{"line_number":167,"context_line":"        // Entry could be a NotFound, if the root path specified does not exist."},{"line_number":168,"context_line":"        let entry \u003d entry.map_err(|e| {"},{"line_number":169,"context_line":"            Error::UnableToOpen(PathBuf::from(p.as_ref()), e.into_io_error().unwrap())"},{"line_number":170,"context_line":"        })?;"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        // process_entry wants an Option\u003cDirectory\u003e in case the entry points to a directory."}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"3d9034cb_f4dc78c4","line":169,"in_reply_to":"189617eb_67a9f7b8","updated":"2023-12-12 15:16:15.000000000","message":"We know e.into_io_error() always succeeds.","commit_id":"88fcc1b121b3895db12c338c5ac29aace386ca2d"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"d5df9b8c086aabfa284a3b3eed8079c20af1bd92","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    {"},{"line_number":167,"context_line":"        // Entry could be a NotFound, if the root path specified does not exist."},{"line_number":168,"context_line":"        let entry \u003d entry.map_err(|e| {"},{"line_number":169,"context_line":"            Error::UnableToOpen(PathBuf::from(p.as_ref()), e.into_io_error().unwrap())"},{"line_number":170,"context_line":"        })?;"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        // process_entry wants an Option\u003cDirectory\u003e in case the entry points to a directory."}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"8d30775a_bf20537c","line":169,"in_reply_to":"3d9034cb_f4dc78c4","updated":"2023-12-12 17:59:46.000000000","message":"https://docs.rs/walkdir/latest/walkdir/struct.IntoIter.html#impl-Iterator-for-IntoIter says:\n\n\u003e If the iterator fails to retrieve the next value, this method returns an error value. The error will be wrapped in an Option::Some.\n\nI made the `unwrap()` an `expect(\"walkdir err must be some\")`, this should suffice.","commit_id":"88fcc1b121b3895db12c338c5ac29aace386ca2d"},{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"080fa91d5225fc85ae00bc22af6f329cc996db8e","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    {"},{"line_number":167,"context_line":"        // Entry could be a NotFound, if the root path specified does not exist."},{"line_number":168,"context_line":"        let entry \u003d entry.map_err(|e| {"},{"line_number":169,"context_line":"            Error::UnableToOpen(PathBuf::from(p.as_ref()), e.into_io_error().unwrap())"},{"line_number":170,"context_line":"        })?;"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        // process_entry wants an Option\u003cDirectory\u003e in case the entry points to a directory."}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"189617eb_67a9f7b8","line":169,"in_reply_to":"4760effe_aeb2605f","updated":"2023-12-12 14:52:36.000000000","message":"Ideally by using `.expect(...)` 😊","commit_id":"88fcc1b121b3895db12c338c5ac29aace386ca2d"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"889684819d91fde1cf86bc7c90ccce20e01c65b5","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    {"},{"line_number":167,"context_line":"        // Entry could be a NotFound, if the root path specified does not exist."},{"line_number":168,"context_line":"        let entry \u003d entry.map_err(|e| {"},{"line_number":169,"context_line":"            Error::UnableToOpen(PathBuf::from(p.as_ref()), e.into_io_error().unwrap())"},{"line_number":170,"context_line":"        })?;"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        // process_entry wants an Option\u003cDirectory\u003e in case the entry points to a directory."}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"fd819945_590847ad","line":169,"in_reply_to":"8d30775a_bf20537c","updated":"2023-12-12 18:00:00.000000000","message":"Marked as resolved.","commit_id":"88fcc1b121b3895db12c338c5ac29aace386ca2d"}]}