)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"55b84c352f94a0428797069c1d4b44331d837f4a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Connor Brewster \u003ccbrewster@hey.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-12-14 11:07:58 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refactor(tvix/store/fs): Remove dependence on PathInfoService from TvixStoreFs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To support tvix builds, we want to be able to use the `TvixStoreFs` to"},{"line_number":10,"context_line":"materialize the sandbox\u0027s /nix/store filesystem with just the list of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"d7ed89ab_367bbd34","line":7,"updated":"2023-12-14 17:28:07.000000000","message":"commit message is too long","commit_id":"69cecf1eae8f988756bd49ec773ae92043621b6f"},{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"7ad877e0e42a4d7cb88d0f4804ca249dc31908b8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Connor Brewster \u003ccbrewster@hey.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-12-14 11:07:58 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refactor(tvix/store/fs): Remove dependence on PathInfoService from TvixStoreFs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To support tvix builds, we want to be able to use the `TvixStoreFs` to"},{"line_number":10,"context_line":"materialize the sandbox\u0027s /nix/store filesystem with just the list of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"2d2bfc52_972b58aa","line":7,"in_reply_to":"d7ed89ab_367bbd34","updated":"2023-12-14 19:29:57.000000000","message":"Done","commit_id":"69cecf1eae8f988756bd49ec773ae92043621b6f"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"55b84c352f94a0428797069c1d4b44331d837f4a","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refactor(tvix/store/fs): Remove dependence on PathInfoService from TvixStoreFs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To support tvix builds, we want to be able to use the `TvixStoreFs` to"},{"line_number":10,"context_line":"materialize the sandbox\u0027s /nix/store filesystem with just the list of"},{"line_number":11,"context_line":"inputs needed for the build. Currently we\u0027d need to implement a new"},{"line_number":12,"context_line":"`PathInfoService` for this which has a larger interface than what is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bd38b4f6_84010a37","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":31},"updated":"2023-12-14 17:28:07.000000000","message":"\"need\". The Nix sandbox actually behaves the same way.","commit_id":"69cecf1eae8f988756bd49ec773ae92043621b6f"},{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"7ad877e0e42a4d7cb88d0f4804ca249dc31908b8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refactor(tvix/store/fs): Remove dependence on PathInfoService from TvixStoreFs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To support tvix builds, we want to be able to use the `TvixStoreFs` to"},{"line_number":10,"context_line":"materialize the sandbox\u0027s /nix/store filesystem with just the list of"},{"line_number":11,"context_line":"inputs needed for the build. Currently we\u0027d need to implement a new"},{"line_number":12,"context_line":"`PathInfoService` for this which has a larger interface than what is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"12249d30_797f9a39","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":31},"in_reply_to":"bd38b4f6_84010a37","updated":"2023-12-14 19:29:57.000000000","message":"Done","commit_id":"69cecf1eae8f988756bd49ec773ae92043621b6f"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"55b84c352f94a0428797069c1d4b44331d837f4a","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To support tvix builds, we want to be able to use the `TvixStoreFs` to"},{"line_number":10,"context_line":"materialize the sandbox\u0027s /nix/store filesystem with just the list of"},{"line_number":11,"context_line":"inputs needed for the build. Currently we\u0027d need to implement a new"},{"line_number":12,"context_line":"`PathInfoService` for this which has a larger interface than what is"},{"line_number":13,"context_line":"required by the `TvixStoreFs`. Instead, we\u0027ll add a new trait which"},{"line_number":14,"context_line":"includes a minimal, non-Nix-specific, interface for querying for CA"},{"line_number":15,"context_line":"nodes based on file/dir name."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"b3540363_4fb7a110","line":13,"range":{"start_line":11,"start_character":52,"end_line":13,"end_character":30},"updated":"2023-12-14 17:28:07.000000000","message":"We\u0027d need to seed an in-memory PathInfoService","commit_id":"69cecf1eae8f988756bd49ec773ae92043621b6f"},{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"7ad877e0e42a4d7cb88d0f4804ca249dc31908b8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To support tvix builds, we want to be able to use the `TvixStoreFs` to"},{"line_number":10,"context_line":"materialize the sandbox\u0027s /nix/store filesystem with just the list of"},{"line_number":11,"context_line":"inputs needed for the build. Currently we\u0027d need to implement a new"},{"line_number":12,"context_line":"`PathInfoService` for this which has a larger interface than what is"},{"line_number":13,"context_line":"required by the `TvixStoreFs`. Instead, we\u0027ll add a new trait which"},{"line_number":14,"context_line":"includes a minimal, non-Nix-specific, interface for querying for CA"},{"line_number":15,"context_line":"nodes based on file/dir name."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"14b58a19_224a6c40","line":13,"range":{"start_line":11,"start_character":52,"end_line":13,"end_character":30},"in_reply_to":"b3540363_4fb7a110","updated":"2023-12-14 19:29:57.000000000","message":"Done","commit_id":"69cecf1eae8f988756bd49ec773ae92043621b6f"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"55b84c352f94a0428797069c1d4b44331d837f4a","unresolved":true,"context_lines":[{"line_number":11,"context_line":"inputs needed for the build. Currently we\u0027d need to implement a new"},{"line_number":12,"context_line":"`PathInfoService` for this which has a larger interface than what is"},{"line_number":13,"context_line":"required by the `TvixStoreFs`. Instead, we\u0027ll add a new trait which"},{"line_number":14,"context_line":"includes a minimal, non-Nix-specific, interface for querying for CA"},{"line_number":15,"context_line":"nodes based on file/dir name."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also removes any reference to `StorePath` in the `TvixStoreFs`,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"d5805ae8_b7d03882","line":14,"updated":"2023-12-14 17:28:07.000000000","message":"tvix-castore","commit_id":"69cecf1eae8f988756bd49ec773ae92043621b6f"},{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"7ad877e0e42a4d7cb88d0f4804ca249dc31908b8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"inputs needed for the build. Currently we\u0027d need to implement a new"},{"line_number":12,"context_line":"`PathInfoService` for this which has a larger interface than what is"},{"line_number":13,"context_line":"required by the `TvixStoreFs`. Instead, we\u0027ll add a new trait which"},{"line_number":14,"context_line":"includes a minimal, non-Nix-specific, interface for querying for CA"},{"line_number":15,"context_line":"nodes based on file/dir name."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also removes any reference to `StorePath` in the `TvixStoreFs`,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bc771a6d_d4aa76f9","line":14,"in_reply_to":"d5805ae8_b7d03882","updated":"2023-12-14 19:29:57.000000000","message":"Done","commit_id":"69cecf1eae8f988756bd49ec773ae92043621b6f"}],"tvix/store/src/fs/lookup.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"18528755ed8bd5b638e6aa33c6befe9393c3b55a","unresolved":true,"context_lines":[{"line_number":7,"context_line":"use crate::pathinfoservice::PathInfoService;"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"#[async_trait]"},{"line_number":10,"context_line":"pub trait Lookup: Send + Sync {"},{"line_number":11,"context_line":"    async fn get(\u0026self, digest: [u8; 20]) -\u003e Result\u003cOption\u003cNode\u003e, Error\u003e;"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    fn list(\u0026self) -\u003e Pin\u003cBox\u003cdyn Stream\u003cItem \u003d Result\u003cNode, Error\u003e\u003e + Send\u003e\u003e;"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"140259ee_af986611","line":10,"updated":"2023-12-14 16:25:32.000000000","message":"NodeBy[Base]Name? Also, needs a docstring explaining this is used by TvixStoreFS to work for all things implementing that trait, not just `PathInfoService`s.","commit_id":"18020f496634b57112579546ad1737d3396d3c5c"},{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"9dee1b31f9d372473e467967ae90511afb817ea1","unresolved":true,"context_lines":[{"line_number":7,"context_line":"use crate::pathinfoservice::PathInfoService;"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"#[async_trait]"},{"line_number":10,"context_line":"pub trait Lookup: Send + Sync {"},{"line_number":11,"context_line":"    async fn get(\u0026self, digest: [u8; 20]) -\u003e Result\u003cOption\u003cNode\u003e, Error\u003e;"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    fn list(\u0026self) -\u003e Pin\u003cBox\u003cdyn Stream\u003cItem \u003d Result\u003cNode, Error\u003e\u003e + Send\u003e\u003e;"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"e42cc4ba_1754c18f","line":10,"in_reply_to":"140259ee_af986611","updated":"2023-12-14 17:03:07.000000000","message":"Renamed this to `RootNodes`, does that sound okay? NodeByName sounded to specific since this also offers a list method.","commit_id":"18020f496634b57112579546ad1737d3396d3c5c"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"2749b01367779f62f1a0623d27208c131cb60123","unresolved":false,"context_lines":[{"line_number":7,"context_line":"use crate::pathinfoservice::PathInfoService;"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"#[async_trait]"},{"line_number":10,"context_line":"pub trait Lookup: Send + Sync {"},{"line_number":11,"context_line":"    async fn get(\u0026self, digest: [u8; 20]) -\u003e Result\u003cOption\u003cNode\u003e, Error\u003e;"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    fn list(\u0026self) -\u003e Pin\u003cBox\u003cdyn Stream\u003cItem \u003d Result\u003cNode, Error\u003e\u003e + Send\u003e\u003e;"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"7dd888dc_ec9b6267","line":10,"in_reply_to":"e42cc4ba_1754c18f","updated":"2023-12-14 21:27:26.000000000","message":"ok","commit_id":"18020f496634b57112579546ad1737d3396d3c5c"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"18528755ed8bd5b638e6aa33c6befe9393c3b55a","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"#[async_trait]"},{"line_number":10,"context_line":"pub trait Lookup: Send + Sync {"},{"line_number":11,"context_line":"    async fn get(\u0026self, digest: [u8; 20]) -\u003e Result\u003cOption\u003cNode\u003e, Error\u003e;"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    fn list(\u0026self) -\u003e Pin\u003cBox\u003cdyn Stream\u003cItem \u003d Result\u003cNode, Error\u003e\u003e + Send\u003e\u003e;"},{"line_number":14,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"c20c0ab2_18cd2df4","line":11,"updated":"2023-12-14 16:25:32.000000000","message":"should look up from a \u0026[u8] basename to a node","commit_id":"18020f496634b57112579546ad1737d3396d3c5c"},{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"9dee1b31f9d372473e467967ae90511afb817ea1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"#[async_trait]"},{"line_number":10,"context_line":"pub trait Lookup: Send + Sync {"},{"line_number":11,"context_line":"    async fn get(\u0026self, digest: [u8; 20]) -\u003e Result\u003cOption\u003cNode\u003e, Error\u003e;"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    fn list(\u0026self) -\u003e Pin\u003cBox\u003cdyn Stream\u003cItem \u003d Result\u003cNode, Error\u003e\u003e + Send\u003e\u003e;"},{"line_number":14,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"7c16c11f_e57c994d","line":11,"in_reply_to":"c20c0ab2_18cd2df4","updated":"2023-12-14 17:03:07.000000000","message":"Done","commit_id":"18020f496634b57112579546ad1737d3396d3c5c"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"18528755ed8bd5b638e6aa33c6befe9393c3b55a","unresolved":true,"context_lines":[{"line_number":23,"context_line":"            .deref()"},{"line_number":24,"context_line":"            .get(digest)"},{"line_number":25,"context_line":"            .await?"},{"line_number":26,"context_line":"            .map(|path_info| path_info.node.unwrap().node.unwrap()))"},{"line_number":27,"context_line":"    }"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fn list(\u0026self) -\u003e Pin\u003cBox\u003cdyn Stream\u003cItem \u003d Result\u003cNode, Error\u003e\u003e + Send\u003e\u003e {"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"cad7c8ae_79a5e179","line":26,"updated":"2023-12-14 16:25:32.000000000","message":"expect(\"missing root node\")","commit_id":"18020f496634b57112579546ad1737d3396d3c5c"},{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"9dee1b31f9d372473e467967ae90511afb817ea1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"            .deref()"},{"line_number":24,"context_line":"            .get(digest)"},{"line_number":25,"context_line":"            .await?"},{"line_number":26,"context_line":"            .map(|path_info| path_info.node.unwrap().node.unwrap()))"},{"line_number":27,"context_line":"    }"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fn list(\u0026self) -\u003e Pin\u003cBox\u003cdyn Stream\u003cItem \u003d Result\u003cNode, Error\u003e\u003e + Send\u003e\u003e {"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"6fa7af46_033b97b3","line":26,"in_reply_to":"cad7c8ae_79a5e179","updated":"2023-12-14 17:03:07.000000000","message":"Done","commit_id":"18020f496634b57112579546ad1737d3396d3c5c"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"18528755ed8bd5b638e6aa33c6befe9393c3b55a","unresolved":true,"context_lines":[{"line_number":30,"context_line":"        Box::pin("},{"line_number":31,"context_line":"            self.deref()"},{"line_number":32,"context_line":"                .list()"},{"line_number":33,"context_line":"                .map(|result| result.map(|path_info| path_info.node.unwrap().node.unwrap())),"},{"line_number":34,"context_line":"        )"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"1656275b_18a3a28d","line":33,"updated":"2023-12-14 16:25:32.000000000","message":"expect(\"missing root node\")","commit_id":"18020f496634b57112579546ad1737d3396d3c5c"},{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"9dee1b31f9d372473e467967ae90511afb817ea1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        Box::pin("},{"line_number":31,"context_line":"            self.deref()"},{"line_number":32,"context_line":"                .list()"},{"line_number":33,"context_line":"                .map(|result| result.map(|path_info| path_info.node.unwrap().node.unwrap())),"},{"line_number":34,"context_line":"        )"},{"line_number":35,"context_line":"    }"},{"line_number":36,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"e0083bd7_5d698150","line":33,"in_reply_to":"1656275b_18a3a28d","updated":"2023-12-14 17:03:07.000000000","message":"Done","commit_id":"18020f496634b57112579546ad1737d3396d3c5c"}],"tvix/store/src/fs/mod.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"18528755ed8bd5b638e6aa33c6befe9393c3b55a","unresolved":true,"context_lines":[{"line_number":45,"context_line":"};"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"/// This implements a read-only FUSE filesystem for a tvix-store"},{"line_number":48,"context_line":"/// with the passed [BlobService], [DirectoryService] and [PathInfoService]."},{"line_number":49,"context_line":"///"},{"line_number":50,"context_line":"/// We don\u0027t allow listing on the root mountpoint (inode 0)."},{"line_number":51,"context_line":"/// In the future, this might be made configurable once a listing method is"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"5f126f8d_354d3053","line":48,"updated":"2023-12-14 16:25:32.000000000","message":"This comment needs updating","commit_id":"18020f496634b57112579546ad1737d3396d3c5c"},{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"9dee1b31f9d372473e467967ae90511afb817ea1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"};"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"/// This implements a read-only FUSE filesystem for a tvix-store"},{"line_number":48,"context_line":"/// with the passed [BlobService], [DirectoryService] and [PathInfoService]."},{"line_number":49,"context_line":"///"},{"line_number":50,"context_line":"/// We don\u0027t allow listing on the root mountpoint (inode 0)."},{"line_number":51,"context_line":"/// In the future, this might be made configurable once a listing method is"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"410e058d_5ba7ea71","line":48,"in_reply_to":"5f126f8d_354d3053","updated":"2023-12-14 17:03:07.000000000","message":"Done","commit_id":"18020f496634b57112579546ad1737d3396d3c5c"}],"tvix/store/src/fs/root_nodes.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"55b84c352f94a0428797069c1d4b44331d837f4a","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"use crate::pathinfoservice::PathInfoService;"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"/// Provides an interface for looking up root nodes for the filesystem."},{"line_number":11,"context_line":"///"},{"line_number":12,"context_line":"/// The filesystem is expected to be structured as root directory containing"},{"line_number":13,"context_line":"/// a flat listing of entries which correspond to nodes from the CA store."}],"source_content_type":"text/x-rustsrc","patch_set":5,"id":"c6240157_6eb4bbe5","line":10,"range":{"start_line":10,"start_character":52,"end_line":10,"end_character":70},"updated":"2023-12-14 17:28:07.000000000","message":"s#for the filesystem#in tvix-castore by given a lookup key (usually the basename), and optionally allow a listing.","commit_id":"69cecf1eae8f988756bd49ec773ae92043621b6f"},{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"7ad877e0e42a4d7cb88d0f4804ca249dc31908b8","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"use crate::pathinfoservice::PathInfoService;"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"/// Provides an interface for looking up root nodes for the filesystem."},{"line_number":11,"context_line":"///"},{"line_number":12,"context_line":"/// The filesystem is expected to be structured as root directory containing"},{"line_number":13,"context_line":"/// a flat listing of entries which correspond to nodes from the CA store."}],"source_content_type":"text/x-rustsrc","patch_set":5,"id":"98ae03ba_6e8aed54","line":10,"range":{"start_line":10,"start_character":52,"end_line":10,"end_character":70},"in_reply_to":"c6240157_6eb4bbe5","updated":"2023-12-14 19:29:57.000000000","message":"Done","commit_id":"69cecf1eae8f988756bd49ec773ae92043621b6f"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"55b84c352f94a0428797069c1d4b44331d837f4a","unresolved":true,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"/// Provides an interface for looking up root nodes for the filesystem."},{"line_number":11,"context_line":"///"},{"line_number":12,"context_line":"/// The filesystem is expected to be structured as root directory containing"},{"line_number":13,"context_line":"/// a flat listing of entries which correspond to nodes from the CA store."},{"line_number":14,"context_line":"///"},{"line_number":15,"context_line":"/// This trait allows for the filesystem to be decoupled from the PathInfoService"}],"source_content_type":"text/x-rustsrc","patch_set":5,"id":"5ccd37dd_cccb6e36","line":12,"updated":"2023-12-14 17:28:07.000000000","message":"I\u0027d move these docs to the impl for PathInfoService.","commit_id":"69cecf1eae8f988756bd49ec773ae92043621b6f"},{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"7ad877e0e42a4d7cb88d0f4804ca249dc31908b8","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"/// Provides an interface for looking up root nodes for the filesystem."},{"line_number":11,"context_line":"///"},{"line_number":12,"context_line":"/// The filesystem is expected to be structured as root directory containing"},{"line_number":13,"context_line":"/// a flat listing of entries which correspond to nodes from the CA store."},{"line_number":14,"context_line":"///"},{"line_number":15,"context_line":"/// This trait allows for the filesystem to be decoupled from the PathInfoService"}],"source_content_type":"text/x-rustsrc","patch_set":5,"id":"c26e2fc6_d8c41635","line":12,"in_reply_to":"5ccd37dd_cccb6e36","updated":"2023-12-14 19:29:57.000000000","message":"Done","commit_id":"69cecf1eae8f988756bd49ec773ae92043621b6f"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"55b84c352f94a0428797069c1d4b44331d837f4a","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    /// directory of the filesystem."},{"line_number":21,"context_line":"    async fn get_by_basename(\u0026self, name: \u0026[u8]) -\u003e Result\u003cOption\u003cNode\u003e, Error\u003e;"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    /// Lists all root CA nodes in the filesystem."},{"line_number":24,"context_line":"    fn list(\u0026self) -\u003e Pin\u003cBox\u003cdyn Stream\u003cItem \u003d Result\u003cNode, Error\u003e\u003e + Send\u003e\u003e;"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":5,"id":"4366246d_6c47be36","line":23,"updated":"2023-12-14 17:28:07.000000000","message":"… an error can be returned in case listing is not allowed.","commit_id":"69cecf1eae8f988756bd49ec773ae92043621b6f"},{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"7ad877e0e42a4d7cb88d0f4804ca249dc31908b8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    /// directory of the filesystem."},{"line_number":21,"context_line":"    async fn get_by_basename(\u0026self, name: \u0026[u8]) -\u003e Result\u003cOption\u003cNode\u003e, Error\u003e;"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    /// Lists all root CA nodes in the filesystem."},{"line_number":24,"context_line":"    fn list(\u0026self) -\u003e Pin\u003cBox\u003cdyn Stream\u003cItem \u003d Result\u003cNode, Error\u003e\u003e + Send\u003e\u003e;"},{"line_number":25,"context_line":"}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":5,"id":"9e96b1cb_26d180e1","line":23,"in_reply_to":"4366246d_6c47be36","updated":"2023-12-14 19:29:57.000000000","message":"Done","commit_id":"69cecf1eae8f988756bd49ec773ae92043621b6f"}]}