)]}'
{"id":"depot~10369","triplet_id":"depot~canon~I9d8b4bd1702d954e325832c5935b0d7e3eb68422","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2023-12-29 21:34:45.000000000","reason":"Change was submitted"},"1000066":{"account":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"last_update":"2023-12-29 21:34:45.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2023-12-29 21:21:12.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I9d8b4bd1702d954e325832c5935b0d7e3eb68422","subject":"fix(tvix/eval): add stack depth assertion to OpReturn","status":"MERGED","created":"2023-12-15 12:36:37.000000000","updated":"2023-12-29 21:34:45.000000000","submitted":"2023-12-29 21:34:45.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10359","meta_rev_id":"619f2a78048ca7a12facbc01dec508170d2d796c","_number":10369,"virtual_id_number":10369,"owner":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2023-12-29 21:34:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2023-12-29 21:34:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-12-15 12:36:37.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-12-15 12:41:00.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-12-15 22:11:30.000000000","updated_by":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2023-12-15 22:11:30.000000000","updated_by":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"reviewer":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"state":"REVIEWER"}],"messages":[{"id":"309dd2aa031cb37d9967b8e4171dc9fa065bc71e","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-15 12:36:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fe77440f74d43107261ededf503d998d0f417fbe","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-15 12:36:37.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/29303","accounts_in_message":[],"_revision_number":1},{"id":"fb4b20e51f18f764b0daee0dbace33245c4c57fc","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-15 12:41:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/29303","accounts_in_message":[],"_revision_number":1},{"id":"6e67323fd7540ab16b0e83cc6c2ce972489a6414","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-15 22:08:31.000000000","message":"Patch Set 1: Autosubmit+1\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":1},{"id":"7a99f8305bcfd00d1ee899971020b4fa8a845699","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-15 22:10:15.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"375858b5edd3b63300d0b98c69a0fa2b93275e75","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-15 22:10:17.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/29307","accounts_in_message":[],"_revision_number":2},{"id":"6751bc60d48903ef65f411447103a17692f6541a","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-15 22:11:30.000000000","message":"Patch Set 2: Autosubmit+1","accounts_in_message":[],"_revision_number":2},{"id":"fbc112841143ab6876eb82a66e7bd55dd8b7ceb9","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"date":"2023-12-15 22:11:30.000000000","message":"\u003cGERRIT_ACCOUNT_1000034\u003e, who was added as reviewer owns the following files:\n* `tvix/eval/src/vm/mod.rs`\n\n\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* `tvix/eval/src/vm/mod.rs`\n","accounts_in_message":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":2},{"id":"ab1b9540f8f9bdc35d473cbf17cd0ecee7b786e9","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-15 22:14:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/29307","accounts_in_message":[],"_revision_number":2},{"id":"c430fbfcd048f4ef35a0651b8b25aeaee6518137","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2023-12-17 16:06:37.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"982335458d2040ee6ba891e8e54a3391e046be8b","tag":"autogenerated:gerrit:deleteVote","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-12-29 21:06:05.000000000","message":"Removed Autosubmit+1 by \u003cGERRIT_ACCOUNT_1000066\u003e\n","accounts_in_message":[{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"}],"_revision_number":2},{"id":"f0c09f9e3147f991a088fd27f19aca3ed57dc17a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-12-29 21:21:12.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"4279eac4094d3111e525eb50da63a065c882cd85","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-12-29 21:21:12.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"455cc21598b11b90f23648d023d354a83a6650c9","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-29 21:21:14.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/29931","accounts_in_message":[],"_revision_number":3},{"id":"3727c607a203cf08afaf7aaeb76b51400af97dfa","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2023-12-29 21:25:44.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/29931","accounts_in_message":[],"_revision_number":3},{"id":"568afb4961203bf81b2823de29567b50342fe832","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-12-29 21:33:22.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"619f2a78048ca7a12facbc01dec508170d2d796c","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2023-12-29 21:34:45.000000000","message":"Change has been successfully rebased and submitted as 0c22454bb93648155b8be4b45fb5d5c8f0389673","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"0c22454bb93648155b8be4b45fb5d5c8f0389673","revisions":{"79f809f58d0400875040794b65825f925f097f32":{"kind":"REWORK","_number":1,"created":"2023-12-15 12:36:37.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/69/10369/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/69/10369/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/69/10369/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/69/10369/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/69/10369/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/69/10369/1"}}},"commit":{"parents":[{"commit":"6815572274c1e61b19bd386d52030e09289a511c","subject":"refactor(tvix/store/fs): Decouple TvixStoreFs from Nix concepts","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6815572274c1e61b19bd386d52030e09289a511c"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-15 10:50:33.000000000","tz":-480},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-15 12:31:03.000000000","tz":-480},"subject":"fix(tvix/eval): add stack depth assertion to OpReturn","message":"fix(tvix/eval): add stack depth assertion to OpReturn\n\nI\u0027m still trying to work out the exact stack invariants for tvix.\nWe really should add assertions for them; getting the stack messed\nup is no fun.  This commit adds one simple assertion.  It also adds\na missing stack-push (my mistake) in one place, which was uncovered\nby the assertion.\n\nChange-Id: I9d8b4bd1702d954e325832c5935b0d7e3eb68422\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d79f809f58d0400875040794b65825f925f097f32"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d79f809f58d0400875040794b65825f925f097f32"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6815572274c1e61b19bd386d52030e09289a511c","is_merged_in_target_branch":true,"change_id":"I928372955017c23b1bf2b37190cbc508a4ed10d5","change_number":10363,"patch_set_number":8,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"6cab0bfed74533251e81dccb2ef5c0aa29dbe2da":{"kind":"REWORK","_number":2,"created":"2023-12-15 22:10:15.000000000","uploader":{"_account_id":1000066,"name":"Adam Joseph","display_name":"amjoseph","email":"adam@westernsemico.com","username":"amjoseph"},"ref":"refs/changes/69/10369/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/69/10369/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/69/10369/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/69/10369/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/69/10369/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/69/10369/2"}}},"commit":{"parents":[{"commit":"6815572274c1e61b19bd386d52030e09289a511c","subject":"refactor(tvix/store/fs): Decouple TvixStoreFs from Nix concepts","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6815572274c1e61b19bd386d52030e09289a511c"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-15 10:50:33.000000000","tz":-480},"committer":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-15 22:10:33.000000000","tz":-480},"subject":"fix(tvix/eval): add stack depth assertion to OpReturn","message":"fix(tvix/eval): add stack depth assertion to OpReturn\n\nI\u0027m still trying to work out the exact stack invariants for tvix.\nWe really should add assertions for them; getting the stack messed\nup is no fun.  This commit adds one simple assertion.  It also adds\na missing stack-push (my mistake) in one place, which was uncovered\nby the assertion.\n\nChange-Id: I9d8b4bd1702d954e325832c5935b0d7e3eb68422\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6cab0bfed74533251e81dccb2ef5c0aa29dbe2da"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6cab0bfed74533251e81dccb2ef5c0aa29dbe2da"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6815572274c1e61b19bd386d52030e09289a511c","is_merged_in_target_branch":true,"change_id":"I928372955017c23b1bf2b37190cbc508a4ed10d5","change_number":10363,"patch_set_number":8,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"61c1cedba6c82881b231ac7ca513ed131db928f0":{"kind":"REWORK","_number":3,"created":"2023-12-29 21:21:12.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/69/10369/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/69/10369/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/69/10369/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/69/10369/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/69/10369/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/69/10369/3"}}},"commit":{"parents":[{"commit":"8a52c7f1c54937c44ed1cdb6f7e7c84070828623","subject":"feat(tvix/castore/fs): borrow some matches","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8a52c7f1c54937c44ed1cdb6f7e7c84070828623"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-15 10:50:33.000000000","tz":-480},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2023-12-29 21:05:43.000000000","tz":180},"subject":"fix(tvix/eval): add stack depth assertion to OpReturn","message":"fix(tvix/eval): add stack depth assertion to OpReturn\n\nI\u0027m still trying to work out the exact stack invariants for tvix.\nWe really should add assertions for them; getting the stack messed\nup is no fun.  This commit adds one simple assertion.  It also adds\na missing stack-push (my mistake) in one place, which was uncovered\nby the assertion.\n\nChange-Id: I9d8b4bd1702d954e325832c5935b0d7e3eb68422\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d61c1cedba6c82881b231ac7ca513ed131db928f0"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d61c1cedba6c82881b231ac7ca513ed131db928f0"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8a52c7f1c54937c44ed1cdb6f7e7c84070828623","is_merged_in_target_branch":true,"change_id":"I6073f7ec7aff717ae3069e28a00b1cb408a50ceb","change_number":10455,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"0c22454bb93648155b8be4b45fb5d5c8f0389673":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2023-12-29 21:34:45.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/69/10369/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/69/10369/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/69/10369/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/69/10369/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/69/10369/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/69/10369/4"}}},"commit":{"parents":[{"commit":"8a52c7f1c54937c44ed1cdb6f7e7c84070828623","subject":"feat(tvix/castore/fs): borrow some matches","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8a52c7f1c54937c44ed1cdb6f7e7c84070828623"}]}],"author":{"name":"Adam Joseph","email":"adam@westernsemico.com","date":"2023-12-15 10:50:33.000000000","tz":-480},"committer":{"name":"tazjin","email":"tazjin@tvl.su","date":"2023-12-29 21:34:45.000000000","tz":0},"subject":"fix(tvix/eval): add stack depth assertion to OpReturn","message":"fix(tvix/eval): add stack depth assertion to OpReturn\n\nI\u0027m still trying to work out the exact stack invariants for tvix.\nWe really should add assertions for them; getting the stack messed\nup is no fun.  This commit adds one simple assertion.  It also adds\na missing stack-push (my mistake) in one place, which was uncovered\nby the assertion.\n\nChange-Id: I9d8b4bd1702d954e325832c5935b0d7e3eb68422\nReviewed-on: https://cl.tvl.fyi/c/depot/+/10369\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0c22454bb93648155b8be4b45fb5d5c8f0389673"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0c22454bb93648155b8be4b45fb5d5c8f0389673"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8a52c7f1c54937c44ed1cdb6f7e7c84070828623","is_merged_in_target_branch":true,"change_id":"I6073f7ec7aff717ae3069e28a00b1cb408a50ceb","change_number":10455,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}