)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"174a80c8c1feef18372c3ab901c2d3c7d4cc1af0","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"feat(tvix/glue): add test for output path calculation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This test serves as a minimal reproducer for output path calculation."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Derivations with the same name and output hash, but different build"},{"line_number":12,"context_line":"recipe should end up with the same outPath."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bc93a592_f493d3e1","line":9,"updated":"2023-12-24 21:52:39.000000000","message":"I reverted cl/9364 and surprisingly this doesn\u0027t panic (and succeeds), so unsure what exactly is broken and cl/9364 was preventing.","commit_id":"ec3ce60f198290db9c145ebd6315a8e50d8ef245"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"076fdf7726cc45a197dfa6694280509e9dd9a55b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"feat(tvix/glue): add test for output path calculation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This test serves as a minimal reproducer for output path calculation."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Derivations with the same name and output hash, but different build"},{"line_number":12,"context_line":"recipe should end up with the same outPath."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fe43548b_51debd42","line":9,"in_reply_to":"06243ebb_57dffde0","updated":"2024-01-08 11:09:09.000000000","message":"The chain landed, I rebased this by myself.","commit_id":"ec3ce60f198290db9c145ebd6315a8e50d8ef245"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"322c05f048d81889f288ab4fb1923feb827e4617","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"feat(tvix/glue): add test for output path calculation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This test serves as a minimal reproducer for output path calculation."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Derivations with the same name and output hash, but different build"},{"line_number":12,"context_line":"recipe should end up with the same outPath."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"06243ebb_57dffde0","line":9,"in_reply_to":"bc93a592_f493d3e1","updated":"2024-01-03 13:50:08.000000000","message":"The string context chain fixes the panicing stuff properly, but this test no matter makes sense to have.\n\n@tvl@lahfa.xyz this needs to be rebased on top of the string context chain, can you do that?","commit_id":"ec3ce60f198290db9c145ebd6315a8e50d8ef245"}],"tvix/glue/src/builtins/mod.rs":[{"author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"change_message_id":"8ef2a336fffddb1db15f7fcdf76d24e60cc71f0d","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    fn test_fod_outpath_different_name() {"},{"line_number":167,"context_line":"        let code \u003d r#\""},{"line_number":168,"context_line":"          (builtins.derivation { name \u003d \"foo\"; builder \u003d \"/bin/sh\"; system \u003d \"x86_64-linux\"; outputHash \u003d \"sha256-Q3QXOoy+iN4VK2CflvRulYvPZXYgF0dO7FoF7CvWFTA\u003d\"; }).outPath \u003d\u003d"},{"line_number":169,"context_line":"          (builtins.derivation { name \u003d \"bar\"; builder \u003d \"/bin/sh\"; system \u003d \"x86_64-linux\"; outputHash \u003d \"sha256-Q3QXOoy+iN4VK2CflvRulYvPZXYgF0dO7FoF7CvWFTA\u003d\"; }).outPath"},{"line_number":170,"context_line":"        \"#;"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        let value \u003d eval(code).value.expect(\"must succeed\");"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"34d00058_877f5dbc","line":169,"range":{"start_line":169,"start_character":164,"end_line":169,"end_character":171},"updated":"2023-12-24 23:34:02.000000000","message":"I don\u0027t think the out*Path* should be the same here? This expr returns `false` in C++ Nix.","commit_id":"ec3ce60f198290db9c145ebd6315a8e50d8ef245"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"c7f514f2bb992f6046253403b243fc573cbb3e21","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    fn test_fod_outpath_different_name() {"},{"line_number":167,"context_line":"        let code \u003d r#\""},{"line_number":168,"context_line":"          (builtins.derivation { name \u003d \"foo\"; builder \u003d \"/bin/sh\"; system \u003d \"x86_64-linux\"; outputHash \u003d \"sha256-Q3QXOoy+iN4VK2CflvRulYvPZXYgF0dO7FoF7CvWFTA\u003d\"; }).outPath \u003d\u003d"},{"line_number":169,"context_line":"          (builtins.derivation { name \u003d \"bar\"; builder \u003d \"/bin/sh\"; system \u003d \"x86_64-linux\"; outputHash \u003d \"sha256-Q3QXOoy+iN4VK2CflvRulYvPZXYgF0dO7FoF7CvWFTA\u003d\"; }).outPath"},{"line_number":170,"context_line":"        \"#;"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        let value \u003d eval(code).value.expect(\"must succeed\");"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"571dbc5d_f69ade18","line":169,"range":{"start_line":169,"start_character":164,"end_line":169,"end_character":171},"in_reply_to":"34d00058_877f5dbc","updated":"2023-12-25 06:59:51.000000000","message":"The docstring is wrong. I updated it in a local version, and also moved the assertion to be not equal to the nix expression itself.\n\nNethertheless, tvix seems to behave as expected (with the panic cl removed), so I\u0027m still missing a reproducer for the bug we\u0027re trying to prevent there.","commit_id":"ec3ce60f198290db9c145ebd6315a8e50d8ef245"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"397230a018b16ace903d596d644c526fcef968e8","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    fn test_fod_outpath_different_name() {"},{"line_number":167,"context_line":"        let code \u003d r#\""},{"line_number":168,"context_line":"          (builtins.derivation { name \u003d \"foo\"; builder \u003d \"/bin/sh\"; system \u003d \"x86_64-linux\"; outputHash \u003d \"sha256-Q3QXOoy+iN4VK2CflvRulYvPZXYgF0dO7FoF7CvWFTA\u003d\"; }).outPath \u003d\u003d"},{"line_number":169,"context_line":"          (builtins.derivation { name \u003d \"bar\"; builder \u003d \"/bin/sh\"; system \u003d \"x86_64-linux\"; outputHash \u003d \"sha256-Q3QXOoy+iN4VK2CflvRulYvPZXYgF0dO7FoF7CvWFTA\u003d\"; }).outPath"},{"line_number":170,"context_line":"        \"#;"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        let value \u003d eval(code).value.expect(\"must succeed\");"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"40a1ae06_79884d1d","line":169,"range":{"start_line":169,"start_character":164,"end_line":169,"end_character":171},"in_reply_to":"571dbc5d_f69ade18","updated":"2023-12-25 15:21:43.000000000","message":"I pushed the new version with the updated docstring and negation already inside Nix code.","commit_id":"ec3ce60f198290db9c145ebd6315a8e50d8ef245"}]}