)]}'
{"tvix/glue/src/builtins/derivation.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"775c54a346aa9661d6619cc242b3f99824d6b2bf","unresolved":true,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        let mut drv \u003d Derivation::default();"},{"line_number":200,"context_line":"        drv.outputs.insert(\"out\".to_string(), Default::default());"},{"line_number":201,"context_line":"        let mut input_context \u003d NixContext::new();"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        async fn select_string("},{"line_number":204,"context_line":"            co: \u0026GenCo,"}],"source_content_type":"text/x-rustsrc","patch_set":4,"id":"148f88dd_fce7def0","line":201,"updated":"2024-01-11 20:11:05.000000000","message":"I think I broke the contexts somewhere, currently the output path calculation is wrong. @tvl@lahfa.xyz, can you take a look?","commit_id":"b6592dff474c6c14a0e622f16a3b5cffbe5824c1"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"751b29ff60bb923c8c95fc03672fe398454a0685","unresolved":true,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        let mut drv \u003d Derivation::default();"},{"line_number":200,"context_line":"        drv.outputs.insert(\"out\".to_string(), Default::default());"},{"line_number":201,"context_line":"        let mut input_context \u003d NixContext::new();"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        async fn select_string("},{"line_number":204,"context_line":"            co: \u0026GenCo,"}],"source_content_type":"text/x-rustsrc","patch_set":4,"id":"8c4dc6e7_aa78dd4e","line":201,"in_reply_to":"148f88dd_fce7def0","updated":"2024-01-12 20:39:49.000000000","message":"Next CLs should fix up this.","commit_id":"b6592dff474c6c14a0e622f16a3b5cffbe5824c1"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"1ce61751720d23db98af3cf78509e2cd26b58f29","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        let mut drv \u003d Derivation::default();"},{"line_number":200,"context_line":"        drv.outputs.insert(\"out\".to_string(), Default::default());"},{"line_number":201,"context_line":"        let mut input_context \u003d NixContext::new();"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        async fn select_string("},{"line_number":204,"context_line":"            co: \u0026GenCo,"}],"source_content_type":"text/x-rustsrc","patch_set":4,"id":"810b4057_3a34065f","line":201,"in_reply_to":"8c4dc6e7_aa78dd4e","updated":"2024-01-12 21:37:56.000000000","message":"Done","commit_id":"b6592dff474c6c14a0e622f16a3b5cffbe5824c1"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"cf0ecc5116f578d9ab729a5a27476fb0aa6ca9b1","unresolved":true,"context_lines":[{"line_number":131,"context_line":"}"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"// TODO: use this more"},{"line_number":134,"context_line":"async fn strong_importing_coerce_to_string("},{"line_number":135,"context_line":"    co: \u0026GenCo,"},{"line_number":136,"context_line":"    val: Value,"},{"line_number":137,"context_line":") -\u003e Result\u003cResult\u003cString, CatchableErrorKind\u003e, ErrorKind\u003e {"}],"source_content_type":"text/x-rustsrc","patch_set":7,"id":"1b562c79_3789983f","line":134,"updated":"2024-01-12 09:15:47.000000000","message":"The error types in here are a bit messed up, I\u0027m not sure if it\u0027s better to use this function, or handle dealing with the catchable stuff when explicitly calling generators::request_*.","commit_id":"00889ab67a634d3fe9418fc98150e27457f6802d"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"751b29ff60bb923c8c95fc03672fe398454a0685","unresolved":true,"context_lines":[{"line_number":131,"context_line":"}"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"// TODO: use this more"},{"line_number":134,"context_line":"async fn strong_importing_coerce_to_string("},{"line_number":135,"context_line":"    co: \u0026GenCo,"},{"line_number":136,"context_line":"    val: Value,"},{"line_number":137,"context_line":") -\u003e Result\u003cResult\u003cString, CatchableErrorKind\u003e, ErrorKind\u003e {"}],"source_content_type":"text/x-rustsrc","patch_set":7,"id":"fc25a5aa_be0a9435","line":134,"in_reply_to":"1b562c79_3789983f","updated":"2024-01-12 20:39:49.000000000","message":"I don\u0027t have a strong opinion, we have two instances of usecase, I think they could be inlined and this function could be inlined, however you want.","commit_id":"00889ab67a634d3fe9418fc98150e27457f6802d"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"a923bf39279fbea0822bacaafdbe2c13d95984e8","unresolved":false,"context_lines":[{"line_number":131,"context_line":"}"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"// TODO: use this more"},{"line_number":134,"context_line":"async fn strong_importing_coerce_to_string("},{"line_number":135,"context_line":"    co: \u0026GenCo,"},{"line_number":136,"context_line":"    val: Value,"},{"line_number":137,"context_line":") -\u003e Result\u003cResult\u003cString, CatchableErrorKind\u003e, ErrorKind\u003e {"}],"source_content_type":"text/x-rustsrc","patch_set":7,"id":"64275a3e_da2f8593","line":134,"in_reply_to":"fc25a5aa_be0a9435","updated":"2024-01-12 22:09:01.000000000","message":"I removed the additional Result\u003c\u003e which only was ok, made sure every possible consumer is actually using it, and rearranged helper functions a bit closer to the callsites.","commit_id":"00889ab67a634d3fe9418fc98150e27457f6802d"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"8194bc8906286558f86e990fd2d95ec0cdfae0b6","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                            return Ok(val);"},{"line_number":321,"context_line":"                        }"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"                        // TODO(raitobezarius): context for json values?"},{"line_number":324,"context_line":"                        // input_context.mimic(\u0026val);"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"                        let val_json \u003d match val.into_json(\u0026co).await? {"}],"source_content_type":"text/x-rustsrc","patch_set":12,"id":"774baa0e_3bdaa1ab","line":323,"updated":"2024-01-12 22:10:54.000000000","message":"TODO also added as a comment to b/366.","commit_id":"7b7e150acc24af493b2ff2ef0156bac01a02c7ce"}]}