)]}'
{"id":"depot~10604","triplet_id":"depot~canon~Ic293822266ced6f8c4826d8ef0d2e098a4adccaa","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2024-01-12 22:25:35.000000000","reason":"Change was submitted"},"1000085":{"account":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"last_update":"2024-01-12 22:25:35.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-01-12 22:25:35.000000000","reason":"Change was submitted"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2024-01-12 22:15:01.000000000","reason":"\u003cGERRIT_ACCOUNT_1000073\u003e replied on the change","reason_account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}}},"hashtags":[],"change_id":"Ic293822266ced6f8c4826d8ef0d2e098a4adccaa","subject":"feat(tvix/glue/derivationStrict): support __structuredAttrs","status":"MERGED","created":"2024-01-11 18:44:34.000000000","updated":"2024-01-12 22:25:35.000000000","submitted":"2024-01-12 22:25:35.000000000","submitter":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10604","meta_rev_id":"4f51a8fc4f71557557c1e48cb3586710618d4b68","_number":10604,"virtual_id_number":10604,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-01-12 22:25:35.000000000","_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-01-12 22:25:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-11 18:44:34.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2024-01-11 18:44:34.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2024-01-11 18:44:37.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-01-11 18:53:14.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-01-12 22:11:05.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"state":"REVIEWER"}],"messages":[{"id":"37d59ac638062b0d16892ccfc83cc0aa8cc040b5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-11 18:44:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"373747037ab34646e15ebb15bbc34976e3e1c253","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-11 18:44:34.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* `tvix/Cargo.lock`\n* `tvix/Cargo.nix`\n* `tvix/glue/Cargo.toml`\n* `tvix/glue/src/builtins/derivation.rs`\n* `tvix/glue/src/builtins/mod.rs`\n* `tvix/glue/src/tvix_build.rs`\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":1},{"id":"419a6f18ac39b79d13978628dd81dcee50e21c4b","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-11 18:44:37.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/30642","accounts_in_message":[],"_revision_number":1},{"id":"c945e8395d60973120ba2e686ac5f9f2e5f0c669","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-11 18:53:14.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/30642","accounts_in_message":[],"_revision_number":1},{"id":"0524d0953cf3ff8f1b883c1a26958f8e06beb60c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-11 19:06:29.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"ca5fa10eae63d4369f906e7c9c383e28c3523603","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-11 19:06:31.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/30644","accounts_in_message":[],"_revision_number":2},{"id":"bd56dac27400b1d6b03dfec7169b8f65c9e286ab","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-11 19:10:34.000000000","message":"Patch Set 2: Verified-1\n\nBuild of patchset 2 failed: https://buildkite.com/tvl/depot/builds/30644","accounts_in_message":[],"_revision_number":2},{"id":"62ac1e7f23deb2109b35134bdd95667807dd6f54","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-11 19:19:37.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"95323e1debe4b016d2dc5b649f8a0fd239be831e","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-11 19:19:38.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/30645","accounts_in_message":[],"_revision_number":3},{"id":"b0663c1d7e5b272754fee4955c2919c443420802","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-11 19:23:21.000000000","message":"Patch Set 3: Verified-1\n\nBuild of patchset 3 failed: https://buildkite.com/tvl/depot/builds/30645","accounts_in_message":[],"_revision_number":3},{"id":"cd78a19dcecf96f18e973f98538e00c7f00100e1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-11 19:44:43.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"3c2eb4e6acbad012ea8644d867ab33256a631022","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-11 19:44:46.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/30647","accounts_in_message":[],"_revision_number":4},{"id":"2c72950cb74dd8171da3102504262f379404ba62","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-11 19:51:10.000000000","message":"Patch Set 4: Verified-1\n\nBuild of patchset 4 failed: https://buildkite.com/tvl/depot/builds/30647","accounts_in_message":[],"_revision_number":4},{"id":"d7b398b9dbc8ec22596708271cc78e96305e3ba8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-11 20:03:10.000000000","message":"Uploaded patch set 5.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"3518cab89752395521dadaa3360ff6d288091c74","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-11 20:03:11.000000000","message":"Patch Set 5:\n\nStarted build for patchset #5 on: https://buildkite.com/tvl/depot/builds/30648","accounts_in_message":[],"_revision_number":5},{"id":"88f27b634c0e19de1bbae1a485cc0cdd7030f2d2","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-11 20:06:47.000000000","message":"Patch Set 5: Verified-1\n\nBuild of patchset 5 failed: https://buildkite.com/tvl/depot/builds/30648","accounts_in_message":[],"_revision_number":5},{"id":"775c54a346aa9661d6619cc242b3f99824d6b2bf","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-11 20:11:05.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"e65190ec274736752758620f8874c165fc41529a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-12 09:07:20.000000000","message":"Uploaded patch set 6.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":6},{"id":"ab2b445d7d9503fd9eb71b9d8575fdf5d7246ed7","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-12 09:07:22.000000000","message":"Patch Set 6:\n\nStarted build for patchset #6 on: https://buildkite.com/tvl/depot/builds/30650","accounts_in_message":[],"_revision_number":6},{"id":"9aa7efa6b8e75a3b45cddcfa4cd21f9c7f364dd1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-12 09:11:29.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"190b641359a39cd2cfbc1f634918e51368ca9b4d","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-12 09:11:33.000000000","message":"Patch Set 7:\n\nStarted build for patchset #7 on: https://buildkite.com/tvl/depot/builds/30653","accounts_in_message":[],"_revision_number":7},{"id":"cf0ecc5116f578d9ab729a5a27476fb0aa6ca9b1","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-12 09:15:47.000000000","message":"Patch Set 7:\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"06546d2cbea9d42b68e66c577d416fa3b0517b61","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-12 09:16:23.000000000","message":"Patch Set 7: Verified-1\n\nBuild of patchset 7 failed: https://buildkite.com/tvl/depot/builds/30653","accounts_in_message":[],"_revision_number":7},{"id":"acc3c629bdb84c4a05c8fbd4b8042856e24706b6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-01-12 20:36:12.000000000","message":"Uploaded patch set 8: New patch set was added with same tree, parent tree, and commit message as Patch Set 7.\n\nCopied Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND **changekind:NO_CODE_CHANGE**) OR **changekind:NO_CHANGE**\")\n","accounts_in_message":[],"_revision_number":8},{"id":"751b29ff60bb923c8c95fc03672fe398454a0685","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-01-12 20:39:49.000000000","message":"Patch Set 8:\n\n(2 comments)","accounts_in_message":[],"_revision_number":8},{"id":"213ba6e70c0109c149399e7c098dcc20b8003b67","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-12 21:28:32.000000000","message":"Uploaded patch set 9.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":9},{"id":"27905971f02e8c2bb780397fe837ee1a789f64a8","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-12 21:28:36.000000000","message":"Patch Set 9:\n\nStarted build for patchset #9 on: https://buildkite.com/tvl/depot/builds/30677","accounts_in_message":[],"_revision_number":9},{"id":"ad674e9d41d8b3e4e298f76e70334271d0d8b0d2","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-12 21:34:01.000000000","message":"Patch Set 9: Verified-1\n\nBuild of patchset 9 failed: https://buildkite.com/tvl/depot/builds/30677","accounts_in_message":[],"_revision_number":9},{"id":"1ce61751720d23db98af3cf78509e2cd26b58f29","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-01-12 21:37:56.000000000","message":"Patch Set 9:\n\n(1 comment)","accounts_in_message":[],"_revision_number":9},{"id":"39a2f453500b2c3519ff8ccab545fbdb47689dbe","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-12 21:40:20.000000000","message":"Uploaded patch set 10.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":10},{"id":"f59f83c6dd8bbe0521b227a5687a5d25cdae321d","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-12 21:40:22.000000000","message":"Patch Set 10:\n\nStarted build for patchset #10 on: https://buildkite.com/tvl/depot/builds/30680","accounts_in_message":[],"_revision_number":10},{"id":"065f0f1cdb9bd9dbc780199124edd09a56525114","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-12 21:44:19.000000000","message":"Patch Set 10: Verified+1\n\nBuild of patchset 10 passed: https://buildkite.com/tvl/depot/builds/30680","accounts_in_message":[],"_revision_number":10},{"id":"7e0383278189ea6970ea1b08775988035705e2b0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-12 22:06:42.000000000","message":"Uploaded patch set 11.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":11},{"id":"4b4e7f6f52ef5113cb7dff153428441646448c1c","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-12 22:06:43.000000000","message":"Patch Set 11:\n\nStarted build for patchset #11 on: https://buildkite.com/tvl/depot/builds/30682","accounts_in_message":[],"_revision_number":11},{"id":"57cf945fe1a34bd52135445b9e3e1ac967d2b424","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-01-12 22:08:12.000000000","message":"Uploaded patch set 12: New patch set was added with same tree, parent tree, and commit message as Patch Set 11.","accounts_in_message":[],"_revision_number":12},{"id":"a923bf39279fbea0822bacaafdbe2c13d95984e8","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-12 22:09:01.000000000","message":"Patch Set 11:\n\n(1 comment)","accounts_in_message":[],"_revision_number":11},{"id":"8194bc8906286558f86e990fd2d95ec0cdfae0b6","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-12 22:10:54.000000000","message":"Patch Set 12:\n\n(1 comment)","accounts_in_message":[],"_revision_number":12},{"id":"1e15b1be08596b3ded430e52a052731dfe111bdd","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-12 22:11:01.000000000","message":"Patch Set 11: Verified+1\n\nCopied votes on follow-up patch sets have been updated:\n* Verified+1 has been copied to patch set 12 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\").\n\nBuild of patchset 11 passed: https://buildkite.com/tvl/depot/builds/30682","accounts_in_message":[],"_revision_number":11},{"id":"d4eb1ac37d7f7d89d58de68a750e2033d0b17921","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-01-12 22:15:01.000000000","message":"Patch Set 12: Code-Review+2","accounts_in_message":[],"_revision_number":12},{"id":"447d75bb47dfac4dfa6c9fd8dc2767713a3ae432","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-12 22:25:31.000000000","message":"Patch Set 13: Commit message was updated.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n* Verified+1 (copy condition: \"(**is:ANY** AND **changekind:NO_CODE_CHANGE**) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":13},{"id":"4f51a8fc4f71557557c1e48cb3586710618d4b68","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-12 22:25:35.000000000","message":"Change has been successfully rebased and submitted as d516ce56b1fe8b765e8833edb1568817158b306f\n\n12 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":14}],"current_revision_number":14,"current_revision":"d516ce56b1fe8b765e8833edb1568817158b306f","revisions":{"9ea48ba5323b3cc9b88066a201cd6c68c1fefb5d":{"kind":"REWORK","_number":1,"created":"2024-01-11 18:44:34.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/04/10604/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/10604/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/10604/1"}}},"commit":{"parents":[{"commit":"33f61554862adc3e1a6544e7223c8943fc7fe6cc","subject":"fix(tvix/eval): use canonical_json in toJson, fix error types","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d33f61554862adc3e1a6544e7223c8943fc7fe6cc"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 17:04:31.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 18:41:54.000000000","tz":120},"subject":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict","message":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict\n\nThis adds support to handle the __structuredAttrs argument, which can be\npassed to builtins.derivationStrict.\n\nIf __structuredAttrs is passed, and set to true, most of the arguments\npassed to builtins.derivationStrict are not simply coerced to a string\nand passed down to \"environments\", but instead kept in a more structured\nfashion.\n\nInside ATerm, which is what\u0027s relevant as far as path calculation is\nconcerned, a virtual `__json` environment variable is present,\ncontaining these structured values.\n\nInside Builds, these structured values are not made available as an\nenvironment variable, but a JSON file (and source-able bash script).\nThis will become relevant once we start emitting BuildRequests,\nand for that we can probably just parse the `__json` key in\nDerivation.environment again - or keep this additionally in\nnon-serialized form around during Evaluation.\n\nNo matter what, this is left for a followup CL.\n\nThe existing handle_derivation_parameters and populate_outputs helper\nfunction were removed, as this behaviour now is also __structuredAttrs -\naware and it got quite unreadable.\n\nThere\u0027s some open questions w.r.t. where and how context is kept, we\nprobably need an entire class of unit tests to ensure we do the same\nas Nix.\n\nPart of b/366.\n\nChange-Id: Ic293822266ced6f8c4826d8ef0d2e098a4adccaa\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9ea48ba5323b3cc9b88066a201cd6c68c1fefb5d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9ea48ba5323b3cc9b88066a201cd6c68c1fefb5d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"33f61554862adc3e1a6544e7223c8943fc7fe6cc","is_merged_in_target_branch":false,"change_id":"I2dafe17ec78ee75cab5937a3a81540fda3175eac","change_number":10603,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"b5aa7840f5aeb7000c3658a23fdccd98cc80995c":{"kind":"REWORK","_number":2,"created":"2024-01-11 19:06:29.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/04/10604/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/10604/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/10604/2"}}},"commit":{"parents":[{"commit":"f3a49c1d3545e9564d04fa2a3686cf40b583ebcd","subject":"fix(tvix/eval): use canonical_json in toJson, fix error types","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df3a49c1d3545e9564d04fa2a3686cf40b583ebcd"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 17:04:31.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 19:06:15.000000000","tz":120},"subject":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict","message":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict\n\nThis adds support to handle the __structuredAttrs argument, which can be\npassed to builtins.derivationStrict.\n\nIf __structuredAttrs is passed, and set to true, most of the arguments\npassed to builtins.derivationStrict are not simply coerced to a string\nand passed down to \"environments\", but instead kept in a more structured\nfashion.\n\nInside ATerm, which is what\u0027s relevant as far as path calculation is\nconcerned, a virtual `__json` environment variable is present,\ncontaining these structured values.\n\nInside Builds, these structured values are not made available as an\nenvironment variable, but a JSON file (and source-able bash script).\nThis will become relevant once we start emitting BuildRequests,\nand for that we can probably just parse the `__json` key in\nDerivation.environment again - or keep this additionally in\nnon-serialized form around during Evaluation.\n\nNo matter what, this is left for a followup CL.\n\nThe existing handle_derivation_parameters and populate_outputs helper\nfunction were removed, as this behaviour now is also __structuredAttrs -\naware and it got quite unreadable.\n\nThere\u0027s some open questions w.r.t. where and how context is kept, we\nprobably need an entire class of unit tests to ensure we do the same\nas Nix.\n\nPart of b/366.\n\nChange-Id: Ic293822266ced6f8c4826d8ef0d2e098a4adccaa\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db5aa7840f5aeb7000c3658a23fdccd98cc80995c"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db5aa7840f5aeb7000c3658a23fdccd98cc80995c"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"f3a49c1d3545e9564d04fa2a3686cf40b583ebcd","is_merged_in_target_branch":false,"change_id":"I2dafe17ec78ee75cab5937a3a81540fda3175eac","change_number":10603,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"bb7b11f1357246ad36442ef079fb3ae014018200":{"kind":"REWORK","_number":3,"created":"2024-01-11 19:19:37.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/04/10604/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/10604/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/10604/3"}}},"commit":{"parents":[{"commit":"f3a49c1d3545e9564d04fa2a3686cf40b583ebcd","subject":"fix(tvix/eval): use canonical_json in toJson, fix error types","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df3a49c1d3545e9564d04fa2a3686cf40b583ebcd"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 17:04:31.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 19:19:25.000000000","tz":120},"subject":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict","message":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict\n\nThis adds support to handle the __structuredAttrs argument, which can be\npassed to builtins.derivationStrict.\n\nIf __structuredAttrs is passed, and set to true, most of the arguments\npassed to builtins.derivationStrict are not simply coerced to a string\nand passed down to \"environments\", but instead kept in a more structured\nfashion.\n\nInside ATerm, which is what\u0027s relevant as far as path calculation is\nconcerned, a virtual `__json` environment variable is present,\ncontaining these structured values.\n\nInside Builds, these structured values are not made available as an\nenvironment variable, but a JSON file (and source-able bash script).\nThis will become relevant once we start emitting BuildRequests,\nand for that we can probably just parse the `__json` key in\nDerivation.environment again - or keep this additionally in\nnon-serialized form around during Evaluation.\n\nNo matter what, this is left for a followup CL.\n\nThe existing handle_derivation_parameters and populate_outputs helper\nfunction were removed, as this behaviour now is also __structuredAttrs -\naware and it got quite unreadable.\n\nThere\u0027s some open questions w.r.t. where and how context is kept, we\nprobably need an entire class of unit tests to ensure we do the same\nas Nix.\n\nPart of b/366.\n\nChange-Id: Ic293822266ced6f8c4826d8ef0d2e098a4adccaa\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbb7b11f1357246ad36442ef079fb3ae014018200"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbb7b11f1357246ad36442ef079fb3ae014018200"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"f3a49c1d3545e9564d04fa2a3686cf40b583ebcd","is_merged_in_target_branch":false,"change_id":"I2dafe17ec78ee75cab5937a3a81540fda3175eac","change_number":10603,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"b6592dff474c6c14a0e622f16a3b5cffbe5824c1":{"kind":"REWORK","_number":4,"created":"2024-01-11 19:44:43.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/04/10604/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/10604/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/10604/4"}}},"commit":{"parents":[{"commit":"6e456359c1736a5ef4cce4e411297ce87c4b0228","subject":"fix(tvix/eval): use render json canonically, fix error types","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6e456359c1736a5ef4cce4e411297ce87c4b0228"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 17:04:31.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 19:43:16.000000000","tz":120},"subject":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict","message":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict\n\nThis adds support to handle the __structuredAttrs argument, which can be\npassed to builtins.derivationStrict.\n\nIf __structuredAttrs is passed, and set to true, most of the arguments\npassed to builtins.derivationStrict are not simply coerced to a string\nand passed down to \"environments\", but instead kept in a more structured\nfashion.\n\nInside ATerm, which is what\u0027s relevant as far as path calculation is\nconcerned, a virtual `__json` environment variable is present,\ncontaining these structured values.\n\nInside Builds, these structured values are not made available as an\nenvironment variable, but a JSON file (and source-able bash script).\nThis will become relevant once we start emitting BuildRequests,\nand for that we can probably just parse the `__json` key in\nDerivation.environment again - or keep this additionally in\nnon-serialized form around during Evaluation.\n\nNo matter what, this is left for a followup CL.\n\nThe existing handle_derivation_parameters and populate_outputs helper\nfunction were removed, as this behaviour now is also __structuredAttrs -\naware and it got quite unreadable.\n\nThere\u0027s some open questions w.r.t. where and how context is kept, we\nprobably need an entire class of unit tests to ensure we do the same\nas Nix.\n\nPart of b/366.\n\nChange-Id: Ic293822266ced6f8c4826d8ef0d2e098a4adccaa\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db6592dff474c6c14a0e622f16a3b5cffbe5824c1"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db6592dff474c6c14a0e622f16a3b5cffbe5824c1"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6e456359c1736a5ef4cce4e411297ce87c4b0228","is_merged_in_target_branch":false,"change_id":"I2dafe17ec78ee75cab5937a3a81540fda3175eac","change_number":10603,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"4a50102cbd2570091221431120fa116999e7f34d":{"kind":"REWORK","_number":5,"created":"2024-01-11 20:03:10.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/04/10604/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/10604/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/10604/5"}}},"commit":{"parents":[{"commit":"6e456359c1736a5ef4cce4e411297ce87c4b0228","subject":"fix(tvix/eval): use render json canonically, fix error types","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6e456359c1736a5ef4cce4e411297ce87c4b0228"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 17:04:31.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 20:02:57.000000000","tz":120},"subject":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict","message":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict\n\nThis adds support to handle the __structuredAttrs argument, which can be\npassed to builtins.derivationStrict.\n\nIf __structuredAttrs is passed, and set to true, most of the arguments\npassed to builtins.derivationStrict are not simply coerced to a string\nand passed down to \"environments\", but instead kept in a more structured\nfashion.\n\nInside ATerm, which is what\u0027s relevant as far as path calculation is\nconcerned, a virtual `__json` environment variable is present,\ncontaining these structured values.\n\nInside Builds, these structured values are not made available as an\nenvironment variable, but a JSON file (and source-able bash script).\nThis will become relevant once we start emitting BuildRequests,\nand for that we can probably just parse the `__json` key in\nDerivation.environment again - or keep this additionally in\nnon-serialized form around during Evaluation.\n\nNo matter what, this is left for a followup CL.\n\nThe existing handle_derivation_parameters and populate_outputs helper\nfunction were removed, as this behaviour now is also __structuredAttrs -\naware and it got quite unreadable.\n\nThere\u0027s some open questions w.r.t. where and how context is kept, we\nprobably need an entire class of unit tests to ensure we do the same\nas Nix.\n\nPart of b/366.\n\nChange-Id: Ic293822266ced6f8c4826d8ef0d2e098a4adccaa\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4a50102cbd2570091221431120fa116999e7f34d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4a50102cbd2570091221431120fa116999e7f34d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6e456359c1736a5ef4cce4e411297ce87c4b0228","is_merged_in_target_branch":false,"change_id":"I2dafe17ec78ee75cab5937a3a81540fda3175eac","change_number":10603,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"4e4e572e13f849798d3d0957262ab8c4583704f8":{"kind":"REWORK","_number":6,"created":"2024-01-12 09:07:20.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/04/10604/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/10604/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/10604/6"}}},"commit":{"parents":[{"commit":"5b4908c6bd6a2814f5ef1e447c265980acbdcc78","subject":"fix(tvix/eval): fix JSON error types","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5b4908c6bd6a2814f5ef1e447c265980acbdcc78"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 17:04:31.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-12 09:06:38.000000000","tz":120},"subject":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict","message":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict\n\nThis adds support to handle the __structuredAttrs argument, which can be\npassed to builtins.derivationStrict.\n\nIf __structuredAttrs is passed, and set to true, most of the arguments\npassed to builtins.derivationStrict are not simply coerced to a string\nand passed down to \"environments\", but instead kept in a more structured\nfashion.\n\nInside ATerm, which is what\u0027s relevant as far as path calculation is\nconcerned, a virtual `__json` environment variable is present,\ncontaining these structured values.\n\nInside Builds, these structured values are not made available as an\nenvironment variable, but a JSON file (and source-able bash script).\nThis will become relevant once we start emitting BuildRequests,\nand for that we can probably just parse the `__json` key in\nDerivation.environment again - or keep this additionally in\nnon-serialized form around during Evaluation.\n\nNo matter what, this is left for a followup CL.\n\nThe existing handle_derivation_parameters and populate_outputs helper\nfunction were removed, as this behaviour now is also __structuredAttrs -\naware and it got quite unreadable.\n\nThere\u0027s some open questions w.r.t. where and how context is kept, we\nprobably need an entire class of unit tests to ensure we do the same\nas Nix.\n\nPart of b/366.\n\nChange-Id: Ic293822266ced6f8c4826d8ef0d2e098a4adccaa\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4e4e572e13f849798d3d0957262ab8c4583704f8"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4e4e572e13f849798d3d0957262ab8c4583704f8"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"5b4908c6bd6a2814f5ef1e447c265980acbdcc78","is_merged_in_target_branch":false,"change_id":"I2dafe17ec78ee75cab5937a3a81540fda3175eac","change_number":10603,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"00889ab67a634d3fe9418fc98150e27457f6802d":{"kind":"REWORK","_number":7,"created":"2024-01-12 09:11:29.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/04/10604/7","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/10604/7","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/10604/7"}}},"commit":{"parents":[{"commit":"a7ce282cf81f62c3d518e693e64b3f1710400fde","subject":"feat(tvix/eval): make into_json public","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da7ce282cf81f62c3d518e693e64b3f1710400fde"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 13:44:31.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-12 09:11:04.000000000","tz":120},"subject":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict","message":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict\n\nThis adds support to handle the __structuredAttrs argument, which can be\npassed to builtins.derivationStrict.\n\nIf __structuredAttrs is passed, and set to true, most of the arguments\npassed to builtins.derivationStrict are not simply coerced to a string\nand passed down to \"environments\", but instead kept in a more structured\nfashion.\n\nInside ATerm, which is what\u0027s relevant as far as path calculation is\nconcerned, a virtual `__json` environment variable is present,\ncontaining these structured values.\n\nInside Builds, these structured values are not made available as an\nenvironment variable, but a JSON file (and source-able bash script).\nThis will become relevant once we start emitting BuildRequests,\nand for that we can probably just parse the `__json` key in\nDerivation.environment again - or keep this additionally in\nnon-serialized form around during Evaluation.\n\nNo matter what, this is left for a followup CL.\n\nThe existing handle_derivation_parameters and populate_outputs helper\nfunction were removed, as this behaviour now is also __structuredAttrs -\naware and it got quite unreadable.\n\nThere\u0027s some open questions w.r.t. where and how context is kept, we\nprobably need an entire class of unit tests to ensure we do the same\nas Nix.\n\nPart of b/366.\n\nChange-Id: Ic293822266ced6f8c4826d8ef0d2e098a4adccaa\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d00889ab67a634d3fe9418fc98150e27457f6802d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d00889ab67a634d3fe9418fc98150e27457f6802d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a7ce282cf81f62c3d518e693e64b3f1710400fde","is_merged_in_target_branch":false,"change_id":"Iba02ace6e11a74c3f9b19dcbef4b008b76dec046","change_number":10602,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"9128892163ee722179f1789f15435e7d35ecdf46":{"kind":"NO_CHANGE","_number":8,"created":"2024-01-12 20:36:12.000000000","uploader":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"ref":"refs/changes/04/10604/8","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/10604/8","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/10604/8"}}},"commit":{"parents":[{"commit":"c92e585cde4080817dd5a3e4f605e700c256a88a","subject":"feat(tvix/eval): make into_json public","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc92e585cde4080817dd5a3e4f605e700c256a88a"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 13:44:31.000000000","tz":120},"committer":{"name":"Ryan Lahfa","email":"tvl@lahfa.xyz","date":"2024-01-12 20:36:05.000000000","tz":60},"subject":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict","message":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict\n\nThis adds support to handle the __structuredAttrs argument, which can be\npassed to builtins.derivationStrict.\n\nIf __structuredAttrs is passed, and set to true, most of the arguments\npassed to builtins.derivationStrict are not simply coerced to a string\nand passed down to \"environments\", but instead kept in a more structured\nfashion.\n\nInside ATerm, which is what\u0027s relevant as far as path calculation is\nconcerned, a virtual `__json` environment variable is present,\ncontaining these structured values.\n\nInside Builds, these structured values are not made available as an\nenvironment variable, but a JSON file (and source-able bash script).\nThis will become relevant once we start emitting BuildRequests,\nand for that we can probably just parse the `__json` key in\nDerivation.environment again - or keep this additionally in\nnon-serialized form around during Evaluation.\n\nNo matter what, this is left for a followup CL.\n\nThe existing handle_derivation_parameters and populate_outputs helper\nfunction were removed, as this behaviour now is also __structuredAttrs -\naware and it got quite unreadable.\n\nThere\u0027s some open questions w.r.t. where and how context is kept, we\nprobably need an entire class of unit tests to ensure we do the same\nas Nix.\n\nPart of b/366.\n\nChange-Id: Ic293822266ced6f8c4826d8ef0d2e098a4adccaa\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9128892163ee722179f1789f15435e7d35ecdf46"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9128892163ee722179f1789f15435e7d35ecdf46"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c92e585cde4080817dd5a3e4f605e700c256a88a","is_merged_in_target_branch":false,"change_id":"Iba02ace6e11a74c3f9b19dcbef4b008b76dec046","change_number":10602,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"ed08d633455fb957507e148667371f5d782dbe52":{"kind":"REWORK","_number":9,"created":"2024-01-12 21:28:32.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/04/10604/9","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/10604/9","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/10604/9"}}},"commit":{"parents":[{"commit":"14b11cee944f91e9b484bf0f4d867e69dc3b619b","subject":"feat(tvix/eval): make into_json public","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d14b11cee944f91e9b484bf0f4d867e69dc3b619b"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 13:44:31.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-12 21:28:00.000000000","tz":120},"subject":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict","message":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict\n\nThis adds support to handle the __structuredAttrs argument, which can be\npassed to builtins.derivationStrict.\n\nIf __structuredAttrs is passed, and set to true, most of the arguments\npassed to builtins.derivationStrict are not simply coerced to a string\nand passed down to \"environments\", but instead kept in a more structured\nfashion.\n\nInside ATerm, which is what\u0027s relevant as far as path calculation is\nconcerned, a virtual `__json` environment variable is present,\ncontaining these structured values.\n\nInside Builds, these structured values are not made available as an\nenvironment variable, but a JSON file (and source-able bash script).\nThis will become relevant once we start emitting BuildRequests,\nand for that we can probably just parse the `__json` key in\nDerivation.environment again - or keep this additionally in\nnon-serialized form around during Evaluation.\n\nNo matter what, this is left for a followup CL.\n\nThe existing handle_derivation_parameters and populate_outputs helper\nfunction were removed, as this behaviour now is also __structuredAttrs -\naware and it got quite unreadable.\n\nThere\u0027s some open questions w.r.t. where and how context is kept, we\nprobably need an entire class of unit tests to ensure we do the same\nas Nix.\n\nPart of b/366.\n\nChange-Id: Ic293822266ced6f8c4826d8ef0d2e098a4adccaa\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ded08d633455fb957507e148667371f5d782dbe52"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ded08d633455fb957507e148667371f5d782dbe52"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"14b11cee944f91e9b484bf0f4d867e69dc3b619b","is_merged_in_target_branch":false,"change_id":"Iba02ace6e11a74c3f9b19dcbef4b008b76dec046","change_number":10602,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"960a13f43ad90a38a8d1d54d52d3055cc06ffeda":{"kind":"REWORK","_number":10,"created":"2024-01-12 21:40:20.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/04/10604/10","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/10604/10","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/10604/10"}}},"commit":{"parents":[{"commit":"14b11cee944f91e9b484bf0f4d867e69dc3b619b","subject":"feat(tvix/eval): make into_json public","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d14b11cee944f91e9b484bf0f4d867e69dc3b619b"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 13:44:31.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-12 21:38:35.000000000","tz":120},"subject":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict","message":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict\n\nThis adds support to handle the __structuredAttrs argument, which can be\npassed to builtins.derivationStrict.\n\nIf __structuredAttrs is passed, and set to true, most of the arguments\npassed to builtins.derivationStrict are not simply coerced to a string\nand passed down to \"environments\", but instead kept in a more structured\nfashion.\n\nInside ATerm, which is what\u0027s relevant as far as path calculation is\nconcerned, a virtual `__json` environment variable is present,\ncontaining these structured values.\n\nInside Builds, these structured values are not made available as an\nenvironment variable, but a JSON file (and source-able bash script).\nThis will become relevant once we start emitting BuildRequests,\nand for that we can probably just parse the `__json` key in\nDerivation.environment again - or keep this additionally in\nnon-serialized form around during Evaluation.\n\nNo matter what, this is left for a followup CL.\n\nThe existing handle_derivation_parameters and populate_outputs helper\nfunction were removed, as this behaviour now is also __structuredAttrs -\naware and it got quite unreadable.\n\nThere\u0027s some open questions w.r.t. where and how context is kept, we\nprobably need an entire class of unit tests to ensure we do the same\nas Nix.\n\nPart of b/366.\n\nChange-Id: Ic293822266ced6f8c4826d8ef0d2e098a4adccaa\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d960a13f43ad90a38a8d1d54d52d3055cc06ffeda"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d960a13f43ad90a38a8d1d54d52d3055cc06ffeda"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"14b11cee944f91e9b484bf0f4d867e69dc3b619b","is_merged_in_target_branch":false,"change_id":"Iba02ace6e11a74c3f9b19dcbef4b008b76dec046","change_number":10602,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"099f8254a4ce1ae6f3d8b55689e506ec6a89ed99":{"kind":"REWORK","_number":11,"created":"2024-01-12 22:06:42.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/04/10604/11","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/10604/11","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/10604/11"}}},"commit":{"parents":[{"commit":"14b11cee944f91e9b484bf0f4d867e69dc3b619b","subject":"feat(tvix/eval): make into_json public","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d14b11cee944f91e9b484bf0f4d867e69dc3b619b"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 13:44:31.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-12 22:03:15.000000000","tz":120},"subject":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict","message":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict\n\nThis adds support to handle the __structuredAttrs argument, which can be\npassed to builtins.derivationStrict.\n\nIf __structuredAttrs is passed, and set to true, most of the arguments\npassed to builtins.derivationStrict are not simply coerced to a string\nand passed down to \"environments\", but instead kept in a more structured\nfashion.\n\nInside ATerm, which is what\u0027s relevant as far as path calculation is\nconcerned, a virtual `__json` environment variable is present,\ncontaining these structured values.\n\nInside Builds, these structured values are not made available as an\nenvironment variable, but a JSON file (and source-able bash script).\n\nThis will need to be respected once we start emitting BuildRequests,\nand for that we can probably just parse the `__json` key in\nDerivation.environment again - or keep this additionally in\nnon-serialized form around during Evaluation.\nNo matter what, this is left for a followup CL.\n\nThe existing handle_derivation_parameters and populate_outputs helper\nfunction were removed, as __structuredAttrs causes quite a change\nin behaviour, and so handling both in the same place makes it more\nreadable.\n\nThere\u0027s some open questions w.r.t. string contexts for structured attrs\nitself. A TODO is left for this, but at least path calculation for\nindividual structured attrs derivations are correct now.\n\nPart of b/366.\n\nChange-Id: Ic293822266ced6f8c4826d8ef0d2e098a4adccaa\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d099f8254a4ce1ae6f3d8b55689e506ec6a89ed99"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d099f8254a4ce1ae6f3d8b55689e506ec6a89ed99"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"14b11cee944f91e9b484bf0f4d867e69dc3b619b","is_merged_in_target_branch":false,"change_id":"Iba02ace6e11a74c3f9b19dcbef4b008b76dec046","change_number":10602,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"7b7e150acc24af493b2ff2ef0156bac01a02c7ce":{"kind":"NO_CHANGE","_number":12,"created":"2024-01-12 22:08:12.000000000","uploader":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"ref":"refs/changes/04/10604/12","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/10604/12","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/10604/12"}}},"commit":{"parents":[{"commit":"5198b8c4923fe048f2b9c568f4dfe267feef1713","subject":"feat(tvix/eval): make into_json public","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5198b8c4923fe048f2b9c568f4dfe267feef1713"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 13:44:31.000000000","tz":120},"committer":{"name":"Ryan Lahfa","email":"tvl@lahfa.xyz","date":"2024-01-12 22:08:07.000000000","tz":60},"subject":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict","message":"feat(tvix/glue): support __structuredAttrs in builtin.derivationStrict\n\nThis adds support to handle the __structuredAttrs argument, which can be\npassed to builtins.derivationStrict.\n\nIf __structuredAttrs is passed, and set to true, most of the arguments\npassed to builtins.derivationStrict are not simply coerced to a string\nand passed down to \"environments\", but instead kept in a more structured\nfashion.\n\nInside ATerm, which is what\u0027s relevant as far as path calculation is\nconcerned, a virtual `__json` environment variable is present,\ncontaining these structured values.\n\nInside Builds, these structured values are not made available as an\nenvironment variable, but a JSON file (and source-able bash script).\n\nThis will need to be respected once we start emitting BuildRequests,\nand for that we can probably just parse the `__json` key in\nDerivation.environment again - or keep this additionally in\nnon-serialized form around during Evaluation.\nNo matter what, this is left for a followup CL.\n\nThe existing handle_derivation_parameters and populate_outputs helper\nfunction were removed, as __structuredAttrs causes quite a change\nin behaviour, and so handling both in the same place makes it more\nreadable.\n\nThere\u0027s some open questions w.r.t. string contexts for structured attrs\nitself. A TODO is left for this, but at least path calculation for\nindividual structured attrs derivations are correct now.\n\nPart of b/366.\n\nChange-Id: Ic293822266ced6f8c4826d8ef0d2e098a4adccaa\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7b7e150acc24af493b2ff2ef0156bac01a02c7ce"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7b7e150acc24af493b2ff2ef0156bac01a02c7ce"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"5198b8c4923fe048f2b9c568f4dfe267feef1713","is_merged_in_target_branch":false,"change_id":"Iba02ace6e11a74c3f9b19dcbef4b008b76dec046","change_number":10602,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"80dab87106385d6577ddc23399e4e5ec1f4dd8e8":{"kind":"NO_CODE_CHANGE","_number":13,"created":"2024-01-12 22:25:31.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/04/10604/13","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/10604/13","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/13 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/13 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/13 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/10604/13"}}},"commit":{"parents":[{"commit":"5198b8c4923fe048f2b9c568f4dfe267feef1713","subject":"feat(tvix/eval): make into_json public","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5198b8c4923fe048f2b9c568f4dfe267feef1713"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 13:44:31.000000000","tz":120},"committer":{"name":"flokli","email":"flokli@flokli.de","date":"2024-01-12 22:25:31.000000000","tz":0},"subject":"feat(tvix/glue/derivationStrict): support __structuredAttrs","message":"feat(tvix/glue/derivationStrict): support __structuredAttrs\n\nThis adds support to handle the __structuredAttrs argument, which can be\npassed to builtins.derivationStrict.\n\nIf __structuredAttrs is passed, and set to true, most of the arguments\npassed to builtins.derivationStrict are not simply coerced to a string\nand passed down to \"environments\", but instead kept in a more structured\nfashion.\n\nInside ATerm, which is what\u0027s relevant as far as path calculation is\nconcerned, a virtual `__json` environment variable is present,\ncontaining these structured values.\n\nInside Builds, these structured values are not made available as an\nenvironment variable, but a JSON file (and source-able bash script).\n\nThis will need to be respected once we start emitting BuildRequests,\nand for that we can probably just parse the `__json` key in\nDerivation.environment again - or keep this additionally in\nnon-serialized form around during Evaluation.\nNo matter what, this is left for a followup CL.\n\nThe existing handle_derivation_parameters and populate_outputs helper\nfunction were removed, as __structuredAttrs causes quite a change\nin behaviour, and so handling both in the same place makes it more\nreadable.\n\nThere\u0027s some open questions w.r.t. string contexts for structured attrs\nitself. A TODO is left for this, but at least path calculation for\nindividual structured attrs derivations are correct now.\n\nPart of b/366.\n\nChange-Id: Ic293822266ced6f8c4826d8ef0d2e098a4adccaa\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d80dab87106385d6577ddc23399e4e5ec1f4dd8e8"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d80dab87106385d6577ddc23399e4e5ec1f4dd8e8"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"5198b8c4923fe048f2b9c568f4dfe267feef1713","is_merged_in_target_branch":false,"change_id":"Iba02ace6e11a74c3f9b19dcbef4b008b76dec046","change_number":10602,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Edit commit message"},"d516ce56b1fe8b765e8833edb1568817158b306f":{"kind":"NO_CODE_CHANGE","_number":14,"created":"2024-01-12 22:25:35.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/04/10604/14","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/10604/14","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/14 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/14 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/10604/14 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/10604/14"}}},"commit":{"parents":[{"commit":"82540717d66a0b0f021763766571fc6c418d2427","subject":"feat(tvix/eval): make into_json public","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d82540717d66a0b0f021763766571fc6c418d2427"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-11 13:44:31.000000000","tz":120},"committer":{"name":"flokli","email":"flokli@flokli.de","date":"2024-01-12 22:25:35.000000000","tz":0},"subject":"feat(tvix/glue/derivationStrict): support __structuredAttrs","message":"feat(tvix/glue/derivationStrict): support __structuredAttrs\n\nThis adds support to handle the __structuredAttrs argument, which can be\npassed to builtins.derivationStrict.\n\nIf __structuredAttrs is passed, and set to true, most of the arguments\npassed to builtins.derivationStrict are not simply coerced to a string\nand passed down to \"environments\", but instead kept in a more structured\nfashion.\n\nInside ATerm, which is what\u0027s relevant as far as path calculation is\nconcerned, a virtual `__json` environment variable is present,\ncontaining these structured values.\n\nInside Builds, these structured values are not made available as an\nenvironment variable, but a JSON file (and source-able bash script).\n\nThis will need to be respected once we start emitting BuildRequests,\nand for that we can probably just parse the `__json` key in\nDerivation.environment again - or keep this additionally in\nnon-serialized form around during Evaluation.\nNo matter what, this is left for a followup CL.\n\nThe existing handle_derivation_parameters and populate_outputs helper\nfunction were removed, as __structuredAttrs causes quite a change\nin behaviour, and so handling both in the same place makes it more\nreadable.\n\nThere\u0027s some open questions w.r.t. string contexts for structured attrs\nitself. A TODO is left for this, but at least path calculation for\nindividual structured attrs derivations are correct now.\n\nPart of b/366.\n\nChange-Id: Ic293822266ced6f8c4826d8ef0d2e098a4adccaa\nReviewed-on: https://cl.tvl.fyi/c/depot/+/10604\nTested-by: BuildkiteCI\nReviewed-by: raitobezarius \u003ctvl@lahfa.xyz\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd516ce56b1fe8b765e8833edb1568817158b306f"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd516ce56b1fe8b765e8833edb1568817158b306f"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"82540717d66a0b0f021763766571fc6c418d2427","is_merged_in_target_branch":true,"change_id":"Iba02ace6e11a74c3f9b19dcbef4b008b76dec046","change_number":10602,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}