)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"2dd66b63094c6817a26c2a4387692a5a18e28cd1","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(nix-compat): accept SRI hashes of invalid length"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the past, we accepted SRI hashes of invalid padding while checking their trailing bits."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Now, we accept SRI hashes of invalid padding and invalid length, as Nix does."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d93e0983_acfb4063","line":9,"updated":"2024-01-20 09:06:11.000000000","message":"I was not sure if past refers to an older commit (before the recent nixhash fixes predating this commit).\n\nCan you reword this message to describe what *this commit\" actually does, rather than describing two states?","commit_id":"fe422fa15cc567d5218f305b2c4f6252a42c735a"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"9458d782090367a3e57b1409a659d8d8a40a4529","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix(nix-compat): accept SRI hashes of invalid length"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In the past, we accepted SRI hashes of invalid padding while checking their trailing bits."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Now, we accept SRI hashes of invalid padding and invalid length, as Nix does."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1721a025_6ac25499","line":9,"in_reply_to":"d93e0983_acfb4063","updated":"2024-01-20 15:00:53.000000000","message":"Done","commit_id":"fe422fa15cc567d5218f305b2c4f6252a42c735a"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"2dd66b63094c6817a26c2a4387692a5a18e28cd1","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Now, we accept SRI hashes of invalid padding and invalid length, as Nix does."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Real world example: `pkgs.javaPackages.openjfx11.deps` in nixpkgs."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I834437e7b94dab9fbb030163f7a2741f52bbf03a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c1b54283_444e7eff","line":13,"updated":"2024-01-20 09:06:11.000000000","message":"This would only work with a rev. Maybe add a permalink to GitHub instead?","commit_id":"fe422fa15cc567d5218f305b2c4f6252a42c735a"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"9458d782090367a3e57b1409a659d8d8a40a4529","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Now, we accept SRI hashes of invalid padding and invalid length, as Nix does."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Real world example: `pkgs.javaPackages.openjfx11.deps` in nixpkgs."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I834437e7b94dab9fbb030163f7a2741f52bbf03a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"53c81cd6_77b42367","line":13,"in_reply_to":"c1b54283_444e7eff","updated":"2024-01-20 15:00:53.000000000","message":"Done","commit_id":"fe422fa15cc567d5218f305b2c4f6252a42c735a"}],"tvix/nix-compat/src/nixhash/mod.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"999d0b274a92afd65ea880c166f934fb302280b7","unresolved":true,"context_lines":[{"line_number":238,"context_line":"    let encoded_digest \u003d encoded_digest.trim_end_matches(\u0027\u003d\u0027);"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    // If we are using BASE64_NOPAD, we must also disable the trailing bit checking otherwise we"},{"line_number":241,"context_line":"    // are bound to pass invalid length for our inputs."},{"line_number":242,"context_line":"    // See the `weird_sha256` example below."},{"line_number":243,"context_line":"    let mut spec \u003d BASE64_NOPAD.specification();"},{"line_number":244,"context_line":"    spec.check_trailing_bits \u003d false;"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"124a37e2_87e1b506","line":241,"updated":"2024-01-20 06:05:21.000000000","message":"to pass, or to get?","commit_id":"fe422fa15cc567d5218f305b2c4f6252a42c735a"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"9458d782090367a3e57b1409a659d8d8a40a4529","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    let encoded_digest \u003d encoded_digest.trim_end_matches(\u0027\u003d\u0027);"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    // If we are using BASE64_NOPAD, we must also disable the trailing bit checking otherwise we"},{"line_number":241,"context_line":"    // are bound to pass invalid length for our inputs."},{"line_number":242,"context_line":"    // See the `weird_sha256` example below."},{"line_number":243,"context_line":"    let mut spec \u003d BASE64_NOPAD.specification();"},{"line_number":244,"context_line":"    spec.check_trailing_bits \u003d false;"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"4aef759a_d1b67f41","line":241,"in_reply_to":"124a37e2_87e1b506","updated":"2024-01-20 15:00:53.000000000","message":"Done","commit_id":"fe422fa15cc567d5218f305b2c4f6252a42c735a"}]}