)]}'
{"id":"depot~10668","triplet_id":"depot~canon~I834437e7b94dab9fbb030163f7a2741f52bbf03a","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-01-20 17:14:05.000000000","reason":"removed on reply"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2024-01-20 17:14:30.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I834437e7b94dab9fbb030163f7a2741f52bbf03a","subject":"fix(nix-compat): accept SRI hashes of invalid length","status":"MERGED","created":"2024-01-20 01:55:03.000000000","updated":"2024-01-20 17:14:30.000000000","submitted":"2024-01-20 17:14:30.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10668","meta_rev_id":"ef576fb10c24f81c877c39d6329ae045a999e796","_number":10668,"virtual_id_number":10668,"owner":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-01-20 17:14:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-01-20 17:14:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-01-20 17:14:30.000000000","_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-20 01:55:09.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-01-20 01:55:14.000000000","updated_by":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2024-01-20 02:14:30.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-01-20 17:14:30.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"3a1232c2c34c20cab65c657919b7545f16964ee3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-01-20 01:55:03.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"4039a40572defcd107e4def9ef9088dc6a6b4f28","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-20 01:55:09.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/31033","accounts_in_message":[],"_revision_number":1},{"id":"1bb24b7ec3336c44f1835ceef16f4e181d20e075","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-01-20 01:55:14.000000000","message":"\u003cGERRIT_ACCOUNT_1000036\u003e, who was added as reviewer owns the following files:\n* `tvix/nix-compat/src/nixhash/mod.rs`\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":1},{"id":"b304b4ae65e521e3fd42d1bd30b95e279c12c16f","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-20 02:14:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/31033","accounts_in_message":[],"_revision_number":1},{"id":"999d0b274a92afd65ea880c166f934fb302280b7","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-20 06:05:21.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2dd66b63094c6817a26c2a4387692a5a18e28cd1","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-20 09:06:11.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"cb7469b42cf818ffed49e165a4b807a544efc28d","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-01-20 14:58:41.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"5c0b226c150e80b9afdd6cb35ae424a49e355cb8","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-20 14:58:44.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/31054","accounts_in_message":[],"_revision_number":2},{"id":"9458d782090367a3e57b1409a659d8d8a40a4529","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-01-20 15:00:53.000000000","message":"Patch Set 2: Autosubmit+1\n\n(3 comments)\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":2},{"id":"ac5a1c49152f2d7d88434c543397be34eb1b1bdb","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-20 15:03:52.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/31054","accounts_in_message":[],"_revision_number":2},{"id":"75bdabbdcf72a55183b1a4548810216f93937410","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-01-20 15:18:49.000000000","message":"Uploaded patch set 3: Commit message was updated.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Verified+1 (copy condition: \"(**is:ANY** AND **changekind:NO_CODE_CHANGE**) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"0a707ae7bb6fc0a1a172c2c3a174ce1d291368bc","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-20 17:14:05.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"ef576fb10c24f81c877c39d6329ae045a999e796","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-01-20 17:14:30.000000000","message":"Change has been successfully rebased and submitted as e98ea31bbd17e71566d56810fa9c1d08960461ad","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"e98ea31bbd17e71566d56810fa9c1d08960461ad","revisions":{"fe422fa15cc567d5218f305b2c4f6252a42c735a":{"kind":"REWORK","_number":1,"created":"2024-01-20 01:55:03.000000000","uploader":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"ref":"refs/changes/68/10668/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/68/10668/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/68/10668/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/68/10668/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/68/10668/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/68/10668/1"}}},"commit":{"parents":[{"commit":"93afc711f65784ed258834613937ca5177201a82","subject":"feat(tvix/castore): convert import error to `std::io::Error`","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d93afc711f65784ed258834613937ca5177201a82"}]}],"author":{"name":"Ryan Lahfa","email":"tvl@lahfa.xyz","date":"2024-01-20 01:54:50.000000000","tz":60},"committer":{"name":"Ryan Lahfa","email":"tvl@lahfa.xyz","date":"2024-01-20 01:54:52.000000000","tz":60},"subject":"fix(nix-compat): accept SRI hashes of invalid length","message":"fix(nix-compat): accept SRI hashes of invalid length\n\nIn the past, we accepted SRI hashes of invalid padding while checking their trailing bits.\n\nNow, we accept SRI hashes of invalid padding and invalid length, as Nix does.\n\nReal world example: `pkgs.javaPackages.openjfx11.deps` in nixpkgs.\n\nChange-Id: I834437e7b94dab9fbb030163f7a2741f52bbf03a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfe422fa15cc567d5218f305b2c4f6252a42c735a"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfe422fa15cc567d5218f305b2c4f6252a42c735a"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"93afc711f65784ed258834613937ca5177201a82","is_merged_in_target_branch":true,"change_id":"Id181b95e8431c69e95f3a8cd569ca10306656e1d","change_number":10572,"patch_set_number":12,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"2b06d451f8564e11a005d4ec8b24e9b7bb77a0da":{"kind":"REWORK","_number":2,"created":"2024-01-20 14:58:41.000000000","uploader":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"ref":"refs/changes/68/10668/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/68/10668/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/68/10668/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/68/10668/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/68/10668/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/68/10668/2"}}},"commit":{"parents":[{"commit":"93afc711f65784ed258834613937ca5177201a82","subject":"feat(tvix/castore): convert import error to `std::io::Error`","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d93afc711f65784ed258834613937ca5177201a82"}]}],"author":{"name":"Ryan Lahfa","email":"tvl@lahfa.xyz","date":"2024-01-20 01:54:50.000000000","tz":60},"committer":{"name":"Ryan Lahfa","email":"tvl@lahfa.xyz","date":"2024-01-20 14:57:16.000000000","tz":60},"subject":"fix(nix-compat): accept SRI hashes of invalid length","message":"fix(nix-compat): accept SRI hashes of invalid length\n\nIn the past (7a84a8fe89e244bf667acc23a6a639fdf977a4e4), we accepted SRI\nhashes of invalid padding while checking their trailing bits.\n\nNow, we accept SRI hashes of invalid padding and invalid length, as Nix does.\n\nReal world example: `pkgs.javaPackages.openjfx11.deps`\n\u003chttps://github.com/NixOS/nixpkgs/blob/849e4dc5ff0ae70fb7a0df19dbbf633e408c0f32/pkgs/development/compilers/openjdk/openjfx/11.nix#L71\u003e\nin nixpkgs.\n\nChange-Id: I834437e7b94dab9fbb030163f7a2741f52bbf03a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2b06d451f8564e11a005d4ec8b24e9b7bb77a0da"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2b06d451f8564e11a005d4ec8b24e9b7bb77a0da"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"93afc711f65784ed258834613937ca5177201a82","is_merged_in_target_branch":true,"change_id":"Id181b95e8431c69e95f3a8cd569ca10306656e1d","change_number":10572,"patch_set_number":12,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"4cd3f6c37049d1be911efb2122686fb15eb023a8":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2024-01-20 15:18:49.000000000","uploader":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"ref":"refs/changes/68/10668/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/68/10668/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/68/10668/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/68/10668/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/68/10668/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/68/10668/3"}}},"commit":{"parents":[{"commit":"93afc711f65784ed258834613937ca5177201a82","subject":"feat(tvix/castore): convert import error to `std::io::Error`","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d93afc711f65784ed258834613937ca5177201a82"}]}],"author":{"name":"Ryan Lahfa","email":"tvl@lahfa.xyz","date":"2024-01-20 01:54:50.000000000","tz":60},"committer":{"name":"Ryan Lahfa","email":"tvl@lahfa.xyz","date":"2024-01-20 15:18:18.000000000","tz":60},"subject":"fix(nix-compat): accept SRI hashes of invalid length","message":"fix(nix-compat): accept SRI hashes of invalid length\n\nIn cl/10468, we accepted SRI hashes of invalid padding while checking\ntheir trailing bits.\n\nIn this commit, we accept SRI hashes of invalid padding and invalid length, as Nix does.\n\nReal world example: `pkgs.javaPackages.openjfx11.deps`\n\u003chttps://github.com/NixOS/nixpkgs/blob/849e4dc5ff0ae70fb7a0df19dbbf633e408c0f32/pkgs/development/compilers/openjdk/openjfx/11.nix#L71\u003e\nin nixpkgs.\n\nChange-Id: I834437e7b94dab9fbb030163f7a2741f52bbf03a\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4cd3f6c37049d1be911efb2122686fb15eb023a8"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4cd3f6c37049d1be911efb2122686fb15eb023a8"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"93afc711f65784ed258834613937ca5177201a82","is_merged_in_target_branch":true,"change_id":"Id181b95e8431c69e95f3a8cd569ca10306656e1d","change_number":10572,"patch_set_number":12,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"e98ea31bbd17e71566d56810fa9c1d08960461ad":{"kind":"REWORK","_number":4,"created":"2024-01-20 17:14:30.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/68/10668/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/68/10668/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/68/10668/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/68/10668/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/68/10668/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/68/10668/4"}}},"commit":{"parents":[{"commit":"a27edf6405070a37b959572e20a0fa28a7a71a33","subject":"feat(users/flokli/kb/dilemma): configure miryoku","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da27edf6405070a37b959572e20a0fa28a7a71a33"}]}],"author":{"name":"Ryan Lahfa","email":"tvl@lahfa.xyz","date":"2024-01-20 01:54:50.000000000","tz":60},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-01-20 17:14:30.000000000","tz":0},"subject":"fix(nix-compat): accept SRI hashes of invalid length","message":"fix(nix-compat): accept SRI hashes of invalid length\n\nIn cl/10468, we accepted SRI hashes of invalid padding while checking\ntheir trailing bits.\n\nIn this commit, we accept SRI hashes of invalid padding and invalid length, as Nix does.\n\nReal world example: `pkgs.javaPackages.openjfx11.deps`\n\u003chttps://github.com/NixOS/nixpkgs/blob/849e4dc5ff0ae70fb7a0df19dbbf633e408c0f32/pkgs/development/compilers/openjdk/openjfx/11.nix#L71\u003e\nin nixpkgs.\n\nChange-Id: I834437e7b94dab9fbb030163f7a2741f52bbf03a\nReviewed-on: https://cl.tvl.fyi/c/depot/+/10668\nAutosubmit: raitobezarius \u003ctvl@lahfa.xyz\u003e\nTested-by: BuildkiteCI\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de98ea31bbd17e71566d56810fa9c1d08960461ad"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de98ea31bbd17e71566d56810fa9c1d08960461ad"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a27edf6405070a37b959572e20a0fa28a7a71a33","is_merged_in_target_branch":true,"change_id":"Icd8b2222c9a68650d9d4ee81aa96df0f4bc3bc99","change_number":10673,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}
