)]}'
{"tvix/castore/src/import.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"e2caf704d6de4c7efcc648f26e120e351031eb50","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    UnableToRead(PathBuf, std::io::Error),"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    #[error(\"unsupported file {0} type: {1}\")]"},{"line_number":52,"context_line":"    UnsupportedFileType(PathBuf, String),"},{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"impl From\u003cCastoreError\u003e for Error {"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"d86495cc_cc558315","line":52,"updated":"2024-01-20 21:10:01.000000000","message":"what if this is just FileType, and we use the debug representation? or is it entirely unusable?","commit_id":"bee56ea65f29a36381bb6b89a46bb77354d758e5"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"885da5773d8d7d1ab7bbf0e1d09b194a8143aa32","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    UnableToRead(PathBuf, std::io::Error),"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    #[error(\"unsupported file {0} type: {1}\")]"},{"line_number":52,"context_line":"    UnsupportedFileType(PathBuf, String),"},{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"impl From\u003cCastoreError\u003e for Error {"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"57125e19_b056889c","line":52,"in_reply_to":"61ff7e1e_d7e5a712","updated":"2024-01-21 15:51:47.000000000","message":"Done","commit_id":"bee56ea65f29a36381bb6b89a46bb77354d758e5"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"49ebc1d5a98410c5b609d3569a04ca28cf43185a","unresolved":true,"context_lines":[{"line_number":49,"context_line":"    UnableToRead(PathBuf, std::io::Error),"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    #[error(\"unsupported file {0} type: {1}\")]"},{"line_number":52,"context_line":"    UnsupportedFileType(PathBuf, String),"},{"line_number":53,"context_line":"}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"impl From\u003cCastoreError\u003e for Error {"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"61ff7e1e_d7e5a712","line":52,"in_reply_to":"d86495cc_cc558315","updated":"2024-01-21 15:51:41.000000000","message":"I can try to use it, yes","commit_id":"bee56ea65f29a36381bb6b89a46bb77354d758e5"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"e2caf704d6de4c7efcc648f26e120e351031eb50","unresolved":true,"context_lines":[{"line_number":82,"context_line":"    } else if file_type.is_symlink() {"},{"line_number":83,"context_line":"        \"symlink\""},{"line_number":84,"context_line":"    } else {"},{"line_number":85,"context_line":"        \"regular\""},{"line_number":86,"context_line":"    }"},{"line_number":87,"context_line":"    .into()"},{"line_number":88,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"83fd9a7b_4e31dc01","line":85,"updated":"2024-01-20 21:10:01.000000000","message":"That should only be returned if https://doc.rust-lang.org/std/fs/struct.FileType.html#method.is_file returns true, and the else case should be unknown.\n\nthere\u0027s a reason file type has is_*() functions returning bool, and not an enum - you can only be certain something is of a given type, but that doesn\u0027t mean it\u0027s automatically one of the others.","commit_id":"bee56ea65f29a36381bb6b89a46bb77354d758e5"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"885da5773d8d7d1ab7bbf0e1d09b194a8143aa32","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    } else if file_type.is_symlink() {"},{"line_number":83,"context_line":"        \"symlink\""},{"line_number":84,"context_line":"    } else {"},{"line_number":85,"context_line":"        \"regular\""},{"line_number":86,"context_line":"    }"},{"line_number":87,"context_line":"    .into()"},{"line_number":88,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"56d5c081_6b50ae73","line":85,"in_reply_to":"83fd9a7b_4e31dc01","updated":"2024-01-21 15:51:47.000000000","message":"Done","commit_id":"bee56ea65f29a36381bb6b89a46bb77354d758e5"}]}