)]}'
{"tvix/eval/src/builtins/to_xml.rs":[{"author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"change_message_id":"f60e996fbc877db181844896a78305e4a520727b","unresolved":true,"context_lines":[{"line_number":94,"context_line":"                    if formals.ellipsis {"},{"line_number":95,"context_line":"                        attrspat \u003d attrspat.attr(\"ellipsis\", \"1\");"},{"line_number":96,"context_line":"                    }"},{"line_number":97,"context_line":"                    if let Some(ref name) \u003d \u0026formals.name {"},{"line_number":98,"context_line":"                        attrspat \u003d attrspat.attr(\"name\", name.as_str());"},{"line_number":99,"context_line":"                    }"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"ea582dae_574d6c3f","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":2},"updated":"2024-01-24 14:02:01.000000000","message":"shouldn\u0027t the whole creation of this element be in there? or does c++ nix create empty attrspat elements if there\u0027s no attrspat assigned? can we add individual tests for these things, it\u0027s kind of difficult to understand them","commit_id":"92751e79f632397278f98232236c6efc0da58476"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"1852db7a2500eb3c01a6cdd9c284d201de491ff7","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                    if formals.ellipsis {"},{"line_number":95,"context_line":"                        attrspat \u003d attrspat.attr(\"ellipsis\", \"1\");"},{"line_number":96,"context_line":"                    }"},{"line_number":97,"context_line":"                    if let Some(ref name) \u003d \u0026formals.name {"},{"line_number":98,"context_line":"                        attrspat \u003d attrspat.attr(\"name\", name.as_str());"},{"line_number":99,"context_line":"                    }"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"847d38ff_4a6cfaee","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":2},"in_reply_to":"075b4258_4d6f0616","updated":"2024-01-25 11:31:05.000000000","message":"Marked this as resolved.","commit_id":"92751e79f632397278f98232236c6efc0da58476"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"d16c50236176dec272747c3de116ce17ec05c17f","unresolved":true,"context_lines":[{"line_number":94,"context_line":"                    if formals.ellipsis {"},{"line_number":95,"context_line":"                        attrspat \u003d attrspat.attr(\"ellipsis\", \"1\");"},{"line_number":96,"context_line":"                    }"},{"line_number":97,"context_line":"                    if let Some(ref name) \u003d \u0026formals.name {"},{"line_number":98,"context_line":"                        attrspat \u003d attrspat.attr(\"name\", name.as_str());"},{"line_number":99,"context_line":"                    }"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"075b4258_4d6f0616","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":2},"in_reply_to":"ea582dae_574d6c3f","updated":"2024-01-24 14:18:37.000000000","message":"Yes, it creates a\n\n```\n      \u003cfunction\u003e\n        \u003cattrspat\u003e\n          \u003cattr name\u003d\"x\" /\u003e\n          \u003cattr name\u003d\"y\" /\u003e\n          \u003cattr name\u003d\"z\" /\u003e\n        \u003c/attrspat\u003e\n      \u003c/function\u003e\n```\n\nfor the following expression: `{ x, y, z }: x`.\n\nI added the four different things to https://cl.tvl.fyi/c/depot/+/10689, PTAL.","commit_id":"92751e79f632397278f98232236c6efc0da58476"}],"tvix/eval/src/value/function.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"ea9e669e5fbb8156e9afbd29f400ff7bdf34c915","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    pub(crate) span: Span,"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    /// An optional name for the pattern binding."},{"line_number":23,"context_line":"    pub(crate) name: Option\u003cString\u003e,"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"impl Formals {"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"6894a620_47806a5d","line":23,"updated":"2024-01-23 14:33:07.000000000","message":"@tazjin@tvl.su @root@gws.fyi let me know if this should instead be a boxed string, a cow string or a smolstr, I honestly lost track :-D","commit_id":"92751e79f632397278f98232236c6efc0da58476"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"1852db7a2500eb3c01a6cdd9c284d201de491ff7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    pub(crate) span: Span,"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    /// An optional name for the pattern binding."},{"line_number":23,"context_line":"    pub(crate) name: Option\u003cString\u003e,"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"impl Formals {"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"4dafc88d_eb9fe088","line":23,"in_reply_to":"6894a620_47806a5d","updated":"2024-01-25 11:31:05.000000000","message":"Considering the +2 let\u0027s mark this as resolved. We can still change the type later on.","commit_id":"92751e79f632397278f98232236c6efc0da58476"},{"author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"change_message_id":"c542cb7fc66df46a4a3c6d6a9602788c1d0f6e8f","unresolved":true,"context_lines":[{"line_number":19,"context_line":"    /// The span of the formals themselves, to use to emit errors"},{"line_number":20,"context_line":"    pub(crate) span: Span,"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    /// An optional name for the pattern binding."},{"line_number":23,"context_line":"    pub(crate) name: Option\u003cString\u003e,"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"150796a8_6c6d2d27","line":22,"updated":"2024-01-24 14:51:36.000000000","message":"can you explain, here:\n\n- why we need this\n- when this is None vs Some","commit_id":"f618a0d3475aca3d1f77acac85400e1909a5ea5e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"1852db7a2500eb3c01a6cdd9c284d201de491ff7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    /// The span of the formals themselves, to use to emit errors"},{"line_number":20,"context_line":"    pub(crate) span: Span,"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    /// An optional name for the pattern binding."},{"line_number":23,"context_line":"    pub(crate) name: Option\u003cString\u003e,"},{"line_number":24,"context_line":"}"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"a824d77c_5b8feb95","line":22,"in_reply_to":"150796a8_6c6d2d27","updated":"2024-01-25 11:31:05.000000000","message":"I added a \n\n```\n    /// Optionally tracks a name for all function arguments (args@ style).\n    /// Used by toXML.\n```\n\nwhich should explain this sufficiently.","commit_id":"f618a0d3475aca3d1f77acac85400e1909a5ea5e"}]}