)]}'
{"id":"depot~10686","triplet_id":"depot~canon~I6bff9c47c2922f878d5c43e48280cda9c9ddb692","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2024-01-25 11:37:35.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2024-01-25 11:37:35.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-01-25 11:31:05.000000000","reason":"removed on reply"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2024-01-25 11:37:35.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I6bff9c47c2922f878d5c43e48280cda9c9ddb692","subject":"feat(tvix/eval): track pattern binding names","status":"MERGED","created":"2024-01-23 14:26:56.000000000","updated":"2024-01-25 11:37:35.000000000","submitted":"2024-01-25 11:37:35.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10687","meta_rev_id":"fd566edb1e5ad79813da27d87b9f8e1ad344fb49","_number":10686,"virtual_id_number":10686,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-01-25 11:37:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-01-25 11:37:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-01-25 11:37:35.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-23 14:26:56.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2024-01-23 14:26:56.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"state":"REVIEWER"},{"updated":"2024-01-23 14:26:59.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-01-23 14:33:07.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"CC"},{"updated":"2024-01-23 14:33:48.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-01-24 14:51:36.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2024-01-25 11:37:35.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"12431b2cc9b50100ec03e6215bc08bff50f23e14","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-23 14:26:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3e051395829c8056abdc5426b51108dba28b764d","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-23 14:26:56.000000000","message":"\u003cGERRIT_ACCOUNT_1000034\u003e, who was added as reviewer owns the following files:\n* `tvix/eval/src/builtins/to_xml.rs`\n* `tvix/eval/src/compiler/mod.rs`\n* `tvix/eval/src/tests/nix_tests/eval-okay-xml.exp.xml`\n* `tvix/eval/src/tests/nix_tests/eval-okay-xml.nix`\n* `tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-xml.exp.xml`\n* `tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-xml.nix`\n* `tvix/eval/src/value/function.rs`\n","accounts_in_message":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}],"_revision_number":1},{"id":"d724b067abaaf318383189239e60acc2e1d993d1","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-23 14:26:56.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* `tvix/eval/src/builtins/to_xml.rs`\n* `tvix/eval/src/compiler/mod.rs`\n* `tvix/eval/src/tests/nix_tests/eval-okay-xml.exp.xml`\n* `tvix/eval/src/tests/nix_tests/eval-okay-xml.nix`\n* `tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-xml.exp.xml`\n* `tvix/eval/src/tests/nix_tests/notyetpassing/eval-okay-xml.nix`\n* `tvix/eval/src/value/function.rs`\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":1},{"id":"bc2b33c0bc48915de73cf3b2c5da7e2facd49c8c","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-23 14:26:59.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/31172","accounts_in_message":[],"_revision_number":1},{"id":"ea9e669e5fbb8156e9afbd29f400ff7bdf34c915","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-23 14:33:07.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"263e3463291ee15c3d7cfbf40df8542f266839cd","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-23 14:33:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/31172","accounts_in_message":[],"_revision_number":1},{"id":"f60e996fbc877db181844896a78305e4a520727b","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2024-01-24 14:02:01.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9253fac054d639a864f4afa25b4b5ee4b7cd45ed","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-24 14:16:52.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"9c80c0f29211ae6ed752f5c5b872170ef5d339ee","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-24 14:16:54.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/31185","accounts_in_message":[],"_revision_number":2},{"id":"d16c50236176dec272747c3de116ce17ec05c17f","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-24 14:18:37.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0ba8178137d86052938519ae55cb59c19a8c705f","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-24 14:19:16.000000000","message":"Patch Set 2: Autosubmit+1","accounts_in_message":[],"_revision_number":2},{"id":"2dcfc85d88111b1ba9a34e0e712d75abd7fb89d4","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-24 14:23:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/31185","accounts_in_message":[],"_revision_number":2},{"id":"c542cb7fc66df46a4a3c6d6a9602788c1d0f6e8f","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-01-24 14:51:36.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"d3d204096e19435a1de37101051a0a12f9140017","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-25 11:31:05.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"1852db7a2500eb3c01a6cdd9c284d201de491ff7","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-01-25 11:31:05.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"8f64a31539164b578291b69f3543cb2f4f19c61b","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-25 11:31:07.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/31189","accounts_in_message":[],"_revision_number":3},{"id":"23cfd52489f5f65fc47ea2498169d7b56dc436e3","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-25 11:37:09.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/31189","accounts_in_message":[],"_revision_number":3},{"id":"fd566edb1e5ad79813da27d87b9f8e1ad344fb49","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-01-25 11:37:35.000000000","message":"Change has been successfully rebased and submitted as 023e372583b7bcc71b5c301c49501cc72204068f\n\n2 is the latest approved patch-set.\nThe change was submitted with unreviewed changes in the following files:\n\n```\nThe name of the file: tvix/eval/src/value/function.rs\nInsertions: 2, Deletions: 1.\n\n@@ -19,7 +19,8 @@\n     /// The span of the formals themselves, to use to emit errors\n     pub(crate) span: Span,\n \n-    /// An optional name for the pattern binding.\n+    /// Optionally tracks a name for all function arguments (args@ style).\n+    /// Used by toXML.\n     pub(crate) name: Option\u003cString\u003e,\n }\n \n```\n","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"023e372583b7bcc71b5c301c49501cc72204068f","revisions":{"92751e79f632397278f98232236c6efc0da58476":{"kind":"REWORK","_number":1,"created":"2024-01-23 14:26:56.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/86/10686/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/86/10686/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/86/10686/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/86/10686/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/86/10686/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/86/10686/1"}}},"commit":{"parents":[{"commit":"a88929bc3e2b09c936765cfce19e93d464eb7b6e","subject":"fix(tvix/eval/value/function): use BTreeMap for function arg names","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da88929bc3e2b09c936765cfce19e93d464eb7b6e"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-23 13:34:38.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-23 14:13:18.000000000","tz":120},"subject":"feat(tvix/eval): track pattern binding names","message":"feat(tvix/eval): track pattern binding names\n\nThese need to be preserved at least for builtins.toXML.\n\nAlso, we incorrectly only wrote an \u003cattrspat\u003e in case ellipsis was true,\nbut that\u0027s not the case.\n\nChange-Id: I6bff9c47c2922f878d5c43e48280cda9c9ddb692\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d92751e79f632397278f98232236c6efc0da58476"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d92751e79f632397278f98232236c6efc0da58476"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a88929bc3e2b09c936765cfce19e93d464eb7b6e","is_merged_in_target_branch":false,"change_id":"I6373d7488fff7c40dc2ddeeecd03ba537c92c4af","change_number":10685,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f618a0d3475aca3d1f77acac85400e1909a5ea5e":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-01-24 14:16:52.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/86/10686/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/86/10686/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/86/10686/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/86/10686/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/86/10686/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/86/10686/2"}}},"commit":{"parents":[{"commit":"e1d25891638597b0085033fd99814fce83fab4b9","subject":"fix(tvix/eval/value/function): use BTreeMap for function arg names","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de1d25891638597b0085033fd99814fce83fab4b9"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-23 13:34:38.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-24 14:08:24.000000000","tz":120},"subject":"feat(tvix/eval): track pattern binding names","message":"feat(tvix/eval): track pattern binding names\n\nThese need to be preserved at least for builtins.toXML.\n\nAlso, we incorrectly only wrote an \u003cattrspat\u003e in case ellipsis was true,\nbut that\u0027s not the case.\n\nChange-Id: I6bff9c47c2922f878d5c43e48280cda9c9ddb692\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df618a0d3475aca3d1f77acac85400e1909a5ea5e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df618a0d3475aca3d1f77acac85400e1909a5ea5e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e1d25891638597b0085033fd99814fce83fab4b9","is_merged_in_target_branch":true,"change_id":"I6373d7488fff7c40dc2ddeeecd03ba537c92c4af","change_number":10685,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"92198d1b1df7951d056d42a911a88abaff19d428":{"kind":"REWORK","_number":3,"created":"2024-01-25 11:31:05.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/86/10686/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/86/10686/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/86/10686/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/86/10686/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/86/10686/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/86/10686/3"}}},"commit":{"parents":[{"commit":"e1d25891638597b0085033fd99814fce83fab4b9","subject":"fix(tvix/eval/value/function): use BTreeMap for function arg names","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de1d25891638597b0085033fd99814fce83fab4b9"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-23 13:34:38.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-25 11:30:25.000000000","tz":120},"subject":"feat(tvix/eval): track pattern binding names","message":"feat(tvix/eval): track pattern binding names\n\nThese need to be preserved at least for builtins.toXML.\n\nAlso, we incorrectly only wrote an \u003cattrspat\u003e in case ellipsis was true,\nbut that\u0027s not the case.\n\nChange-Id: I6bff9c47c2922f878d5c43e48280cda9c9ddb692\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d92198d1b1df7951d056d42a911a88abaff19d428"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d92198d1b1df7951d056d42a911a88abaff19d428"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e1d25891638597b0085033fd99814fce83fab4b9","is_merged_in_target_branch":true,"change_id":"I6373d7488fff7c40dc2ddeeecd03ba537c92c4af","change_number":10685,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"023e372583b7bcc71b5c301c49501cc72204068f":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2024-01-25 11:37:35.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/86/10686/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/86/10686/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/86/10686/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/86/10686/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/86/10686/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/86/10686/4"}}},"commit":{"parents":[{"commit":"e1d25891638597b0085033fd99814fce83fab4b9","subject":"fix(tvix/eval/value/function): use BTreeMap for function arg names","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de1d25891638597b0085033fd99814fce83fab4b9"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-01-23 13:34:38.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-01-25 11:37:35.000000000","tz":0},"subject":"feat(tvix/eval): track pattern binding names","message":"feat(tvix/eval): track pattern binding names\n\nThese need to be preserved at least for builtins.toXML.\n\nAlso, we incorrectly only wrote an \u003cattrspat\u003e in case ellipsis was true,\nbut that\u0027s not the case.\n\nChange-Id: I6bff9c47c2922f878d5c43e48280cda9c9ddb692\nReviewed-on: https://cl.tvl.fyi/c/depot/+/10686\nTested-by: BuildkiteCI\nAutosubmit: flokli \u003cflokli@flokli.de\u003e\nReviewed-by: aspen \u003croot@gws.fyi\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d023e372583b7bcc71b5c301c49501cc72204068f"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d023e372583b7bcc71b5c301c49501cc72204068f"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e1d25891638597b0085033fd99814fce83fab4b9","is_merged_in_target_branch":true,"change_id":"I6373d7488fff7c40dc2ddeeecd03ba537c92c4af","change_number":10685,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}