)]}'
{"id":"depot~10714","triplet_id":"depot~canon~I2105fd431d4bad699087907e16c789418e9a4062","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2024-01-31 00:52:38.000000000","reason":"\u003cGERRIT_ACCOUNT_1000034\u003e replied on the change","reason_account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2024-02-01 17:46:29.000000000","reason":"removed on reply"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2024-02-01 21:08:35.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I2105fd431d4bad699087907e16c789418e9a4062","subject":"feat(tvix/eval): Don\u0027t emit OpForce for non-thunk constants","status":"MERGED","created":"2024-01-30 19:24:26.000000000","updated":"2024-02-01 21:08:35.000000000","submitted":"2024-02-01 21:08:35.000000000","submitter":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10714","meta_rev_id":"5a75c9c0ba04933b8577ab05d8e2c28edeffbf72","_number":10714,"virtual_id_number":10714,"owner":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-02-01 21:08:35.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-02-01 21:08:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-02-01 21:08:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-30 19:24:27.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-01-30 19:28:55.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-01-30 19:28:58.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"state":"REVIEWER"},{"updated":"2024-01-30 19:28:58.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"}],"messages":[{"id":"dc5cbb6a00db0a8f53745d49b084fd1c119a352e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-01-30 19:24:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b8f5735a01dd7344ed793ec1bcadc3f93cd9b3bf","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-30 19:24:27.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/31223","accounts_in_message":[],"_revision_number":1},{"id":"91c8cd7af49886f01ce633b2e264d0980d622132","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-01-30 19:28:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/31223","accounts_in_message":[],"_revision_number":1},{"id":"2aeb4030df2810d858fbca8f98a4d8676250f83a","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-01-30 19:28:58.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* `tvix/eval/src/chunk.rs`\n* `tvix/eval/src/compiler/mod.rs`\n* `tvix/eval/src/value/mod.rs`\n\n\u003cGERRIT_ACCOUNT_1000034\u003e, who was added as reviewer owns the following files:\n* `tvix/eval/src/chunk.rs`\n* `tvix/eval/src/compiler/mod.rs`\n* `tvix/eval/src/value/mod.rs`\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}],"_revision_number":1},{"id":"6ab20ddbfff973470d08d6e0fd81bb793d9166ee","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2024-01-31 00:52:38.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"5bdec65b6cc8d3fec17e1324a82a53e7c13fcd0c","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2024-02-01 17:46:29.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5a75c9c0ba04933b8577ab05d8e2c28edeffbf72","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-02-01 21:08:35.000000000","message":"Change has been successfully rebased and submitted as 8caa097ba84f57515513d86621826556f2374fad","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8caa097ba84f57515513d86621826556f2374fad","revisions":{"114199b6864f0977b2feb79969f2b48167c3f693":{"kind":"REWORK","_number":1,"created":"2024-01-30 19:24:26.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/14/10714/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/14/10714/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/14/10714/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/14/10714/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/14/10714/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/14/10714/1"}}},"commit":{"parents":[{"commit":"1b21d17583ce0766d820c5add4c3e725920f8d7c","subject":"feat(tvix/eval/observer): Allow capturing timing of events","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1b21d17583ce0766d820c5add4c3e725920f8d7c"}]}],"author":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-01-30 19:21:53.000000000","tz":-300},"committer":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-01-30 19:21:53.000000000","tz":-300},"subject":"feat(tvix/eval): Don\u0027t emit OpForce for non-thunk constants","message":"feat(tvix/eval): Don\u0027t emit OpForce for non-thunk constants\n\nIn the compiler, skip emitting an OpForce if the last op was an\nOpConstant for a non-thunk constant. This gives a small (~1% on my\nmachine) perf boost, eg when evaluating hello.outPath:\n\n    ❯ hyperfine \\\n        \"./before --no-warnings -E \u0027(import \u003cnixpkgs\u003e {}).hello.outPath\u0027\" \\\n        \"./after --no-warnings -E \u0027(import \u003cnixpkgs\u003e {}).hello.outPath\u0027\"\n    Benchmark 1: ./before --no-warnings -E \u0027(import \u003cnixpkgs\u003e {}).hello.outPath\u0027\n      Time (mean ± σ):      1.151 s ±  0.022 s    [User: 1.003 s, System: 0.151 s]\n      Range (min … max):    1.123 s …  1.184 s    10 runs\n\n    Benchmark 2: ./after --no-warnings -E \u0027(import \u003cnixpkgs\u003e {}).hello.outPath\u0027\n      Time (mean ± σ):      1.140 s ±  0.022 s    [User: 0.989 s, System: 0.152 s]\n      Range (min … max):    1.115 s …  1.175 s    10 runs\n\n    Summary\n      ./after --no-warnings -E \u0027(import \u003cnixpkgs\u003e {}).hello.outPath\u0027 ran\n        1.01 ± 0.03 times faster than ./before --no-warnings -E \u0027(import \u003cnixpkgs\u003e {}).hello.outPath\u0027\n\nChange-Id: I2105fd431d4bad699087907e16c789418e9a4062\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d114199b6864f0977b2feb79969f2b48167c3f693"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d114199b6864f0977b2feb79969f2b48167c3f693"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1b21d17583ce0766d820c5add4c3e725920f8d7c","is_merged_in_target_branch":false,"change_id":"Id7f12077291c39bf3eef42ab6744bfba53687a65","change_number":10713,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"8caa097ba84f57515513d86621826556f2374fad":{"kind":"REWORK","_number":2,"created":"2024-02-01 21:08:35.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/14/10714/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/14/10714/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/14/10714/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/14/10714/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/14/10714/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/14/10714/2"}}},"commit":{"parents":[{"commit":"25f092002554fa53497fc7d844ae257832ad655a","subject":"chore(3p/sources): Bump channels \u0026 overlays","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d25f092002554fa53497fc7d844ae257832ad655a"}]}],"author":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-01-30 19:21:53.000000000","tz":-300},"committer":{"name":"aspen","email":"root@gws.fyi","date":"2024-02-01 21:08:35.000000000","tz":0},"subject":"feat(tvix/eval): Don\u0027t emit OpForce for non-thunk constants","message":"feat(tvix/eval): Don\u0027t emit OpForce for non-thunk constants\n\nIn the compiler, skip emitting an OpForce if the last op was an\nOpConstant for a non-thunk constant. This gives a small (~1% on my\nmachine) perf boost, eg when evaluating hello.outPath:\n\n    ❯ hyperfine \\\n        \"./before --no-warnings -E \u0027(import \u003cnixpkgs\u003e {}).hello.outPath\u0027\" \\\n        \"./after --no-warnings -E \u0027(import \u003cnixpkgs\u003e {}).hello.outPath\u0027\"\n    Benchmark 1: ./before --no-warnings -E \u0027(import \u003cnixpkgs\u003e {}).hello.outPath\u0027\n      Time (mean ± σ):      1.151 s ±  0.022 s    [User: 1.003 s, System: 0.151 s]\n      Range (min … max):    1.123 s …  1.184 s    10 runs\n\n    Benchmark 2: ./after --no-warnings -E \u0027(import \u003cnixpkgs\u003e {}).hello.outPath\u0027\n      Time (mean ± σ):      1.140 s ±  0.022 s    [User: 0.989 s, System: 0.152 s]\n      Range (min … max):    1.115 s …  1.175 s    10 runs\n\n    Summary\n      ./after --no-warnings -E \u0027(import \u003cnixpkgs\u003e {}).hello.outPath\u0027 ran\n        1.01 ± 0.03 times faster than ./before --no-warnings -E \u0027(import \u003cnixpkgs\u003e {}).hello.outPath\u0027\n\nChange-Id: I2105fd431d4bad699087907e16c789418e9a4062\nReviewed-on: https://cl.tvl.fyi/c/depot/+/10714\nReviewed-by: sterni \u003csternenseemann@systemli.org\u003e\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8caa097ba84f57515513d86621826556f2374fad"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8caa097ba84f57515513d86621826556f2374fad"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"25f092002554fa53497fc7d844ae257832ad655a","is_merged_in_target_branch":true,"change_id":"I54557ef09d14ccf243c286101e75e948e65e0217","change_number":10712,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}