)]}'
{"tvix/castore/src/proto/mod.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"fe0039610219418cccc331635569c536561b2037","unresolved":true,"context_lines":[{"line_number":63,"context_line":"    #[error(\"Invalid digest length {0} for chunk #{1}\")]"},{"line_number":64,"context_line":"    InvalidDigestLen(usize, usize),"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    /// Empty list of chunks encountered"},{"line_number":67,"context_line":"    #[error(\"Empty list of chunks encountered\")]"},{"line_number":68,"context_line":"    NoChunks,"},{"line_number":69,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"01324c33_eb3db229","line":66,"updated":"2024-02-01 14:43:31.000000000","message":"Not quite sure about this one, it could be better to explicitly allow it (for 0-byte files), rather than doing an additional chunk request for the empty chunk (or having special-casing for it).","commit_id":"8969424868c4bab0f8e2fddf21d2eda82ac13457"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"8a661589394023a0ca42bc8ca91f79f8e15189f6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    #[error(\"Invalid digest length {0} for chunk #{1}\")]"},{"line_number":64,"context_line":"    InvalidDigestLen(usize, usize),"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    /// Empty list of chunks encountered"},{"line_number":67,"context_line":"    #[error(\"Empty list of chunks encountered\")]"},{"line_number":68,"context_line":"    NoChunks,"},{"line_number":69,"context_line":"}"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"4998d6be_fb14fc94","line":66,"in_reply_to":"01324c33_eb3db229","updated":"2024-02-02 15:56:29.000000000","message":"I removed that validation. It is allowed to send an empty list if no more granular chunking is available, and that\u0027s certainly the case for 0 byte blobs ;-)","commit_id":"8969424868c4bab0f8e2fddf21d2eda82ac13457"}]}