)]}'
{"id":"depot~10797","triplet_id":"depot~canon~I0d3e84f646c8f5ffd0b7259c4e456637eea360f7","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2024-02-10 18:01:41.000000000","reason":"\u003cGERRIT_ACCOUNT_1000034\u003e replied on the change","reason_account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2024-02-10 20:29:58.000000000","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change","reason_account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2024-02-13 16:49:53.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I0d3e84f646c8f5ffd0b7259c4e456637eea360f7","subject":"revert(tvix/eval): Don\u0027t double-box Path values","status":"MERGED","created":"2024-02-10 17:41:04.000000000","updated":"2024-02-13 16:49:53.000000000","submitted":"2024-02-13 16:49:53.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10799","meta_rev_id":"0a091cd425bb5d0025234f4c9892b5be53548268","_number":10797,"virtual_id_number":10797,"owner":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-02-13 16:49:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-02-13 16:49:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-02-13 16:49:53.000000000","_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}],"reviewers":{"REVIEWER":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-02-10 17:41:07.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-02-10 17:41:48.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2024-02-10 17:41:48.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"state":"REVIEWER"},{"updated":"2024-02-10 17:48:50.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-02-13 16:49:53.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f088ad7185aedb504307ad4398810eaabadc349e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-02-10 17:41:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5b182d75328751d9ee81a7ecce6485279f5d80a1","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-02-10 17:41:07.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/31361","accounts_in_message":[],"_revision_number":1},{"id":"684c8078b82ebb593f4a1734f19c22e5595d010d","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-02-10 17:41:48.000000000","message":"\u003cGERRIT_ACCOUNT_1000034\u003e, who was added as reviewer owns the following files:\n* `tvix/eval/src/builtins/mod.rs`\n* `tvix/eval/src/compiler/mod.rs`\n* `tvix/eval/src/value/arbitrary.rs`\n* `tvix/eval/src/value/json.rs`\n* `tvix/eval/src/value/mod.rs`\n* `tvix/eval/src/vm/mod.rs`\n","accounts_in_message":[{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}],"_revision_number":1},{"id":"14e415ec22c01cbb4250dc8ed469657cbc8b87be","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-02-10 17:48:50.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/31361","accounts_in_message":[],"_revision_number":1},{"id":"cf8bd507c2d64986e0c6f548f2ca3a5b2dd13dd8","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2024-02-10 18:01:41.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"c33e66940347345092db46851e61c9f2c059316a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-02-10 20:29:30.000000000","message":"Uploaded patch set 2: Commit message was updated.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n* Verified+1 (copy condition: \"(**is:ANY** AND **changekind:NO_CODE_CHANGE**) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"5a681098c780c51725f7f33bb08ce0e68c2bc0d1","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-02-10 20:29:58.000000000","message":"Patch Set 2: Autosubmit+1","accounts_in_message":[],"_revision_number":2},{"id":"04f40972193d69c3f118ebbc81bb03fdadd9a916","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-02-10 20:30:02.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"ed2cfdc1a3aae28b8696e9508d7bafc50c2e03d5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2024-02-10 23:03:35.000000000","message":"Uploaded patch set 3: New patch set was added with same tree, parent tree, and commit message as Patch Set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"**changekind:NO_CHANGE** OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR **changekind:NO_CHANGE**\")\n* Verified+1 (copy condition: \"(**is:ANY** AND **changekind:NO_CODE_CHANGE**) OR **changekind:NO_CHANGE**\")\n","accounts_in_message":[],"_revision_number":3},{"id":"0a091cd425bb5d0025234f4c9892b5be53548268","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-02-13 16:49:53.000000000","message":"Change has been successfully rebased and submitted as dd261773192d0928571f806892d8065fbba1cf2d\n\n1 is the latest approved patch-set.\nNo files were changed between the latest approved patch-set and the submitted one.\n","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"dd261773192d0928571f806892d8065fbba1cf2d","revisions":{"004e845d5fda30439944d23137d19bad0d9637ce":{"kind":"REWORK","_number":1,"created":"2024-02-10 17:41:04.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/97/10797/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/97/10797/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/97/10797/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/97/10797/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/97/10797/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/97/10797/1"}}},"commit":{"parents":[{"commit":"b0a7b7bfc037c2c42244954514b0d68d4e350767","subject":"refactor(tvix/eval): Box the strings in CatchableErrorKind","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db0a7b7bfc037c2c42244954514b0d68d4e350767"}]}],"author":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-02-10 17:35:44.000000000","tz":-300},"committer":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-02-10 17:37:06.000000000","tz":-300},"subject":"Revert \"refactor(tvix/eval): Don\u0027t double-box Path values\"","message":"Revert \"refactor(tvix/eval): Don\u0027t double-box Path values\"\n\nThis reverts commit d3d41552cf1f6485f8ebc597a2128a0d15b030a5.\n\nThis was well-intentioned, but now the boxed Path values are actually\nthe *largest* Value enum variants, at 16 bytes (because they\u0027re\nfat-pointers, with a len) instead of 8 bytes like all the other values.\nHaving the double reference is a reasonable price to pay (it seems; more\nbenchmarks may end up disagreeing) for a smaller Value repr.\n\nChange-Id: I0d3e84f646c8f5ffd0b7259c4e456637eea360f7\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d004e845d5fda30439944d23137d19bad0d9637ce"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d004e845d5fda30439944d23137d19bad0d9637ce"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b0a7b7bfc037c2c42244954514b0d68d4e350767","is_merged_in_target_branch":false,"change_id":"I3e5cb070fe6c5bf82114c92d04f6bae775663a7e","change_number":10796,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"9563c7c99d9b6cc94b366937d8672debf7599a11":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-02-10 20:29:30.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/97/10797/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/97/10797/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/97/10797/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/97/10797/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/97/10797/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/97/10797/2"}}},"commit":{"parents":[{"commit":"b8a71e92e2cea0606a753410e5ab8c8cdeb18ec8","subject":"fix(tvix/eval): Replace inner NixString repr with Box\u003cBstr\u003e","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db8a71e92e2cea0606a753410e5ab8c8cdeb18ec8"}]}],"author":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-02-10 17:35:44.000000000","tz":-300},"committer":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-02-10 20:29:18.000000000","tz":-300},"subject":"revert(tvix/eval): Don\u0027t double-box Path values","message":"revert(tvix/eval): Don\u0027t double-box Path values\n\nThis reverts commit d3d41552cf1f6485f8ebc597a2128a0d15b030a5.\n\nThis was well-intentioned, but now the boxed Path values are actually\nthe *largest* Value enum variants, at 16 bytes (because they\u0027re\nfat-pointers, with a len) instead of 8 bytes like all the other values.\nHaving the double reference is a reasonable price to pay (it seems; more\nbenchmarks may end up disagreeing) for a smaller Value repr.\n\nChange-Id: I0d3e84f646c8f5ffd0b7259c4e456637eea360f7\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9563c7c99d9b6cc94b366937d8672debf7599a11"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9563c7c99d9b6cc94b366937d8672debf7599a11"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b8a71e92e2cea0606a753410e5ab8c8cdeb18ec8","is_merged_in_target_branch":false,"change_id":"I11f34c14a08fa02759f260b1c78b2a2b981714e4","change_number":10794,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"36ac303d735af0d6f54445ccc7d7f5e8358fc369":{"kind":"NO_CHANGE","_number":3,"created":"2024-02-10 23:03:35.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/97/10797/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/97/10797/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/97/10797/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/97/10797/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/97/10797/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/97/10797/3"}}},"commit":{"parents":[{"commit":"c2a2511797548e557237d5b7ceb3cfe28ae6bce0","subject":"fix(tvix/eval): Replace inner NixString repr with Box\u003cBstr\u003e","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc2a2511797548e557237d5b7ceb3cfe28ae6bce0"}]}],"author":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-02-10 17:35:44.000000000","tz":-300},"committer":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-02-10 22:52:17.000000000","tz":-300},"subject":"revert(tvix/eval): Don\u0027t double-box Path values","message":"revert(tvix/eval): Don\u0027t double-box Path values\n\nThis reverts commit d3d41552cf1f6485f8ebc597a2128a0d15b030a5.\n\nThis was well-intentioned, but now the boxed Path values are actually\nthe *largest* Value enum variants, at 16 bytes (because they\u0027re\nfat-pointers, with a len) instead of 8 bytes like all the other values.\nHaving the double reference is a reasonable price to pay (it seems; more\nbenchmarks may end up disagreeing) for a smaller Value repr.\n\nChange-Id: I0d3e84f646c8f5ffd0b7259c4e456637eea360f7\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d36ac303d735af0d6f54445ccc7d7f5e8358fc369"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d36ac303d735af0d6f54445ccc7d7f5e8358fc369"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c2a2511797548e557237d5b7ceb3cfe28ae6bce0","is_merged_in_target_branch":false,"change_id":"I11f34c14a08fa02759f260b1c78b2a2b981714e4","change_number":10794,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"dd261773192d0928571f806892d8065fbba1cf2d":{"kind":"REWORK","_number":4,"created":"2024-02-13 16:49:53.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/97/10797/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/97/10797/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/97/10797/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/97/10797/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/97/10797/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/97/10797/4"}}},"commit":{"parents":[{"commit":"e3c92ac3b4b07a7397b565738ec4237b9bf621f6","subject":"fix(tvix/eval): Replace inner NixString repr with Box\u003cBstr\u003e","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de3c92ac3b4b07a7397b565738ec4237b9bf621f6"}]}],"author":{"name":"Aspen Smith","email":"root@gws.fyi","date":"2024-02-10 17:35:44.000000000","tz":-300},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-02-13 16:49:53.000000000","tz":0},"subject":"revert(tvix/eval): Don\u0027t double-box Path values","message":"revert(tvix/eval): Don\u0027t double-box Path values\n\nThis reverts commit d3d41552cf1f6485f8ebc597a2128a0d15b030a5.\n\nThis was well-intentioned, but now the boxed Path values are actually\nthe *largest* Value enum variants, at 16 bytes (because they\u0027re\nfat-pointers, with a len) instead of 8 bytes like all the other values.\nHaving the double reference is a reasonable price to pay (it seems; more\nbenchmarks may end up disagreeing) for a smaller Value repr.\n\nChange-Id: I0d3e84f646c8f5ffd0b7259c4e456637eea360f7\nReviewed-on: https://cl.tvl.fyi/c/depot/+/10797\nTested-by: BuildkiteCI\nAutosubmit: aspen \u003croot@gws.fyi\u003e\nReviewed-by: sterni \u003csternenseemann@systemli.org\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddd261773192d0928571f806892d8065fbba1cf2d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003ddd261773192d0928571f806892d8065fbba1cf2d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e3c92ac3b4b07a7397b565738ec4237b9bf621f6","is_merged_in_target_branch":true,"change_id":"I11f34c14a08fa02759f260b1c78b2a2b981714e4","change_number":10794,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}