)]}'
{"id":"depot~10990","triplet_id":"depot~canon~I87a59492099f6c138c752478901b9aa614bb57cc","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2024-02-20 11:54:03.000000000","reason":"Change was submitted"},"1000097":{"account":{"_account_id":1000097,"name":"Peter Kolloch","email":"info@eigenvalue.net","username":"pkolloch"},"last_update":"2024-02-20 11:41:22.000000000","reason":"\u003cGERRIT_ACCOUNT_1000097\u003e replied on the change","reason_account":{"_account_id":1000097,"name":"Peter Kolloch","email":"info@eigenvalue.net","username":"pkolloch"}},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-02-20 11:53:58.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"I87a59492099f6c138c752478901b9aa614bb57cc","subject":"fix(tvix/eval): fix accidental recursion in printing errors","status":"MERGED","created":"2024-02-20 11:10:43.000000000","updated":"2024-02-20 11:54:03.000000000","submitted":"2024-02-20 11:54:03.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"10990","meta_rev_id":"ba883c0e50ed2c73e83871a26f85f5327b8e52d2","_number":10990,"virtual_id_number":10990,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-02-20 11:54:03.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000097,"name":"Peter Kolloch","email":"info@eigenvalue.net","username":"pkolloch"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-02-20 11:54:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000097,"name":"Peter Kolloch","email":"info@eigenvalue.net","username":"pkolloch"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-02-20 11:54:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-02-20 11:54:03.000000000","_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000097,"name":"Peter Kolloch","email":"info@eigenvalue.net","username":"pkolloch"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000097,"name":"Peter Kolloch","email":"info@eigenvalue.net","username":"pkolloch"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000097,"name":"Peter Kolloch","email":"info@eigenvalue.net","username":"pkolloch"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000097,"name":"Peter Kolloch","email":"info@eigenvalue.net","username":"pkolloch"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-02-20 11:10:45.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-02-20 11:16:29.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-02-20 11:36:41.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000097,"name":"Peter Kolloch","email":"info@eigenvalue.net","username":"pkolloch"},"state":"REVIEWER"},{"updated":"2024-02-20 11:36:41.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2024-02-20 11:54:03.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"cd95e03f9f0feead3601bc6e3e61bc8c34873d8e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2024-02-20 11:10:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7e4b068f81bae7b9d62d8ba8416fd153b3b9327e","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-02-20 11:10:45.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/31722","accounts_in_message":[],"_revision_number":1},{"id":"9ebfeed468fb6c9c57f14084d6c6064d5c04605a","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-02-20 11:16:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/31722","accounts_in_message":[],"_revision_number":1},{"id":"08fad08167c8cd00938ef942731efd6444e94429","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2024-02-20 11:36:41.000000000","message":"Patch Set 1: Autosubmit+1","accounts_in_message":[],"_revision_number":1},{"id":"0cde73f420966624cb5cd6dea88c41fd6465e0bd","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2024-02-20 11:36:41.000000000","message":"\u003cGERRIT_ACCOUNT_1000036\u003e, who was added as reviewer owns the following files:\n* `tvix/eval/src/errors.rs`\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":1},{"id":"ce288dcd4a12795d4330cb5af3855db77f9286d8","author":{"_account_id":1000097,"name":"Peter Kolloch","email":"info@eigenvalue.net","username":"pkolloch"},"date":"2024-02-20 11:41:22.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"17853b2f8150753f3c0f9f895d440adaf323ab29","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-02-20 11:53:58.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ba883c0e50ed2c73e83871a26f85f5327b8e52d2","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-02-20 11:54:03.000000000","message":"Change has been successfully rebased and submitted as f40ff1737e829fb98a01951794eb1f3624cd3cad","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f40ff1737e829fb98a01951794eb1f3624cd3cad","revisions":{"32ee6cf31e43574a189dab40ddd1411bc367a624":{"kind":"REWORK","_number":1,"created":"2024-02-20 11:10:43.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/90/10990/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/90/10990/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/90/10990/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/90/10990/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/90/10990/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/90/10990/1"}}},"commit":{"parents":[{"commit":"94f582341e4f37228fbdf0997255d6374264b4b3","subject":"refactor(tvix/eval): use internal SourceCode field in error printers","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d94f582341e4f37228fbdf0997255d6374264b4b3"}]}],"author":{"name":"Vincent Ambo","email":"tazjin@tvl.su","date":"2024-02-20 11:06:36.000000000","tz":420},"committer":{"name":"Vincent Ambo","email":"tazjin@tvl.su","date":"2024-02-20 11:06:36.000000000","tz":420},"subject":"fix(tvix/eval): fix accidental recursion in printing errors","message":"fix(tvix/eval): fix accidental recursion in printing errors\n\nThere\u0027s some code path where fancy_format_str()-\u003eError::Display, which\nrecurses forever and overflows the stack. This was introduced in a\nprevious commit today.\n\nChange-Id: I87a59492099f6c138c752478901b9aa614bb57cc\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d32ee6cf31e43574a189dab40ddd1411bc367a624"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d32ee6cf31e43574a189dab40ddd1411bc367a624"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"94f582341e4f37228fbdf0997255d6374264b4b3","is_merged_in_target_branch":true,"change_id":"Iddc5d7a6b4bab391f30a999e4c68aca34304c059","change_number":10987,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f40ff1737e829fb98a01951794eb1f3624cd3cad":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-02-20 11:54:03.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/90/10990/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/90/10990/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/90/10990/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/90/10990/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/90/10990/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/90/10990/2"}}},"commit":{"parents":[{"commit":"94f582341e4f37228fbdf0997255d6374264b4b3","subject":"refactor(tvix/eval): use internal SourceCode field in error printers","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d94f582341e4f37228fbdf0997255d6374264b4b3"}]}],"author":{"name":"Vincent Ambo","email":"tazjin@tvl.su","date":"2024-02-20 11:06:36.000000000","tz":420},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-02-20 11:54:03.000000000","tz":0},"subject":"fix(tvix/eval): fix accidental recursion in printing errors","message":"fix(tvix/eval): fix accidental recursion in printing errors\n\nThere\u0027s some code path where fancy_format_str()-\u003eError::Display, which\nrecurses forever and overflows the stack. This was introduced in a\nprevious commit today.\n\nChange-Id: I87a59492099f6c138c752478901b9aa614bb57cc\nReviewed-on: https://cl.tvl.fyi/c/depot/+/10990\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\nTested-by: BuildkiteCI\nAutosubmit: tazjin \u003ctazjin@tvl.su\u003e\nReviewed-by: Peter Kolloch \u003cinfo@eigenvalue.net\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df40ff1737e829fb98a01951794eb1f3624cd3cad"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df40ff1737e829fb98a01951794eb1f3624cd3cad"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"94f582341e4f37228fbdf0997255d6374264b4b3","is_merged_in_target_branch":true,"change_id":"Iddc5d7a6b4bab391f30a999e4c68aca34304c059","change_number":10987,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}