)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000097,"name":"Peter Kolloch","email":"info@eigenvalue.net","username":"pkolloch"},"change_message_id":"680c9d11fab50198fb0c91800593eaab3095283a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"af9931de_5ca875f1","updated":"2024-02-21 08:18:07.000000000","message":"I\u0027d appreciate a review now","commit_id":"3c3c812232eff61c48bff06fef5aaa53aee31f1a"}],"tvix/nix-compat/src/derivation/parser.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"5c48a0a1b064492d6fba6abbb0e5f70401f72eb5","unresolved":true,"context_lines":[{"line_number":97,"context_line":"                    Ok(hash_with_mode) \u003d\u003e Ok(("},{"line_number":98,"context_line":"                        output_name,"},{"line_number":99,"context_line":"                        Output {"},{"line_number":100,"context_line":"                            // TODO: Check allow empty"},{"line_number":101,"context_line":"                            path: if output_path.is_empty() {"},{"line_number":102,"context_line":"                                None"},{"line_number":103,"context_line":"                            } else {"}],"source_content_type":"text/x-rustsrc","patch_set":8,"id":"f7e88599_0a835bdf","line":100,"updated":"2024-02-21 10:56:36.000000000","message":"Not quite sure what this means?","commit_id":"3c3c812232eff61c48bff06fef5aaa53aee31f1a"},{"author":{"_account_id":1000097,"name":"Peter Kolloch","email":"info@eigenvalue.net","username":"pkolloch"},"change_message_id":"6e371dfa65076a04ac98e8df5b7ce6034dce232b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                    Ok(hash_with_mode) \u003d\u003e Ok(("},{"line_number":98,"context_line":"                        output_name,"},{"line_number":99,"context_line":"                        Output {"},{"line_number":100,"context_line":"                            // TODO: Check allow empty"},{"line_number":101,"context_line":"                            path: if output_path.is_empty() {"},{"line_number":102,"context_line":"                                None"},{"line_number":103,"context_line":"                            } else {"}],"source_content_type":"text/x-rustsrc","patch_set":8,"id":"78ce34af_88099770","line":100,"in_reply_to":"f7e88599_0a835bdf","updated":"2024-02-21 11:32:46.000000000","message":"Basically, I wanted to first preserve the prior behavior. But I am not sure if it is actually important that this also works with empty store paths.","commit_id":"3c3c812232eff61c48bff06fef5aaa53aee31f1a"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"5c48a0a1b064492d6fba6abbb0e5f70401f72eb5","unresolved":true,"context_lines":[{"line_number":350,"context_line":"                \"lib\".to_string(),"},{"line_number":351,"context_line":"                Output {"},{"line_number":352,"context_line":"                    path: Some("},{"line_number":353,"context_line":"                        StorePathRef::from_absolute_path("},{"line_number":354,"context_line":"                            \"/nix/store/2vixb94v0hy2xc6p7mbnxxcyc095yyia-has-multi-out-lib\""},{"line_number":355,"context_line":"                                .as_bytes(),"},{"line_number":356,"context_line":"                        )"}],"source_content_type":"text/x-rustsrc","patch_set":8,"id":"b59e75ab_1bb176d2","line":353,"updated":"2024-02-21 10:56:36.000000000","message":"`StorePathRef::from_bytes(b\"2vixb94v0hy2xc6p7mbnxxcyc095yyia-has-multi-out-lib\").unwrap()` should be shorter:\n\nhttps://docs.tvix.dev/rust/nix_compat/store_path/struct.StorePathRef.html#method.from_bytes\n\n(same below)","commit_id":"3c3c812232eff61c48bff06fef5aaa53aee31f1a"},{"author":{"_account_id":1000097,"name":"Peter Kolloch","email":"info@eigenvalue.net","username":"pkolloch"},"change_message_id":"6e371dfa65076a04ac98e8df5b7ce6034dce232b","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                \"lib\".to_string(),"},{"line_number":351,"context_line":"                Output {"},{"line_number":352,"context_line":"                    path: Some("},{"line_number":353,"context_line":"                        StorePathRef::from_absolute_path("},{"line_number":354,"context_line":"                            \"/nix/store/2vixb94v0hy2xc6p7mbnxxcyc095yyia-has-multi-out-lib\""},{"line_number":355,"context_line":"                                .as_bytes(),"},{"line_number":356,"context_line":"                        )"}],"source_content_type":"text/x-rustsrc","patch_set":8,"id":"167fb760_f320fb87","line":353,"in_reply_to":"96d1647c_e2af7419","updated":"2024-02-21 11:32:46.000000000","message":"Done","commit_id":"3c3c812232eff61c48bff06fef5aaa53aee31f1a"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"a6ccedc39dad88cb7a6fdbc02158cc8c9f305690","unresolved":true,"context_lines":[{"line_number":350,"context_line":"                \"lib\".to_string(),"},{"line_number":351,"context_line":"                Output {"},{"line_number":352,"context_line":"                    path: Some("},{"line_number":353,"context_line":"                        StorePathRef::from_absolute_path("},{"line_number":354,"context_line":"                            \"/nix/store/2vixb94v0hy2xc6p7mbnxxcyc095yyia-has-multi-out-lib\""},{"line_number":355,"context_line":"                                .as_bytes(),"},{"line_number":356,"context_line":"                        )"}],"source_content_type":"text/x-rustsrc","patch_set":8,"id":"96d1647c_e2af7419","line":353,"in_reply_to":"b59e75ab_1bb176d2","updated":"2024-02-21 10:57:21.000000000","message":"This is essentially the same as https://cl.tvl.fyi/c/depot/+/10957/comment/679cfdfb_dae9a0de/.","commit_id":"3c3c812232eff61c48bff06fef5aaa53aee31f1a"}]}