)]}'
{"id":"depot~11003","triplet_id":"depot~canon~I87f0291dc855a132689576559c891d66c30ddf2b","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2024-02-21 13:55:41.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-02-21 13:55:36.000000000","reason":"removed on reply"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2024-02-21 13:55:41.000000000","reason":"Change was submitted"},"1000089":{"account":{"_account_id":1000089,"name":"Pádraic Ó Mhuiris","email":"patrick.morris.310@gmail.com","username":"padraic-o-mhuiris"},"last_update":"2024-02-21 13:53:27.000000000","reason":"\u003cGERRIT_ACCOUNT_1000089\u003e replied on the change","reason_account":{"_account_id":1000089,"name":"Pádraic Ó Mhuiris","email":"patrick.morris.310@gmail.com","username":"padraic-o-mhuiris"}}},"hashtags":[],"change_id":"I87f0291dc855a132689576559c891d66c30ddf2b","subject":"fix(tvix/eval): allow reading non-UTF8 files","status":"MERGED","created":"2024-02-21 13:42:29.000000000","updated":"2024-02-21 13:55:41.000000000","submitted":"2024-02-21 13:55:41.000000000","submitter":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"11003","meta_rev_id":"22d44c9adf923f6ad8e1067275b222f9e72bd991","_number":11003,"virtual_id_number":11003,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-02-21 13:55:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-02-21 13:55:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000089,"name":"Pádraic Ó Mhuiris","email":"patrick.morris.310@gmail.com","username":"padraic-o-mhuiris"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000089,"name":"Pádraic Ó Mhuiris","email":"patrick.morris.310@gmail.com","username":"padraic-o-mhuiris"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-02-21 13:55:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-02-21 13:55:41.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000089,"name":"Pádraic Ó Mhuiris","email":"patrick.morris.310@gmail.com","username":"padraic-o-mhuiris"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000089,"name":"Pádraic Ó Mhuiris","email":"patrick.morris.310@gmail.com","username":"padraic-o-mhuiris"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000089,"name":"Pádraic Ó Mhuiris","email":"patrick.morris.310@gmail.com","username":"padraic-o-mhuiris"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000089,"name":"Pádraic Ó Mhuiris","email":"patrick.morris.310@gmail.com","username":"padraic-o-mhuiris"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-02-21 13:42:29.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2024-02-21 13:42:29.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2024-02-21 13:42:32.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-02-21 13:44:16.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000089,"name":"Pádraic Ó Mhuiris","email":"patrick.morris.310@gmail.com","username":"padraic-o-mhuiris"},"state":"REVIEWER"},{"updated":"2024-02-21 13:48:42.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"78e4b27d6649ef7a7092606aaf47f3f3e9ad9f57","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-02-21 13:42:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bbb450f8015b7b63f4c15eab06d7f18124dd0ce8","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-02-21 13:42:29.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* `tvix/eval/src/io.rs`\n* `tvix/eval/src/vm/generators.rs`\n* `tvix/glue/src/tvix_io.rs`\n* `tvix/glue/src/tvix_store_io.rs`\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":1},{"id":"5b21922fa41246dd027bbe8b75711ce9e6abbe76","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-02-21 13:42:29.000000000","message":"\u003cGERRIT_ACCOUNT_1000010\u003e, who was added as reviewer owns the following files:\n* `tvix/eval/src/io.rs`\n* `tvix/eval/src/vm/generators.rs`\n* `tvix/glue/src/tvix_io.rs`\n* `tvix/glue/src/tvix_store_io.rs`\n","accounts_in_message":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"_revision_number":1},{"id":"8f81f53ccd4e5236cd023029a91e66f72bc2a331","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-02-21 13:42:32.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/31795","accounts_in_message":[],"_revision_number":1},{"id":"f034931ccd04ca4b637f11d5befc3b585f28fd45","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-02-21 13:48:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/31795","accounts_in_message":[],"_revision_number":1},{"id":"6013cd49512f694ba33e3ea2e86967a19ac677ea","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-02-21 13:49:12.000000000","message":"Patch Set 1: Autosubmit+1","accounts_in_message":[],"_revision_number":1},{"id":"a998fc998b002b27e4a7b2c5d0b754325dc0efa3","author":{"_account_id":1000089,"name":"Pádraic Ó Mhuiris","email":"patrick.morris.310@gmail.com","username":"padraic-o-mhuiris"},"date":"2024-02-21 13:53:27.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"ca6f19dea68ccdcca728698e06731df85a23e48d","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-02-21 13:55:36.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"22d44c9adf923f6ad8e1067275b222f9e72bd991","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-02-21 13:55:41.000000000","message":"Change has been successfully rebased and submitted as 771200df7c311fc8b87a0a65a02e22a11d80cd66","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"771200df7c311fc8b87a0a65a02e22a11d80cd66","revisions":{"2da7ee3bc9b73043fc0903d06f51ec437f0a7eb9":{"kind":"REWORK","_number":1,"created":"2024-02-21 13:42:29.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/03/11003/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/03/11003/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/03/11003/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/03/11003/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/03/11003/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/03/11003/1"}}},"commit":{"parents":[{"commit":"3e93efdc8cb3c6cefaedf8f9f11f1f3f697d079e","subject":"docs(tvix/eval): notes on the implementation of catchable errors","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3e93efdc8cb3c6cefaedf8f9f11f1f3f697d079e"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-02-21 13:39:53.000000000","tz":420},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-02-21 13:39:53.000000000","tz":420},"subject":"fix(tvix/eval): allow reading non-UTF8 files","message":"fix(tvix/eval): allow reading non-UTF8 files\n\nWith our values using bstr now, we\u0027re not restricted to only reading\nfiles that contain valid UTF-8.\n\nUpdate our `read_to_string` function to `read_to_end`\n(named like `std::io::Read::read_to_end`), and have it return a Vec\u003cu8\u003e.\n\nChange-Id: I87f0291dc855a132689576559c891d66c30ddf2b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2da7ee3bc9b73043fc0903d06f51ec437f0a7eb9"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2da7ee3bc9b73043fc0903d06f51ec437f0a7eb9"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3e93efdc8cb3c6cefaedf8f9f11f1f3f697d079e","is_merged_in_target_branch":true,"change_id":"I3b2f039d2c2d40ee5d13d071915ced6f3deb18f2","change_number":11000,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"771200df7c311fc8b87a0a65a02e22a11d80cd66":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-02-21 13:55:41.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/03/11003/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/03/11003/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/03/11003/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/03/11003/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/03/11003/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/03/11003/2"}}},"commit":{"parents":[{"commit":"3e93efdc8cb3c6cefaedf8f9f11f1f3f697d079e","subject":"docs(tvix/eval): notes on the implementation of catchable errors","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3e93efdc8cb3c6cefaedf8f9f11f1f3f697d079e"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-02-21 13:39:53.000000000","tz":420},"committer":{"name":"flokli","email":"flokli@flokli.de","date":"2024-02-21 13:55:41.000000000","tz":0},"subject":"fix(tvix/eval): allow reading non-UTF8 files","message":"fix(tvix/eval): allow reading non-UTF8 files\n\nWith our values using bstr now, we\u0027re not restricted to only reading\nfiles that contain valid UTF-8.\n\nUpdate our `read_to_string` function to `read_to_end`\n(named like `std::io::Read::read_to_end`), and have it return a Vec\u003cu8\u003e.\n\nChange-Id: I87f0291dc855a132689576559c891d66c30ddf2b\nReviewed-on: https://cl.tvl.fyi/c/depot/+/11003\nTested-by: BuildkiteCI\nAutosubmit: flokli \u003cflokli@flokli.de\u003e\nReviewed-by: Pádraic Ó Mhuiris \u003cpatrick.morris.310@gmail.com\u003e\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d771200df7c311fc8b87a0a65a02e22a11d80cd66"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d771200df7c311fc8b87a0a65a02e22a11d80cd66"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3e93efdc8cb3c6cefaedf8f9f11f1f3f697d079e","is_merged_in_target_branch":true,"change_id":"I3b2f039d2c2d40ee5d13d071915ced6f3deb18f2","change_number":11000,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}