)]}'
{"id":"depot~11004","triplet_id":"depot~canon~If96a013ab0e936781f8c056006c1fe57c7502901","project":"depot","branch":"canon","hashtags":[],"change_id":"If96a013ab0e936781f8c056006c1fe57c7502901","subject":"refactor(tvix/store/protos): CalculateNAR -\u003e CalculateDigest","status":"ABANDONED","created":"2024-02-21 16:41:45.000000000","updated":"2024-05-02 10:26:17.000000000","total_comment_count":0,"unresolved_comment_count":0,"work_in_progress":true,"has_review_started":false,"meta_rev_id":"ec651ba0028c441828a78ce279449c0423aa2dc6","_number":11004,"virtual_id_number":11004,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"rejected":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"tag":"autogenerated:buildkite~result","value":-1,"date":"2024-03-01 10:04:26.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0,"blocking":true},"Autosubmit":{"all":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}]},"pending_reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"reviewer_updates":[{"updated":"2024-02-21 16:41:45.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2024-02-21 16:41:47.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-02-21 16:46:28.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-02-29 09:57:10.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2024-02-29 09:57:10.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"}],"messages":[{"id":"f147813ca25b548e104dfe910ff8d14463e1c63e","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-02-21 16:41:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"74ac83130a65ed7ed24c03d3e3179f44e5a077b8","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-02-21 16:41:45.000000000","message":"\u003cGERRIT_ACCOUNT_1000010\u003e, who was added as reviewer owns the following files:\n* `tvix/store-go/rpc_pathinfo.pb.go`\n* `tvix/store-go/rpc_pathinfo_grpc.pb.go`\n* `tvix/store/protos/rpc_pathinfo.proto`\n* `tvix/store/src/pathinfoservice/grpc.rs`\n* `tvix/store/src/pathinfoservice/mod.rs`\n* `tvix/store/src/proto/grpc_pathinfoservice_wrapper.rs`\n","accounts_in_message":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}],"_revision_number":1},{"id":"6bc09ced047b9b3e41098b83440a31f783d166be","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-02-21 16:41:47.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/31798","accounts_in_message":[],"_revision_number":1},{"id":"fd9548350ab8698bfd8e0d8eb5fb42bd7070b6ed","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-02-21 16:46:28.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/31798","accounts_in_message":[],"_revision_number":1},{"id":"3854670f8ca69b48ae7e29f9755e1f3d9aa1f034","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-02-29 09:57:10.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"3ba48f649ceadf2f25e9612493738bc45e8b58f8","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-02-29 09:57:10.000000000","message":"\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* `tvix/store-go/rpc_pathinfo.pb.go`\n* `tvix/store-go/rpc_pathinfo_grpc.pb.go`\n* `tvix/store/protos/rpc_pathinfo.proto`\n* `tvix/store/src/import.rs`\n* `tvix/store/src/pathinfoservice/grpc.rs`\n* `tvix/store/src/pathinfoservice/memory.rs`\n* `tvix/store/src/pathinfoservice/mod.rs`\n* `tvix/store/src/pathinfoservice/nix_http.rs`\n* `tvix/store/src/pathinfoservice/sled.rs`\n* `tvix/store/src/proto/grpc_pathinfoservice_wrapper.rs`\n","accounts_in_message":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":2},{"id":"be94464527ac02b0cfe8e9fabb0a56ea84adebdd","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-02-29 09:57:15.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/31923","accounts_in_message":[],"_revision_number":2},{"id":"c78a77d189985e23209bdb699dc9d70097da3a48","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-02-29 10:01:35.000000000","message":"Patch Set 2: Verified-1\n\nBuild of patchset 2 failed: https://buildkite.com/tvl/depot/builds/31923","accounts_in_message":[],"_revision_number":2},{"id":"30a9e3e438db79afbd8caf14280e0b96ac84c2af","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-03-01 09:58:04.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"085a35608c82313ff3c9cc24f7879630ab47b7a4","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-01 09:58:17.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/31937","accounts_in_message":[],"_revision_number":3},{"id":"5e69e9181dfe36b8904f03dd3ed0a90084199119","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-01 10:04:26.000000000","message":"Patch Set 3: Verified-1\n\nBuild of patchset 3 failed: https://buildkite.com/tvl/depot/builds/31937","accounts_in_message":[],"_revision_number":3},{"id":"ec651ba0028c441828a78ce279449c0423aa2dc6","tag":"autogenerated:gerrit:abandon","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-05-02 10:26:17.000000000","message":"Abandoned\n\nWith all of the cleanups that happened around fetchers etc, there\u0027s luckily not really a reason to do this anymore, especially not bake it into the protocol.\n\nThe only place where we still need to do this is when ingesting a single file in recursive mode, inside builtins.file, and we know that case upfront, so can arguably calculate the nar hash in-memory there, if we\u0027re concerned about the roundtrip.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"5614761e6bd90211ecec00f86187b873299d815d","revisions":{"d6a927a46674b0eaadff9a200695982c6cf2121f":{"kind":"REWORK","_number":1,"created":"2024-02-21 16:41:45.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/04/11004/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/11004/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/11004/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/11004/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/11004/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/11004/1"}}},"commit":{"parents":[{"commit":"771200df7c311fc8b87a0a65a02e22a11d80cd66","subject":"fix(tvix/eval): allow reading non-UTF8 files","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d771200df7c311fc8b87a0a65a02e22a11d80cd66"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-02-21 15:29:39.000000000","tz":420},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-02-21 16:41:27.000000000","tz":420},"subject":"refactor(tvix/store/protos): CalculateNAR -\u003e CalculateDigest","message":"refactor(tvix/store/protos): CalculateNAR -\u003e CalculateDigest\n\nThis previously only supported calculating NAR_SHA256 style hashes.\n\nExpand this function to also support all NAR_* hashing types, as well\nas FLAT_* hashing types.\n\nPass a structured CalculateDigestRequest message type, which in addition\nto the hashing type needs to either include the root node (in case NAR_*\nis used), or the blake3 digest of the blob (in case FLAT_* is used).\n\nI opted against just adding a second RPC method, as we now have the CA\nstructure anyways, and this interface makes it easy to introduce, e.g.\ngit tree hashing too (translating from a castore root node to a git tree\nobject sha1).\n\nChange-Id: If96a013ab0e936781f8c056006c1fe57c7502901\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd6a927a46674b0eaadff9a200695982c6cf2121f"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd6a927a46674b0eaadff9a200695982c6cf2121f"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"771200df7c311fc8b87a0a65a02e22a11d80cd66","is_merged_in_target_branch":true,"change_id":"I87f0291dc855a132689576559c891d66c30ddf2b","change_number":11003,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"0dbb71cba3583bf7655c56b8415154af22d8132a":{"kind":"REWORK","_number":2,"created":"2024-02-29 09:57:10.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/04/11004/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/11004/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/11004/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/11004/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/11004/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/11004/2"}}},"commit":{"parents":[{"commit":"62a47311e1a8f37c645739cf090be264ad3223f3","subject":"refactor(tvix/store/protos): more granular conversions with nix-compat","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d62a47311e1a8f37c645739cf090be264ad3223f3"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-02-21 15:29:39.000000000","tz":420},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-02-29 09:56:20.000000000","tz":120},"subject":"refactor(tvix/store/protos): CalculateNAR -\u003e CalculateDigest","message":"refactor(tvix/store/protos): CalculateNAR -\u003e CalculateDigest\n\nThis previously only supported calculating NAR_SHA256 style hashes.\n\nExpand this function to also support all NAR_* hashing types, as well\nas FLAT_* hashing types.\n\nPass a structured CalculateDigestRequest message type, which in addition\nto the hashing type needs to either include the root node (in case NAR_*\nis used), or the blake3 digest of the blob (in case FLAT_* is used).\n\nI opted against just adding a second RPC method, as we now have the CA\nstructure anyways, and this interface makes it easy to introduce, e.g.\ngit tree hashing too (translating from a castore root node to a git tree\nobject sha1).\n\nChange-Id: If96a013ab0e936781f8c056006c1fe57c7502901\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0dbb71cba3583bf7655c56b8415154af22d8132a"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0dbb71cba3583bf7655c56b8415154af22d8132a"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"62a47311e1a8f37c645739cf090be264ad3223f3","is_merged_in_target_branch":false,"change_id":"I7e9b6edd1e3f149eb270faf2928cd846d74e77ad","change_number":11071,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"5614761e6bd90211ecec00f86187b873299d815d":{"kind":"REWORK","_number":3,"created":"2024-03-01 09:58:04.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/04/11004/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/04/11004/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/04/11004/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/04/11004/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/04/11004/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/04/11004/3"}}},"commit":{"parents":[{"commit":"29e8c2db262282c45ae28ecdd382bb97c8b73d69","subject":"refactor(tvix/store/protos): more granular conversions with nix-compat","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d29e8c2db262282c45ae28ecdd382bb97c8b73d69"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-02-21 15:29:39.000000000","tz":420},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-03-01 09:57:51.000000000","tz":120},"subject":"refactor(tvix/store/protos): CalculateNAR -\u003e CalculateDigest","message":"refactor(tvix/store/protos): CalculateNAR -\u003e CalculateDigest\n\nThis previously only supported calculating NAR_SHA256 style hashes.\n\nExpand this function to also support all NAR_* hashing types, as well\nas FLAT_* hashing types.\n\nPass a structured CalculateDigestRequest message type, which in addition\nto the hashing type needs to either include the root node (in case NAR_*\nis used), or the blake3 digest of the blob (in case FLAT_* is used).\n\nI opted against just adding a second RPC method, as we now have the CA\nstructure anyways, and this interface makes it easy to introduce, e.g.\ngit tree hashing too (translating from a castore root node to a git tree\nobject sha1).\n\nChange-Id: If96a013ab0e936781f8c056006c1fe57c7502901\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5614761e6bd90211ecec00f86187b873299d815d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5614761e6bd90211ecec00f86187b873299d815d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"29e8c2db262282c45ae28ecdd382bb97c8b73d69","is_merged_in_target_branch":false,"change_id":"I7e9b6edd1e3f149eb270faf2928cd846d74e77ad","change_number":11071,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[],"submit_requirements":[]}