)]}'
{"id":"depot~11079","triplet_id":"depot~canon~I2399867591df923faa73927b924e7c116ad98dc0","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000082":{"account":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"last_update":"2024-03-03 10:50:42.000000000","reason":"\u003cGERRIT_ACCOUNT_1000082\u003e replied on the change","reason_account":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"}},"1000085":{"account":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"last_update":"2024-03-02 17:01:59.000000000","reason":"removed on reply"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-03-03 11:22:56.000000000","reason":"Change was submitted"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2024-03-03 11:22:56.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I2399867591df923faa73927b924e7c116ad98dc0","subject":"refactor(tvix/castore/blobsvc/chunked_reader): refactor, document","status":"MERGED","created":"2024-03-02 16:47:53.000000000","updated":"2024-03-03 11:22:56.000000000","submitted":"2024-03-03 11:22:56.000000000","submitter":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"11079","meta_rev_id":"86547a4c6c3f6835af3391dd75f5dc9caac39805","_number":11079,"virtual_id_number":11079,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-03 11:22:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-03-03 11:22:56.000000000","_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-03 11:22:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-03-02 16:47:53.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"state":"REVIEWER"},{"updated":"2024-03-02 16:47:53.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2024-03-02 16:47:53.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"state":"REVIEWER"},{"updated":"2024-03-02 16:48:03.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-03-02 16:54:57.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9d1defbf2d15911a50eadbe407f8bafc443fc4f3","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-03-02 16:47:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5f55bd72e37320e9e7a5bdf09364187e156852b4","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-02 16:48:03.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/31952","accounts_in_message":[],"_revision_number":1},{"id":"529914f812f1cc942326cd90e58eb02290841164","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-02 16:54:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/31952","accounts_in_message":[],"_revision_number":1},{"id":"2b43337a6a4d1c7d7b007c4044b148c22fbe3b4f","tag":"autogenerated:gerrit:setReadyForReview","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-03-02 16:55:04.000000000","message":"Set Ready For Review","accounts_in_message":[],"_revision_number":1},{"id":"88d5239c0bdb731ddf2dbb468569cfb7f9458898","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-03-02 17:01:59.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ae1c83b8c90e1d2dd34215d2cf6f7ae077f7be4a","author":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"date":"2024-03-03 10:50:42.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"86547a4c6c3f6835af3391dd75f5dc9caac39805","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-03-03 11:22:56.000000000","message":"Change has been successfully rebased and submitted as 7bebf492ec7742b8a24c695d77fa64fdf654ab19","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"7bebf492ec7742b8a24c695d77fa64fdf654ab19","revisions":{"03524b0992a4e0518591ffb32ee220287341cf41":{"kind":"REWORK","_number":1,"created":"2024-03-02 16:47:53.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/79/11079/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/79/11079/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/79/11079/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/79/11079/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/79/11079/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/79/11079/1"}}},"commit":{"parents":[{"commit":"782ebfc025454fa0bd35873cb940e5a0af206e63","subject":"feat(tvix/castore/blobsvc): implement BlobReader on more trivial types","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d782ebfc025454fa0bd35873cb940e5a0af206e63"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-03-02 16:00:04.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-03-02 16:06:41.000000000","tz":120},"subject":"refactor(tvix/castore/blobsvc/chunked_reader): refactor, document","message":"refactor(tvix/castore/blobsvc/chunked_reader): refactor, document\n\nThe public-consumable thing here is ChunkedReader, not ChunkedBlob.\n\nChunkedBlob is a helper that can be used to get a new AsyncRead, but\nnot AsyncSeek. It is used internally by ChunkedReader whenever the\nclient seeks.\n\nMake this more obvious, by extending the documentation, and putting\nChunkedReader at the top of this file.\n\nAlso make ChunkedBlob and its methods private, and give ChunkedReader a\nmore useful constructor (from_chunks, instead of from_chunked_blob).\n\nChange-Id: I2399867591df923faa73927b924e7c116ad98dc0\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d03524b0992a4e0518591ffb32ee220287341cf41"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d03524b0992a4e0518591ffb32ee220287341cf41"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"782ebfc025454fa0bd35873cb940e5a0af206e63","is_merged_in_target_branch":false,"change_id":"I80e4f26c41a504fa4c6a013c2a1e76de613ba294","change_number":11078,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"7bebf492ec7742b8a24c695d77fa64fdf654ab19":{"kind":"REWORK","_number":2,"created":"2024-03-03 11:22:56.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/79/11079/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/79/11079/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/79/11079/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/79/11079/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/79/11079/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/79/11079/2"}}},"commit":{"parents":[{"commit":"1608f935aad2696f38231ef779bffc1f5ac31fec","subject":"refactor(nix/buildkite): unify target attr path calculation","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1608f935aad2696f38231ef779bffc1f5ac31fec"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-03-02 16:00:04.000000000","tz":120},"committer":{"name":"flokli","email":"flokli@flokli.de","date":"2024-03-03 11:22:56.000000000","tz":0},"subject":"refactor(tvix/castore/blobsvc/chunked_reader): refactor, document","message":"refactor(tvix/castore/blobsvc/chunked_reader): refactor, document\n\nThe public-consumable thing here is ChunkedReader, not ChunkedBlob.\n\nChunkedBlob is a helper that can be used to get a new AsyncRead, but\nnot AsyncSeek. It is used internally by ChunkedReader whenever the\nclient seeks.\n\nMake this more obvious, by extending the documentation, and putting\nChunkedReader at the top of this file.\n\nAlso make ChunkedBlob and its methods private, and give ChunkedReader a\nmore useful constructor (from_chunks, instead of from_chunked_blob).\n\nChange-Id: I2399867591df923faa73927b924e7c116ad98dc0\nReviewed-on: https://cl.tvl.fyi/c/depot/+/11079\nTested-by: BuildkiteCI\nReviewed-by: Brian Olsen \u003cme@griff.name\u003e\nReviewed-by: Connor Brewster \u003ccbrewster@hey.com\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7bebf492ec7742b8a24c695d77fa64fdf654ab19"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7bebf492ec7742b8a24c695d77fa64fdf654ab19"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"1608f935aad2696f38231ef779bffc1f5ac31fec","is_merged_in_target_branch":true,"change_id":"I50f9687e85c3b4407e4a55ff7e645db882bb80d6","change_number":10849,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}