)]}'
{"id":"depot~11153","triplet_id":"depot~canon~Ia926df4ac1b440ec430403ab7b40924a0c97221b","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000034":{"account":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"last_update":"2024-03-19 06:20:17.000000000","reason":"Change was submitted"},"1000001":{"account":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"last_update":"2024-03-19 06:20:01.000000000","reason":"removed on reply"},"1000010":{"account":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"last_update":"2024-03-19 06:20:17.000000000","reason":"Change was submitted"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2024-03-19 06:20:17.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia926df4ac1b440ec430403ab7b40924a0c97221b","subject":"fix(tvix/eval): don\u0027t force lambda arg in map, mapAttrs \u0026 genList","status":"MERGED","created":"2024-03-15 13:37:25.000000000","updated":"2024-03-19 06:20:17.000000000","submitted":"2024-03-19 06:20:17.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"11153","meta_rev_id":"19f0c110f5339190d9f646722610489802ca5c67","_number":11153,"virtual_id_number":11153,"owner":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-03-19 06:20:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-19 06:20:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-03-19 06:20:17.000000000","_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"all":[{"value":0,"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-03-15 13:37:27.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-03-15 13:42:09.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-03-15 13:42:32.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"CC"},{"updated":"2024-03-15 20:46:16.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2024-03-15 20:46:16.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2024-03-15 20:46:16.000000000","updated_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2024-03-19 06:20:17.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"9b0c4142ead6e84dc9c2309705d9dc9c28c96853","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2024-03-15 13:37:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"50a17c053dee38b0e001ee41a58b17307fac0e4c","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-15 13:37:27.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/32203","accounts_in_message":[],"_revision_number":1},{"id":"44c821b94b7b103d83da84b9b87bc063e0eea334","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-15 13:42:09.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/32203","accounts_in_message":[],"_revision_number":1},{"id":"4e061e6626d5fe66296e38f5ac956ef016603e34","tag":"autogenerated:gerrit:setWorkInProgress","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2024-03-15 13:42:24.000000000","message":"Set Work In Progress","accounts_in_message":[],"_revision_number":1},{"id":"199b3a5efd27545118102fff2d0afdbce483fe33","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2024-03-15 13:42:32.000000000","message":"Patch Set 1:\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":1},{"id":"e9404ce8ae3f668fdf9ccb34a9d0e1ab602c0237","tag":"autogenerated:gerrit:setWorkInProgress","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2024-03-15 13:42:39.000000000","message":"Set Work In Progress","accounts_in_message":[],"_revision_number":1},{"id":"364242495c3b95e5bbcb09d5119374ee573f37e5","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2024-03-15 20:46:02.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"3fddab408c7b4789dcc76926e1dff5fac9121a75","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-15 20:46:04.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/32207","accounts_in_message":[],"_revision_number":2},{"id":"6fe9137470a7958a86e42203741a9077b9765f9b","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2024-03-15 20:46:16.000000000","message":"Patch Set 2:\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":2},{"id":"7633e8f351d900eaf54b5f06b46260099d76c586","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2024-03-15 20:46:16.000000000","message":"\u003cGERRIT_ACCOUNT_1000010\u003e, who was added as reviewer owns the following files:\n* `tvix/eval/src/builtins/mod.rs`\n* `tvix/eval/src/tests/tvix_tests/eval-okay-builtins-genList-function-strictness.exp`\n* `tvix/eval/src/tests/tvix_tests/eval-okay-builtins-genList-function-strictness.nix`\n* `tvix/eval/src/tests/tvix_tests/eval-okay-builtins-map-function-strictness.exp`\n* `tvix/eval/src/tests/tvix_tests/eval-okay-builtins-map-function-strictness.nix`\n* `tvix/eval/src/tests/tvix_tests/eval-okay-builtins-mapAttrs-function-strictness.exp`\n* `tvix/eval/src/tests/tvix_tests/eval-okay-builtins-mapAttrs-function-strictness.nix`\n* `tvix/verify-lang-tests/default.nix`\n\n\u003cGERRIT_ACCOUNT_1000001\u003e, who was added as reviewer owns the following files:\n* `tvix/eval/src/builtins/mod.rs`\n* `tvix/eval/src/tests/tvix_tests/eval-okay-builtins-genList-function-strictness.exp`\n* `tvix/eval/src/tests/tvix_tests/eval-okay-builtins-genList-function-strictness.nix`\n* `tvix/eval/src/tests/tvix_tests/eval-okay-builtins-map-function-strictness.exp`\n* `tvix/eval/src/tests/tvix_tests/eval-okay-builtins-map-function-strictness.nix`\n* `tvix/eval/src/tests/tvix_tests/eval-okay-builtins-mapAttrs-function-strictness.exp`\n* `tvix/eval/src/tests/tvix_tests/eval-okay-builtins-mapAttrs-function-strictness.nix`\n* `tvix/verify-lang-tests/default.nix`\n","accounts_in_message":[{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}],"_revision_number":2},{"id":"faf3b2181af4cb8a3fa1c7478fcc41906ba2a22c","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2024-03-15 20:46:23.000000000","message":"Patch Set 2: Autosubmit+1","accounts_in_message":[],"_revision_number":2},{"id":"665feeb671b3705bd681f5c9e2734489a4ac52e9","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-15 20:50:48.000000000","message":"Patch Set 2: Verified-1\n\nBuild of patchset 2 failed: https://buildkite.com/tvl/depot/builds/32207","accounts_in_message":[],"_revision_number":2},{"id":"4e61e7854f4af83550ffc535dd88d4c974ed2076","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2024-03-15 20:53:45.000000000","message":"Uploaded patch set 3.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"c7ce166391f0ac6db1b6ad9a78255dd14a478881","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-15 20:53:49.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/32209","accounts_in_message":[],"_revision_number":3},{"id":"cd7bde51f5626f3628a36e4870a0694a9e4e8053","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-15 20:58:41.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/32209","accounts_in_message":[],"_revision_number":3},{"id":"6e45e551051d2cb9b90dc7464fd36bbe91eac471","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"date":"2024-03-15 21:48:00.000000000","message":"Uploaded patch set 4.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"0e9d672b00db8dfa3482fce79457865dda08e20d","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-15 21:48:04.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/32221","accounts_in_message":[],"_revision_number":4},{"id":"1ea556309fd29470dfe4fa1da616ee3f7db9c863","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-15 21:53:05.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/32221","accounts_in_message":[],"_revision_number":4},{"id":"62489938ff0386e47bb669e15d8c949abe177a58","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2024-03-19 06:20:01.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"19f0c110f5339190d9f646722610489802ca5c67","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-03-19 06:20:17.000000000","message":"Change has been successfully rebased and submitted as d1b7e0872608b2d78ddcb2ee473ec9bdbf9695a8","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"d1b7e0872608b2d78ddcb2ee473ec9bdbf9695a8","revisions":{"e0be64ba8efc81cc7990088603e3eff6face6369":{"kind":"REWORK","_number":1,"created":"2024-03-15 13:37:25.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/53/11153/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/53/11153/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11153/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11153/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11153/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/53/11153/1"}}},"commit":{"parents":[{"commit":"d5b6704d3d82c1c1acf45aba71ab1a337f94defd","subject":"chore: move protoCheck into extraStep of //nix/bufCheck","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd5b6704d3d82c1c1acf45aba71ab1a337f94defd"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2024-03-15 13:36:34.000000000","tz":60},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2024-03-15 13:36:34.000000000","tz":60},"subject":"test: wip b/386","message":"test: wip b/386\n\nChange-Id: Ia926df4ac1b440ec430403ab7b40924a0c97221b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de0be64ba8efc81cc7990088603e3eff6face6369"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de0be64ba8efc81cc7990088603e3eff6face6369"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"d5b6704d3d82c1c1acf45aba71ab1a337f94defd","is_merged_in_target_branch":true,"change_id":"I2a2b63d135a2f8bcc982aa1138ff3213c6012f20","change_number":11152,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"8c6508cdcb43ee5e5269ffd5ab9af04a00c52179":{"kind":"REWORK","_number":2,"created":"2024-03-15 20:46:02.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/53/11153/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/53/11153/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11153/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11153/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11153/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/53/11153/2"}}},"commit":{"parents":[{"commit":"d5b6704d3d82c1c1acf45aba71ab1a337f94defd","subject":"chore: move protoCheck into extraStep of //nix/bufCheck","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd5b6704d3d82c1c1acf45aba71ab1a337f94defd"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2024-03-15 13:36:34.000000000","tz":60},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2024-03-15 20:41:36.000000000","tz":60},"subject":"fix(tvix/eval): don\u0027t force lambda arg in map, mapAttrs \u0026 genList","message":"fix(tvix/eval): don\u0027t force lambda arg in map, mapAttrs \u0026 genList\n\nIt is pretty pointless to force the function argument if we are going to\nuse a suspended call later since forcing the function may fail in ways\nthat are not covered by Catchables (non-recoverable errors, infinite\nrecursions). From this, it kind of seems as if using #[catch] is never\ncorrect and should be replaced by #[lazy]. Also we should probably try\nto come up with more test cases for stuff where laziness gets us out of\nthe jam as an equivalent to the catchable tests for nonrecoverable\nerrors.\n\nFixes b/386.\n\nChange-Id: Ia926df4ac1b440ec430403ab7b40924a0c97221b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8c6508cdcb43ee5e5269ffd5ab9af04a00c52179"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8c6508cdcb43ee5e5269ffd5ab9af04a00c52179"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"d5b6704d3d82c1c1acf45aba71ab1a337f94defd","is_merged_in_target_branch":true,"change_id":"I2a2b63d135a2f8bcc982aa1138ff3213c6012f20","change_number":11152,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"a895b6583b9c2459cf8efe5a2f0e490351d833c9":{"kind":"REWORK","_number":3,"created":"2024-03-15 20:53:45.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/53/11153/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/53/11153/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11153/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11153/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11153/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/53/11153/3"}}},"commit":{"parents":[{"commit":"d5b6704d3d82c1c1acf45aba71ab1a337f94defd","subject":"chore: move protoCheck into extraStep of //nix/bufCheck","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd5b6704d3d82c1c1acf45aba71ab1a337f94defd"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2024-03-15 13:36:34.000000000","tz":60},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2024-03-15 20:53:39.000000000","tz":60},"subject":"fix(tvix/eval): don\u0027t force lambda arg in map, mapAttrs \u0026 genList","message":"fix(tvix/eval): don\u0027t force lambda arg in map, mapAttrs \u0026 genList\n\nIt is pretty pointless to force the function argument if we are going to\nuse a suspended call later since forcing the function may fail in ways\nthat are not covered by Catchables (non-recoverable errors, infinite\nrecursions). From this, it kind of seems as if using #[catch] is never\ncorrect and should be replaced by #[lazy]. Also we should probably try\nto come up with more test cases for stuff where laziness gets us out of\nthe jam as an equivalent to the catchable tests for nonrecoverable\nerrors.\n\nFixes b/386.\n\nChange-Id: Ia926df4ac1b440ec430403ab7b40924a0c97221b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da895b6583b9c2459cf8efe5a2f0e490351d833c9"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da895b6583b9c2459cf8efe5a2f0e490351d833c9"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"d5b6704d3d82c1c1acf45aba71ab1a337f94defd","is_merged_in_target_branch":true,"change_id":"I2a2b63d135a2f8bcc982aa1138ff3213c6012f20","change_number":11152,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"a6a714df9fbfee4e19e7d601d1cd0fd0c5fd11ea":{"kind":"REWORK","_number":4,"created":"2024-03-15 21:48:00.000000000","uploader":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"},"ref":"refs/changes/53/11153/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/53/11153/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11153/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11153/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11153/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/53/11153/4"}}},"commit":{"parents":[{"commit":"d3534ee051abad5117e9578854b6cd13a14d940d","subject":"fix(depotfmt): only exclude *imported* tvix tests","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd3534ee051abad5117e9578854b6cd13a14d940d"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2024-03-15 13:36:34.000000000","tz":60},"committer":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2024-03-15 21:47:22.000000000","tz":60},"subject":"fix(tvix/eval): don\u0027t force lambda arg in map, mapAttrs \u0026 genList","message":"fix(tvix/eval): don\u0027t force lambda arg in map, mapAttrs \u0026 genList\n\nIt is pretty pointless to force the function argument if we are going to\nuse a suspended call later since forcing the function may fail in ways\nthat are not covered by Catchables (non-recoverable errors, infinite\nrecursions). From this, it kind of seems as if using #[catch] is never\ncorrect and should be replaced by #[lazy]. Also we should probably try\nto come up with more test cases for stuff where laziness gets us out of\nthe jam as an equivalent to the catchable tests for nonrecoverable\nerrors.\n\nFixes b/386.\n\nChange-Id: Ia926df4ac1b440ec430403ab7b40924a0c97221b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da6a714df9fbfee4e19e7d601d1cd0fd0c5fd11ea"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da6a714df9fbfee4e19e7d601d1cd0fd0c5fd11ea"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"d3534ee051abad5117e9578854b6cd13a14d940d","is_merged_in_target_branch":true,"change_id":"I2b66d79e30fae17e75d5a1f8c44e279886091c5f","change_number":11154,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"d1b7e0872608b2d78ddcb2ee473ec9bdbf9695a8":{"kind":"REWORK","_number":5,"created":"2024-03-19 06:20:17.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/53/11153/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/53/11153/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11153/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11153/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11153/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/53/11153/5"}}},"commit":{"parents":[{"commit":"3633d846f88d8306dabd5e820d0f3cd999404050","subject":"chore(3p/sources): bump channels \u0026 overlays (2024-03-17)","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3633d846f88d8306dabd5e820d0f3cd999404050"}]}],"author":{"name":"sterni","email":"sternenseemann@systemli.org","date":"2024-03-15 13:36:34.000000000","tz":60},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-03-19 06:20:17.000000000","tz":0},"subject":"fix(tvix/eval): don\u0027t force lambda arg in map, mapAttrs \u0026 genList","message":"fix(tvix/eval): don\u0027t force lambda arg in map, mapAttrs \u0026 genList\n\nIt is pretty pointless to force the function argument if we are going to\nuse a suspended call later since forcing the function may fail in ways\nthat are not covered by Catchables (non-recoverable errors, infinite\nrecursions). From this, it kind of seems as if using #[catch] is never\ncorrect and should be replaced by #[lazy]. Also we should probably try\nto come up with more test cases for stuff where laziness gets us out of\nthe jam as an equivalent to the catchable tests for nonrecoverable\nerrors.\n\nFixes b/386.\n\nChange-Id: Ia926df4ac1b440ec430403ab7b40924a0c97221b\nReviewed-on: https://cl.tvl.fyi/c/depot/+/11153\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\nTested-by: BuildkiteCI\nAutosubmit: sterni \u003csternenseemann@systemli.org\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd1b7e0872608b2d78ddcb2ee473ec9bdbf9695a8"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd1b7e0872608b2d78ddcb2ee473ec9bdbf9695a8"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3633d846f88d8306dabd5e820d0f3cd999404050","is_merged_in_target_branch":true,"change_id":"I763f1f075778f2ed8db7803f87248c9dabde4213","change_number":11174,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000034,"name":"sterni","email":"sternenseemann@systemli.org","username":"sterni"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}