)]}'
{"id":"depot~1123","triplet_id":"depot~canon~I7fbd1f4d5c449e2f9b82102a701b0bacd5e80672","project":"depot","branch":"canon","topic":"tvix","hashtags":[],"change_id":"I7fbd1f4d5c449e2f9b82102a701b0bacd5e80672","subject":"feat(3p/nix): Add vector-backed impl for Bindings","status":"MERGED","created":"2020-07-12 20:52:23.000000000","updated":"2020-08-29 13:59:59.000000000","submitted":"2020-07-13 23:50:24.000000000","submitter":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1125","meta_rev_id":"41ffc5c7e628931a774e05087aa17524905cb55b","_number":1123,"virtual_id_number":1123,"owner":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-07-13 23:50:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2020-07-13 23:50:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-12 20:53:49.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-12 20:56:09.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"CC"},{"updated":"2020-07-12 21:25:51.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"}],"messages":[{"id":"97d80894722a4336e842e2ca7e60a53f91e9f20d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-12 20:52:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"48adb4e7cb0f4fcda6b222a53aa53a629c13153d","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-12 20:53:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/813","accounts_in_message":[],"_revision_number":1},{"id":"9148b7fde73bf68d3363c9c350d69090efeb0d00","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-12 20:54:57.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6d0967f6c93d800ae431bde3b5689ea67b1401e5","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-07-12 20:56:09.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"2f6b0430b6455ae00d935a49f6c5dd7f861971a3","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-12 20:56:23.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/814","accounts_in_message":[],"_revision_number":2},{"id":"b95d92442e78e39279df902c0663a846f8cbd872","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-12 20:58:32.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"d020b998fd28d3927bf0cfc75b24056ea56ff709","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-12 20:59:25.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"a9d01601ef5063acc83aa93f40a27d0b92aae7a5","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-12 20:59:39.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"d9176b5ade3aac3c5172c1276d107cfe319bb7e3","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-12 20:59:58.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/815","accounts_in_message":[],"_revision_number":3},{"id":"47333877572b38ee7cfbb76dad36e509b6a63af8","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-12 21:00:53.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/816","accounts_in_message":[],"_revision_number":4},{"id":"e7d1b0193ee1f7d71328cd0112952afb6bf5642b","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-07-12 21:25:51.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"eae244fa465318c55ea148d047de47b867842f84","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-13 13:40:45.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"e0cb59c96b6e8b499b2946f6f32e1d607830eac7","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-13 13:42:44.000000000","message":"Patch Set 5: Verified+1\n\nBuild of patchset 5 passed: https://buildkite.com/tvl/depot/builds/832","accounts_in_message":[],"_revision_number":5},{"id":"ca6b148839df92991f572cf07748e54f5b87f14d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-13 17:40:43.000000000","message":"Uploaded patch set 6: Patch Set 5 was rebased.","accounts_in_message":[],"_revision_number":6},{"id":"ac887faf7438b66989e5f689d164f2e8d6e3cc7f","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-13 17:41:07.000000000","message":"Patch Set 6: Verified+1\n\nBuild of patchset 6 passed: https://buildkite.com/tvl/depot/builds/843","accounts_in_message":[],"_revision_number":6},{"id":"da462babbad9b5902c3e2bdf84b28bd5b9d8adbf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-13 17:50:11.000000000","message":"Uploaded patch set 7: Patch Set 6 was rebased.","accounts_in_message":[],"_revision_number":7},{"id":"77b49a645dff1761198871cfe8aecec7a5d52e55","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-13 17:50:36.000000000","message":"Patch Set 7: Verified+1\n\nBuild of patchset 7 passed: https://buildkite.com/tvl/depot/builds/853","accounts_in_message":[],"_revision_number":7},{"id":"645f54eddfc45ea358a84708ffb4f324d8a2e874","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-07-13 21:11:08.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"57353e4d19f7acbc4477f4f6e3a8f7bfb7bffd7e","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-13 21:12:38.000000000","message":"Patch Set 8: Verified-1\n\nBuild of patchset 8 failed: https://buildkite.com/tvl/depot/builds/887","accounts_in_message":[],"_revision_number":8},{"id":"9f7a1b0f65ffaa7e3fefee065848944cf84a0720","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-13 21:13:25.000000000","message":"Patch Set 8:\n\n(1 comment)","accounts_in_message":[],"_revision_number":8},{"id":"a2f26d04c0f205128a15e39892dcc73e8523a510","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-13 23:21:15.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"ffc90bfee2ba1f60fa493ab733a11877d9082808","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-13 23:22:38.000000000","message":"Patch Set 9: Verified-1\n\nBuild of patchset 9 failed: https://buildkite.com/tvl/depot/builds/890","accounts_in_message":[],"_revision_number":9},{"id":"d633bd1a6498b565ab8dd7629bf15e06afa83305","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-13 23:33:10.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"ff411a478dfeaf09e76d351786909ceb6c1f8c6a","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-13 23:34:56.000000000","message":"Patch Set 10: Verified+1\n\nBuild of patchset 10 passed: https://buildkite.com/tvl/depot/builds/893","accounts_in_message":[],"_revision_number":10},{"id":"22d3bf414dde6e1028369c5215052c21b8995d33","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-13 23:48:42.000000000","message":"Patch Set 10:\n\n(1 comment)","accounts_in_message":[],"_revision_number":10},{"id":"a9229207820f612b313a6a5c3e552994010422d0","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-13 23:50:24.000000000","message":"Change has been successfully rebased and submitted as d5505fcff9dc9ad76b4cb822cc642fdd0e238553 by glittershark","accounts_in_message":[],"_revision_number":11},{"id":"c8dc2eee2d8540b28a573a9cf39341d64e6e9299","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-13 23:50:52.000000000","message":"Patch Set 11:\n\nBuild of patchset 11 passed: https://buildkite.com/tvl/depot/builds/907","accounts_in_message":[],"_revision_number":11},{"id":"41ffc5c7e628931a774e05087aa17524905cb55b","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-08-29 13:59:59.000000000","message":"Topic set to tvix","accounts_in_message":[],"_revision_number":11}],"current_revision_number":11,"current_revision":"d5505fcff9dc9ad76b4cb822cc642fdd0e238553","revisions":{"35fa228c99892327190ce26d8186a3c3849b8aaa":{"kind":"REWORK","_number":1,"created":"2020-07-12 20:52:23.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/23/1123/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/23/1123/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/23/1123/1"}}},"commit":{"parents":[{"commit":"61e2c5c4fd412a6ae2db6035555d200957a290d8","subject":"refactor(3p/nix): Abstract away concrete bindings impl","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d61e2c5c4fd412a6ae2db6035555d200957a290d8"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-12 20:51:00.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-12 20:51:00.000000000","tz":-240},"subject":"feat(3p/nix): Add vector-backed impl for Bindings","message":"feat(3p/nix): Add vector-backed impl for Bindings\n\nAdd an alternative impl of the now-abstract Bindings base class that is\nbacked by a std::vector, somewhat similar but stylistically a little\nsuperior to the array-backed implementation in upstream nix. The\nunderlying iterator type in BindingsIterator is now backed by a\nstd::variant that we std::visit an overload over in order to implement\nthe various bits of the iterator interface.\n\nChange-Id: I7fbd1f4d5c449e2f9b82102a701b0bacd5e80672\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d35fa228c99892327190ce26d8186a3c3849b8aaa"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d35fa228c99892327190ce26d8186a3c3849b8aaa"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"61e2c5c4fd412a6ae2db6035555d200957a290d8","is_merged_in_target_branch":false,"change_id":"Ie02ca5a1c55e8ebf99ab1e957110bd9284278907","change_number":1121,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"a29951844930dc116c1bda51a995efe67c9d23cd":{"kind":"REWORK","_number":2,"created":"2020-07-12 20:54:57.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/23/1123/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/23/1123/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/23/1123/2"}}},"commit":{"parents":[{"commit":"61e2c5c4fd412a6ae2db6035555d200957a290d8","subject":"refactor(3p/nix): Abstract away concrete bindings impl","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d61e2c5c4fd412a6ae2db6035555d200957a290d8"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-12 20:51:00.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-12 20:54:25.000000000","tz":-240},"subject":"feat(3p/nix): Add vector-backed impl for Bindings","message":"feat(3p/nix): Add vector-backed impl for Bindings\n\nAdd an alternative impl of the now-abstract Bindings base class that is\nbacked by a std::vector, somewhat similar but stylistically a little\nsuperior to the array-backed implementation in upstream nix. The\nunderlying iterator type in BindingsIterator is now backed by a\nstd::variant that we std::visit an overload over in order to implement\nthe various bits of the iterator interface.\n\nPaired-With: Luke Granger-Brown \u003cgit@lukegb.com\u003e\nPaired-With: Vincent Ambo \u003cmail@tazj.in\u003e\nPaired-With: Perry Lorier \u003cisomer@tvl.fyi\u003e\nChange-Id: I7fbd1f4d5c449e2f9b82102a701b0bacd5e80672\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da29951844930dc116c1bda51a995efe67c9d23cd"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da29951844930dc116c1bda51a995efe67c9d23cd"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"61e2c5c4fd412a6ae2db6035555d200957a290d8","is_merged_in_target_branch":false,"change_id":"Ie02ca5a1c55e8ebf99ab1e957110bd9284278907","change_number":1121,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"70359a7ef6ae133f22a8f31379ec4d834a534cad":{"kind":"REWORK","_number":3,"created":"2020-07-12 20:58:32.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/23/1123/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/23/1123/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/23/1123/3"}}},"commit":{"parents":[{"commit":"61e2c5c4fd412a6ae2db6035555d200957a290d8","subject":"refactor(3p/nix): Abstract away concrete bindings impl","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d61e2c5c4fd412a6ae2db6035555d200957a290d8"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-12 20:51:00.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-12 20:58:23.000000000","tz":-240},"subject":"feat(3p/nix): Add vector-backed impl for Bindings","message":"feat(3p/nix): Add vector-backed impl for Bindings\n\nAdd an alternative impl of the now-abstract Bindings base class that is\nbacked by a std::vector, somewhat similar but stylistically a little\nsuperior to the array-backed implementation in upstream nix. The\nunderlying iterator type in BindingsIterator is now backed by a\nstd::variant that we std::visit an overload over in order to implement\nthe various bits of the iterator interface.\n\nPaired-With: Luke Granger-Brown \u003cgit@lukegb.com\u003e\nPaired-With: Vincent Ambo \u003cmail@tazj.in\u003e\nPaired-With: Perry Lorier \u003cisomer@tvl.fyi\u003e\nChange-Id: I7fbd1f4d5c449e2f9b82102a701b0bacd5e80672\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d70359a7ef6ae133f22a8f31379ec4d834a534cad"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d70359a7ef6ae133f22a8f31379ec4d834a534cad"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"61e2c5c4fd412a6ae2db6035555d200957a290d8","is_merged_in_target_branch":false,"change_id":"Ie02ca5a1c55e8ebf99ab1e957110bd9284278907","change_number":1121,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"ca1f903f1f3d4da95ab65cea26204e56f6bfc0d8":{"kind":"REWORK","_number":4,"created":"2020-07-12 20:59:25.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/23/1123/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/23/1123/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/23/1123/4"}}},"commit":{"parents":[{"commit":"61e2c5c4fd412a6ae2db6035555d200957a290d8","subject":"refactor(3p/nix): Abstract away concrete bindings impl","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d61e2c5c4fd412a6ae2db6035555d200957a290d8"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-12 20:51:00.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-12 20:59:23.000000000","tz":-240},"subject":"feat(3p/nix): Add vector-backed impl for Bindings","message":"feat(3p/nix): Add vector-backed impl for Bindings\n\nAdd an alternative impl of the now-abstract Bindings base class that is\nbacked by a std::vector, somewhat similar but stylistically a little\nsuperior to the array-backed implementation in upstream nix. The\nunderlying iterator type in BindingsIterator is now backed by a\nstd::variant that we std::visit an overload over in order to implement\nthe various bits of the iterator interface.\n\nPaired-With: Luke Granger-Brown \u003cgit@lukegb.com\u003e\nPaired-With: Vincent Ambo \u003cmail@tazj.in\u003e\nPaired-With: Perry Lorier \u003cisomer@tvl.fyi\u003e\nChange-Id: I7fbd1f4d5c449e2f9b82102a701b0bacd5e80672\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dca1f903f1f3d4da95ab65cea26204e56f6bfc0d8"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dca1f903f1f3d4da95ab65cea26204e56f6bfc0d8"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"61e2c5c4fd412a6ae2db6035555d200957a290d8","is_merged_in_target_branch":false,"change_id":"Ie02ca5a1c55e8ebf99ab1e957110bd9284278907","change_number":1121,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"ea3df2f4341e9d1a749230ff9a32639a1841734b":{"kind":"REWORK","_number":5,"created":"2020-07-13 13:40:45.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/23/1123/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/23/1123/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/23/1123/5"}}},"commit":{"parents":[{"commit":"72e184bf094420f6a4e108f7dab8770b09a2f1ed","subject":"refactor(3p/nix): Abstract away concrete bindings impl","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d72e184bf094420f6a4e108f7dab8770b09a2f1ed"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-12 20:51:00.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-13 13:40:42.000000000","tz":-240},"subject":"feat(3p/nix): Add vector-backed impl for Bindings","message":"feat(3p/nix): Add vector-backed impl for Bindings\n\nAdd an alternative impl of the now-abstract Bindings base class that is\nbacked by a std::vector, somewhat similar but stylistically a little\nsuperior to the array-backed implementation in upstream nix. The\nunderlying iterator type in BindingsIterator is now backed by a\nstd::variant that we std::visit an overload over in order to implement\nthe various bits of the iterator interface.\n\nPaired-With: Luke Granger-Brown \u003cgit@lukegb.com\u003e\nPaired-With: Vincent Ambo \u003cmail@tazj.in\u003e\nPaired-With: Perry Lorier \u003cisomer@tvl.fyi\u003e\nChange-Id: I7fbd1f4d5c449e2f9b82102a701b0bacd5e80672\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dea3df2f4341e9d1a749230ff9a32639a1841734b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dea3df2f4341e9d1a749230ff9a32639a1841734b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"72e184bf094420f6a4e108f7dab8770b09a2f1ed","is_merged_in_target_branch":false,"change_id":"Ie02ca5a1c55e8ebf99ab1e957110bd9284278907","change_number":1121,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"b4972e290827a6f3ea762a46a09a088d79384311":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2020-07-13 17:40:43.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/23/1123/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/23/1123/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/23/1123/6"}}},"commit":{"parents":[{"commit":"e4ea32e0fbb8abb29480d4d85a1ed98d4acc45ac","subject":"refactor(3p/nix): Abstract away concrete bindings impl","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de4ea32e0fbb8abb29480d4d85a1ed98d4acc45ac"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-12 20:51:00.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-13 17:37:02.000000000","tz":-240},"subject":"feat(3p/nix): Add vector-backed impl for Bindings","message":"feat(3p/nix): Add vector-backed impl for Bindings\n\nAdd an alternative impl of the now-abstract Bindings base class that is\nbacked by a std::vector, somewhat similar but stylistically a little\nsuperior to the array-backed implementation in upstream nix. The\nunderlying iterator type in BindingsIterator is now backed by a\nstd::variant that we std::visit an overload over in order to implement\nthe various bits of the iterator interface.\n\nPaired-With: Luke Granger-Brown \u003cgit@lukegb.com\u003e\nPaired-With: Vincent Ambo \u003cmail@tazj.in\u003e\nPaired-With: Perry Lorier \u003cisomer@tvl.fyi\u003e\nChange-Id: I7fbd1f4d5c449e2f9b82102a701b0bacd5e80672\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db4972e290827a6f3ea762a46a09a088d79384311"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db4972e290827a6f3ea762a46a09a088d79384311"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e4ea32e0fbb8abb29480d4d85a1ed98d4acc45ac","is_merged_in_target_branch":false,"change_id":"Ie02ca5a1c55e8ebf99ab1e957110bd9284278907","change_number":1121,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"ba94db89c41419f91745813fec8a3d8fa749a978":{"kind":"TRIVIAL_REBASE","_number":7,"created":"2020-07-13 17:50:11.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/23/1123/7","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/23/1123/7","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/23/1123/7"}}},"commit":{"parents":[{"commit":"68e745a41ddb95d88166201d065c2ac038ab9839","subject":"refactor(3p/nix): Abstract away concrete bindings impl","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d68e745a41ddb95d88166201d065c2ac038ab9839"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-12 20:51:00.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-13 17:44:04.000000000","tz":-240},"subject":"feat(3p/nix): Add vector-backed impl for Bindings","message":"feat(3p/nix): Add vector-backed impl for Bindings\n\nAdd an alternative impl of the now-abstract Bindings base class that is\nbacked by a std::vector, somewhat similar but stylistically a little\nsuperior to the array-backed implementation in upstream nix. The\nunderlying iterator type in BindingsIterator is now backed by a\nstd::variant that we std::visit an overload over in order to implement\nthe various bits of the iterator interface.\n\nPaired-With: Luke Granger-Brown \u003cgit@lukegb.com\u003e\nPaired-With: Vincent Ambo \u003cmail@tazj.in\u003e\nPaired-With: Perry Lorier \u003cisomer@tvl.fyi\u003e\nChange-Id: I7fbd1f4d5c449e2f9b82102a701b0bacd5e80672\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dba94db89c41419f91745813fec8a3d8fa749a978"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dba94db89c41419f91745813fec8a3d8fa749a978"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"68e745a41ddb95d88166201d065c2ac038ab9839","is_merged_in_target_branch":false,"change_id":"Ie02ca5a1c55e8ebf99ab1e957110bd9284278907","change_number":1121,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"77f2f61ffe0e8a6f974185077d1342516bbccc66":{"kind":"REWORK","_number":8,"created":"2020-07-13 21:11:08.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/23/1123/8","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/23/1123/8","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/23/1123/8"}}},"commit":{"parents":[{"commit":"0e6fee6fadad326a69b60d9bdfb8f7d1b106ce0e","subject":"refactor(3p/nix): Abstract away concrete bindings impl","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0e6fee6fadad326a69b60d9bdfb8f7d1b106ce0e"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-12 20:51:00.000000000","tz":-240},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-07-13 21:11:02.000000000","tz":60},"subject":"feat(3p/nix): Add vector-backed impl for Bindings","message":"feat(3p/nix): Add vector-backed impl for Bindings\n\nAdd an alternative impl of the now-abstract Bindings base class that is\nbacked by a std::vector, somewhat similar but stylistically a little\nsuperior to the array-backed implementation in upstream nix. The\nunderlying iterator type in BindingsIterator is now backed by a\nstd::variant that we std::visit an overload over in order to implement\nthe various bits of the iterator interface.\n\nPaired-With: Luke Granger-Brown \u003cgit@lukegb.com\u003e\nPaired-With: Vincent Ambo \u003cmail@tazj.in\u003e\nPaired-With: Perry Lorier \u003cisomer@tvl.fyi\u003e\nChange-Id: I7fbd1f4d5c449e2f9b82102a701b0bacd5e80672\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d77f2f61ffe0e8a6f974185077d1342516bbccc66"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d77f2f61ffe0e8a6f974185077d1342516bbccc66"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"0e6fee6fadad326a69b60d9bdfb8f7d1b106ce0e","is_merged_in_target_branch":false,"change_id":"Ie02ca5a1c55e8ebf99ab1e957110bd9284278907","change_number":1121,"patch_set_number":8,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"7f663f396de4a4f3ae0cabe7baf27b012e227ab0":{"kind":"REWORK","_number":9,"created":"2020-07-13 23:21:15.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/23/1123/9","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/23/1123/9","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/23/1123/9"}}},"commit":{"parents":[{"commit":"0e6fee6fadad326a69b60d9bdfb8f7d1b106ce0e","subject":"refactor(3p/nix): Abstract away concrete bindings impl","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0e6fee6fadad326a69b60d9bdfb8f7d1b106ce0e"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-12 20:51:00.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-13 23:21:10.000000000","tz":-240},"subject":"feat(3p/nix): Add vector-backed impl for Bindings","message":"feat(3p/nix): Add vector-backed impl for Bindings\n\nAdd an alternative impl of the now-abstract Bindings base class that is\nbacked by a std::vector, somewhat similar but stylistically a little\nsuperior to the array-backed implementation in upstream nix. The\nunderlying iterator type in BindingsIterator is now backed by a\nstd::variant that we std::visit an overload over in order to implement\nthe various bits of the iterator interface.\n\nPaired-With: Luke Granger-Brown \u003cgit@lukegb.com\u003e\nPaired-With: Vincent Ambo \u003cmail@tazj.in\u003e\nPaired-With: Perry Lorier \u003cisomer@tvl.fyi\u003e\nChange-Id: I7fbd1f4d5c449e2f9b82102a701b0bacd5e80672\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7f663f396de4a4f3ae0cabe7baf27b012e227ab0"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7f663f396de4a4f3ae0cabe7baf27b012e227ab0"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"0e6fee6fadad326a69b60d9bdfb8f7d1b106ce0e","is_merged_in_target_branch":false,"change_id":"Ie02ca5a1c55e8ebf99ab1e957110bd9284278907","change_number":1121,"patch_set_number":8,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"1326c509b12c4f52e7eb20bc53b737a0475e787e":{"kind":"REWORK","_number":10,"created":"2020-07-13 23:33:10.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/23/1123/10","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/23/1123/10","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/23/1123/10"}}},"commit":{"parents":[{"commit":"0e6fee6fadad326a69b60d9bdfb8f7d1b106ce0e","subject":"refactor(3p/nix): Abstract away concrete bindings impl","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0e6fee6fadad326a69b60d9bdfb8f7d1b106ce0e"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-12 20:51:00.000000000","tz":-240},"committer":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-13 23:33:03.000000000","tz":-240},"subject":"feat(3p/nix): Add vector-backed impl for Bindings","message":"feat(3p/nix): Add vector-backed impl for Bindings\n\nAdd an alternative impl of the now-abstract Bindings base class that is\nbacked by a std::vector, somewhat similar but stylistically a little\nsuperior to the array-backed implementation in upstream nix. The\nunderlying iterator type in BindingsIterator is now backed by a\nstd::variant that we std::visit an overload over in order to implement\nthe various bits of the iterator interface.\n\nPaired-With: Luke Granger-Brown \u003cgit@lukegb.com\u003e\nPaired-With: Vincent Ambo \u003cmail@tazj.in\u003e\nPaired-With: Perry Lorier \u003cisomer@tvl.fyi\u003e\nChange-Id: I7fbd1f4d5c449e2f9b82102a701b0bacd5e80672\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1326c509b12c4f52e7eb20bc53b737a0475e787e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1326c509b12c4f52e7eb20bc53b737a0475e787e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"0e6fee6fadad326a69b60d9bdfb8f7d1b106ce0e","is_merged_in_target_branch":false,"change_id":"Ie02ca5a1c55e8ebf99ab1e957110bd9284278907","change_number":1121,"patch_set_number":8,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"d5505fcff9dc9ad76b4cb822cc642fdd0e238553":{"kind":"REWORK","_number":11,"created":"2020-07-13 23:50:24.000000000","uploader":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"ref":"refs/changes/23/1123/11","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/23/1123/11","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/23/1123/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/23/1123/11"}}},"commit":{"parents":[{"commit":"98148e671130c93d5c292ab560628eb8b8acee8a","subject":"refactor(3p/nix): Abstract away concrete bindings impl","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d98148e671130c93d5c292ab560628eb8b8acee8a"}]}],"author":{"name":"Griffin Smith","email":"grfn@gws.fyi","date":"2020-07-12 20:51:00.000000000","tz":-240},"committer":{"name":"glittershark","email":"grfn@gws.fyi","date":"2020-07-13 23:50:24.000000000","tz":0},"subject":"feat(3p/nix): Add vector-backed impl for Bindings","message":"feat(3p/nix): Add vector-backed impl for Bindings\n\nAdd an alternative impl of the now-abstract Bindings base class that is\nbacked by a std::vector, somewhat similar but stylistically a little\nsuperior to the array-backed implementation in upstream nix. The\nunderlying iterator type in BindingsIterator is now backed by a\nstd::variant that we std::visit an overload over in order to implement\nthe various bits of the iterator interface.\n\nPaired-With: Luke Granger-Brown \u003cgit@lukegb.com\u003e\nPaired-With: Vincent Ambo \u003cmail@tazj.in\u003e\nPaired-With: Perry Lorier \u003cisomer@tvl.fyi\u003e\nChange-Id: I7fbd1f4d5c449e2f9b82102a701b0bacd5e80672\nReviewed-on: https://cl.tvl.fyi/c/depot/+/1123\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003cmail@tazj.in\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd5505fcff9dc9ad76b4cb822cc642fdd0e238553"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd5505fcff9dc9ad76b4cb822cc642fdd0e238553"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"98148e671130c93d5c292ab560628eb8b8acee8a","is_merged_in_target_branch":true,"change_id":"Ie02ca5a1c55e8ebf99ab1e957110bd9284278907","change_number":1121,"patch_set_number":9,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}