)]}'
{"id":"depot~11236","triplet_id":"depot~canon~Ifa1c8324bcee8f751604b0b449feab875c632fda","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000085":{"account":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"last_update":"2024-04-09 17:31:58.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-04-09 17:31:10.000000000","reason":"removed on reply"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2024-04-09 17:31:58.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ifa1c8324bcee8f751604b0b449feab875c632fda","subject":"fix(tvix): Avoid buffering file into memory in builtins.hashFile","status":"MERGED","created":"2024-03-23 00:07:49.000000000","updated":"2024-04-09 17:31:58.000000000","submitted":"2024-04-09 17:31:58.000000000","submitter":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"total_comment_count":43,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"11236","meta_rev_id":"1ce9ee97a1f859ee517ab8cf3df6ff7246efd5a8","_number":11236,"virtual_id_number":11236,"owner":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-04-09 17:31:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-04-09 17:31:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-03-23 00:07:51.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-03-23 00:12:44.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-03-23 16:32:46.000000000","updated_by":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"CC"},{"updated":"2024-03-23 16:32:46.000000000","updated_by":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"CC"},{"updated":"2024-03-23 16:33:34.000000000","updated_by":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2024-03-23 16:33:34.000000000","updated_by":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"}],"messages":[{"id":"469a9b7868acdbe920902e7bdc339df1f3827aad","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-03-23 00:07:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f8ab1ba2bea9ec4818d149624cd02b2b259448a2","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-23 00:07:51.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/32479","accounts_in_message":[],"_revision_number":1},{"id":"db553ba69fb151247f7b22f2b91b1027c8356343","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-03-23 00:12:08.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"033b51c556d7452cb24cb7a46ba15798be75e237","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-23 00:12:44.000000000","message":"Patch Set 1: Verified+1\n\nCopied votes on follow-up patch sets have been updated:\n* Verified+1 has been copied to patch set 2 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\").\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/32479","accounts_in_message":[],"_revision_number":1},{"id":"ccb068867f82437cb5acd0d736d94855916b884c","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-03-23 00:14:29.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"74605150961d68bcad763e8df0442f200dc4571d","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-23 00:14:32.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/32480","accounts_in_message":[],"_revision_number":3},{"id":"26b3bed4e37b9e0f1965e88e26a8904e94e8bc1d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-23 00:19:03.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/32480","accounts_in_message":[],"_revision_number":3},{"id":"d8d85d457bc3a1303fc79cf485dfc69af1f5d97e","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-03-23 16:32:46.000000000","message":"Patch Set 3:\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":3},{"id":"3e6566f06038063d96e5ce58195bef0ac8519e37","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-03-23 16:33:34.000000000","message":"\u003cGERRIT_ACCOUNT_1000036\u003e, who was added as reviewer owns the following files:\n* `tvix/eval/src/builtins/hash.rs`\n* `tvix/eval/src/builtins/impure.rs`\n* `tvix/eval/src/builtins/mod.rs`\n* `tvix/eval/src/compiler/import.rs`\n* `tvix/eval/src/io.rs`\n* `tvix/eval/src/vm/generators.rs`\n* `tvix/glue/src/tvix_io.rs`\n* `tvix/glue/src/tvix_store_io.rs`\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":3},{"id":"e8f03da6e28458964696ee166b1f9c4d725d8eed","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-03-24 08:30:09.000000000","message":"Patch Set 3:\n\n(7 comments)","accounts_in_message":[],"_revision_number":3},{"id":"784bb431b8c5fda91970da3d1d1e9f17f25127f1","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-03-24 18:00:02.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"f3e53272e21d6c7f557fce95fcc1c7fe9b5c4524","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-03-26 16:02:43.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"37fe3a0012e6c27557d25f34d5cb3ef9da4a40e3","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-26 16:02:47.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/32630","accounts_in_message":[],"_revision_number":4},{"id":"f9543f4951926029a50b80fda2a84be8e455383a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-03-26 16:04:10.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"bad20d9f9536fd63dbd315b0e7d660c186f7dc45","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-26 16:04:14.000000000","message":"Patch Set 5:\n\nStarted build for patchset #5 on: https://buildkite.com/tvl/depot/builds/32631","accounts_in_message":[],"_revision_number":5},{"id":"b236142e03e3f1fbc23bf30f054ff32581c9719a","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-03-26 16:04:24.000000000","message":"Patch Set 5:\n\n(7 comments)","accounts_in_message":[],"_revision_number":5},{"id":"062d09d676ebed02efa62576ebde19a66038a54d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-26 16:10:14.000000000","message":"Patch Set 5: Verified-1\n\nBuild of patchset 5 failed: https://buildkite.com/tvl/depot/builds/32631","accounts_in_message":[],"_revision_number":5},{"id":"2118c5406ffe735b2863eba37d573a215ba99f98","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-03-26 16:14:29.000000000","message":"Uploaded patch set 6: New patch set was added with same tree, parent tree, and commit message as Patch Set 5.\n\nCopied Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND **changekind:NO_CODE_CHANGE**) OR **changekind:NO_CHANGE**\")\n","accounts_in_message":[],"_revision_number":6},{"id":"cda4ab997257f26c97e582c0657768611a28a8e2","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-03-26 16:17:08.000000000","message":"Patch Set 5:\n\n(4 comments)","accounts_in_message":[],"_revision_number":5},{"id":"c534e4f65fbcce9e716409df75c1568c3d1e8e1c","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-03-26 17:12:26.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"bf21207dbe4e5f947aefa8fe10a03c8fd89573c3","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-03-29 15:15:05.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"e9c93498dd1357e4182b1063150d5144516cd581","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-03-30 16:17:59.000000000","message":"Uploaded patch set 7.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":7},{"id":"aaf255e5a8299ca493aeb9ecaa40e619a61214bb","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-30 16:18:00.000000000","message":"Patch Set 7:\n\nStarted build for patchset #7 on: https://buildkite.com/tvl/depot/builds/32781","accounts_in_message":[],"_revision_number":7},{"id":"d939c5553a87c13c067ec6d931c7a647b7a4135a","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-03-30 16:22:45.000000000","message":"Patch Set 7: Verified-1\n\nBuild of patchset 7 failed: https://buildkite.com/tvl/depot/builds/32781","accounts_in_message":[],"_revision_number":7},{"id":"4a9a049b287d23ad757f2bc22055734ff87603c1","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-03-31 12:44:26.000000000","message":"Patch Set 7: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"c11ca5aee0f57a8a92a7f4f27cebc62cfc382adf","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-03-31 12:44:40.000000000","message":"Patch Set 7:\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"fddf05cbb7fec7a4b63bc6c6625938d3af2f1edc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-04-05 23:00:58.000000000","message":"Uploaded patch set 8.\n\nOutdated Votes:\n* Code-Review+2 (copy condition: \"((**is:ANY** AND has:unchanged-files) OR is:MIN) OR changekind:NO_CHANGE\")\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":8},{"id":"e02a0a9bf93ab7d0b192bf3791c90e299fdab682","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-05 23:00:59.000000000","message":"Patch Set 8:\n\nStarted build for patchset #8 on: https://buildkite.com/tvl/depot/builds/33002","accounts_in_message":[],"_revision_number":8},{"id":"1a5104e3482174e0b38ac3f5f57de08e459bd7a5","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-05 23:07:23.000000000","message":"Patch Set 8: Verified-1\n\nBuild of patchset 8 failed: https://buildkite.com/tvl/depot/builds/33002","accounts_in_message":[],"_revision_number":8},{"id":"f8a79e40b7e653dbbea460bb965246c084f4568d","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-04-05 23:09:46.000000000","message":"Patch Set 8:\n\n(4 comments)","accounts_in_message":[],"_revision_number":8},{"id":"75a31792177398edd590447270ba1b061fd9be72","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-04-05 23:10:38.000000000","message":"Uploaded patch set 9.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":9},{"id":"0e4586b069ea9adb486e669acf12b90d4413a187","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-05 23:10:39.000000000","message":"Patch Set 9:\n\nStarted build for patchset #9 on: https://buildkite.com/tvl/depot/builds/33003","accounts_in_message":[],"_revision_number":9},{"id":"b430318e8dffdf2d286d06cddb01901a6e4e6084","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-05 23:15:31.000000000","message":"Patch Set 9: Verified-1\n\nBuild of patchset 9 failed: https://buildkite.com/tvl/depot/builds/33003","accounts_in_message":[],"_revision_number":9},{"id":"25654568fc4fcc2dc5012c557b91b550131dae73","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-05 23:35:08.000000000","message":"Patch Set 9:\n\n(3 comments)","accounts_in_message":[],"_revision_number":9},{"id":"7383a61d6028d26ee9ebd8e5283d14ff5e7a2cc1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-04-08 15:47:26.000000000","message":"Uploaded patch set 10.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":10},{"id":"28847884f1f8f5e6caeb0d37a837a25a61f46be6","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-08 15:47:26.000000000","message":"Patch Set 10:\n\nStarted build for patchset #10 on: https://buildkite.com/tvl/depot/builds/33096","accounts_in_message":[],"_revision_number":10},{"id":"3ff941e5bc1260161555814112ba7587a7f05d29","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-04-08 15:47:38.000000000","message":"Patch Set 10:\n\n(3 comments)","accounts_in_message":[],"_revision_number":10},{"id":"b1aca3d5a163b7a056b23c4ddebc42f2722a2100","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-08 15:51:37.000000000","message":"Patch Set 10: Verified+1\n\nBuild of patchset 10 passed: https://buildkite.com/tvl/depot/builds/33096","accounts_in_message":[],"_revision_number":10},{"id":"292920844e5b5abcdc1097d5fa69762d83571996","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-08 17:03:22.000000000","message":"Patch Set 10:\n\n(5 comments)","accounts_in_message":[],"_revision_number":10},{"id":"ca8453ae0d4ea656786f8433b9dd1ebe4fa72ccd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-04-09 15:24:54.000000000","message":"Uploaded patch set 11.\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":11},{"id":"f05f55451e3a2fa613ea895d93ebba782d237bd4","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-09 15:24:55.000000000","message":"Patch Set 11:\n\nStarted build for patchset #11 on: https://buildkite.com/tvl/depot/builds/33116","accounts_in_message":[],"_revision_number":11},{"id":"c8b5bc9ba4a6faa3c2d93677b86e9c9c709a5571","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-04-09 15:24:55.000000000","message":"Patch Set 10:\n\n(5 comments)","accounts_in_message":[],"_revision_number":10},{"id":"703d3e43e36986f76be05d33c4389beae18ef251","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-09 15:29:50.000000000","message":"Patch Set 11: Verified+1\n\nBuild of patchset 11 passed: https://buildkite.com/tvl/depot/builds/33116","accounts_in_message":[],"_revision_number":11},{"id":"d8ba03fed9a87c310d4e52e17e1d6e2a5bbc617a","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-09 17:31:10.000000000","message":"Patch Set 11: Code-Review+2","accounts_in_message":[],"_revision_number":11},{"id":"1ce9ee97a1f859ee517ab8cf3df6ff7246efd5a8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-04-09 17:31:58.000000000","message":"Change has been successfully rebased and submitted as 63116d8c21afdc50725ae93d13839fe1915b06b7","accounts_in_message":[],"_revision_number":12}],"current_revision_number":12,"current_revision":"63116d8c21afdc50725ae93d13839fe1915b06b7","revisions":{"8ce717c6c5d44a822eca9763da52da9b70d0eaee":{"kind":"REWORK","_number":1,"created":"2024-03-23 00:07:49.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/36/11236/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/36/11236/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/36/11236/1"}}},"commit":{"parents":[{"commit":"3633d846f88d8306dabd5e820d0f3cd999404050","subject":"chore(3p/sources): bump channels \u0026 overlays (2024-03-17)","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3633d846f88d8306dabd5e820d0f3cd999404050"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-22 23:52:21.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-23 00:07:31.000000000","tz":-300},"subject":"fix(tvix): Avoid buffering file into memory in builtins.hashFile","message":"fix(tvix): Avoid buffering file into memory in builtins.hashFile\n\nChange-Id: Ifa1c8324bcee8f751604b0b449feab875c632fda\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8ce717c6c5d44a822eca9763da52da9b70d0eaee"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8ce717c6c5d44a822eca9763da52da9b70d0eaee"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3633d846f88d8306dabd5e820d0f3cd999404050","is_merged_in_target_branch":true,"change_id":"I763f1f075778f2ed8db7803f87248c9dabde4213","change_number":11174,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"eb363506b02e33393396f2e9f44fd17c98250410":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-03-23 00:12:08.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/36/11236/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/36/11236/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/36/11236/2"}}},"commit":{"parents":[{"commit":"3633d846f88d8306dabd5e820d0f3cd999404050","subject":"chore(3p/sources): bump channels \u0026 overlays (2024-03-17)","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3633d846f88d8306dabd5e820d0f3cd999404050"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-22 23:52:21.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-23 00:10:09.000000000","tz":-300},"subject":"fix(tvix): Avoid buffering file into memory in builtins.hashFile","message":"fix(tvix): Avoid buffering file into memory in builtins.hashFile\n\nRight now `builtins.hashFile` always reads the entire file into memory\nbefore hashing, which is not ideal for large files. This replaces\n`read_to_string` with `open_file` which allows calculating the hash of\nthe file without buffering it entirely into memory. Other callers can\ncontinue to buffer into memory if they choose, but they still use the\n`open_file` VM request and then call `read_to_string` on the\n`std::io::Reader`.\n\nFixes b/380\n\nChange-Id: Ifa1c8324bcee8f751604b0b449feab875c632fda\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003deb363506b02e33393396f2e9f44fd17c98250410"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003deb363506b02e33393396f2e9f44fd17c98250410"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3633d846f88d8306dabd5e820d0f3cd999404050","is_merged_in_target_branch":true,"change_id":"I763f1f075778f2ed8db7803f87248c9dabde4213","change_number":11174,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"08e71941a849b088f39937bdf743fd40a06cf0f1":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2024-03-23 00:14:29.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/36/11236/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/36/11236/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/36/11236/3"}}},"commit":{"parents":[{"commit":"3281fb9132c815c9a017e8ecd1e49b91b6cb92ff","subject":"docs(ops/terraform/deploy-nixos): document inputs and outputs","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3281fb9132c815c9a017e8ecd1e49b91b6cb92ff"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-22 23:52:21.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-23 00:14:21.000000000","tz":-300},"subject":"fix(tvix): Avoid buffering file into memory in builtins.hashFile","message":"fix(tvix): Avoid buffering file into memory in builtins.hashFile\n\nRight now `builtins.hashFile` always reads the entire file into memory\nbefore hashing, which is not ideal for large files. This replaces\n`read_to_string` with `open_file` which allows calculating the hash of\nthe file without buffering it entirely into memory. Other callers can\ncontinue to buffer into memory if they choose, but they still use the\n`open_file` VM request and then call `read_to_string` on the\n`std::io::Reader`.\n\nFixes b/380\n\nChange-Id: Ifa1c8324bcee8f751604b0b449feab875c632fda\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d08e71941a849b088f39937bdf743fd40a06cf0f1"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d08e71941a849b088f39937bdf743fd40a06cf0f1"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3281fb9132c815c9a017e8ecd1e49b91b6cb92ff","is_merged_in_target_branch":true,"change_id":"I8492cc3e386f89b299469c78e586644ee82a708f","change_number":11213,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"02d87ca62bafd6130e33b08cd1f3d85f4c31a7a7":{"kind":"REWORK","_number":4,"created":"2024-03-26 16:02:43.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/36/11236/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/36/11236/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/36/11236/4"}}},"commit":{"parents":[{"commit":"3281fb9132c815c9a017e8ecd1e49b91b6cb92ff","subject":"docs(ops/terraform/deploy-nixos): document inputs and outputs","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3281fb9132c815c9a017e8ecd1e49b91b6cb92ff"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-22 23:52:21.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-26 16:02:18.000000000","tz":-300},"subject":"fix(tvix): Avoid buffering file into memory in builtins.hashFile","message":"fix(tvix): Avoid buffering file into memory in builtins.hashFile\n\nRight now `builtins.hashFile` always reads the entire file into memory\nbefore hashing, which is not ideal for large files. This replaces\n`read_to_string` with `open_file` which allows calculating the hash of\nthe file without buffering it entirely into memory. Other callers can\ncontinue to buffer into memory if they choose, but they still use the\n`open_file` VM request and then call `read_to_string` on the\n`std::io::Reader`.\n\nFixes b/380\n\nChange-Id: Ifa1c8324bcee8f751604b0b449feab875c632fda\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d02d87ca62bafd6130e33b08cd1f3d85f4c31a7a7"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d02d87ca62bafd6130e33b08cd1f3d85f4c31a7a7"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3281fb9132c815c9a017e8ecd1e49b91b6cb92ff","is_merged_in_target_branch":true,"change_id":"I8492cc3e386f89b299469c78e586644ee82a708f","change_number":11213,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"e791b3d4ae00766b6d1e5eb3da38248670aff670":{"kind":"REWORK","_number":5,"created":"2024-03-26 16:04:10.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/36/11236/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/36/11236/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/36/11236/5"}}},"commit":{"parents":[{"commit":"34d1cc178fb21e1e7e0d5c7e4cedeca1abfa6da1","subject":"feat(users/picnoir/tvix-daemon): implement full handshake","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d34d1cc178fb21e1e7e0d5c7e4cedeca1abfa6da1"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-22 23:52:21.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-26 16:03:28.000000000","tz":-300},"subject":"fix(tvix): Avoid buffering file into memory in builtins.hashFile","message":"fix(tvix): Avoid buffering file into memory in builtins.hashFile\n\nRight now `builtins.hashFile` always reads the entire file into memory\nbefore hashing, which is not ideal for large files. This replaces\n`read_to_string` with `open_file` which allows calculating the hash of\nthe file without buffering it entirely into memory. Other callers can\ncontinue to buffer into memory if they choose, but they still use the\n`open_file` VM request and then call `read_to_string` on the\n`std::io::Reader`.\n\nFixes b/380\n\nChange-Id: Ifa1c8324bcee8f751604b0b449feab875c632fda\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de791b3d4ae00766b6d1e5eb3da38248670aff670"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de791b3d4ae00766b6d1e5eb3da38248670aff670"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"34d1cc178fb21e1e7e0d5c7e4cedeca1abfa6da1","is_merged_in_target_branch":true,"change_id":"I98322832848ee5b048f22105731b0adeb44b2ce0","change_number":11227,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"c07d90b7013795a125421139c53b66c43954a6c4":{"kind":"NO_CHANGE","_number":6,"created":"2024-03-26 16:14:29.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/36/11236/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/36/11236/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/36/11236/6"}}},"commit":{"parents":[{"commit":"34d1cc178fb21e1e7e0d5c7e4cedeca1abfa6da1","subject":"feat(users/picnoir/tvix-daemon): implement full handshake","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d34d1cc178fb21e1e7e0d5c7e4cedeca1abfa6da1"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-22 23:52:21.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-26 16:14:22.000000000","tz":-300},"subject":"fix(tvix): Avoid buffering file into memory in builtins.hashFile","message":"fix(tvix): Avoid buffering file into memory in builtins.hashFile\n\nRight now `builtins.hashFile` always reads the entire file into memory\nbefore hashing, which is not ideal for large files. This replaces\n`read_to_string` with `open_file` which allows calculating the hash of\nthe file without buffering it entirely into memory. Other callers can\ncontinue to buffer into memory if they choose, but they still use the\n`open_file` VM request and then call `read_to_string` on the\n`std::io::Reader`.\n\nFixes b/380\n\nChange-Id: Ifa1c8324bcee8f751604b0b449feab875c632fda\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc07d90b7013795a125421139c53b66c43954a6c4"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc07d90b7013795a125421139c53b66c43954a6c4"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"34d1cc178fb21e1e7e0d5c7e4cedeca1abfa6da1","is_merged_in_target_branch":true,"change_id":"I98322832848ee5b048f22105731b0adeb44b2ce0","change_number":11227,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"5385b396f2f2a565007433ab9437523f140ecc4e":{"kind":"REWORK","_number":7,"created":"2024-03-30 16:17:59.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/36/11236/7","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/36/11236/7","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/36/11236/7"}}},"commit":{"parents":[{"commit":"34d1cc178fb21e1e7e0d5c7e4cedeca1abfa6da1","subject":"feat(users/picnoir/tvix-daemon): implement full handshake","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d34d1cc178fb21e1e7e0d5c7e4cedeca1abfa6da1"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-22 23:52:21.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-30 16:17:20.000000000","tz":-300},"subject":"fix(tvix): Avoid buffering file into memory in builtins.hashFile","message":"fix(tvix): Avoid buffering file into memory in builtins.hashFile\n\nRight now `builtins.hashFile` always reads the entire file into memory\nbefore hashing, which is not ideal for large files. This replaces\n`read_to_string` with `open_file` which allows calculating the hash of\nthe file without buffering it entirely into memory. Other callers can\ncontinue to buffer into memory if they choose, but they still use the\n`open_file` VM request and then call `read_to_string` on the\n`std::io::Reader`.\n\nThis also moves the hashers into their own module so that `tvix/eval`\ndoes not pick up a dependency on `nix_compat` which is where the hasher\nutilies live.\n\nFixes b/380\n\nChange-Id: Ifa1c8324bcee8f751604b0b449feab875c632fda\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5385b396f2f2a565007433ab9437523f140ecc4e"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5385b396f2f2a565007433ab9437523f140ecc4e"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"34d1cc178fb21e1e7e0d5c7e4cedeca1abfa6da1","is_merged_in_target_branch":true,"change_id":"I98322832848ee5b048f22105731b0adeb44b2ce0","change_number":11227,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"8de86270eedcc7854e2fee90a57247869d952e11":{"kind":"REWORK","_number":8,"created":"2024-04-05 23:00:58.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/36/11236/8","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/36/11236/8","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/36/11236/8"}}},"commit":{"parents":[{"commit":"9e8106305018057821905f1c7b8249e5a882336c","subject":"feat(tazjin/khamovnik): enable docker","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9e8106305018057821905f1c7b8249e5a882336c"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-22 23:52:21.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-04-05 23:00:39.000000000","tz":-300},"subject":"fix(tvix): Avoid buffering file into memory in builtins.hashFile","message":"fix(tvix): Avoid buffering file into memory in builtins.hashFile\n\nRight now `builtins.hashFile` always reads the entire file into memory\nbefore hashing, which is not ideal for large files. This replaces\n`read_to_string` with `open_file` which allows calculating the hash of\nthe file without buffering it entirely into memory. Other callers can\ncontinue to buffer into memory if they choose, but they still use the\n`open_file` VM request and then call `read_to_string` on the\n`std::io::Reader`.\n\nThis also moves the hashers into their own module so that `tvix/eval`\ndoes not pick up a dependency on `nix_compat` which is where the hasher\nutilies live.\n\nFixes b/380\n\nChange-Id: Ifa1c8324bcee8f751604b0b449feab875c632fda\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8de86270eedcc7854e2fee90a57247869d952e11"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8de86270eedcc7854e2fee90a57247869d952e11"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"9e8106305018057821905f1c7b8249e5a882336c","is_merged_in_target_branch":true,"change_id":"I105aad32cfcebd7a1b9108e4fd847073fb30da15","change_number":11360,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"270fca31f0803a38b177c7be9f246c1791c79286":{"kind":"REWORK","_number":9,"created":"2024-04-05 23:10:38.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/36/11236/9","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/36/11236/9","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/36/11236/9"}}},"commit":{"parents":[{"commit":"9e8106305018057821905f1c7b8249e5a882336c","subject":"feat(tazjin/khamovnik): enable docker","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9e8106305018057821905f1c7b8249e5a882336c"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-22 23:52:21.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-04-05 23:10:14.000000000","tz":-300},"subject":"fix(tvix): Avoid buffering file into memory in builtins.hashFile","message":"fix(tvix): Avoid buffering file into memory in builtins.hashFile\n\nRight now `builtins.hashFile` always reads the entire file into memory\nbefore hashing, which is not ideal for large files. This replaces\n`read_to_string` with `open_file` which allows calculating the hash of\nthe file without buffering it entirely into memory. Other callers can\ncontinue to buffer into memory if they choose, but they still use the\n`open_file` VM request and then call `read_to_string` on the\n`std::io::Reader`.\n\nThis also moves the hashers into their own module so that `tvix/eval`\ndoes not pick up a dependency on `nix_compat` which is where the hasher\nutilies live.\n\nFixes b/380\n\nChange-Id: Ifa1c8324bcee8f751604b0b449feab875c632fda\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d270fca31f0803a38b177c7be9f246c1791c79286"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d270fca31f0803a38b177c7be9f246c1791c79286"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"9e8106305018057821905f1c7b8249e5a882336c","is_merged_in_target_branch":true,"change_id":"I105aad32cfcebd7a1b9108e4fd847073fb30da15","change_number":11360,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"48a00cba3a8f0c0dec919a059138a79f2603a547":{"kind":"REWORK","_number":10,"created":"2024-04-08 15:47:26.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/36/11236/10","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/36/11236/10","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/36/11236/10"}}},"commit":{"parents":[{"commit":"9e8106305018057821905f1c7b8249e5a882336c","subject":"feat(tazjin/khamovnik): enable docker","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9e8106305018057821905f1c7b8249e5a882336c"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-22 23:52:21.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-04-08 15:47:16.000000000","tz":-300},"subject":"fix(tvix): Avoid buffering file into memory in builtins.hashFile","message":"fix(tvix): Avoid buffering file into memory in builtins.hashFile\n\nRight now `builtins.hashFile` always reads the entire file into memory\nbefore hashing, which is not ideal for large files. This replaces\n`read_to_string` with `open_file` which allows calculating the hash of\nthe file without buffering it entirely into memory. Other callers can\ncontinue to buffer into memory if they choose, but they still use the\n`open_file` VM request and then call `read_to_string` on the\n`std::io::Reader`.\n\nThis also moves the hashers into their own module so that `tvix/eval`\ndoes not pick up a dependency on `nix_compat` which is where the hasher\nutilies live.\n\nFixes b/380\n\nChange-Id: Ifa1c8324bcee8f751604b0b449feab875c632fda\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d48a00cba3a8f0c0dec919a059138a79f2603a547"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d48a00cba3a8f0c0dec919a059138a79f2603a547"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"9e8106305018057821905f1c7b8249e5a882336c","is_merged_in_target_branch":true,"change_id":"I105aad32cfcebd7a1b9108e4fd847073fb30da15","change_number":11360,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"0ff6d3be418c5b41cd3742926f78ee8532ae7266":{"kind":"REWORK","_number":11,"created":"2024-04-09 15:24:54.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/36/11236/11","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/36/11236/11","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/36/11236/11"}}},"commit":{"parents":[{"commit":"9e8106305018057821905f1c7b8249e5a882336c","subject":"feat(tazjin/khamovnik): enable docker","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9e8106305018057821905f1c7b8249e5a882336c"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-22 23:52:21.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-04-09 15:24:46.000000000","tz":-300},"subject":"fix(tvix): Avoid buffering file into memory in builtins.hashFile","message":"fix(tvix): Avoid buffering file into memory in builtins.hashFile\n\nRight now `builtins.hashFile` always reads the entire file into memory\nbefore hashing, which is not ideal for large files. This replaces\n`read_to_string` with `open_file` which allows calculating the hash of\nthe file without buffering it entirely into memory. Other callers can\ncontinue to buffer into memory if they choose, but they still use the\n`open_file` VM request and then call `read_to_string` or `read_to_end`\non the `std::io::Reader`.\n\nFixes b/380\n\nChange-Id: Ifa1c8324bcee8f751604b0b449feab875c632fda\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0ff6d3be418c5b41cd3742926f78ee8532ae7266"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0ff6d3be418c5b41cd3742926f78ee8532ae7266"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"9e8106305018057821905f1c7b8249e5a882336c","is_merged_in_target_branch":true,"change_id":"I105aad32cfcebd7a1b9108e4fd847073fb30da15","change_number":11360,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"63116d8c21afdc50725ae93d13839fe1915b06b7":{"kind":"REWORK","_number":12,"created":"2024-04-09 17:31:58.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/36/11236/12","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/36/11236/12","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/36/11236/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/36/11236/12"}}},"commit":{"parents":[{"commit":"17849c5c0033fa1909f0403b5d5e6a5e018b7fee","subject":"feat(tvix/castore/directory): add bigtable backend","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d17849c5c0033fa1909f0403b5d5e6a5e018b7fee"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-03-22 23:52:21.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-04-09 17:31:58.000000000","tz":0},"subject":"fix(tvix): Avoid buffering file into memory in builtins.hashFile","message":"fix(tvix): Avoid buffering file into memory in builtins.hashFile\n\nRight now `builtins.hashFile` always reads the entire file into memory\nbefore hashing, which is not ideal for large files. This replaces\n`read_to_string` with `open_file` which allows calculating the hash of\nthe file without buffering it entirely into memory. Other callers can\ncontinue to buffer into memory if they choose, but they still use the\n`open_file` VM request and then call `read_to_string` or `read_to_end`\non the `std::io::Reader`.\n\nFixes b/380\n\nChange-Id: Ifa1c8324bcee8f751604b0b449feab875c632fda\nReviewed-on: https://cl.tvl.fyi/c/depot/+/11236\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d63116d8c21afdc50725ae93d13839fe1915b06b7"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d63116d8c21afdc50725ae93d13839fe1915b06b7"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"17849c5c0033fa1909f0403b5d5e6a5e018b7fee","is_merged_in_target_branch":true,"change_id":"I7fada45bf386a78b7ec93be38c5f03879a2a6e22","change_number":11212,"patch_set_number":24,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}
