)]}'
{"tvix/eval/src/builtins/mod.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"73861a05e8403c1fdd4c5268c0a74b66e40e84be","unresolved":true,"context_lines":[{"line_number":1591,"context_line":"            .await?"},{"line_number":1592,"context_line":"            .to_contextful_str()?;"},{"line_number":1593,"context_line":""},{"line_number":1594,"context_line":"        // If there\u0027s any context, we will swap any ... by an path one."},{"line_number":1595,"context_line":"        if let Some(ctx) \u003d v.context_mut() {"},{"line_number":1596,"context_line":"            let new_context: tvix_eval::NixContext \u003d ctx"},{"line_number":1597,"context_line":"                .iter()"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"12c0472c_601283f6","line":1594,"range":{"start_line":1594,"start_character":59,"end_line":1594,"end_character":61},"updated":"2024-03-25 17:28:52.000000000","message":"\"a\"?","commit_id":"747f877f4306e8b1498017905d0cc53a9f881328"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"bc8d2335322a2f0926007ec0f6407c3e4809ebfb","unresolved":false,"context_lines":[{"line_number":1591,"context_line":"            .await?"},{"line_number":1592,"context_line":"            .to_contextful_str()?;"},{"line_number":1593,"context_line":""},{"line_number":1594,"context_line":"        // If there\u0027s any context, we will swap any ... by an path one."},{"line_number":1595,"context_line":"        if let Some(ctx) \u003d v.context_mut() {"},{"line_number":1596,"context_line":"            let new_context: tvix_eval::NixContext \u003d ctx"},{"line_number":1597,"context_line":"                .iter()"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"7598747d_8b8ab381","line":1594,"range":{"start_line":1594,"start_character":59,"end_line":1594,"end_character":61},"in_reply_to":"12c0472c_601283f6","updated":"2024-03-28 22:12:11.000000000","message":"Done","commit_id":"747f877f4306e8b1498017905d0cc53a9f881328"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"73861a05e8403c1fdd4c5268c0a74b66e40e84be","unresolved":true,"context_lines":[{"line_number":1595,"context_line":"        if let Some(ctx) \u003d v.context_mut() {"},{"line_number":1596,"context_line":"            let new_context: tvix_eval::NixContext \u003d ctx"},{"line_number":1597,"context_line":"                .iter()"},{"line_number":1598,"context_line":"                .map(|elt| match elt {"},{"line_number":1599,"context_line":"                    // FUTUREWORK(performance): ideally, we should either:"},{"line_number":1600,"context_line":"                    // (a) do interior mutation of the existing context."},{"line_number":1601,"context_line":"                    // (b) let the structural sharing make those clones cheap."}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"cf20bbdf_12c21132","line":1598,"range":{"start_line":1598,"start_character":22,"end_line":1598,"end_character":25},"updated":"2024-03-25 17:28:52.000000000","message":"elem?","commit_id":"747f877f4306e8b1498017905d0cc53a9f881328"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"bc8d2335322a2f0926007ec0f6407c3e4809ebfb","unresolved":false,"context_lines":[{"line_number":1595,"context_line":"        if let Some(ctx) \u003d v.context_mut() {"},{"line_number":1596,"context_line":"            let new_context: tvix_eval::NixContext \u003d ctx"},{"line_number":1597,"context_line":"                .iter()"},{"line_number":1598,"context_line":"                .map(|elt| match elt {"},{"line_number":1599,"context_line":"                    // FUTUREWORK(performance): ideally, we should either:"},{"line_number":1600,"context_line":"                    // (a) do interior mutation of the existing context."},{"line_number":1601,"context_line":"                    // (b) let the structural sharing make those clones cheap."}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"233f8fc8_8c3e4e9a","line":1598,"range":{"start_line":1598,"start_character":22,"end_line":1598,"end_character":25},"in_reply_to":"cf20bbdf_12c21132","updated":"2024-03-28 22:12:11.000000000","message":"Done","commit_id":"747f877f4306e8b1498017905d0cc53a9f881328"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"73861a05e8403c1fdd4c5268c0a74b66e40e84be","unresolved":true,"context_lines":[{"line_number":1598,"context_line":"                .map(|elt| match elt {"},{"line_number":1599,"context_line":"                    // FUTUREWORK(performance): ideally, we should either:"},{"line_number":1600,"context_line":"                    // (a) do interior mutation of the existing context."},{"line_number":1601,"context_line":"                    // (b) let the structural sharing make those clones cheap."},{"line_number":1602,"context_line":"                    crate::NixContextElement::Derivation(drv_path) \u003d\u003e {"},{"line_number":1603,"context_line":"                        crate::NixContextElement::Plain(drv_path.to_string())"},{"line_number":1604,"context_line":"                    }"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"96021aab_f6435ee8","line":1601,"updated":"2024-03-25 17:28:52.000000000","message":"What about adding `into_iter()` to NixContext, describing this transformation here with a map, and then  assigning it?","commit_id":"747f877f4306e8b1498017905d0cc53a9f881328"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"574153038b07108ef4e2d61022a9c37d37895423","unresolved":true,"context_lines":[{"line_number":1598,"context_line":"                .map(|elt| match elt {"},{"line_number":1599,"context_line":"                    // FUTUREWORK(performance): ideally, we should either:"},{"line_number":1600,"context_line":"                    // (a) do interior mutation of the existing context."},{"line_number":1601,"context_line":"                    // (b) let the structural sharing make those clones cheap."},{"line_number":1602,"context_line":"                    crate::NixContextElement::Derivation(drv_path) \u003d\u003e {"},{"line_number":1603,"context_line":"                        crate::NixContextElement::Plain(drv_path.to_string())"},{"line_number":1604,"context_line":"                    }"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"a02c97be_62448696","line":1601,"in_reply_to":"96021aab_f6435ee8","updated":"2024-03-28 21:55:07.000000000","message":"ctx is `\u0026mut T`, so it wouldn\u0027t buy us so much, I will leave this as the futurework for optimizations.","commit_id":"747f877f4306e8b1498017905d0cc53a9f881328"},{"author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"change_message_id":"bc8d2335322a2f0926007ec0f6407c3e4809ebfb","unresolved":false,"context_lines":[{"line_number":1598,"context_line":"                .map(|elt| match elt {"},{"line_number":1599,"context_line":"                    // FUTUREWORK(performance): ideally, we should either:"},{"line_number":1600,"context_line":"                    // (a) do interior mutation of the existing context."},{"line_number":1601,"context_line":"                    // (b) let the structural sharing make those clones cheap."},{"line_number":1602,"context_line":"                    crate::NixContextElement::Derivation(drv_path) \u003d\u003e {"},{"line_number":1603,"context_line":"                        crate::NixContextElement::Plain(drv_path.to_string())"},{"line_number":1604,"context_line":"                    }"}],"source_content_type":"text/x-rustsrc","patch_set":2,"id":"d362e919_ff101973","line":1601,"in_reply_to":"a02c97be_62448696","updated":"2024-03-28 22:12:11.000000000","message":"Done","commit_id":"747f877f4306e8b1498017905d0cc53a9f881328"}]}