)]}'
{"id":"depot~11351","triplet_id":"depot~canon~Ifd6671aeba6949324b0bb9f0f766b87db728d484","project":"depot","branch":"canon","topic":"evaluation-correctness","attention_set":{},"removed_from_attention_set":{"1000018":{"account":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"last_update":"2024-04-03 14:18:47.000000000","reason":"\u003cGERRIT_ACCOUNT_1000018\u003e replied on the change","reason_account":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"}},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-04-03 23:23:02.000000000","reason":"removed on reply"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2024-04-03 23:23:29.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ifd6671aeba6949324b0bb9f0f766b87db728d484","subject":"fix(tvix/glue): produce context for `builtins.(path|filterSource)`","status":"MERGED","created":"2024-04-03 13:09:03.000000000","updated":"2024-04-03 23:23:29.000000000","submitted":"2024-04-03 23:23:29.000000000","submitter":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"11351-evaluation-correctness","meta_rev_id":"359026d52aff8f6077edaa46990b8f5b3dc36c7a","_number":11351,"virtual_id_number":11351,"owner":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-04-03 23:23:29.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-04-03 23:23:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-04-03 23:23:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"all":[{"value":0,"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"all":[{"value":0,"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-04-03 13:09:03.000000000","updated_by":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2024-04-03 13:09:04.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-04-03 13:09:49.000000000","updated_by":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"reviewer":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"state":"REVIEWER"},{"updated":"2024-04-03 13:16:45.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d339126b10ace0ad9e48220421d2379d3e994656","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-04-03 13:09:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8168132fd63d2c16c1eadef0c3af0857111dcf1d","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-04-03 13:09:03.000000000","message":"\u003cGERRIT_ACCOUNT_1000036\u003e, who was added as reviewer owns the following files:\n* `tvix/glue/src/builtins/import.rs`\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":1},{"id":"6321b73406a3d5d57ee649305875476229a692e1","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-03 13:09:04.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/32959","accounts_in_message":[],"_revision_number":1},{"id":"c39eced3e4cfbaa3b8de336e243b5401c17fb48a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-04-03 13:12:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"23dd9e05a35a423657f03d3d8034b01a4052faa0","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-03 13:12:34.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/32960","accounts_in_message":[],"_revision_number":2},{"id":"5f775d36fa41e7178384d03bf92726384ea9dec7","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-03 13:16:45.000000000","message":"Patch Set 2: Verified-1\n\nBuild of patchset 2 failed: https://buildkite.com/tvl/depot/builds/32960","accounts_in_message":[],"_revision_number":2},{"id":"0493eb5d12522c96b9af545b355504dddfdf6ad1","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-04-03 13:19:27.000000000","message":"Uploaded patch set 3.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"c190d61cf6937471a2579209b0c69693319cb03c","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-03 13:19:28.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/32961","accounts_in_message":[],"_revision_number":3},{"id":"5a1ef0884923a319e548364812bb055521aebf20","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-03 13:23:36.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/32961","accounts_in_message":[],"_revision_number":3},{"id":"017a21d2f81f855f3437b2542dbc05429804e121","author":{"_account_id":1000018,"name":"Alyssa Ross","display_name":"qyliss","email":"hi@alyssa.is","username":"qyliss"},"date":"2024-04-03 14:18:47.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"04dbf4e81d4243f089fbd08868a383bceef49bc5","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-03 23:23:02.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"359026d52aff8f6077edaa46990b8f5b3dc36c7a","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-04-03 23:23:29.000000000","message":"Change has been successfully rebased and submitted as e9a23bb4782615722374e7bec643cba669a492bc","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"e9a23bb4782615722374e7bec643cba669a492bc","revisions":{"91852b27a54b6b6766181111cd93f4d3eb2957f8":{"kind":"REWORK","_number":1,"created":"2024-04-03 13:09:03.000000000","uploader":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"ref":"refs/changes/51/11351/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/51/11351/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/51/11351/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/51/11351/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/51/11351/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/51/11351/1"}}},"commit":{"parents":[{"commit":"c59e11dc3e6b57dd11feabd3478e95bd384eebcb","subject":"fix(nix/buildkite): solve bogus realpath errors if build steps fail","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc59e11dc3e6b57dd11feabd3478e95bd384eebcb"}]}],"author":{"name":"Ryan Lahfa","email":"tvl@lahfa.xyz","date":"2024-04-03 13:08:54.000000000","tz":120},"committer":{"name":"Ryan Lahfa","email":"tvl@lahfa.xyz","date":"2024-04-03 13:08:54.000000000","tz":120},"subject":"fix(tvix/glue): produce context for `builtins.(path|filterSource)`","message":"fix(tvix/glue): produce context for `builtins.(path|filterSource)`\n\nFixes b/392.\n\nOutput paths were created, depending on a plain store path but no\ncontext string was attached to track that plain dependency.\n\nChange-Id: Ifd6671aeba6949324b0bb9f0f766b87db728d484\nSigned-off-by: Ryan Lahfa \u003ctvl@lahfa.xyz\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d91852b27a54b6b6766181111cd93f4d3eb2957f8"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d91852b27a54b6b6766181111cd93f4d3eb2957f8"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c59e11dc3e6b57dd11feabd3478e95bd384eebcb","is_merged_in_target_branch":true,"change_id":"I526a18df877601d884b83862da5f37336cdf52cd","change_number":11312,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"0a74f05755f8527edb6b851c53b5a9d1d06527d7":{"kind":"REWORK","_number":2,"created":"2024-04-03 13:12:33.000000000","uploader":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"ref":"refs/changes/51/11351/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/51/11351/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/51/11351/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/51/11351/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/51/11351/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/51/11351/2"}}},"commit":{"parents":[{"commit":"c59e11dc3e6b57dd11feabd3478e95bd384eebcb","subject":"fix(nix/buildkite): solve bogus realpath errors if build steps fail","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc59e11dc3e6b57dd11feabd3478e95bd384eebcb"}]}],"author":{"name":"Ryan Lahfa","email":"tvl@lahfa.xyz","date":"2024-04-03 13:08:54.000000000","tz":120},"committer":{"name":"Ryan Lahfa","email":"tvl@lahfa.xyz","date":"2024-04-03 13:12:11.000000000","tz":120},"subject":"fix(tvix/glue): produce context for `builtins.(path|filterSource)`","message":"fix(tvix/glue): produce context for `builtins.(path|filterSource)`\n\nFixes b/392.\n\nOutput paths were created, depending on a plain store path but no\ncontext string was attached to track that plain dependency.\n\nContext string propagation tests are strengthened to prevent any\nregression on this.\n\nChange-Id: Ifd6671aeba6949324b0bb9f0f766b87db728d484\nSigned-off-by: Ryan Lahfa \u003ctvl@lahfa.xyz\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0a74f05755f8527edb6b851c53b5a9d1d06527d7"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d0a74f05755f8527edb6b851c53b5a9d1d06527d7"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c59e11dc3e6b57dd11feabd3478e95bd384eebcb","is_merged_in_target_branch":true,"change_id":"I526a18df877601d884b83862da5f37336cdf52cd","change_number":11312,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"16b4373b02502e8147001fb2164f0568c8d48d66":{"kind":"REWORK","_number":3,"created":"2024-04-03 13:19:27.000000000","uploader":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"ref":"refs/changes/51/11351/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/51/11351/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/51/11351/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/51/11351/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/51/11351/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/51/11351/3"}}},"commit":{"parents":[{"commit":"c59e11dc3e6b57dd11feabd3478e95bd384eebcb","subject":"fix(nix/buildkite): solve bogus realpath errors if build steps fail","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc59e11dc3e6b57dd11feabd3478e95bd384eebcb"}]}],"author":{"name":"Ryan Lahfa","email":"tvl@lahfa.xyz","date":"2024-04-03 13:08:54.000000000","tz":120},"committer":{"name":"Ryan Lahfa","email":"tvl@lahfa.xyz","date":"2024-04-03 13:19:25.000000000","tz":120},"subject":"fix(tvix/glue): produce context for `builtins.(path|filterSource)`","message":"fix(tvix/glue): produce context for `builtins.(path|filterSource)`\n\nFixes b/392.\n\nOutput paths were created, depending on a plain store path but no\ncontext string was attached to track that plain dependency.\n\nContext string propagation tests are strengthened to prevent any\nregression on this.\n\nChange-Id: Ifd6671aeba6949324b0bb9f0f766b87db728d484\nSigned-off-by: Ryan Lahfa \u003ctvl@lahfa.xyz\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d16b4373b02502e8147001fb2164f0568c8d48d66"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d16b4373b02502e8147001fb2164f0568c8d48d66"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c59e11dc3e6b57dd11feabd3478e95bd384eebcb","is_merged_in_target_branch":true,"change_id":"I526a18df877601d884b83862da5f37336cdf52cd","change_number":11312,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"e9a23bb4782615722374e7bec643cba669a492bc":{"kind":"REWORK","_number":4,"created":"2024-04-03 23:23:29.000000000","uploader":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"ref":"refs/changes/51/11351/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/51/11351/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/51/11351/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/51/11351/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/51/11351/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/51/11351/4"}}},"commit":{"parents":[{"commit":"3821fd4224c066c40fc492c8b049bd47c9a212fa","subject":"chore(users/picnoir/tvix-daemon): apply clippy suggestions","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3821fd4224c066c40fc492c8b049bd47c9a212fa"}]}],"author":{"name":"Ryan Lahfa","email":"tvl@lahfa.xyz","date":"2024-04-03 13:08:54.000000000","tz":120},"committer":{"name":"raitobezarius","email":"tvl@lahfa.xyz","date":"2024-04-03 23:23:29.000000000","tz":0},"subject":"fix(tvix/glue): produce context for `builtins.(path|filterSource)`","message":"fix(tvix/glue): produce context for `builtins.(path|filterSource)`\n\nFixes b/392.\n\nOutput paths were created, depending on a plain store path but no\ncontext string was attached to track that plain dependency.\n\nContext string propagation tests are strengthened to prevent any\nregression on this.\n\nChange-Id: Ifd6671aeba6949324b0bb9f0f766b87db728d484\nSigned-off-by: Ryan Lahfa \u003ctvl@lahfa.xyz\u003e\nReviewed-on: https://cl.tvl.fyi/c/depot/+/11351\nReviewed-by: Alyssa Ross \u003chi@alyssa.is\u003e\nTested-by: BuildkiteCI\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de9a23bb4782615722374e7bec643cba669a492bc"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de9a23bb4782615722374e7bec643cba669a492bc"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3821fd4224c066c40fc492c8b049bd47c9a212fa","is_merged_in_target_branch":true,"change_id":"I1f767baf23fa80c2babb8113f61d1a9e72a8d8dd","change_number":11350,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}