)]}'
{"id":"depot~11372","triplet_id":"depot~canon~Iaed2832998cae5f192eafe7fd5243e82ff6e051e","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000097":{"account":{"_account_id":1000097,"name":"Peter Kolloch","email":"info@eigenvalue.net","username":"pkolloch"},"last_update":"2024-04-07 21:21:09.000000000","reason":"Change was submitted"},"1000096":{"account":{"_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"},"last_update":"2024-04-07 21:20:39.000000000","reason":"removed on reply"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-04-07 21:21:09.000000000","reason":"Change was submitted"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2024-04-07 21:21:09.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Iaed2832998cae5f192eafe7fd5243e82ff6e051e","subject":"fix(nix-compat/store_path): fix Deserialize with borrow","status":"MERGED","created":"2024-04-07 20:54:50.000000000","updated":"2024-04-07 21:21:09.000000000","submitted":"2024-04-07 21:21:09.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"11372","meta_rev_id":"9806cb5339bb9fdc058397115cacfd4349e06162","_number":11372,"virtual_id_number":11372,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-04-07 21:21:09.000000000","_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-04-07 21:21:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-04-07 21:21:09.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000097,"name":"Peter Kolloch","email":"info@eigenvalue.net","username":"pkolloch"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"},{"_account_id":1000097,"name":"Peter Kolloch","email":"info@eigenvalue.net","username":"pkolloch"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-04-07 20:54:50.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2024-04-07 20:54:50.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"},"state":"REVIEWER"},{"updated":"2024-04-07 20:54:51.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-04-07 20:58:07.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000097,"name":"Peter Kolloch","email":"info@eigenvalue.net","username":"pkolloch"},"state":"REVIEWER"},{"updated":"2024-04-07 21:00:09.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-04-07 21:21:09.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7c247560152f1491d3cfa86cf9efee43ad797931","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-07 20:54:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"651e850fdcef94ea14e89d952491a74cbab2ae82","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-07 20:54:51.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/33055","accounts_in_message":[],"_revision_number":1},{"id":"e999562df4e9599f8ec02095fe083c36cb3ec221","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-07 20:58:54.000000000","message":"Patch Set 1: Autosubmit+1","accounts_in_message":[],"_revision_number":1},{"id":"7717bf0ccb4d7e51740d3b9058015b30ccaa5d5f","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-07 21:00:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/33055","accounts_in_message":[],"_revision_number":1},{"id":"c70dc8e924d56deeaf7a337344c8ad2662742851","author":{"_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"},"date":"2024-04-07 21:20:39.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9806cb5339bb9fdc058397115cacfd4349e06162","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-04-07 21:21:09.000000000","message":"Change has been successfully rebased and submitted as d00c75ea9cd2d31d6e0f02fa678678519317182c","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d00c75ea9cd2d31d6e0f02fa678678519317182c","revisions":{"03b4c7ff58010f41e39c29ac40a7c398c9de8609":{"kind":"REWORK","_number":1,"created":"2024-04-07 20:54:50.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/72/11372/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/72/11372/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/72/11372/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/72/11372/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/72/11372/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/72/11372/1"}}},"commit":{"parents":[{"commit":"199f9b0a79de0fb0fd57ce9307b36390339ee7e7","subject":"feat(tvix/nix-compat): read client setting from wire","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d199f9b0a79de0fb0fd57ce9307b36390339ee7e7"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-07 20:40:38.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-07 20:52:13.000000000","tz":180},"subject":"fix(nix-compat/store_path): fix Deserialize with borrow","message":"fix(nix-compat/store_path): fix Deserialize with borrow\n\nWe were wrongly using `\u0027de` as a lifetime for both `Deserializer` and\n`StorePathRef`.\n\nThis prevented Deserializing into a struct containing `StorePathRef`.\n\nSee https://serde.rs/lifetimes.html#the-deserializede-lifetime, the last\npart of the paragraph:\n\nThe \u0027de lifetime should not appear in the type to which the Deserialize\nimpl applies.\n\n- // Do not do this. Sooner or later you will be sad.\n- impl\u003c\u0027de\u003e Deserialize\u003c\u0027de\u003e for Q\u003c\u0027de\u003e {\n+ // Do this instead.\n+ impl\u003c\u0027de: \u0027a, \u0027a\u003e Deserialize\u003c\u0027de\u003e for Q\u003c\u0027a\u003e {\n\nThis fixes it, and adds a test, deserializing into a `Container` struct.\n\nIt also fixes the existing test cases, deserialize_ref was actually\ndeserialize_owned, and deserialize_owned didn\u0027t exist yet - but they\nalone are not enough to provoke the lifetime issues.\n\nChange-Id: Iaed2832998cae5f192eafe7fd5243e82ff6e051e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d03b4c7ff58010f41e39c29ac40a7c398c9de8609"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d03b4c7ff58010f41e39c29ac40a7c398c9de8609"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"199f9b0a79de0fb0fd57ce9307b36390339ee7e7","is_merged_in_target_branch":true,"change_id":"Ie1253523a6bd4e31e7924e9898a0898109da2fa0","change_number":11358,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"d00c75ea9cd2d31d6e0f02fa678678519317182c":{"kind":"REWORK","_number":2,"created":"2024-04-07 21:21:09.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/72/11372/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/72/11372/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/72/11372/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/72/11372/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/72/11372/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/72/11372/2"}}},"commit":{"parents":[{"commit":"efd8ab5e0b595648acad8a96d0b4f0d49fddee8f","subject":"feat(users/picnoir/tvix-daemon): implement set_options operation","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003defd8ab5e0b595648acad8a96d0b4f0d49fddee8f"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-07 20:40:38.000000000","tz":180},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-04-07 21:21:09.000000000","tz":0},"subject":"fix(nix-compat/store_path): fix Deserialize with borrow","message":"fix(nix-compat/store_path): fix Deserialize with borrow\n\nWe were wrongly using `\u0027de` as a lifetime for both `Deserializer` and\n`StorePathRef`.\n\nThis prevented Deserializing into a struct containing `StorePathRef`.\n\nSee https://serde.rs/lifetimes.html#the-deserializede-lifetime, the last\npart of the paragraph:\n\nThe \u0027de lifetime should not appear in the type to which the Deserialize\nimpl applies.\n\n- // Do not do this. Sooner or later you will be sad.\n- impl\u003c\u0027de\u003e Deserialize\u003c\u0027de\u003e for Q\u003c\u0027de\u003e {\n+ // Do this instead.\n+ impl\u003c\u0027de: \u0027a, \u0027a\u003e Deserialize\u003c\u0027de\u003e for Q\u003c\u0027a\u003e {\n\nThis fixes it, and adds a test, deserializing into a `Container` struct.\n\nIt also fixes the existing test cases, deserialize_ref was actually\ndeserialize_owned, and deserialize_owned didn\u0027t exist yet - but they\nalone are not enough to provoke the lifetime issues.\n\nChange-Id: Iaed2832998cae5f192eafe7fd5243e82ff6e051e\nReviewed-on: https://cl.tvl.fyi/c/depot/+/11372\nTested-by: BuildkiteCI\nAutosubmit: flokli \u003cflokli@flokli.de\u003e\nReviewed-by: picnoir picnoir \u003cpicnoir@alternativebit.fr\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd00c75ea9cd2d31d6e0f02fa678678519317182c"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd00c75ea9cd2d31d6e0f02fa678678519317182c"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"efd8ab5e0b595648acad8a96d0b4f0d49fddee8f","is_merged_in_target_branch":true,"change_id":"Ibd34fbe7821c20a460934ea1af0719f5de46e491","change_number":11359,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}