)]}'
{"id":"depot~11427","triplet_id":"depot~canon~If4e6cff6d8b580671b1548ae3862851db4af6694","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000082":{"account":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"last_update":"2024-04-15 13:20:07.000000000","reason":"Change was submitted"},"1000096":{"account":{"_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"},"last_update":"2024-04-15 13:20:07.000000000","reason":"Change was submitted"},"1000085":{"account":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"last_update":"2024-04-15 13:20:07.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-04-15 13:20:07.000000000","reason":"Change was submitted"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2024-04-15 12:42:48.000000000","reason":"\u003cGERRIT_ACCOUNT_1000073\u003e replied on the change","reason_account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}}},"hashtags":[],"change_id":"If4e6cff6d8b580671b1548ae3862851db4af6694","subject":"refactor(tvix/castore/fs): use consistent span field name for handle","status":"MERGED","created":"2024-04-15 09:47:43.000000000","updated":"2024-04-15 13:20:07.000000000","submitted":"2024-04-15 13:20:07.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"11427","meta_rev_id":"5faa95fb455fa0099cc7e1fb762badc9d5e0f68e","_number":11427,"virtual_id_number":11427,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-04-15 13:20:07.000000000","_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-04-15 13:20:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-04-15 13:20:07.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"},{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-04-15 09:47:43.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"},"state":"REVIEWER"},{"updated":"2024-04-15 09:47:43.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"state":"REVIEWER"},{"updated":"2024-04-15 09:47:43.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"state":"REVIEWER"},{"updated":"2024-04-15 09:47:43.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2024-04-15 09:47:45.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-04-15 10:10:48.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-04-15 13:20:07.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"90546e00449d81af2ac4555beda177d2781f6a6c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-15 09:47:43.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"a820dd46a940a41247837ec147881969cc28f098","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-15 09:47:45.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/33267","accounts_in_message":[],"_revision_number":1},{"id":"c1094951285f5d09f7dc85b5a7de6a70d0487dc9","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-15 10:10:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/33267","accounts_in_message":[],"_revision_number":1},{"id":"ae971146efa4f2bec7241833ad5aa260aef68fc6","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-04-15 12:42:48.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"8f925410585ce22f8bcb1bc47e9aafbb78490658","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-15 13:10:13.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"22ebe32023562b95751396523ce3cc27ef7b6fbf","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-15 13:10:16.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/33274","accounts_in_message":[],"_revision_number":2},{"id":"5a9b467f642d64cfbedc4b013c5e6ce0f62a4be5","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-15 13:19:24.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/33274","accounts_in_message":[],"_revision_number":2},{"id":"c0dbd04e7426519968ba01cf933ef3b6ac3a84c8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-15 13:19:55.000000000","message":"Uploaded patch set 3: New patch set was added with same tree, parent tree, and commit message as Patch Set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"**changekind:NO_CHANGE** OR **is:ANY**\")\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR **changekind:NO_CHANGE**\")\n* Verified+1 (copy condition: \"(**is:ANY** AND **changekind:NO_CODE_CHANGE**) OR **changekind:NO_CHANGE**\")\n","accounts_in_message":[],"_revision_number":3},{"id":"5faa95fb455fa0099cc7e1fb762badc9d5e0f68e","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-04-15 13:20:07.000000000","message":"Change has been successfully rebased and submitted as 456191e69e5f7abef8961ea31c0c8975faf88b8b\n\n1 is the latest approved patch-set.\nThe change was submitted with unreviewed changes in the following files:\n\n```\nThe name of the file: tvix/castore/src/fs/mod.rs\nInsertions: 2, Deletions: 2.\n\n@@ -97,6 +97,8 @@\n     /// This keeps track of inodes and data alongside them.\n     inode_tracker: RwLock\u003cInodeTracker\u003e,\n \n+    // FUTUREWORK: have a generic container type for dir/file handles and handle\n+    // allocation.\n     /// Maps from the handle returned from an opendir to\n     /// This holds all opendir handles (for the root inode)\n     /// They point to the rx part of the channel producing the listing.\n@@ -288,6 +290,9 @@\n     }\n }\n \n+/// Buffer size of the channel providing nodes in the mount root\n+const ROOT_NODES_BUFFER_SIZE: usize \u003d 16;\n+\n const XATTR_NAME_DIRECTORY_DIGEST: \u0026[u8] \u003d b\"user.tvix.castore.directory.digest\";\n const XATTR_NAME_BLOB_DIGEST: \u0026[u8] \u003d b\"user.tvix.castore.blob.digest\";\n \n@@ -395,7 +400,7 @@\n             }\n \n             let root_nodes_provider \u003d self.root_nodes_provider.clone();\n-            let (tx, rx) \u003d mpsc::channel(16);\n+            let (tx, rx) \u003d mpsc::channel(ROOT_NODES_BUFFER_SIZE);\n \n             // This task will run in the background immediately and will exit\n             // after the stream ends or if we no longer want any more entries.\n@@ -464,7 +469,7 @@\n             while let Some((i, n)) \u003d rx.blocking_recv() {\n                 let root_node \u003d n.map_err(|e| {\n                     warn!(\"failed to retrieve root node: {}\", e);\n-                    io::Error::from_raw_os_error(libc::EPERM)\n+                    io::Error::from_raw_os_error(libc::EIO)\n                 })?;\n \n                 let name \u003d root_node.get_name();\n@@ -548,7 +553,7 @@\n                 // drop it, which will close it.\n                 Some(rx) \u003d\u003e drop(rx),\n                 None \u003d\u003e {\n-                    debug!(\"dir handle not found\");\n+                    warn!(\"dir handle not found\");\n                 }\n             }\n         }\n@@ -634,7 +639,7 @@\n             Some(blob_reader) \u003d\u003e drop(blob_reader),\n             None \u003d\u003e {\n                 // These might already be dropped if a read error occured.\n-                debug!(\"file handle not found\");\n+                warn!(\"file handle not found\");\n             }\n         }\n \n```\n","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"456191e69e5f7abef8961ea31c0c8975faf88b8b","revisions":{"a0f11f668e8a7ae7815ca0c40dbd57d64e2addae":{"kind":"REWORK","_number":1,"created":"2024-04-15 09:47:43.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/27/11427/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/27/11427/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/27/11427/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/27/11427/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/27/11427/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/27/11427/1"}}},"commit":{"parents":[{"commit":"5496488dd389549092dd4847e8d79e44b84ffd9f","subject":"feat(tvix/castore/fs): implement opendir/releasedir","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5496488dd389549092dd4847e8d79e44b84ffd9f"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 09:42:51.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 09:44:45.000000000","tz":180},"subject":"refactor(tvix/castore/fs): use consistent span field name for handle","message":"refactor(tvix/castore/fs): use consistent span field name for handle\n\nUse rq.handle in `release` too, and remove interpolating it into the\n`debug!` log message itself. Also update the comment, we don\u0027t get\nownership, just simply drop.\n\nChange-Id: If4e6cff6d8b580671b1548ae3862851db4af6694\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da0f11f668e8a7ae7815ca0c40dbd57d64e2addae"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da0f11f668e8a7ae7815ca0c40dbd57d64e2addae"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"5496488dd389549092dd4847e8d79e44b84ffd9f","is_merged_in_target_branch":false,"change_id":"I0d3ec4cb70a8792c5a1343439cf47d78d9cbb1d6","change_number":11425,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"05165b2b1f4f726c4823ad2ef83459fd94653acb":{"kind":"REWORK","_number":2,"created":"2024-04-15 13:10:13.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/27/11427/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/27/11427/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/27/11427/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/27/11427/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/27/11427/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/27/11427/2"}}},"commit":{"parents":[{"commit":"85a13ecb5edd702d2c0316005db0b4fb9a7e6cbe","subject":"feat(tvix/castore/fs): implement opendir/releasedir","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d85a13ecb5edd702d2c0316005db0b4fb9a7e6cbe"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 09:42:51.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 13:09:21.000000000","tz":180},"subject":"refactor(tvix/castore/fs): use consistent span field name for handle","message":"refactor(tvix/castore/fs): use consistent span field name for handle\n\nUse rq.handle in `release` too, and remove interpolating it into the\nlog message itself.\n\nAlso update the comment, we don\u0027t get ownership, just simply drop, and\nchange the level to warn!, as suggested in cl/11425.\n\nChange-Id: If4e6cff6d8b580671b1548ae3862851db4af6694\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d05165b2b1f4f726c4823ad2ef83459fd94653acb"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d05165b2b1f4f726c4823ad2ef83459fd94653acb"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"85a13ecb5edd702d2c0316005db0b4fb9a7e6cbe","is_merged_in_target_branch":false,"change_id":"I0d3ec4cb70a8792c5a1343439cf47d78d9cbb1d6","change_number":11425,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"84dc2d04467f0fcfec4c4e04d79e09d63dafdfe2":{"kind":"NO_CHANGE","_number":3,"created":"2024-04-15 13:19:55.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/27/11427/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/27/11427/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/27/11427/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/27/11427/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/27/11427/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/27/11427/3"}}},"commit":{"parents":[{"commit":"2a47ad1d902c44f3986ef1fcd7770d73d54b0904","subject":"feat(tvix/castore/fs): implement opendir/releasedir","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2a47ad1d902c44f3986ef1fcd7770d73d54b0904"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 09:42:51.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 13:19:29.000000000","tz":180},"subject":"refactor(tvix/castore/fs): use consistent span field name for handle","message":"refactor(tvix/castore/fs): use consistent span field name for handle\n\nUse rq.handle in `release` too, and remove interpolating it into the\nlog message itself.\n\nAlso update the comment, we don\u0027t get ownership, just simply drop, and\nchange the level to warn!, as suggested in cl/11425.\n\nChange-Id: If4e6cff6d8b580671b1548ae3862851db4af6694\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d84dc2d04467f0fcfec4c4e04d79e09d63dafdfe2"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d84dc2d04467f0fcfec4c4e04d79e09d63dafdfe2"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2a47ad1d902c44f3986ef1fcd7770d73d54b0904","is_merged_in_target_branch":true,"change_id":"I0d3ec4cb70a8792c5a1343439cf47d78d9cbb1d6","change_number":11425,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"456191e69e5f7abef8961ea31c0c8975faf88b8b":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2024-04-15 13:20:07.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/27/11427/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/27/11427/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/27/11427/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/27/11427/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/27/11427/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/27/11427/4"}}},"commit":{"parents":[{"commit":"2a47ad1d902c44f3986ef1fcd7770d73d54b0904","subject":"feat(tvix/castore/fs): implement opendir/releasedir","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d2a47ad1d902c44f3986ef1fcd7770d73d54b0904"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 09:42:51.000000000","tz":180},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-04-15 13:20:07.000000000","tz":0},"subject":"refactor(tvix/castore/fs): use consistent span field name for handle","message":"refactor(tvix/castore/fs): use consistent span field name for handle\n\nUse rq.handle in `release` too, and remove interpolating it into the\nlog message itself.\n\nAlso update the comment, we don\u0027t get ownership, just simply drop, and\nchange the level to warn!, as suggested in cl/11425.\n\nChange-Id: If4e6cff6d8b580671b1548ae3862851db4af6694\nReviewed-on: https://cl.tvl.fyi/c/depot/+/11427\nReviewed-by: raitobezarius \u003ctvl@lahfa.xyz\u003e\nTested-by: BuildkiteCI\nAutosubmit: flokli \u003cflokli@flokli.de\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d456191e69e5f7abef8961ea31c0c8975faf88b8b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d456191e69e5f7abef8961ea31c0c8975faf88b8b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"2a47ad1d902c44f3986ef1fcd7770d73d54b0904","is_merged_in_target_branch":true,"change_id":"I0d3ec4cb70a8792c5a1343439cf47d78d9cbb1d6","change_number":11425,"patch_set_number":7,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}