)]}'
{"id":"depot~11429","triplet_id":"depot~canon~Ia354842fccdbc7f45c2d3efda3acf058b2dbc48e","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000082":{"account":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"last_update":"2024-04-15 13:50:28.000000000","reason":"\u003cGERRIT_ACCOUNT_1000082\u003e replied on the change","reason_account":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"}},"1000096":{"account":{"_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"},"last_update":"2024-04-15 13:54:14.000000000","reason":"Change was submitted"},"1000085":{"account":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"last_update":"2024-04-15 13:53:57.000000000","reason":"removed on reply"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-04-15 13:54:14.000000000","reason":"Change was submitted"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2024-04-15 13:54:14.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"Ia354842fccdbc7f45c2d3efda3acf058b2dbc48e","subject":"feat(tvix/castore/fs): assign read[dir*]/release[dir] ops to parent span","status":"MERGED","created":"2024-04-15 11:17:53.000000000","updated":"2024-04-15 13:54:14.000000000","submitted":"2024-04-15 13:54:14.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"11433","meta_rev_id":"8f04958e9f844ee64f7ad366ab7dd1e7c962e7ae","_number":11429,"virtual_id_number":11429,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-04-15 13:54:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-04-15 13:54:14.000000000","_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-04-15 13:54:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-04-15 13:54:14.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-04-15 11:17:53.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000096,"name":"picnoir picnoir","display_name":"picnoir","email":"picnoir@alternativebit.fr","username":"picnoir"},"state":"REVIEWER"},{"updated":"2024-04-15 11:17:53.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"state":"REVIEWER"},{"updated":"2024-04-15 11:17:53.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"state":"REVIEWER"},{"updated":"2024-04-15 11:17:53.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2024-04-15 11:17:55.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-04-15 11:25:46.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-04-15 13:54:14.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b618e60a5fd6acd31839a602f97da12ed61e5680","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-15 11:17:53.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"6d600af19afbe8cbf30fc31d693b717840893db1","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-15 11:17:55.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/33269","accounts_in_message":[],"_revision_number":1},{"id":"007d9af5b5d7b369341a19a425febb79651bdb46","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-15 11:25:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/33269","accounts_in_message":[],"_revision_number":1},{"id":"684fdc7e21bef8e69c994dff583d28c6f364b087","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-15 13:10:13.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"b50adb2a230e4465197f13b952d9aa64d2a84346","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-15 13:10:17.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/33277","accounts_in_message":[],"_revision_number":2},{"id":"459f89d11038b82bc75b6abbcefaaff147af0549","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-15 13:19:55.000000000","message":"Uploaded patch set 3: New patch set was added with same tree, parent tree, and commit message as Patch Set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"**changekind:NO_CHANGE** OR **is:ANY**\")\n","accounts_in_message":[],"_revision_number":3},{"id":"42ebdd64432ae7e94c08e015f17cb1e6eb60d0e4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-15 13:20:56.000000000","message":"Uploaded patch set 4: New patch set was added with same tree, parent tree, and commit message as Patch Set 3.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"**changekind:NO_CHANGE** OR **is:ANY**\")\n","accounts_in_message":[],"_revision_number":4},{"id":"1d13c2824d0e97d8e7f00cbb8d39df0de2a589da","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-15 13:24:35.000000000","message":"Uploaded patch set 5: New patch set was added with same tree, parent tree, and commit message as Patch Set 4.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"**changekind:NO_CHANGE** OR **is:ANY**\")\n","accounts_in_message":[],"_revision_number":5},{"id":"50a7271aaf27e2d6d200a32a1b30a84b8541baf7","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-15 13:27:11.000000000","message":"Patch Set 2: Verified+1\n\nCopied votes on follow-up patch sets have been updated:\n* Verified+1 has been copied to patch set 3, 4, 5 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\").\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/33277","accounts_in_message":[],"_revision_number":2},{"id":"151db53d17b5a23a2a4c336b3de1022b36c0ab9d","author":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"date":"2024-04-15 13:50:28.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"593c905deb60b2106d2107ef383e91e11c97295f","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-04-15 13:53:57.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"8f04958e9f844ee64f7ad366ab7dd1e7c962e7ae","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-04-15 13:54:14.000000000","message":"Change has been successfully rebased and submitted as d3d88431f3fab17f545b459273d180f433a1b419","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"d3d88431f3fab17f545b459273d180f433a1b419","revisions":{"61727fe40cdc737c0ae879a338a7b402bace2624":{"kind":"REWORK","_number":1,"created":"2024-04-15 11:17:53.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/29/11429/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/29/11429/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/29/11429/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/29/11429/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/29/11429/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/29/11429/1"}}},"commit":{"parents":[{"commit":"22cf78d187e1c3bb4d543be90f9ae38be028b2ec","subject":"fix(tvix/castore/fs): use record to add fields to current span","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d22cf78d187e1c3bb4d543be90f9ae38be028b2ec"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 10:52:55.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 11:09:08.000000000","tz":180},"subject":"feat(tvix/castore/fs): assign read[dir*]/release[dir] ops to parent span","message":"feat(tvix/castore/fs): assign read[dir*]/release[dir] ops to parent span\n\nWhen a directory or file is open()\u0027ed, we already put some data into\na lookup table, and subsequent operations then use the returned handle\nid.\n\nBy also adding the span that\u0027s been created during these calls into the\nlookup table, we can properly set the span parent for these requests,\nnicely connecting the individual operations to the bigger picture.\n\nChange-Id: Ia354842fccdbc7f45c2d3efda3acf058b2dbc48e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d61727fe40cdc737c0ae879a338a7b402bace2624"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d61727fe40cdc737c0ae879a338a7b402bace2624"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"22cf78d187e1c3bb4d543be90f9ae38be028b2ec","is_merged_in_target_branch":false,"change_id":"I337faac0e73a0da6eb0a52cb75c2e8c026eff774","change_number":11428,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"4602dab391bb2e36605444343d8066ffab88b4f5":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2024-04-15 13:10:13.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/29/11429/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/29/11429/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/29/11429/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/29/11429/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/29/11429/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/29/11429/2"}}},"commit":{"parents":[{"commit":"47736bff16b1213b28286af8d5f10bf3254e9125","subject":"fix(tvix/castore/fs): use record to add fields to current span","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d47736bff16b1213b28286af8d5f10bf3254e9125"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 10:52:55.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 13:09:21.000000000","tz":180},"subject":"feat(tvix/castore/fs): assign read[dir*]/release[dir] ops to parent span","message":"feat(tvix/castore/fs): assign read[dir*]/release[dir] ops to parent span\n\nWhen a directory or file is open()\u0027ed, we already put some data into\na lookup table, and subsequent operations then use the returned handle\nid.\n\nBy also adding the span that\u0027s been created during these calls into the\nlookup table, we can properly set the span parent for these requests,\nnicely connecting the individual operations to the bigger picture.\n\nChange-Id: Ia354842fccdbc7f45c2d3efda3acf058b2dbc48e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4602dab391bb2e36605444343d8066ffab88b4f5"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4602dab391bb2e36605444343d8066ffab88b4f5"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"47736bff16b1213b28286af8d5f10bf3254e9125","is_merged_in_target_branch":false,"change_id":"I337faac0e73a0da6eb0a52cb75c2e8c026eff774","change_number":11428,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"5669d69dd525287a98a8f610aa1f4b8d6448f0ff":{"kind":"NO_CHANGE","_number":3,"created":"2024-04-15 13:19:55.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/29/11429/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/29/11429/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/29/11429/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/29/11429/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/29/11429/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/29/11429/3"}}},"commit":{"parents":[{"commit":"e390287954c5a1cef878850df24cb53b2e6672c3","subject":"fix(tvix/castore/fs): use record to add fields to current span","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de390287954c5a1cef878850df24cb53b2e6672c3"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 10:52:55.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 13:19:29.000000000","tz":180},"subject":"feat(tvix/castore/fs): assign read[dir*]/release[dir] ops to parent span","message":"feat(tvix/castore/fs): assign read[dir*]/release[dir] ops to parent span\n\nWhen a directory or file is open()\u0027ed, we already put some data into\na lookup table, and subsequent operations then use the returned handle\nid.\n\nBy also adding the span that\u0027s been created during these calls into the\nlookup table, we can properly set the span parent for these requests,\nnicely connecting the individual operations to the bigger picture.\n\nChange-Id: Ia354842fccdbc7f45c2d3efda3acf058b2dbc48e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5669d69dd525287a98a8f610aa1f4b8d6448f0ff"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d5669d69dd525287a98a8f610aa1f4b8d6448f0ff"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e390287954c5a1cef878850df24cb53b2e6672c3","is_merged_in_target_branch":false,"change_id":"I337faac0e73a0da6eb0a52cb75c2e8c026eff774","change_number":11428,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f96dbb4cbb1994e254f7dbc1de3b51438573a071":{"kind":"NO_CHANGE","_number":4,"created":"2024-04-15 13:20:56.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/29/11429/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/29/11429/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/29/11429/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/29/11429/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/29/11429/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/29/11429/4"}}},"commit":{"parents":[{"commit":"8505724bd2fed424e4811e4430f4fd1add5f6060","subject":"fix(tvix/castore/fs): use record to add fields to current span","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8505724bd2fed424e4811e4430f4fd1add5f6060"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 10:52:55.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 13:20:20.000000000","tz":180},"subject":"feat(tvix/castore/fs): assign read[dir*]/release[dir] ops to parent span","message":"feat(tvix/castore/fs): assign read[dir*]/release[dir] ops to parent span\n\nWhen a directory or file is open()\u0027ed, we already put some data into\na lookup table, and subsequent operations then use the returned handle\nid.\n\nBy also adding the span that\u0027s been created during these calls into the\nlookup table, we can properly set the span parent for these requests,\nnicely connecting the individual operations to the bigger picture.\n\nChange-Id: Ia354842fccdbc7f45c2d3efda3acf058b2dbc48e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df96dbb4cbb1994e254f7dbc1de3b51438573a071"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df96dbb4cbb1994e254f7dbc1de3b51438573a071"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8505724bd2fed424e4811e4430f4fd1add5f6060","is_merged_in_target_branch":false,"change_id":"I337faac0e73a0da6eb0a52cb75c2e8c026eff774","change_number":11428,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"7263e1e08a719a47361654f5540b9e9cd0b02dbf":{"kind":"NO_CHANGE","_number":5,"created":"2024-04-15 13:24:35.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/29/11429/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/29/11429/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/29/11429/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/29/11429/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/29/11429/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/29/11429/5"}}},"commit":{"parents":[{"commit":"34d9d54aae4b5ff2b6a231ca986c987568a03bda","subject":"fix(tvix/castore/fs): use record to add fields to current span","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d34d9d54aae4b5ff2b6a231ca986c987568a03bda"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 10:52:55.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 13:23:54.000000000","tz":180},"subject":"feat(tvix/castore/fs): assign read[dir*]/release[dir] ops to parent span","message":"feat(tvix/castore/fs): assign read[dir*]/release[dir] ops to parent span\n\nWhen a directory or file is open()\u0027ed, we already put some data into\na lookup table, and subsequent operations then use the returned handle\nid.\n\nBy also adding the span that\u0027s been created during these calls into the\nlookup table, we can properly set the span parent for these requests,\nnicely connecting the individual operations to the bigger picture.\n\nChange-Id: Ia354842fccdbc7f45c2d3efda3acf058b2dbc48e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7263e1e08a719a47361654f5540b9e9cd0b02dbf"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d7263e1e08a719a47361654f5540b9e9cd0b02dbf"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"34d9d54aae4b5ff2b6a231ca986c987568a03bda","is_merged_in_target_branch":true,"change_id":"I337faac0e73a0da6eb0a52cb75c2e8c026eff774","change_number":11428,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"d3d88431f3fab17f545b459273d180f433a1b419":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2024-04-15 13:54:14.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/29/11429/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/29/11429/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/29/11429/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/29/11429/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/29/11429/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/29/11429/6"}}},"commit":{"parents":[{"commit":"34d9d54aae4b5ff2b6a231ca986c987568a03bda","subject":"fix(tvix/castore/fs): use record to add fields to current span","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d34d9d54aae4b5ff2b6a231ca986c987568a03bda"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 10:52:55.000000000","tz":180},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-04-15 13:54:14.000000000","tz":0},"subject":"feat(tvix/castore/fs): assign read[dir*]/release[dir] ops to parent span","message":"feat(tvix/castore/fs): assign read[dir*]/release[dir] ops to parent span\n\nWhen a directory or file is open()\u0027ed, we already put some data into\na lookup table, and subsequent operations then use the returned handle\nid.\n\nBy also adding the span that\u0027s been created during these calls into the\nlookup table, we can properly set the span parent for these requests,\nnicely connecting the individual operations to the bigger picture.\n\nChange-Id: Ia354842fccdbc7f45c2d3efda3acf058b2dbc48e\nReviewed-on: https://cl.tvl.fyi/c/depot/+/11429\nReviewed-by: Connor Brewster \u003ccbrewster@hey.com\u003e\nTested-by: BuildkiteCI\nAutosubmit: flokli \u003cflokli@flokli.de\u003e\nReviewed-by: Brian Olsen \u003cme@griff.name\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd3d88431f3fab17f545b459273d180f433a1b419"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd3d88431f3fab17f545b459273d180f433a1b419"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"34d9d54aae4b5ff2b6a231ca986c987568a03bda","is_merged_in_target_branch":true,"change_id":"I337faac0e73a0da6eb0a52cb75c2e8c026eff774","change_number":11428,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}