)]}'
{"id":"depot~11442","triplet_id":"depot~canon~I2d22e1c8a835c0f3dd0c648917009b2bad4fd57c","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000085":{"account":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"last_update":"2024-04-16 18:45:52.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-04-16 18:25:22.000000000","reason":"removed on reply"},"1000073":{"account":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"last_update":"2024-04-16 18:45:52.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I2d22e1c8a835c0f3dd0c648917009b2bad4fd57c","subject":"refactor(tvix/castore/blob/naive_seeker): rework skipping for clarity","status":"MERGED","created":"2024-04-16 15:13:43.000000000","updated":"2024-04-16 18:45:52.000000000","submitted":"2024-04-16 18:45:52.000000000","submitter":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"11191","meta_rev_id":"50fee738cf7994b2b478ba3f87ca562f5ab84619","_number":11442,"virtual_id_number":11442,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-04-16 18:45:52.000000000","_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-04-16 18:45:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-04-16 15:13:43.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"state":"REVIEWER"},{"updated":"2024-04-16 15:13:43.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"state":"REVIEWER"},{"updated":"2024-04-16 15:13:45.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-04-16 17:18:08.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4fa7a5a41afa8005bb97df2b0b10f70a7f5915e2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-16 15:13:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7357cbe0c0ae9604ca6d035872ae74f3fc33f5ae","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-16 15:13:45.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/33330","accounts_in_message":[],"_revision_number":1},{"id":"2be57475574c82950ca74cd976b566b7b5e7dca7","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-04-16 15:19:10.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"317bc60d381f7c90eb96db49b1f77bb204edae64","author":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"},"date":"2024-04-16 15:19:22.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d622f28dcba94833b6d86a569eef1d7513046cab","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-16 17:18:08.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/33330","accounts_in_message":[],"_revision_number":1},{"id":"4be0267017a4b922f902c1bfa9446d8d134d1d42","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-16 17:34:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/33344","accounts_in_message":[],"_revision_number":1},{"id":"00528d123ff01a32a895e81aad836d2c45dcc331","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-16 18:25:22.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n\nOutdated Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"f3588f830d0c05faf88a6ab0dea1a3299edf35c2","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-16 18:25:22.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"b370f36b7d03645f1430691f5c17a1c78890ba59","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-16 18:25:24.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/33347","accounts_in_message":[],"_revision_number":2},{"id":"3485f41f619a556c9bb778b68b82d3ffe5200a13","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-16 18:35:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/33347","accounts_in_message":[],"_revision_number":2},{"id":"50fee738cf7994b2b478ba3f87ca562f5ab84619","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-16 18:45:52.000000000","message":"Change has been successfully rebased and submitted as 9398bc46b60d809aac679157fe4c491586e649ff\n\n1 is the latest approved patch-set.\nThe change was submitted with unreviewed changes in the following files:\n\n```\nThe name of the file: tvix/castore/src/blobservice/naive_seeker.rs\nInsertions: 17, Deletions: 14.\n\n@@ -65,6 +65,9 @@\n     }\n }\n \n+/// The buffer size used to discard data.\n+const DISCARD_BUF_SIZE: usize \u003d 4096;\n+\n impl\u003cR: tokio::io::AsyncRead\u003e NaiveSeeker\u003cR\u003e {\n     pub fn new(r: R) -\u003e Self {\n         NaiveSeeker {\n@@ -174,7 +177,7 @@\n \n         // discard some bytes, until pos is where we want it to be.\n         // We create a buffer that we\u0027ll discard later on.\n-        let mut discard_buf \u003d [0; 4096];\n+        let mut discard_buf \u003d [0; DISCARD_BUF_SIZE];\n \n         // Loop until we\u0027ve reached the desired seek position. This is done by issuing repeated\n         // `poll_read` calls.\n@@ -210,16 +213,16 @@\n \n #[cfg(test)]\n mod tests {\n-    use super::NaiveSeeker;\n+    use super::{NaiveSeeker, DISCARD_BUF_SIZE};\n     use std::io::{Cursor, SeekFrom};\n     use tokio::io::{AsyncReadExt, AsyncSeekExt};\n \n-    /// This seek requires multiple `poll_read` as we use a 1024 bytes internal\n-    /// buffer when doing the seek.\n+    /// This seek requires multiple `poll_read` as we use a multiples of\n+    /// DISCARD_BUF_SIZE when doing the seek.\n     /// This ensures we don\u0027t hang indefinitely.\n     #[tokio::test]\n     async fn seek() {\n-        let buf \u003d vec![0u8; 4096];\n+        let buf \u003d vec![0u8; DISCARD_BUF_SIZE * 4];\n         let reader \u003d Cursor::new(\u0026buf);\n         let mut seeker \u003d NaiveSeeker::new(reader);\n         seeker.seek(SeekFrom::Start(4000)).await.unwrap();\n@@ -227,29 +230,29 @@\n \n     #[tokio::test]\n     async fn seek_read() {\n-        let mut buf \u003d vec![0u8; 2048];\n-        buf.extend_from_slice(\u0026[1u8; 2048]);\n-        buf.extend_from_slice(\u0026[2u8; 2048]);\n+        let mut buf \u003d vec![0u8; DISCARD_BUF_SIZE * 2];\n+        buf.extend_from_slice(\u0026[1u8; DISCARD_BUF_SIZE * 2]);\n+        buf.extend_from_slice(\u0026[2u8; DISCARD_BUF_SIZE * 2]);\n \n         let reader \u003d Cursor::new(\u0026buf);\n         let mut seeker \u003d NaiveSeeker::new(reader);\n \n-        let mut read_buf \u003d vec![0u8; 1024];\n+        let mut read_buf \u003d vec![0u8; DISCARD_BUF_SIZE];\n         seeker.read_exact(\u0026mut read_buf).await.expect(\"must read\");\n-        assert_eq!(read_buf.as_slice(), \u0026[0u8; 1024]);\n+        assert_eq!(read_buf.as_slice(), \u0026[0u8; DISCARD_BUF_SIZE]);\n \n         seeker\n-            .seek(SeekFrom::Current(1024))\n+            .seek(SeekFrom::Current(DISCARD_BUF_SIZE as i64))\n             .await\n             .expect(\"must seek\");\n         seeker.read_exact(\u0026mut read_buf).await.expect(\"must read\");\n-        assert_eq!(read_buf.as_slice(), \u0026[1u8; 1024]);\n+        assert_eq!(read_buf.as_slice(), \u0026[1u8; DISCARD_BUF_SIZE]);\n \n         seeker\n-            .seek(SeekFrom::Start(2 * 2048))\n+            .seek(SeekFrom::Start(2 * 2 * DISCARD_BUF_SIZE as u64))\n             .await\n             .expect(\"must seek\");\n         seeker.read_exact(\u0026mut read_buf).await.expect(\"must read\");\n-        assert_eq!(read_buf.as_slice(), \u0026[2u8; 1024]);\n+        assert_eq!(read_buf.as_slice(), \u0026[2u8; DISCARD_BUF_SIZE]);\n     }\n }\n```\n","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"9398bc46b60d809aac679157fe4c491586e649ff","revisions":{"49815736559f58c3072523382520030b70f6f91b":{"kind":"REWORK","_number":1,"created":"2024-04-16 15:13:43.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/42/11442/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/42/11442/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/42/11442/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/42/11442/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/42/11442/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/42/11442/1"}}},"commit":{"parents":[{"commit":"e90b0443e0b7e14044326eea394695f5b884f01f","subject":"feat(tvix/castore/blob/chunked_reader): only reassemble on real seek","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de90b0443e0b7e14044326eea394695f5b884f01f"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 15:46:10.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-16 15:12:50.000000000","tz":180},"subject":"refactor(tvix/castore/blob/naive_seeker): rework skipping for clarity","message":"refactor(tvix/castore/blob/naive_seeker): rework skipping for clarity\n\nIncrease the discard_buf to 4096 (as I\u0027ve seen this size).\nUse the ready! macro to propagate pendings.\nMake it more clear what exactly should be skipped in total, and what\nduring the current iteration.\n\nAlso write down that poll_read call already takes care of updating\nself.pos, as I ran into that trap earlier (and added it here).\n\nChange-Id: I2d22e1c8a835c0f3dd0c648917009b2bad4fd57c\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d49815736559f58c3072523382520030b70f6f91b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d49815736559f58c3072523382520030b70f6f91b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e90b0443e0b7e14044326eea394695f5b884f01f","is_merged_in_target_branch":false,"change_id":"I855f0c79c514c16ca48a78e12978af2835fbbd6a","change_number":11441,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"fc6641c4ee13bea308989aaf8511d4e2b5256f77":{"kind":"REWORK","_number":2,"created":"2024-04-16 18:25:22.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/42/11442/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/42/11442/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/42/11442/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/42/11442/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/42/11442/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/42/11442/2"}}},"commit":{"parents":[{"commit":"268c62e3a1e554310b1f2cce7e612a1eb99aafae","subject":"feat(tvix/castore/blob/chunked_reader): only reassemble on real seek","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d268c62e3a1e554310b1f2cce7e612a1eb99aafae"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 15:46:10.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-16 18:22:29.000000000","tz":180},"subject":"refactor(tvix/castore/blob/naive_seeker): rework skipping for clarity","message":"refactor(tvix/castore/blob/naive_seeker): rework skipping for clarity\n\nIncrease the discard_buf to 4096 (as I\u0027ve seen this size).\nUse the ready! macro to propagate pendings.\nMake it more clear what exactly should be skipped in total, and what\nduring the current iteration.\n\nAlso write down that poll_read call already takes care of updating\nself.pos, as I ran into that trap earlier (and added it here).\n\nChange-Id: I2d22e1c8a835c0f3dd0c648917009b2bad4fd57c\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfc6641c4ee13bea308989aaf8511d4e2b5256f77"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfc6641c4ee13bea308989aaf8511d4e2b5256f77"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"268c62e3a1e554310b1f2cce7e612a1eb99aafae","is_merged_in_target_branch":false,"change_id":"I855f0c79c514c16ca48a78e12978af2835fbbd6a","change_number":11441,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"9398bc46b60d809aac679157fe4c491586e649ff":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2024-04-16 18:45:52.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/42/11442/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/42/11442/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/42/11442/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/42/11442/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/42/11442/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/42/11442/3"}}},"commit":{"parents":[{"commit":"4d802fa0aefbc22b5f78bf7281c0028ad3bf2fff","subject":"feat(tvix/castore/blob/chunked_reader): only reassemble on real seek","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d4d802fa0aefbc22b5f78bf7281c0028ad3bf2fff"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-04-15 15:46:10.000000000","tz":180},"committer":{"name":"flokli","email":"flokli@flokli.de","date":"2024-04-16 18:45:52.000000000","tz":0},"subject":"refactor(tvix/castore/blob/naive_seeker): rework skipping for clarity","message":"refactor(tvix/castore/blob/naive_seeker): rework skipping for clarity\n\nIncrease the discard_buf to 4096 (as I\u0027ve seen this size).\nUse the ready! macro to propagate pendings.\nMake it more clear what exactly should be skipped in total, and what\nduring the current iteration.\n\nAlso write down that poll_read call already takes care of updating\nself.pos, as I ran into that trap earlier (and added it here).\n\nChange-Id: I2d22e1c8a835c0f3dd0c648917009b2bad4fd57c\nReviewed-on: https://cl.tvl.fyi/c/depot/+/11442\nReviewed-by: raitobezarius \u003ctvl@lahfa.xyz\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9398bc46b60d809aac679157fe4c491586e649ff"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9398bc46b60d809aac679157fe4c491586e649ff"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"4d802fa0aefbc22b5f78bf7281c0028ad3bf2fff","is_merged_in_target_branch":true,"change_id":"I855f0c79c514c16ca48a78e12978af2835fbbd6a","change_number":11441,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000073,"name":"raitobezarius","display_name":"Ryan Lahfa","email":"tvl@lahfa.xyz","username":"raitobezarius"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}