)]}'
{"tvix/castore/src/import.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"83c6893ecbb4e1db02afc1081b7a88ffbb4cf949","unresolved":true,"context_lines":[{"line_number":93,"context_line":"        .follow_links(false)"},{"line_number":94,"context_line":"        .follow_root_links(false)"},{"line_number":95,"context_line":"        .contents_first(true)"},{"line_number":96,"context_line":"        .sort_by_file_name()"},{"line_number":97,"context_line":"        .into_iter();"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    dir_entry_iter_to_ingestion_stream(blob_service, iter, path.to_owned())"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"dc14d4a7_ca6fced8","line":96,"updated":"2024-04-18 20:43:56.000000000","message":"We don\u0027t need to sort, As Directory.add() can deal with elements being inserted in unsorted order.","commit_id":"35fd27887023c70930a7f0b7f4f07d190f803d4e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"2eb16711f71f3724a1b06a2ab2bf345cf10d0252","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        .follow_links(false)"},{"line_number":94,"context_line":"        .follow_root_links(false)"},{"line_number":95,"context_line":"        .contents_first(true)"},{"line_number":96,"context_line":"        .sort_by_file_name()"},{"line_number":97,"context_line":"        .into_iter();"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    dir_entry_iter_to_ingestion_stream(blob_service, iter, path.to_owned())"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"bffa948f_b1e1c7f2","line":96,"in_reply_to":"dc14d4a7_ca6fced8","updated":"2024-04-19 19:24:50.000000000","message":"Done","commit_id":"35fd27887023c70930a7f0b7f4f07d190f803d4e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"83c6893ecbb4e1db02afc1081b7a88ffbb4cf949","unresolved":true,"context_lines":[{"line_number":99,"context_line":"    dir_entry_iter_to_ingestion_stream(blob_service, iter, path.to_owned())"},{"line_number":100,"context_line":"}"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"pub fn dir_entry_iter_to_ingestion_stream\u003c\u0027a, BS, I\u003e("},{"line_number":103,"context_line":"    blob_service: BS,"},{"line_number":104,"context_line":"    iter: I,"},{"line_number":105,"context_line":"    root_path: PathBuf,"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"f3732264_621a7b6a","line":102,"updated":"2024-04-18 20:43:56.000000000","message":"Let\u0027s merge that function together with the one below.","commit_id":"35fd27887023c70930a7f0b7f4f07d190f803d4e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"2eb16711f71f3724a1b06a2ab2bf345cf10d0252","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    dir_entry_iter_to_ingestion_stream(blob_service, iter, path.to_owned())"},{"line_number":100,"context_line":"}"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"pub fn dir_entry_iter_to_ingestion_stream\u003c\u0027a, BS, I\u003e("},{"line_number":103,"context_line":"    blob_service: BS,"},{"line_number":104,"context_line":"    iter: I,"},{"line_number":105,"context_line":"    root_path: PathBuf,"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"6f3c9933_d92947c3","line":102,"in_reply_to":"dc8ecd09_e94e886e","updated":"2024-04-19 19:24:50.000000000","message":"Done","commit_id":"35fd27887023c70930a7f0b7f4f07d190f803d4e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"be6e5162d38020bd49b7279c3ad1c6cabd8c7384","unresolved":true,"context_lines":[{"line_number":99,"context_line":"    dir_entry_iter_to_ingestion_stream(blob_service, iter, path.to_owned())"},{"line_number":100,"context_line":"}"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"pub fn dir_entry_iter_to_ingestion_stream\u003c\u0027a, BS, I\u003e("},{"line_number":103,"context_line":"    blob_service: BS,"},{"line_number":104,"context_line":"    iter: I,"},{"line_number":105,"context_line":"    root_path: PathBuf,"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"dc8ecd09_e94e886e","line":102,"in_reply_to":"f3732264_621a7b6a","updated":"2024-04-18 21:12:54.000000000","message":"I meant above, sorry. The conversion thing still makes sense to be separate.","commit_id":"35fd27887023c70930a7f0b7f4f07d190f803d4e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"83c6893ecbb4e1db02afc1081b7a88ffbb4cf949","unresolved":true,"context_lines":[{"line_number":121,"context_line":"pub fn dir_entry_to_ingestion_entry\u003c\u0027a, BS\u003e("},{"line_number":122,"context_line":"    blob_service: BS,"},{"line_number":123,"context_line":"    entry: \u0026DirEntry,"},{"line_number":124,"context_line":"    root_path: \u0026Path,"},{"line_number":125,"context_line":") -\u003e Result\u003cIngestionEntry\u003c\u0027a\u003e, Error\u003e"},{"line_number":126,"context_line":"where"},{"line_number":127,"context_line":"    BS: AsRef\u003cdyn BlobService\u003e + Clone + Send + \u0027a,"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"795e0171_30aee276","line":124,"updated":"2024-04-18 20:43:56.000000000","message":"Don\u0027t we want to pass the parent of the path we\u0027re ingesting here (and then rename this just \"prefix\"? that should keep the name on the root node itself.","commit_id":"35fd27887023c70930a7f0b7f4f07d190f803d4e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"2eb16711f71f3724a1b06a2ab2bf345cf10d0252","unresolved":false,"context_lines":[{"line_number":121,"context_line":"pub fn dir_entry_to_ingestion_entry\u003c\u0027a, BS\u003e("},{"line_number":122,"context_line":"    blob_service: BS,"},{"line_number":123,"context_line":"    entry: \u0026DirEntry,"},{"line_number":124,"context_line":"    root_path: \u0026Path,"},{"line_number":125,"context_line":") -\u003e Result\u003cIngestionEntry\u003c\u0027a\u003e, Error\u003e"},{"line_number":126,"context_line":"where"},{"line_number":127,"context_line":"    BS: AsRef\u003cdyn BlobService\u003e + Clone + Send + \u0027a,"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"1907cb21_d9d8180c","line":124,"in_reply_to":"795e0171_30aee276","updated":"2024-04-19 19:24:50.000000000","message":"Done","commit_id":"35fd27887023c70930a7f0b7f4f07d190f803d4e"}],"tvix/castore/src/proto/mod.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"83c6893ecbb4e1db02afc1081b7a88ffbb4cf949","unresolved":true,"context_lines":[{"line_number":179,"context_line":"    }"},{"line_number":180,"context_line":"}"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"impl PartialOrd for FileNode {"},{"line_number":183,"context_line":"    fn partial_cmp(\u0026self, other: \u0026Self) -\u003e Option\u003cstd::cmp::Ordering\u003e {"},{"line_number":184,"context_line":"        Some(self.cmp(other))"},{"line_number":185,"context_line":"    }"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"f265a639_236460ff","line":182,"updated":"2024-04-18 20:43:56.000000000","message":"Please put this into a separate CL.","commit_id":"35fd27887023c70930a7f0b7f4f07d190f803d4e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"2eb16711f71f3724a1b06a2ab2bf345cf10d0252","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    }"},{"line_number":180,"context_line":"}"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"impl PartialOrd for FileNode {"},{"line_number":183,"context_line":"    fn partial_cmp(\u0026self, other: \u0026Self) -\u003e Option\u003cstd::cmp::Ordering\u003e {"},{"line_number":184,"context_line":"        Some(self.cmp(other))"},{"line_number":185,"context_line":"    }"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"004a52d3_8a845fbf","line":182,"in_reply_to":"f265a639_236460ff","updated":"2024-04-19 19:24:50.000000000","message":"Done","commit_id":"35fd27887023c70930a7f0b7f4f07d190f803d4e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"83c6893ecbb4e1db02afc1081b7a88ffbb4cf949","unresolved":true,"context_lines":[{"line_number":340,"context_line":"        };"},{"line_number":341,"context_line":"    }"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    pub fn add(\u0026mut self, node: node::Node) -\u003e Option\u003cnode::Node\u003e {"},{"line_number":344,"context_line":"        match node {"},{"line_number":345,"context_line":"            node::Node::File(node) \u003d\u003e match self.files.binary_search(\u0026node) {"},{"line_number":346,"context_line":"                Ok(pos) \u003d\u003e Some(node::Node::File(std::mem::replace("}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"bc75cb8e_3c3bf7e5","line":343,"updated":"2024-04-18 20:43:56.000000000","message":"This needs a docstring, and tests.","commit_id":"35fd27887023c70930a7f0b7f4f07d190f803d4e"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"2eb16711f71f3724a1b06a2ab2bf345cf10d0252","unresolved":false,"context_lines":[{"line_number":340,"context_line":"        };"},{"line_number":341,"context_line":"    }"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"    pub fn add(\u0026mut self, node: node::Node) -\u003e Option\u003cnode::Node\u003e {"},{"line_number":344,"context_line":"        match node {"},{"line_number":345,"context_line":"            node::Node::File(node) \u003d\u003e match self.files.binary_search(\u0026node) {"},{"line_number":346,"context_line":"                Ok(pos) \u003d\u003e Some(node::Node::File(std::mem::replace("}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"1cf5078e_f2d9deb8","line":343,"in_reply_to":"bc75cb8e_3c3bf7e5","updated":"2024-04-19 19:24:50.000000000","message":"Done","commit_id":"35fd27887023c70930a7f0b7f4f07d190f803d4e"}]}