)]}'
{"id":"depot~11481","triplet_id":"depot~canon~I94b86bdef5d0da55aa352e098988b9704cafca19","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000085":{"account":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"last_update":"2024-04-19 19:51:44.000000000","reason":"\u003cGERRIT_ACCOUNT_1000085\u003e replied on the change","reason_account":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}}},"hashtags":[],"change_id":"I94b86bdef5d0da55aa352e098988b9704cafca19","subject":"feat(tvix/castore): add convenience `add` method to Directory","status":"MERGED","created":"2024-04-19 18:59:20.000000000","updated":"2024-04-19 20:10:14.000000000","submitted":"2024-04-19 20:10:14.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"11481","meta_rev_id":"cfb134032cfe5835aa51e2f0ab210f1a797c9bcf","_number":11481,"virtual_id_number":11481,"owner":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-04-19 20:10:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-04-19 20:10:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"all":[{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-04-19 20:10:14.000000000","_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-04-19 18:59:21.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-04-19 19:08:38.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-04-19 19:30:51.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2024-04-19 20:10:14.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c17bb823bbbb7f940c7ef491b5e3499c577f788e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-04-19 18:59:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0fc3482e237f32e9638dd50f3a70306b9affc12d","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-19 18:59:21.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/33431","accounts_in_message":[],"_revision_number":1},{"id":"dcf0250a89c922e6979f580f4762fb2c81e26d8d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-19 19:08:38.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/33431","accounts_in_message":[],"_revision_number":1},{"id":"35bc9cb5b48c0b7e0f38eb37023135a708ed587b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-04-19 19:30:02.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"d8d60006c57917ec35c6ba96ae0afca6961d4995","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-19 19:30:51.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/33449","accounts_in_message":[],"_revision_number":2},{"id":"543d7904df8bf461f2bcc098d35769e8df3a0a15","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-19 19:30:51.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"04c12625634b48811f3db18baee633eed3e4c60e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-04-19 19:31:02.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":3},{"id":"5533fd139633574c8df2e72fd23ef6bde64db7a3","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-19 19:31:05.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/33451","accounts_in_message":[],"_revision_number":3},{"id":"37fdca080926fe6ff0e539c42dc97db1daddc190","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-19 19:32:06.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"1633de33888ce0528d8ea2ea6ae8c6d2428aa755","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-19 19:32:32.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"372e1f2582254b55b2027ae5966e99f9da5c1202","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-04-19 19:46:14.000000000","message":"Uploaded patch set 4.\n\nCopied Votes:\n* Code-Review+2 (copy condition: \"((**is:ANY** AND **has:unchanged-files**) OR is:MIN) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"4a76c17cec9055b9d5980ddd6886fb82b652cd71","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-19 19:46:15.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/33455","accounts_in_message":[],"_revision_number":4},{"id":"842d2043b959fb2ad41dddc88b274463f7ea43e4","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-04-19 19:46:17.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"53728d99a3928e9c193d5e4ac7a1da10d261f838","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-04-19 19:51:44.000000000","message":"Patch Set 4: Autosubmit+1","accounts_in_message":[],"_revision_number":4},{"id":"5f227865e97862866b4c04eebbbcd8e8ebfed50c","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-19 20:09:58.000000000","message":"Patch Set 4: Verified+1\n\nBuild of patchset 4 passed: https://buildkite.com/tvl/depot/builds/33455","accounts_in_message":[],"_revision_number":4},{"id":"cfb134032cfe5835aa51e2f0ab210f1a797c9bcf","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-04-19 20:10:14.000000000","message":"Change has been successfully rebased and submitted as 150106610e60e95267c0968a9679797b05db7f3d\n\n3 is the latest approved patch-set.\nThe change was submitted with unreviewed changes in the following files:\n\n```\nThe name of the file: tvix/castore/src/proto/mod.rs\nInsertions: 10, Deletions: 7.\n\n@@ -341,24 +341,27 @@\n     }\n \n     /// Adds the specified [node::Node] to the [Directory], preserving sorted entries.\n-    /// This assumes that prior to adding the node, that the [Directory] is already sorted.\n+    /// This assumes the [Directory] to be sorted prior to adding the node.\n     ///\n     /// Inserting an element that already exists with the same name in the directory is not\n     /// supported.\n     pub fn add(\u0026mut self, node: node::Node) {\n         debug_assert!(\n-            !self.files\n-                .iter().any(|x| x.get_name() \u003d\u003d node.get_name()),\n+            !self.files.iter().any(|x| x.get_name() \u003d\u003d node.get_name()),\n             \"name already exists in files\"\n         );\n         debug_assert!(\n-            !self.directories\n-                .iter().any(|x| x.get_name() \u003d\u003d node.get_name()),\n+            !self\n+                .directories\n+                .iter()\n+                .any(|x| x.get_name() \u003d\u003d node.get_name()),\n             \"name already exists in directories\"\n         );\n         debug_assert!(\n-            !self.symlinks\n-                .iter().any(|x| x.get_name() \u003d\u003d node.get_name()),\n+            !self\n+                .symlinks\n+                .iter()\n+                .any(|x| x.get_name() \u003d\u003d node.get_name()),\n             \"name already exists in symlinks\"\n         );\n \n```\n","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"150106610e60e95267c0968a9679797b05db7f3d","revisions":{"ae482fce2f4b086418cb6940266adde55e45014b":{"kind":"REWORK","_number":1,"created":"2024-04-19 18:59:20.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/81/11481/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/81/11481/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/81/11481/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/81/11481/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/81/11481/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/81/11481/1"}}},"commit":{"parents":[{"commit":"cf47294b9ee7887ca1f21db34d48c346e89f9cec","subject":"feat(tvix/boot): boot nixos VM","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcf47294b9ee7887ca1f21db34d48c346e89f9cec"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-04-19 18:57:30.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-04-19 18:57:30.000000000","tz":-300},"subject":"feat(tvix/castore): add convenience `add` method to Directory","message":"feat(tvix/castore): add convenience `add` method to Directory\n\nThis adds `Directory::add` which is a convenience helper for adding\nnodes into a `Directory` while preserving sorted order.\n\nThis implements `Ord` and `PartialOrd` for `FileNode`, `SymlinkNode`,\nand `DirectoryNode` so `binary_search` can be used.\n\nChange-Id: I94b86bdef5d0da55aa352e098988b9704cafca19\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dae482fce2f4b086418cb6940266adde55e45014b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dae482fce2f4b086418cb6940266adde55e45014b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"cf47294b9ee7887ca1f21db34d48c346e89f9cec","is_merged_in_target_branch":true,"change_id":"I6887d935f589eb0ad6507033c01337e1ec500a0b","change_number":11191,"patch_set_number":18,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"327cb700fff6d90329840be5dcfc72ae107ce2e7":{"kind":"REWORK","_number":2,"created":"2024-04-19 19:30:02.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/81/11481/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/81/11481/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/81/11481/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/81/11481/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/81/11481/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/81/11481/2"}}},"commit":{"parents":[{"commit":"cf47294b9ee7887ca1f21db34d48c346e89f9cec","subject":"feat(tvix/boot): boot nixos VM","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dcf47294b9ee7887ca1f21db34d48c346e89f9cec"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-04-19 18:57:30.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-04-19 19:28:53.000000000","tz":-300},"subject":"feat(tvix/castore): add convenience `add` method to Directory","message":"feat(tvix/castore): add convenience `add` method to Directory\n\nThis adds `Directory::add` which is a convenience helper for adding\nnodes into a `Directory` while preserving sorted order.\n\nThis implements `Ord` and `PartialOrd` for `FileNode`, `SymlinkNode`,\nand `DirectoryNode` so `binary_search` can be used.\n\nChange-Id: I94b86bdef5d0da55aa352e098988b9704cafca19\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d327cb700fff6d90329840be5dcfc72ae107ce2e7"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d327cb700fff6d90329840be5dcfc72ae107ce2e7"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"cf47294b9ee7887ca1f21db34d48c346e89f9cec","is_merged_in_target_branch":true,"change_id":"I6887d935f589eb0ad6507033c01337e1ec500a0b","change_number":11191,"patch_set_number":18,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"85689af1bd0e0814686dd717569fc8116b5443eb":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2024-04-19 19:31:02.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/81/11481/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/81/11481/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/81/11481/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/81/11481/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/81/11481/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/81/11481/3"}}},"commit":{"parents":[{"commit":"8a40c92f5d62466d51b9e59a79cff3108aeff1d7","subject":"chore(tvix/glue): migrate from test_case to rstest","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8a40c92f5d62466d51b9e59a79cff3108aeff1d7"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-04-19 18:57:30.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-04-19 19:30:33.000000000","tz":-300},"subject":"feat(tvix/castore): add convenience `add` method to Directory","message":"feat(tvix/castore): add convenience `add` method to Directory\n\nThis adds `Directory::add` which is a convenience helper for adding\nnodes into a `Directory` while preserving sorted order.\n\nThis implements `Ord` and `PartialOrd` for `FileNode`, `SymlinkNode`,\nand `DirectoryNode` so `binary_search` can be used.\n\nChange-Id: I94b86bdef5d0da55aa352e098988b9704cafca19\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d85689af1bd0e0814686dd717569fc8116b5443eb"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d85689af1bd0e0814686dd717569fc8116b5443eb"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8a40c92f5d62466d51b9e59a79cff3108aeff1d7","is_merged_in_target_branch":true,"change_id":"Id1bac94e7b95960dabd55f095f04bdabfeee10ea","change_number":11476,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"92481db076a4e3b4351b6351fbcd5f2738a8394a":{"kind":"REWORK","_number":4,"created":"2024-04-19 19:46:14.000000000","uploader":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"ref":"refs/changes/81/11481/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/81/11481/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/81/11481/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/81/11481/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/81/11481/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/81/11481/4"}}},"commit":{"parents":[{"commit":"8a40c92f5d62466d51b9e59a79cff3108aeff1d7","subject":"chore(tvix/glue): migrate from test_case to rstest","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8a40c92f5d62466d51b9e59a79cff3108aeff1d7"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-04-19 18:57:30.000000000","tz":-300},"committer":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-04-19 19:46:09.000000000","tz":-300},"subject":"feat(tvix/castore): add convenience `add` method to Directory","message":"feat(tvix/castore): add convenience `add` method to Directory\n\nThis adds `Directory::add` which is a convenience helper for adding\nnodes into a `Directory` while preserving sorted order.\n\nThis implements `Ord` and `PartialOrd` for `FileNode`, `SymlinkNode`,\nand `DirectoryNode` so `binary_search` can be used.\n\nChange-Id: I94b86bdef5d0da55aa352e098988b9704cafca19\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d92481db076a4e3b4351b6351fbcd5f2738a8394a"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d92481db076a4e3b4351b6351fbcd5f2738a8394a"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8a40c92f5d62466d51b9e59a79cff3108aeff1d7","is_merged_in_target_branch":true,"change_id":"Id1bac94e7b95960dabd55f095f04bdabfeee10ea","change_number":11476,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"150106610e60e95267c0968a9679797b05db7f3d":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2024-04-19 20:10:14.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/81/11481/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/81/11481/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/81/11481/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/81/11481/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/81/11481/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/81/11481/5"}}},"commit":{"parents":[{"commit":"8a40c92f5d62466d51b9e59a79cff3108aeff1d7","subject":"chore(tvix/glue): migrate from test_case to rstest","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8a40c92f5d62466d51b9e59a79cff3108aeff1d7"}]}],"author":{"name":"Connor Brewster","email":"cbrewster@hey.com","date":"2024-04-19 18:57:30.000000000","tz":-300},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-04-19 20:10:14.000000000","tz":0},"subject":"feat(tvix/castore): add convenience `add` method to Directory","message":"feat(tvix/castore): add convenience `add` method to Directory\n\nThis adds `Directory::add` which is a convenience helper for adding\nnodes into a `Directory` while preserving sorted order.\n\nThis implements `Ord` and `PartialOrd` for `FileNode`, `SymlinkNode`,\nand `DirectoryNode` so `binary_search` can be used.\n\nChange-Id: I94b86bdef5d0da55aa352e098988b9704cafca19\nReviewed-on: https://cl.tvl.fyi/c/depot/+/11481\nAutosubmit: Connor Brewster \u003ccbrewster@hey.com\u003e\nTested-by: BuildkiteCI\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d150106610e60e95267c0968a9679797b05db7f3d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d150106610e60e95267c0968a9679797b05db7f3d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"8a40c92f5d62466d51b9e59a79cff3108aeff1d7","is_merged_in_target_branch":true,"change_id":"Id1bac94e7b95960dabd55f095f04bdabfeee10ea","change_number":11476,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}