)]}'
{"id":"depot~11553","triplet_id":"depot~canon~Ie97777af6765fe1c12c8aa593afe1c9b69125775","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000005":{"account":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"last_update":"2024-05-01 12:32:39.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-05-01 12:20:44.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Ie97777af6765fe1c12c8aa593afe1c9b69125775","subject":"fix(nix-compat/store_path): permit store paths with dots again","status":"MERGED","created":"2024-04-30 12:43:10.000000000","updated":"2024-05-01 12:32:39.000000000","submitted":"2024-05-01 12:32:39.000000000","submitter":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"11553","meta_rev_id":"8d9ce3738f9d4739f81c3dcc8da3aaec9144c5dc","_number":11553,"virtual_id_number":11553,"owner":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-05-01 12:32:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-05-01 12:32:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-04-30 12:43:10.000000000","updated_by":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2024-04-30 12:43:11.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-04-30 12:50:23.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fe7b25a083007efb2c3c529c089bcf256ba5056c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2024-04-30 12:43:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"da4b9de704a103feecef8d565c54c8f1ab0dd38d","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2024-04-30 12:43:10.000000000","message":"\u003cGERRIT_ACCOUNT_1000036\u003e, who was added as reviewer owns the following files:\n* `tvix/nix-compat/src/store_path/mod.rs`\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":1},{"id":"8ef5fadf57e7ce45141593f7d7a17de11cbb6aad","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-30 12:43:11.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/33734","accounts_in_message":[],"_revision_number":1},{"id":"9776c0ac163914370a02234a2cb44e08aaf45e2f","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-04-30 12:50:23.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/33734","accounts_in_message":[],"_revision_number":1},{"id":"e91a4b61fcabc05df0353f1b35a1cae8e9a2dd50","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-05-01 12:20:44.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"8d9ce3738f9d4739f81c3dcc8da3aaec9144c5dc","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2024-05-01 12:32:39.000000000","message":"Change has been successfully rebased and submitted as d84fd49169ac7f106262801ef2f14a4cc6296152","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d84fd49169ac7f106262801ef2f14a4cc6296152","revisions":{"020320aaf9a65351f9369cf95d01c1fb0467d670":{"kind":"REWORK","_number":1,"created":"2024-04-30 12:43:10.000000000","uploader":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"ref":"refs/changes/53/11553/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/53/11553/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11553/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11553/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11553/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/53/11553/1"}}},"commit":{"parents":[{"commit":"b3305ea6e26bef913cfa1a1d7b5cb0c13392ed4c","subject":"refactor(nix-compat/wire/bytes): branchless padding computation","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db3305ea6e26bef913cfa1a1d7b5cb0c13392ed4c"}]}],"author":{"name":"edef","email":"edef@edef.eu","date":"2024-04-30 11:32:25.000000000","tz":0},"committer":{"name":"edef","email":"edef@edef.eu","date":"2024-04-30 12:43:00.000000000","tz":0},"subject":"fix(nix-compat/store_path): permit store paths with dots again","message":"fix(nix-compat/store_path): permit store paths with dots again\n\nNix 2.4 accidentally permitted this behaviour, but the revert came\ntoo late to beat Hyrum\u0027s law. It is now considered permissible.\n\nLink: https://github.com/NixOS/nix/pull/9867\nChange-Id: Ie97777af6765fe1c12c8aa593afe1c9b69125775\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d020320aaf9a65351f9369cf95d01c1fb0467d670"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d020320aaf9a65351f9369cf95d01c1fb0467d670"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"b3305ea6e26bef913cfa1a1d7b5cb0c13392ed4c","is_merged_in_target_branch":true,"change_id":"Ie07c2516a485c78afa6f9a3c8256e9708c4c42c5","change_number":11548,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"d84fd49169ac7f106262801ef2f14a4cc6296152":{"kind":"REWORK","_number":2,"created":"2024-05-01 12:32:39.000000000","uploader":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"ref":"refs/changes/53/11553/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/53/11553/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11553/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11553/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/53/11553/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/53/11553/2"}}},"commit":{"parents":[{"commit":"c5b318700235113fc687dcf9b201d64e775fc9d6","subject":"feat(tvix/castore/path): implement Debug + Display","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc5b318700235113fc687dcf9b201d64e775fc9d6"}]}],"author":{"name":"edef","email":"edef@edef.eu","date":"2024-04-30 11:32:25.000000000","tz":0},"committer":{"name":"edef","email":"edef@edef.eu","date":"2024-05-01 12:32:39.000000000","tz":0},"subject":"fix(nix-compat/store_path): permit store paths with dots again","message":"fix(nix-compat/store_path): permit store paths with dots again\n\nNix 2.4 accidentally permitted this behaviour, but the revert came\ntoo late to beat Hyrum\u0027s law. It is now considered permissible.\n\nLink: https://github.com/NixOS/nix/pull/9867\nChange-Id: Ie97777af6765fe1c12c8aa593afe1c9b69125775\nReviewed-on: https://cl.tvl.fyi/c/depot/+/11553\nTested-by: BuildkiteCI\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd84fd49169ac7f106262801ef2f14a4cc6296152"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dd84fd49169ac7f106262801ef2f14a4cc6296152"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c5b318700235113fc687dcf9b201d64e775fc9d6","is_merged_in_target_branch":true,"change_id":"I11213094728f3e0c674562ee71c092a950041632","change_number":11565,"patch_set_number":8,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}