)]}'
{"tvix/glue/tests/nix_oracle.rs":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"f94643ba37d3c4fa292f2df5ae77c469a2dc1d7d","unresolved":true,"context_lines":[{"line_number":98,"context_line":"    eval.builtins.extend(impure_builtins());"},{"line_number":99,"context_line":"    add_derivation_builtins(\u0026mut eval, Rc::clone(\u0026tvix_store_io));"},{"line_number":100,"context_line":"    add_fetcher_builtins(\u0026mut eval, Rc::clone(\u0026tvix_store_io));"},{"line_number":101,"context_line":"    add_import_builtins(\u0026mut eval, tvix_store_io);"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    let tvix_result \u003d eval.evaluate(expr, None);"},{"line_number":104,"context_line":"    for error in \u0026tvix_result.errors {"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"85295f1d_139edb91","line":101,"updated":"2024-05-04 19:35:47.000000000","message":"You need `configure_nix_path(\u0026mut eval, \u0026None)` too.","commit_id":"ad20ad169bf3afb8447fd0ad10b69a38f6b512d1"},{"author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"change_message_id":"106cde099772b2da98605963e769fd31d58e18de","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    eval.builtins.extend(impure_builtins());"},{"line_number":99,"context_line":"    add_derivation_builtins(\u0026mut eval, Rc::clone(\u0026tvix_store_io));"},{"line_number":100,"context_line":"    add_fetcher_builtins(\u0026mut eval, Rc::clone(\u0026tvix_store_io));"},{"line_number":101,"context_line":"    add_import_builtins(\u0026mut eval, tvix_store_io);"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    let tvix_result \u003d eval.evaluate(expr, None);"},{"line_number":104,"context_line":"    for error in \u0026tvix_result.errors {"}],"source_content_type":"text/x-rustsrc","patch_set":1,"id":"9da2a8d4_edd602c6","line":101,"in_reply_to":"85295f1d_139edb91","updated":"2024-05-04 20:12:18.000000000","message":"Done","commit_id":"ad20ad169bf3afb8447fd0ad10b69a38f6b512d1"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"819160d1ceaacb3a07f9d950b41951a30610a874","unresolved":true,"context_lines":[{"line_number":1,"context_line":"//! Tests which use upstream nix as an oracle to test evaluation against"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"use std::{env, path::PathBuf, process::Command, rc::Rc, sync::Arc};"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"0def6e2f_6dcdb34b","line":1,"updated":"2024-05-05 08:00:04.000000000","message":"I don\u0027t quite get it. Shouldn\u0027t this (and the counterpart in tvix-eval) be expressed by the existing `.nix`/`.exp` mechanism, and the verification that the .exp on disk equals to what Nix produces covered by `verify-lang-tests/default.nix` (which would need to be extended to multiple test roots)?","commit_id":"949d281266dbf8753446114ce484eda715468da5"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"819160d1ceaacb3a07f9d950b41951a30610a874","unresolved":true,"context_lines":[{"line_number":143,"context_line":"}"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"compare_strict_eval_tests! {"},{"line_number":146,"context_line":"    // Wrap in a string since nix-instantiate formats store paths with quotes, but tvix does not."},{"line_number":147,"context_line":"    fetchurl_file(r#\"[ \"${(builtins.fetchurl \"file:///dev/null\")}\" ]\"#);"},{"line_number":148,"context_line":"}"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-rustsrc","patch_set":3,"id":"63dfec0a_da0f6db7","line":146,"updated":"2024-05-05 08:00:04.000000000","message":"Hmmh, I think the non-stable string output is one of the reasons why the testsuite uses XML format in some cases.\n\nIn cl/10687 (and following) I extended the test suite to actually compare these outputs - I\u0027d prefer this comparison to live there.","commit_id":"949d281266dbf8753446114ce484eda715468da5"}]}