)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"936441e4af0907f52acfe57f6290366e2b607a22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ae634396_cd964c27","updated":"2024-05-20 14:14:22.000000000","message":"Nice! Can you add a test case for the example from https://b.tvl.fyi/issues/399 into `eval/src/tests/tvix_tests/` ?\n\nWe probably only need a `eval-okay-xml-2.nix` containing an empty attrset, and a `eval-okay-xml-2.exp.xml` with the output from the bug.","commit_id":"d4ea12ba64220480e6731cf0963e5e05dfd0bd65"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"8257f75d2a55b3013225f9c7851a78e77f5a98f7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6ffd05ad_e425e551","in_reply_to":"16e5f1fd_75f2eb8f","updated":"2024-05-20 15:32:15.000000000","message":"You don\u0027t need to toXML directly, if there\u0027s a `.xml` file we can directly compare the XML representations - see the other two comments.","commit_id":"d4ea12ba64220480e6731cf0963e5e05dfd0bd65"},{"author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"change_message_id":"5200afcea579477534fa08a23b6daa0ae3102d8d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"16e5f1fd_75f2eb8f","in_reply_to":"193860f0_78f99217","updated":"2024-05-20 14:19:17.000000000","message":"I added it as `eval-okay-toxml-empty`","commit_id":"d4ea12ba64220480e6731cf0963e5e05dfd0bd65"},{"author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"change_message_id":"d7dddea2290183adca9df20ee5c4557a2b451979","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d2311adc_4af966f1","in_reply_to":"6ffd05ad_e425e551","updated":"2024-05-21 10:19:53.000000000","message":"Acknowledged","commit_id":"d4ea12ba64220480e6731cf0963e5e05dfd0bd65"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"92a66ea98c8e165e4e9499d3335212a41a61d849","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"193860f0_78f99217","in_reply_to":"ae634396_cd964c27","updated":"2024-05-20 14:14:32.000000000","message":"unresolved","commit_id":"d4ea12ba64220480e6731cf0963e5e05dfd0bd65"}],"tvix/eval/src/tests/nix_tests/eval-okay-toxml-empty.exp":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"8257f75d2a55b3013225f9c7851a78e77f5a98f7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\"\u003c?xml version\u003d\u00271.0\u0027 encoding\u003d\u0027utf-8\u0027?\u003e\\n\u003cexpr\u003e\\n  \u003cattrs\u003e\\n  \u003c/attrs\u003e\\n\u003c/expr\u003e\\n\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"183c1d5b_6010e3d0","line":1,"updated":"2024-05-20 15:32:15.000000000","message":"… and suffix this file with `.xml`","commit_id":"a9f2f8d1960b5bb0e4c2afdcffb477cf11f8928d"},{"author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"change_message_id":"d7dddea2290183adca9df20ee5c4557a2b451979","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\"\u003c?xml version\u003d\u00271.0\u0027 encoding\u003d\u0027utf-8\u0027?\u003e\\n\u003cexpr\u003e\\n  \u003cattrs\u003e\\n  \u003c/attrs\u003e\\n\u003c/expr\u003e\\n\""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ade52a82_550788c3","line":1,"in_reply_to":"183c1d5b_6010e3d0","updated":"2024-05-21 10:19:53.000000000","message":"Acknowledged","commit_id":"a9f2f8d1960b5bb0e4c2afdcffb477cf11f8928d"}],"tvix/eval/src/tests/nix_tests/eval-okay-toxml-empty.nix":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"8257f75d2a55b3013225f9c7851a78e77f5a98f7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"builtins.toXML { }"}],"source_content_type":"text/x-nix","patch_set":3,"id":"50fd30bd_8bb23093","line":1,"updated":"2024-05-20 15:32:15.000000000","message":"Just { }","commit_id":"a9f2f8d1960b5bb0e4c2afdcffb477cf11f8928d"},{"author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"change_message_id":"d7dddea2290183adca9df20ee5c4557a2b451979","unresolved":false,"context_lines":[{"line_number":1,"context_line":"builtins.toXML { }"}],"source_content_type":"text/x-nix","patch_set":3,"id":"0858b56f_ba873b07","line":1,"in_reply_to":"50fd30bd_8bb23093","updated":"2024-05-21 10:19:53.000000000","message":"\u003e Just { }\n\nI feel like it’s a bit confusing that the toXML is added implicitly, but I’ll concur.","commit_id":"a9f2f8d1960b5bb0e4c2afdcffb477cf11f8928d"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"34e90f8275bd7e53793e6ee8a16aae6feb7b6fc7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{ }"}],"source_content_type":"text/x-nix","patch_set":4,"id":"a544b13b_4d215822","line":1,"updated":"2024-05-21 13:09:10.000000000","message":"please add to tvix_tests, this is not coming from the nix test suite.","commit_id":"e6a9c05f57e80a148cb6dd67e0f5d353fc3a9039"},{"author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"change_message_id":"c04aa158b0236c1af5efe4d36a161fb5dcc4cf72","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{ }"}],"source_content_type":"text/x-nix","patch_set":4,"id":"617306fb_09c3a352","line":1,"in_reply_to":"a544b13b_4d215822","updated":"2024-05-21 14:58:28.000000000","message":"Done","commit_id":"e6a9c05f57e80a148cb6dd67e0f5d353fc3a9039"}],"tvix/eval/src/tests/nix_tests/eval-okay-toxml.exp":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"34e90f8275bd7e53793e6ee8a16aae6feb7b6fc7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\"\u003c?xml version\u003d\u00271.0\u0027 encoding\u003d\u0027utf-8\u0027?\u003e\\n\u003cexpr\u003e\\n  \u003cattrs\u003e\\n    \u003cattr name\u003d\\\"a\\\"\u003e\\n      \u003cstring value\u003d\\\"s\\\" /\u003e\\n    \u003c/attr\u003e\\n  \u003c/attrs\u003e\\n\u003c/expr\u003e\\n\""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"a5104d33_d994cde7","side":"PARENT","line":1,"updated":"2024-05-21 13:09:10.000000000","message":"This is `nix_tests`, which is coming from the nix test suite. please add your own additional test to tvix_tests.","commit_id":"d4978521b01e76b573f81d8c69e607cf6fdee986"},{"author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"change_message_id":"c04aa158b0236c1af5efe4d36a161fb5dcc4cf72","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\"\u003c?xml version\u003d\u00271.0\u0027 encoding\u003d\u0027utf-8\u0027?\u003e\\n\u003cexpr\u003e\\n  \u003cattrs\u003e\\n    \u003cattr name\u003d\\\"a\\\"\u003e\\n      \u003cstring value\u003d\\\"s\\\" /\u003e\\n    \u003c/attr\u003e\\n  \u003c/attrs\u003e\\n\u003c/expr\u003e\\n\""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"44d33c0f_b2eb49e7","side":"PARENT","line":1,"in_reply_to":"a5104d33_d994cde7","updated":"2024-05-21 14:58:28.000000000","message":"Done","commit_id":"d4978521b01e76b573f81d8c69e607cf6fdee986"}],"tvix/eval/src/tests/tvix_tests/eval-okay-toxml.nix":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"3583a4663e1547e34146dc7354b4b24eea360912","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Make sure the expected XML output is produced; in particular, make sure it"},{"line_number":2,"context_line":"# doesn\u0027t contain source location information."},{"line_number":3,"context_line":"builtins.toXML { a \u003d \"s\"; \"\u0026-{\" \u003d \";\u0026\\\"\"; }"}],"source_content_type":"text/x-nix","patch_set":6,"id":"eb3e9b5d_4b71173d","line":1,"updated":"2024-05-21 15:33:49.000000000","message":"what does this comment mean?","commit_id":"6a38247e96c979b5891a24b3b8eb74b3781843f7"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"ffa886913aa5fe99aaeb381f78a30ebd06841864","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Make sure the expected XML output is produced; in particular, make sure it"},{"line_number":2,"context_line":"# doesn\u0027t contain source location information."},{"line_number":3,"context_line":"builtins.toXML { a \u003d \"s\"; \"\u0026-{\" \u003d \";\u0026\\\"\"; }"}],"source_content_type":"text/x-nix","patch_set":6,"id":"239dfb2e_7e4f96e8","line":1,"in_reply_to":"64754cda_59717ba1","updated":"2024-05-22 10:26:04.000000000","message":"Done","commit_id":"6a38247e96c979b5891a24b3b8eb74b3781843f7"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"a36fb4178b3e69754f5392739f07ad501dbcdb31","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Make sure the expected XML output is produced; in particular, make sure it"},{"line_number":2,"context_line":"# doesn\u0027t contain source location information."},{"line_number":3,"context_line":"builtins.toXML { a \u003d \"s\"; \"\u0026-{\" \u003d \";\u0026\\\"\"; }"}],"source_content_type":"text/x-nix","patch_set":6,"id":"64754cda_59717ba1","line":1,"in_reply_to":"eb3e9b5d_4b71173d","updated":"2024-05-21 17:29:20.000000000","message":"Ah, the comment is just copied from `tvix/eval/src/tests/nix_tests/eval-okay-toxml.nix`, so it can be removed here. Or replaced with an explaination we actually test some escaping cases.","commit_id":"6a38247e96c979b5891a24b3b8eb74b3781843f7"}]}