)]}'
{"id":"depot~11698","triplet_id":"depot~canon~I884af4db61b5b251abed50dc51f3923823ef35e2","project":"depot","branch":"canon","attention_set":{"1000013":{"account":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"last_update":"2024-05-21 10:26:46.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I884af4db61b5b251abed50dc51f3923823ef35e2","subject":"fix(tvix/eval): make xml emitter not use call stack","status":"NEW","created":"2024-05-20 17:41:48.000000000","updated":"2024-06-06 10:23:58.000000000","submit_type":"REBASE_ALWAYS","submittable":false,"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"e60cc1c1b69167afc8182e9dff60e75fe3992f5f","_number":11698,"virtual_id_number":11698,"owner":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"rejected":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:buildkite~result","value":-1,"date":"2024-05-21 15:07:20.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0,"blocking":true},"Autosubmit":{"approved":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"all":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:newPatchSet","value":1,"date":"2024-05-21 15:00:44.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{},"Conformant-Commit-Message":{"approved":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-20 17:41:49.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-05-20 17:46:13.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-05-22 10:26:37.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2024-06-06 10:23:58.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REMOVED"}],"messages":[{"id":"2a2ae027157c47d4c53be9d46e5211674f736746","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2024-05-20 17:41:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"94d1bd0d984aff8f3fea1d06a961653351f12f9d","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-05-20 17:41:49.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/34237","accounts_in_message":[],"_revision_number":1},{"id":"f04447bbb9f7f837e806dca3eddfaeca5e93a825","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2024-05-20 17:42:58.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"e6c84e354f30f245392235d05f32e02bdfbcaf54","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2024-05-20 17:43:26.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"3902f38a9f9e50871c91aded445e8f2d2f5e135d","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-05-20 17:46:13.000000000","message":"Patch Set 1: Verified-1\n\nCopied votes on follow-up patch sets have been updated:\n* Verified-1 has been copied to patch set 2, 3 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\").\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/34237","accounts_in_message":[],"_revision_number":1},{"id":"473204558c5ef3ac2aab470a3ac47e3f67c6de2c","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2024-05-20 20:13:45.000000000","message":"Uploaded patch set 4.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":4},{"id":"e0f6af200f52199be7cf6f2e0e1f2b37b142aa09","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-05-20 20:13:46.000000000","message":"Patch Set 4:\n\nStarted build for patchset #4 on: https://buildkite.com/tvl/depot/builds/34238","accounts_in_message":[],"_revision_number":4},{"id":"4e66b1eed161f6a1e7869db61e84d6cf326c92c3","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-05-20 20:20:20.000000000","message":"Patch Set 4: Verified-1\n\nBuild of patchset 4 failed: https://buildkite.com/tvl/depot/builds/34238","accounts_in_message":[],"_revision_number":4},{"id":"aa71574ac026fe1a19bf74d61395adb3f658383e","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2024-05-20 21:23:23.000000000","message":"Patch Set 4:\n\n(1 comment)\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":4},{"id":"df09feb56b6f02832e702ec166f64dbd49b71373","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2024-05-21 10:19:34.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":5},{"id":"448842d276ca452138d1dbd8b60314ca41d5524b","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-05-21 10:19:36.000000000","message":"Patch Set 5:\n\nStarted build for patchset #5 on: https://buildkite.com/tvl/depot/builds/34240","accounts_in_message":[],"_revision_number":5},{"id":"71559324cef49084421a8a8b229ed0eb7a501add","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-05-21 10:26:46.000000000","message":"Patch Set 5: Verified-1\n\nBuild of patchset 5 failed: https://buildkite.com/tvl/depot/builds/34240","accounts_in_message":[],"_revision_number":5},{"id":"fd8fb785a0aef1c41f908ac7809446a8d5753a88","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2024-05-21 14:58:19.000000000","message":"Uploaded patch set 6: Autosubmit+1: Patch Set 5 was rebased.\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":6},{"id":"d6c2b839d660217adbda2d64827737b84df6633d","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-05-21 14:58:20.000000000","message":"Patch Set 6:\n\nStarted build for patchset #6 on: https://buildkite.com/tvl/depot/builds/34242","accounts_in_message":[],"_revision_number":6},{"id":"c3045b147b3dcea5ec17070fe1428b2a858ab2b4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"date":"2024-05-21 15:00:44.000000000","message":"Uploaded patch set 7: Patch Set 6 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n","accounts_in_message":[],"_revision_number":7},{"id":"fa3c85744a55c32b975e631102e1a66b2ca7ef04","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-05-21 15:00:47.000000000","message":"Patch Set 7:\n\nStarted build for patchset #7 on: https://buildkite.com/tvl/depot/builds/34244","accounts_in_message":[],"_revision_number":7},{"id":"7aaecc31b8cc5eacaedab3a5ac9d8df0b66b8dda","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-05-21 15:07:20.000000000","message":"Patch Set 7: Verified-1\n\nBuild of patchset 7 failed: https://buildkite.com/tvl/depot/builds/34244","accounts_in_message":[],"_revision_number":7},{"id":"9eda5665eac6111802284e635c9649c140beebee","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-05-22 10:26:37.000000000","message":"Patch Set 7: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":7},{"id":"e60cc1c1b69167afc8182e9dff60e75fe3992f5f","tag":"autogenerated:gerrit:deleteReviewer","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-06-06 10:23:58.000000000","message":"Removed reviewer \u003cGERRIT_ACCOUNT_1000036\u003e with the following votes:\n\n* Code-Review-2 by \u003cGERRIT_ACCOUNT_1000036\u003e\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":7}],"current_revision_number":7,"current_revision":"e2edda9024dba0323ed2abc12a04ae11b5b670d9","revisions":{"fec0ee6d4e271166358018ae4480b451376db276":{"kind":"REWORK","_number":1,"created":"2024-05-20 17:41:48.000000000","uploader":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"ref":"refs/changes/98/11698/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/11698/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/11698/1"}}},"commit":{"parents":[{"commit":"a9f2f8d1960b5bb0e4c2afdcffb477cf11f8928d","subject":"refact(tvix/eval): rewrite xml emitter to be simple-stupid","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da9f2f8d1960b5bb0e4c2afdcffb477cf11f8928d"}]}],"author":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2024-05-20 17:41:22.000000000","tz":120},"committer":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2024-05-20 17:41:22.000000000","tz":120},"subject":"fix(tvix/eval): make xml emitter not use call stack","message":"fix(tvix/eval): make xml emitter not use call stack\n\nWIP\n\nChange-Id: I884af4db61b5b251abed50dc51f3923823ef35e2\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfec0ee6d4e271166358018ae4480b451376db276"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dfec0ee6d4e271166358018ae4480b451376db276"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a9f2f8d1960b5bb0e4c2afdcffb477cf11f8928d","is_merged_in_target_branch":false,"change_id":"If4d407d324864b3bb9aa3160e2ec6889f7727127","change_number":11697,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"b267cac77f03bc5185e6942d15a85ff313ed1d31":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-05-20 17:42:58.000000000","uploader":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"ref":"refs/changes/98/11698/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/11698/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/11698/2"}}},"commit":{"parents":[{"commit":"a9f2f8d1960b5bb0e4c2afdcffb477cf11f8928d","subject":"refact(tvix/eval): rewrite xml emitter to be simple-stupid","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da9f2f8d1960b5bb0e4c2afdcffb477cf11f8928d"}]}],"author":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2024-05-20 17:41:22.000000000","tz":120},"committer":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2024-05-20 17:42:15.000000000","tz":120},"subject":"fix(tvix/eval): make xml emitter not use call stack","message":"fix(tvix/eval): make xml emitter not use call stack\n\nWIP\n\nIdea: instead of recursing in the function, return a list of what to\ndo and then loop over it.\n\nProblem: lifetime of Value\n\nChange-Id: I884af4db61b5b251abed50dc51f3923823ef35e2\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db267cac77f03bc5185e6942d15a85ff313ed1d31"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003db267cac77f03bc5185e6942d15a85ff313ed1d31"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a9f2f8d1960b5bb0e4c2afdcffb477cf11f8928d","is_merged_in_target_branch":false,"change_id":"If4d407d324864b3bb9aa3160e2ec6889f7727127","change_number":11697,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"f092c6ae906740373afc0f75e796097f50662636":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2024-05-20 17:43:26.000000000","uploader":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"ref":"refs/changes/98/11698/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/11698/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/11698/3"}}},"commit":{"parents":[{"commit":"a9f2f8d1960b5bb0e4c2afdcffb477cf11f8928d","subject":"refact(tvix/eval): rewrite xml emitter to be simple-stupid","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da9f2f8d1960b5bb0e4c2afdcffb477cf11f8928d"}]}],"author":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2024-05-20 17:41:22.000000000","tz":120},"committer":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2024-05-20 17:43:18.000000000","tz":120},"subject":"fix(tvix/eval): make xml emitter not use call stack","message":"fix(tvix/eval): make xml emitter not use call stack\n\nWIP\n\nIdea: instead of recursing in the function, return a list of what to\ndo and then loop over it.\n\nProblem: lifetime of Value\n\nFixes: https://b.tvl.fyi/issues/397\nChange-Id: I884af4db61b5b251abed50dc51f3923823ef35e2\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df092c6ae906740373afc0f75e796097f50662636"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003df092c6ae906740373afc0f75e796097f50662636"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a9f2f8d1960b5bb0e4c2afdcffb477cf11f8928d","is_merged_in_target_branch":false,"change_id":"If4d407d324864b3bb9aa3160e2ec6889f7727127","change_number":11697,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"78d0da028e61ea80c73edf328d231d486743bfc2":{"kind":"REWORK","_number":4,"created":"2024-05-20 20:13:45.000000000","uploader":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"ref":"refs/changes/98/11698/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/11698/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/11698/4"}}},"commit":{"parents":[{"commit":"a9f2f8d1960b5bb0e4c2afdcffb477cf11f8928d","subject":"refact(tvix/eval): rewrite xml emitter to be simple-stupid","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003da9f2f8d1960b5bb0e4c2afdcffb477cf11f8928d"}]}],"author":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2024-05-20 17:41:22.000000000","tz":120},"committer":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2024-05-20 20:13:41.000000000","tz":120},"subject":"fix(tvix/eval): make xml emitter not use call stack","message":"fix(tvix/eval): make xml emitter not use call stack\n\nWIP\n\nIdea: instead of recursing in the function, return a list of what to\ndo and then loop over it.\n\nProblem: lifetime of Value\n\nFixes: https://b.tvl.fyi/issues/397\nChange-Id: I884af4db61b5b251abed50dc51f3923823ef35e2\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d78d0da028e61ea80c73edf328d231d486743bfc2"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d78d0da028e61ea80c73edf328d231d486743bfc2"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"a9f2f8d1960b5bb0e4c2afdcffb477cf11f8928d","is_merged_in_target_branch":false,"change_id":"If4d407d324864b3bb9aa3160e2ec6889f7727127","change_number":11697,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"437d6b70525088df15279832c681c6c288204e2f":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2024-05-21 10:19:34.000000000","uploader":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"ref":"refs/changes/98/11698/5","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/11698/5","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/11698/5"}}},"commit":{"parents":[{"commit":"e6a9c05f57e80a148cb6dd67e0f5d353fc3a9039","subject":"refact(tvix/eval): rewrite xml emitter to be simple-stupid","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de6a9c05f57e80a148cb6dd67e0f5d353fc3a9039"}]}],"author":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2024-05-20 17:41:22.000000000","tz":120},"committer":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2024-05-21 10:19:30.000000000","tz":120},"subject":"fix(tvix/eval): make xml emitter not use call stack","message":"fix(tvix/eval): make xml emitter not use call stack\n\nWIP\n\nIdea: instead of recursing in the function, return a list of what to\ndo and then loop over it.\n\nProblem: lifetime of Value\n\nFixes: https://b.tvl.fyi/issues/397\nChange-Id: I884af4db61b5b251abed50dc51f3923823ef35e2\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d437d6b70525088df15279832c681c6c288204e2f"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d437d6b70525088df15279832c681c6c288204e2f"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"e6a9c05f57e80a148cb6dd67e0f5d353fc3a9039","is_merged_in_target_branch":false,"change_id":"If4d407d324864b3bb9aa3160e2ec6889f7727127","change_number":11697,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"32585961975e1a894a961616666692107125fddb":{"kind":"TRIVIAL_REBASE","_number":6,"created":"2024-05-21 14:58:19.000000000","uploader":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"ref":"refs/changes/98/11698/6","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/11698/6","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/11698/6"}}},"commit":{"parents":[{"commit":"9a6953a73b737c1915e3312ff3d2e60061b8558f","subject":"refact(tvix/eval): rewrite xml emitter to be simple-stupid","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9a6953a73b737c1915e3312ff3d2e60061b8558f"}]}],"author":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2024-05-20 17:41:22.000000000","tz":120},"committer":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2024-05-21 14:58:16.000000000","tz":120},"subject":"fix(tvix/eval): make xml emitter not use call stack","message":"fix(tvix/eval): make xml emitter not use call stack\n\nWIP\n\nIdea: instead of recursing in the function, return a list of what to\ndo and then loop over it.\n\nProblem: lifetime of Value\n\nFixes: https://b.tvl.fyi/issues/397\nChange-Id: I884af4db61b5b251abed50dc51f3923823ef35e2\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d32585961975e1a894a961616666692107125fddb"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d32585961975e1a894a961616666692107125fddb"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"9a6953a73b737c1915e3312ff3d2e60061b8558f","is_merged_in_target_branch":false,"change_id":"If4d407d324864b3bb9aa3160e2ec6889f7727127","change_number":11697,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"e2edda9024dba0323ed2abc12a04ae11b5b670d9":{"kind":"TRIVIAL_REBASE","_number":7,"created":"2024-05-21 15:00:44.000000000","uploader":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"},"ref":"refs/changes/98/11698/7","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/98/11698/7","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/98/11698/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/98/11698/7"}}},"commit":{"parents":[{"commit":"6a38247e96c979b5891a24b3b8eb74b3781843f7","subject":"refact(tvix/eval): rewrite xml emitter to be simple-stupid","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d6a38247e96c979b5891a24b3b8eb74b3781843f7"}]}],"author":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2024-05-20 17:41:22.000000000","tz":120},"committer":{"name":"Profpatsch","email":"mail@profpatsch.de","date":"2024-05-21 15:00:42.000000000","tz":120},"subject":"fix(tvix/eval): make xml emitter not use call stack","message":"fix(tvix/eval): make xml emitter not use call stack\n\nWIP\n\nIdea: instead of recursing in the function, return a list of what to\ndo and then loop over it.\n\nProblem: lifetime of Value\n\nFixes: https://b.tvl.fyi/issues/397\nChange-Id: I884af4db61b5b251abed50dc51f3923823ef35e2\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de2edda9024dba0323ed2abc12a04ae11b5b670d9"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003de2edda9024dba0323ed2abc12a04ae11b5b670d9"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"6a38247e96c979b5891a24b3b8eb74b3781843f7","is_merged_in_target_branch":false,"change_id":"If4d407d324864b3bb9aa3160e2ec6889f7727127","change_number":11697,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[{"status":"NOT_READY","fallback_text":"Code-Owners","type":"code-owners"}],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"NOT_READY","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000013,"name":"Profpatsch","email":"mail@profpatsch.de","username":"Profpatsch"}},{"label":"All-Comments-Resolved","status":"NEED"},{"label":"Verified","status":"REJECT","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"NEED"}]},{"rule_name":"Code-Owners","status":"NOT_READY","requirements":[{"status":"NOT_READY","fallback_text":"Code-Owners","type":"code-owners"}]}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"]}},{"name":"Verified","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dgerrit~PrologRule"]}},{"name":"Code-Owners","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["Code-Owners"]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dgerrit~PrologRule"]}}]}