)]}'
{"id":"depot~11712","triplet_id":"depot~canon~Ie84d26fb0d4b59e68354891ba13bde3bae40ab6e","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000005":{"account":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"last_update":"2024-05-25 08:42:32.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-05-25 06:33:24.000000000","reason":"removed on reply"}},"hashtags":[],"change_id":"Ie84d26fb0d4b59e68354891ba13bde3bae40ab6e","subject":"fix(tvix/eval): disallow empty but allocated string contexts","status":"MERGED","created":"2024-05-25 04:31:25.000000000","updated":"2024-05-25 08:42:32.000000000","submitted":"2024-05-25 08:42:32.000000000","submitter":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"11712","meta_rev_id":"204d0b34d955da3d7e97890ee2e9eae62f126467","_number":11712,"virtual_id_number":11712,"owner":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-05-25 08:42:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-05-25 08:42:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"all":[{"value":0,"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"}],"REVIEWER":[{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-25 04:31:25.000000000","updated_by":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"reviewer":{"_account_id":1000082,"name":"Brian Olsen","display_name":"griff","email":"me@griff.name","username":"griff"},"state":"CC"},{"updated":"2024-05-25 04:31:25.000000000","updated_by":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"reviewer":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"state":"REVIEWER"},{"updated":"2024-05-25 04:31:26.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-05-25 04:38:08.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"288bb853d94fc0f2552443587727bc508f2c08c7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2024-05-25 04:31:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9c8c2fec271b8fc8dca1c79793b790df2b1aaeb4","tag":"autogenerated:gerrit:code-owners:addReviewer","author":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2024-05-25 04:31:25.000000000","message":"\u003cGERRIT_ACCOUNT_1000036\u003e, who was added as reviewer owns the following files:\n* `tvix/eval/src/value/string.rs`\n","accounts_in_message":[{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}],"_revision_number":1},{"id":"c97f9db3e31211f8e2aae667ebc661512291799e","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-05-25 04:31:26.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/34267","accounts_in_message":[],"_revision_number":1},{"id":"14f5705643b47eb5e2fa64670f3bcd902d865597","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2024-05-25 04:32:02.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"ae4a686011ddc88b4575a10aff0754e3d3f23e33","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-05-25 04:38:08.000000000","message":"Patch Set 1: Verified+1\n\nCopied votes on follow-up patch sets have been updated:\n* Verified+1 has been copied to patch set 2 (copy condition: \"(is:ANY AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\").\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/34267","accounts_in_message":[],"_revision_number":1},{"id":"ada12e46c367f6544b3ee32fb3a2d557fa3ac302","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-05-25 06:33:24.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"204d0b34d955da3d7e97890ee2e9eae62f126467","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"date":"2024-05-25 08:42:32.000000000","message":"Change has been successfully rebased and submitted as 49750fa1e7e307a323e22f4f0d98ad2dc88d78bf","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"49750fa1e7e307a323e22f4f0d98ad2dc88d78bf","revisions":{"30fda19b05183680108bcba2ae1c36eae9b3f00f":{"kind":"REWORK","_number":1,"created":"2024-05-25 04:31:25.000000000","uploader":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"ref":"refs/changes/12/11712/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/12/11712/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/12/11712/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/12/11712/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/12/11712/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/12/11712/1"}}},"commit":{"parents":[{"commit":"c4c42c8b6c064b8b1a30632034948de07cbef305","subject":"docs(tvix/docs/TODO): add item for string context rework","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc4c42c8b6c064b8b1a30632034948de07cbef305"}]}],"author":{"name":"edef","email":"edef@edef.eu","date":"2024-05-25 04:24:59.000000000","tz":0},"committer":{"name":"edef","email":"edef@edef.eu","date":"2024-05-25 04:24:59.000000000","tz":0},"subject":"fix(tvix/eval): disallow empty but allocated string contexts","message":"fix(tvix/eval): disallow empty but allocated string contexts\n\nBoth `Some(NixContext::new())` and `None` represent empty contexts, but\nthe former trips up `NixString::has_context`, and seems likely to trip\nup other things.\n\nWe could hide the difference in the accessors, but we don\u0027t really\n*want* the distinction to exist, since heap-allocating a null value\nis pretty much always a mistake.\n\nChange-Id: Ie84d26fb0d4b59e68354891ba13bde3bae40ab6e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d30fda19b05183680108bcba2ae1c36eae9b3f00f"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d30fda19b05183680108bcba2ae1c36eae9b3f00f"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c4c42c8b6c064b8b1a30632034948de07cbef305","is_merged_in_target_branch":true,"change_id":"I4592490a75fb05093b3fd8649db3b57bff748c0d","change_number":11707,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"de481d3221c5cf272f7cf8f7c8522fcdf06bcf4d":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2024-05-25 04:32:02.000000000","uploader":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"ref":"refs/changes/12/11712/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/12/11712/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/12/11712/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/12/11712/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/12/11712/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/12/11712/2"}}},"commit":{"parents":[{"commit":"c4c42c8b6c064b8b1a30632034948de07cbef305","subject":"docs(tvix/docs/TODO): add item for string context rework","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc4c42c8b6c064b8b1a30632034948de07cbef305"}]}],"author":{"name":"edef","email":"edef@edef.eu","date":"2024-05-25 04:24:59.000000000","tz":0},"committer":{"name":"edef","email":"edef@edef.eu","date":"2024-05-25 04:31:46.000000000","tz":0},"subject":"fix(tvix/eval): disallow empty but allocated string contexts","message":"fix(tvix/eval): disallow empty but allocated string contexts\n\nBoth `Some(NixContext::new())` and `None` represent empty contexts,\nbut the former trips up `NixString::has_context`, and seems likely\nto trip up other things.\n\nWe could hide the difference in the accessors, but we don\u0027t really\n*want* the distinction to exist, since heap-allocating a null value\nis pretty much always a mistake.\n\nChange-Id: Ie84d26fb0d4b59e68354891ba13bde3bae40ab6e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dde481d3221c5cf272f7cf8f7c8522fcdf06bcf4d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dde481d3221c5cf272f7cf8f7c8522fcdf06bcf4d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c4c42c8b6c064b8b1a30632034948de07cbef305","is_merged_in_target_branch":true,"change_id":"I4592490a75fb05093b3fd8649db3b57bff748c0d","change_number":11707,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"49750fa1e7e307a323e22f4f0d98ad2dc88d78bf":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2024-05-25 08:42:32.000000000","uploader":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"},"ref":"refs/changes/12/11712/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/12/11712/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/12/11712/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/12/11712/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/12/11712/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/12/11712/3"}}},"commit":{"parents":[{"commit":"c4c42c8b6c064b8b1a30632034948de07cbef305","subject":"docs(tvix/docs/TODO): add item for string context rework","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dc4c42c8b6c064b8b1a30632034948de07cbef305"}]}],"author":{"name":"edef","email":"edef@edef.eu","date":"2024-05-25 04:24:59.000000000","tz":0},"committer":{"name":"edef","email":"edef@edef.eu","date":"2024-05-25 08:42:32.000000000","tz":0},"subject":"fix(tvix/eval): disallow empty but allocated string contexts","message":"fix(tvix/eval): disallow empty but allocated string contexts\n\nBoth `Some(NixContext::new())` and `None` represent empty contexts,\nbut the former trips up `NixString::has_context`, and seems likely\nto trip up other things.\n\nWe could hide the difference in the accessors, but we don\u0027t really\n*want* the distinction to exist, since heap-allocating a null value\nis pretty much always a mistake.\n\nChange-Id: Ie84d26fb0d4b59e68354891ba13bde3bae40ab6e\nReviewed-on: https://cl.tvl.fyi/c/depot/+/11712\nTested-by: BuildkiteCI\nReviewed-by: flokli \u003cflokli@flokli.de\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d49750fa1e7e307a323e22f4f0d98ad2dc88d78bf"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d49750fa1e7e307a323e22f4f0d98ad2dc88d78bf"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"c4c42c8b6c064b8b1a30632034948de07cbef305","is_merged_in_target_branch":true,"change_id":"I4592490a75fb05093b3fd8649db3b57bff748c0d","change_number":11707,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000005,"name":"edef","email":"edef@edef.eu","username":"edef"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}