)]}'
{"id":"depot~11715","triplet_id":"depot~canon~I8fbbad3e4457e326bdfd171aa5c43d25d3187b5b","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000085":{"account":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"last_update":"2024-05-26 19:46:47.000000000","reason":"Change was submitted"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-05-26 19:46:47.000000000","reason":"Change was submitted"},"1000090":{"account":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"last_update":"2024-05-26 19:46:47.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I8fbbad3e4457e326bdfd171aa5c43d25d3187b5b","subject":"refactor(tvix/castore): move src/fs/test into fuse mod","status":"MERGED","created":"2024-05-26 14:25:10.000000000","updated":"2024-05-26 19:46:47.000000000","submitted":"2024-05-26 19:46:47.000000000","submitter":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"11716","meta_rev_id":"441ac319f91010bc35c94fc3c570ede77d3025d8","_number":11715,"virtual_id_number":11715,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-05-26 19:46:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-05-26 19:46:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-05-26 19:46:47.000000000","_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"}],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-05-26 14:25:10.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"state":"REVIEWER"},{"updated":"2024-05-26 14:25:10.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"state":"REVIEWER"},{"updated":"2024-05-26 14:25:11.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-05-26 14:33:03.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-05-26 19:46:18.000000000","updated_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"reviewer":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"state":"REVIEWER"},{"updated":"2024-05-26 19:46:47.000000000","updated_by":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d3351ffa97d0dfa1a9bfbe08245cc771a088220f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-05-26 14:25:10.000000000","message":"Uploaded patch set 1: Autosubmit+1.","accounts_in_message":[],"_revision_number":1},{"id":"85a987c2aa7454b0a301291912a6d221cc144032","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-05-26 14:25:11.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/34274","accounts_in_message":[],"_revision_number":1},{"id":"b66b1213241c59e0d8bcd783fe3e7889b1a07405","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-05-26 14:33:03.000000000","message":"Patch Set 1: Verified-1\n\nBuild of patchset 1 failed: https://buildkite.com/tvl/depot/builds/34274","accounts_in_message":[],"_revision_number":1},{"id":"4320ef42e9349c99ec8173af6a85b96c10510f7e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-05-26 14:34:47.000000000","message":"Uploaded patch set 2.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n\nOutdated Votes:\n* Verified-1 (copy condition: \"(**is:ANY** AND changekind:NO_CODE_CHANGE) OR changekind:NO_CHANGE\")\n","accounts_in_message":[],"_revision_number":2},{"id":"6664972376561e9dae96ade72b465f055297de18","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-05-26 14:34:48.000000000","message":"Patch Set 2:\n\nStarted build for patchset #2 on: https://buildkite.com/tvl/depot/builds/34276","accounts_in_message":[],"_revision_number":2},{"id":"1a92bdb85936a5063eddffa6dcdd0fc8bdd317a2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-05-26 14:35:18.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.\n\nCopied Votes:\n* Autosubmit+1 (copy condition: \"changekind:NO_CHANGE OR **is:ANY**\")\n","accounts_in_message":[],"_revision_number":3},{"id":"fe3a4d303dec7fea65f424cdf9202b95cb931555","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-05-26 14:35:18.000000000","message":"Patch Set 3:\n\nStarted build for patchset #3 on: https://buildkite.com/tvl/depot/builds/34277","accounts_in_message":[],"_revision_number":3},{"id":"3493bb2ca9bd58237f84a0678edd03071de82963","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-05-26 14:42:37.000000000","message":"Patch Set 3: Verified+1\n\nBuild of patchset 3 passed: https://buildkite.com/tvl/depot/builds/34277","accounts_in_message":[],"_revision_number":3},{"id":"822fd6bb92e0135d077e1a758c4ea03241d04ff2","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2024-05-26 19:46:18.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"441ac319f91010bc35c94fc3c570ede77d3025d8","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"date":"2024-05-26 19:46:47.000000000","message":"Change has been successfully rebased and submitted as 9586e5c30da23dd25d404d075a64161689f8cc02","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"9586e5c30da23dd25d404d075a64161689f8cc02","revisions":{"bb53d498f6dacba1609ca58a6a29c0c20c0aaf4a":{"kind":"REWORK","_number":1,"created":"2024-05-26 14:25:10.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/15/11715/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/15/11715/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/15/11715/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/15/11715/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/15/11715/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/15/11715/1"}}},"commit":{"parents":[{"commit":"edd93b19628e655c5903dd79393e6387b23b8168","subject":"fix(tvix/eval): drop superfluous string context check","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dedd93b19628e655c5903dd79393e6387b23b8168"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-05-26 14:21:48.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-05-26 14:24:47.000000000","tz":120},"subject":"refactor(tvix/castore): move src/fs/test into fuse mod","message":"refactor(tvix/castore): move src/fs/test into fuse mod\n\nThese tests only interact with the FUSE layer, and\nimport super::fuse to do its work.\n\nHowever, this only works if the `fuse` feature is enabled, which we\ndon\u0027t do if we enable the `virtiofs` feature only, causing the tests\nto fail:\n\n```\n❯ cargo test --no-default-features --features virtiofs\n   Compiling tvix-castore v0.1.0 (/home/flokli/dev/nixos/code.tvl.fyi-submit2/tvix/castore)\nerror[E0432]: unresolved import `super::fuse`\n  --\u003e castore/src/fs/tests.rs:14:13\n   |\n14 | use super::{fuse::FuseDaemon, TvixStoreFs};\n   |             ^^^^ could not find `fuse` in `super`\n```\n\nWe move src/fs/tests.rs to src/fs/fuse/tests.rs\n(and src/fs/fuse.rs to src/fs/fuse/mod.rs) to better structure this,\nwhich will automatically cause both tests and code to only be built if\nwe have the `fuse` feature enabled.\n\nChange-Id: I8fbbad3e4457e326bdfd171aa5c43d25d3187b5b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbb53d498f6dacba1609ca58a6a29c0c20c0aaf4a"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dbb53d498f6dacba1609ca58a6a29c0c20c0aaf4a"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"edd93b19628e655c5903dd79393e6387b23b8168","is_merged_in_target_branch":true,"change_id":"I41a655ff33910e8326cbb7d7526eb91bd19e9585","change_number":11713,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"ee8e7dee9ea98b1d30077ddbb1ae112192af48a6":{"kind":"REWORK","_number":2,"created":"2024-05-26 14:34:47.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/15/11715/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/15/11715/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/15/11715/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/15/11715/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/15/11715/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/15/11715/2"}}},"commit":{"parents":[{"commit":"edd93b19628e655c5903dd79393e6387b23b8168","subject":"fix(tvix/eval): drop superfluous string context check","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dedd93b19628e655c5903dd79393e6387b23b8168"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-05-26 14:21:48.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-05-26 14:34:37.000000000","tz":120},"subject":"refactor(tvix/castore): move src/fs/test into fuse mod","message":"refactor(tvix/castore): move src/fs/test into fuse mod\n\nThese tests only interact with the FUSE layer, and\nimport super::fuse to do its work.\n\nHowever, this only works if the `fuse` feature is enabled, which we\ndon\u0027t do if we enable the `virtiofs` feature only, causing the tests\nto fail:\n\n```\n❯ cargo test --no-default-features --features virtiofs\n   Compiling tvix-castore v0.1.0 (/home/flokli/dev/nixos/code.tvl.fyi-submit2/tvix/castore)\nerror[E0432]: unresolved import `super::fuse`\n  --\u003e castore/src/fs/tests.rs:14:13\n   |\n14 | use super::{fuse::FuseDaemon, TvixStoreFs};\n   |             ^^^^ could not find `fuse` in `super`\n```\n\nWe move src/fs/tests.rs to src/fs/fuse/tests.rs\n(and src/fs/fuse.rs to src/fs/fuse/mod.rs) to better structure this,\nwhich will automatically cause both tests and code to only be built if\nwe have the `fuse` feature enabled.\n\nChange-Id: I8fbbad3e4457e326bdfd171aa5c43d25d3187b5b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dee8e7dee9ea98b1d30077ddbb1ae112192af48a6"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dee8e7dee9ea98b1d30077ddbb1ae112192af48a6"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"edd93b19628e655c5903dd79393e6387b23b8168","is_merged_in_target_branch":true,"change_id":"I41a655ff33910e8326cbb7d7526eb91bd19e9585","change_number":11713,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"80429d26ea080553c4fc9141e45d4f54a5babae4":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2024-05-26 14:35:18.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/15/11715/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/15/11715/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/15/11715/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/15/11715/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/15/11715/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/15/11715/3"}}},"commit":{"parents":[{"commit":"3ebcf30b64038198f82db4ffd109f2a0af3e0cf7","subject":"feat(tvix): filter src via lib.fileset","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3ebcf30b64038198f82db4ffd109f2a0af3e0cf7"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-05-26 14:21:48.000000000","tz":120},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-05-26 14:35:06.000000000","tz":120},"subject":"refactor(tvix/castore): move src/fs/test into fuse mod","message":"refactor(tvix/castore): move src/fs/test into fuse mod\n\nThese tests only interact with the FUSE layer, and\nimport super::fuse to do its work.\n\nHowever, this only works if the `fuse` feature is enabled, which we\ndon\u0027t do if we enable the `virtiofs` feature only, causing the tests\nto fail:\n\n```\n❯ cargo test --no-default-features --features virtiofs\n   Compiling tvix-castore v0.1.0 (/home/flokli/dev/nixos/code.tvl.fyi-submit2/tvix/castore)\nerror[E0432]: unresolved import `super::fuse`\n  --\u003e castore/src/fs/tests.rs:14:13\n   |\n14 | use super::{fuse::FuseDaemon, TvixStoreFs};\n   |             ^^^^ could not find `fuse` in `super`\n```\n\nWe move src/fs/tests.rs to src/fs/fuse/tests.rs\n(and src/fs/fuse.rs to src/fs/fuse/mod.rs) to better structure this,\nwhich will automatically cause both tests and code to only be built if\nwe have the `fuse` feature enabled.\n\nChange-Id: I8fbbad3e4457e326bdfd171aa5c43d25d3187b5b\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d80429d26ea080553c4fc9141e45d4f54a5babae4"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d80429d26ea080553c4fc9141e45d4f54a5babae4"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"3ebcf30b64038198f82db4ffd109f2a0af3e0cf7","is_merged_in_target_branch":true,"change_id":"I7ab5a0064a76938d14f7f65801be9f3a5c3bad04","change_number":11714,"patch_set_number":4,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"9586e5c30da23dd25d404d075a64161689f8cc02":{"kind":"REWORK","_number":4,"created":"2024-05-26 19:46:47.000000000","uploader":{"_account_id":1000015,"name":"clbot","email":"clbot@tvl.fyi","username":"clbot","tags":["SERVICE_USER"]},"ref":"refs/changes/15/11715/4","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/15/11715/4","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/15/11715/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/15/11715/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/15/11715/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/15/11715/4"}}},"commit":{"parents":[{"commit":"61cf4905fe4ad01b87c0251d7a90426b7b0ea3bc","subject":"feat(ops/modules): launch teleirc for Volga Sprint","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d61cf4905fe4ad01b87c0251d7a90426b7b0ea3bc"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-05-26 14:21:48.000000000","tz":120},"committer":{"name":"clbot","email":"clbot@tvl.fyi","date":"2024-05-26 19:46:47.000000000","tz":0},"subject":"refactor(tvix/castore): move src/fs/test into fuse mod","message":"refactor(tvix/castore): move src/fs/test into fuse mod\n\nThese tests only interact with the FUSE layer, and\nimport super::fuse to do its work.\n\nHowever, this only works if the `fuse` feature is enabled, which we\ndon\u0027t do if we enable the `virtiofs` feature only, causing the tests\nto fail:\n\n```\n❯ cargo test --no-default-features --features virtiofs\n   Compiling tvix-castore v0.1.0 (/home/flokli/dev/nixos/code.tvl.fyi-submit2/tvix/castore)\nerror[E0432]: unresolved import `super::fuse`\n  --\u003e castore/src/fs/tests.rs:14:13\n   |\n14 | use super::{fuse::FuseDaemon, TvixStoreFs};\n   |             ^^^^ could not find `fuse` in `super`\n```\n\nWe move src/fs/tests.rs to src/fs/fuse/tests.rs\n(and src/fs/fuse.rs to src/fs/fuse/mod.rs) to better structure this,\nwhich will automatically cause both tests and code to only be built if\nwe have the `fuse` feature enabled.\n\nChange-Id: I8fbbad3e4457e326bdfd171aa5c43d25d3187b5b\nReviewed-on: https://cl.tvl.fyi/c/depot/+/11715\nAutosubmit: flokli \u003cflokli@flokli.de\u003e\nTested-by: BuildkiteCI\nReviewed-by: tazjin \u003ctazjin@tvl.su\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9586e5c30da23dd25d404d075a64161689f8cc02"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d9586e5c30da23dd25d404d075a64161689f8cc02"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"61cf4905fe4ad01b87c0251d7a90426b7b0ea3bc","is_merged_in_target_branch":true,"change_id":"I6d5b1316fc85ddd26adf55e31f6bff742907fc24","change_number":11727,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}