)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"891039f085a8d08459b32b9ad9f329151e3075da","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-05-26 20:03:34 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I966dde1413d057770787da3296cce9c1924570e0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fad4f7ca_dc73b2ab","line":8,"updated":"2024-05-26 17:12:03.000000000","message":"needs a commit message, and link to the bug it fixes.","commit_id":"e42426d2ef7eb13da5d4e041803d8e3a97f4d273"},{"author":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"change_message_id":"971274395037441142dc8e1488297722a5f73f50","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-05-26 20:03:34 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I966dde1413d057770787da3296cce9c1924570e0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f48a4df7_05346fc3","line":8,"in_reply_to":"a508326b_e3641565","updated":"2024-06-03 16:23:07.000000000","message":"Done","commit_id":"e42426d2ef7eb13da5d4e041803d8e3a97f4d273"},{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"a8b4f07a7bbffd6ffffd636ca1f8d3aeb34f257c","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2024-05-26 20:03:34 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I966dde1413d057770787da3296cce9c1924570e0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a508326b_e3641565","line":8,"in_reply_to":"fad4f7ca_dc73b2ab","updated":"2024-05-26 17:22:55.000000000","message":"please also add a small note to the docs explaining the crate2nix process that whenever a new feature is introduced these lists might need updating.","commit_id":"e42426d2ef7eb13da5d4e041803d8e3a97f4d273"}],"tvix/castore/default.nix":[{"author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"change_message_id":"891039f085a8d08459b32b9ad9f329151e3075da","unresolved":true,"context_lines":[{"line_number":10,"context_line":"  features \u003d [ \"default\" \"cloud\" ];"},{"line_number":11,"context_line":"}).overrideAttrs (_: {"},{"line_number":12,"context_line":"  meta.ci.targets \u003d [ \"integration-tests\" ];"},{"line_number":13,"context_line":"  passthru.integration-tests \u003d depot.tvix.crates.workspaceMembers.tvix-castore.build.override {"},{"line_number":14,"context_line":"    runTests \u003d true;"},{"line_number":15,"context_line":"    testPreRun \u003d \u0027\u0027"},{"line_number":16,"context_line":"      export SSL_CERT_FILE\u003d${pkgs.cacert}/etc/ssl/certs/ca-bundle.crt;"}],"source_content_type":"text/x-nix","patch_set":1,"id":"94f3c35d_1d2a4cf0","side":"PARENT","line":13,"updated":"2024-05-26 17:12:03.000000000","message":"This (and the one in store) is the only place where this should be called integration-tests, because we add the `integration` feature to an additional build, which pulls in some tests requiring simulators.\n\nPlease call the other places differently (feature-permutations?), and keep the integration one a separate passthrough. That feature doesn\u0027t need to be part of the permutations.","commit_id":"cf190ff30c5230d329b5e64553c7a87c9567d8fb"},{"author":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"change_message_id":"a41609d57b6b548673b0c564837aa3ccb7197aa4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  features \u003d [ \"default\" \"cloud\" ];"},{"line_number":11,"context_line":"}).overrideAttrs (_: {"},{"line_number":12,"context_line":"  meta.ci.targets \u003d [ \"integration-tests\" ];"},{"line_number":13,"context_line":"  passthru.integration-tests \u003d depot.tvix.crates.workspaceMembers.tvix-castore.build.override {"},{"line_number":14,"context_line":"    runTests \u003d true;"},{"line_number":15,"context_line":"    testPreRun \u003d \u0027\u0027"},{"line_number":16,"context_line":"      export SSL_CERT_FILE\u003d${pkgs.cacert}/etc/ssl/certs/ca-bundle.crt;"}],"source_content_type":"text/x-nix","patch_set":1,"id":"b8eb332d_6a1b364c","side":"PARENT","line":13,"in_reply_to":"94f3c35d_1d2a4cf0","updated":"2024-05-26 19:18:15.000000000","message":"Done","commit_id":"cf190ff30c5230d329b5e64553c7a87c9567d8fb"}]}