)]}'
{"id":"depot~1185","triplet_id":"depot~canon~Ida6a54b74f1ec635fec930db7e2a2aa039dd1443","project":"depot","branch":"canon","hashtags":[],"change_id":"Ida6a54b74f1ec635fec930db7e2a2aa039dd1443","subject":"fix(tools/perf-flamegraph): Get rid of most \u0027unknown\u0027s","status":"MERGED","created":"2020-07-16 00:35:21.000000000","updated":"2020-07-16 00:38:01.000000000","submitted":"2020-07-16 00:37:29.000000000","submitter":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1185","meta_rev_id":"423208266c9c7e54d0b2f9190a02d57aa2d64eee","_number":1185,"virtual_id_number":1185,"owner":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"tag":"autogenerated:gerrit:merged","value":2,"date":"2020-07-16 00:37:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2020-07-16 00:37:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"all":[{"value":0,"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"value":0,"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-16 00:36:24.000000000","updated_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"reviewer":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"state":"REVIEWER"},{"updated":"2020-07-16 00:37:04.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"882de71c60d8f817424dacb409ce30f413880053","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-07-16 00:35:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"81bb8a9a591a2514db9ff3cf0e85bb015395795e","author":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"},"date":"2020-07-16 00:36:24.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"03c989a2bbab04b5c7c1a3eb517567bb51e7d721","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-16 00:37:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/991","accounts_in_message":[],"_revision_number":1},{"id":"80eb27873bdd544ed964a7d1d1562a7a3a44ce3d","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"date":"2020-07-16 00:37:29.000000000","message":"Change has been successfully rebased and submitted as 1bd08e73cd053c526f60b49c6ba2f03b11271e1b by tazjin","accounts_in_message":[],"_revision_number":2},{"id":"423208266c9c7e54d0b2f9190a02d57aa2d64eee","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2020-07-16 00:38:01.000000000","message":"Patch Set 2:\n\nBuild of patchset 2 passed: https://buildkite.com/tvl/depot/builds/998","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1bd08e73cd053c526f60b49c6ba2f03b11271e1b","revisions":{"548c7b093616ea1616874686f8ddfd4affb6c6c8":{"kind":"REWORK","_number":1,"created":"2020-07-16 00:35:21.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/85/1185/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/85/1185/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/85/1185/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/85/1185/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/85/1185/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/85/1185/1"}}},"commit":{"parents":[{"commit":"de9f44466894e57fe31bf60620c036d927488434","subject":"refactor(3p/libstore): Optimise nix::printString","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003dde9f44466894e57fe31bf60620c036d927488434"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-07-16 00:33:53.000000000","tz":60},"committer":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-07-16 00:35:18.000000000","tz":60},"subject":"fix(tools/perf-flamegraph): Get rid of most \u0027unknown\u0027s","message":"fix(tools/perf-flamegraph): Get rid of most \u0027unknown\u0027s\n\nThis makes two main changes:\n\n1) It disables profiling of things that aren\u0027t part of the invoked\n   process (-a). This isn\u0027t particularly useful in most cases because\n   it will show things like Chrome\u0027s VP9 decoding while you\u0027re\n   profiling something else.\n\n2) It tells perf about the debug symbol format, which for some reason\n   isn\u0027t DWARF2 by default.\n\nChange-Id: Ida6a54b74f1ec635fec930db7e2a2aa039dd1443\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d548c7b093616ea1616874686f8ddfd4affb6c6c8"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d548c7b093616ea1616874686f8ddfd4affb6c6c8"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"de9f44466894e57fe31bf60620c036d927488434","is_merged_in_target_branch":false,"change_id":"I48bad90c8f2831ae4524c814a12b1982989922f9","change_number":1184,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"1bd08e73cd053c526f60b49c6ba2f03b11271e1b":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-07-16 00:37:29.000000000","uploader":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"},"ref":"refs/changes/85/1185/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/85/1185/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/85/1185/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/85/1185/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/85/1185/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/85/1185/2"}}},"commit":{"parents":[{"commit":"eff165425a1a225ac22427ec94b25da9ef6d6e04","subject":"refactor(3p/libstore): Optimise nix::printString","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003deff165425a1a225ac22427ec94b25da9ef6d6e04"}]}],"author":{"name":"Vincent Ambo","email":"mail@tazj.in","date":"2020-07-16 00:33:53.000000000","tz":60},"committer":{"name":"tazjin","email":"mail@tazj.in","date":"2020-07-16 00:37:29.000000000","tz":0},"subject":"fix(tools/perf-flamegraph): Get rid of most \u0027unknown\u0027s","message":"fix(tools/perf-flamegraph): Get rid of most \u0027unknown\u0027s\n\nThis makes two main changes:\n\n1) It disables profiling of things that aren\u0027t part of the invoked\n   process (-a). This isn\u0027t particularly useful in most cases because\n   it will show things like Chrome\u0027s VP9 decoding while you\u0027re\n   profiling something else.\n\n2) It tells perf about the debug symbol format, which for some reason\n   isn\u0027t DWARF2 by default.\n\nChange-Id: Ida6a54b74f1ec635fec930db7e2a2aa039dd1443\nReviewed-on: https://cl.tvl.fyi/c/depot/+/1185\nReviewed-by: glittershark \u003cgrfn@gws.fyi\u003e\nTested-by: BuildkiteCI\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1bd08e73cd053c526f60b49c6ba2f03b11271e1b"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d1bd08e73cd053c526f60b49c6ba2f03b11271e1b"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"eff165425a1a225ac22427ec94b25da9ef6d6e04","is_merged_in_target_branch":true,"change_id":"I48bad90c8f2831ae4524c814a12b1982989922f9","change_number":1184,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000001,"name":"tazjin","email":"tazjin@tvl.su","username":"tazjin"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000010,"name":"aspen","email":"root@gws.fyi","username":"aspen"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dCustom-Rule"],"failing_atoms":[]}}]}
