)]}'
{"id":"depot~11872","triplet_id":"depot~canon~I500b19dd9e4b7cc897d88b44547e7851559e5a4e","project":"depot","branch":"canon","attention_set":{},"removed_from_attention_set":{"1000085":{"account":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"last_update":"2024-06-25 22:36:13.000000000","reason":"removed on reply"},"1000036":{"account":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"last_update":"2024-06-26 04:51:31.000000000","reason":"Change was submitted"},"1000090":{"account":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"last_update":"2024-06-25 19:22:12.000000000","reason":"\u003cGERRIT_ACCOUNT_1000090\u003e replied on the change","reason_account":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"}},"1000110":{"account":{"_account_id":1000110,"name":"Simon Hauser","email":"simon.hauser@helsinki-systems.de","username":"conni2461"},"last_update":"2024-06-26 04:51:31.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I500b19dd9e4b7cc897d88b44547e7851559e5a4e","subject":"feat(tvix/glue): handle regular file at builtins.path import","status":"MERGED","created":"2024-06-25 18:32:23.000000000","updated":"2024-06-26 04:51:31.000000000","submitted":"2024-06-26 04:51:31.000000000","submitter":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"11877","meta_rev_id":"9d4afbcceec4a0dd24aafeb2033cd7a6624951af","_number":11872,"virtual_id_number":11872,"owner":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"all":[{"tag":"autogenerated:gerrit:merged","value":2,"date":"2024-06-26 04:51:31.000000000","_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-26 04:51:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"tag":"autogenerated:gerrit:merged","value":1,"date":"2024-06-26 04:51:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Autosubmit":{"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}],"values":{" 0":"Submit manually","+1":"Submit automatically"},"description":"","default_value":0,"optional":true},"All-Comments-Resolved":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]},"Conformant-Commit-Message":{"approved":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"all":[{"value":0,"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"value":0,"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"value":0,"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"value":0,"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}]}},"removable_reviewers":[{"_account_id":1000110,"name":"Simon Hauser","email":"simon.hauser@helsinki-systems.de","username":"conni2461"}],"reviewers":{"REVIEWER":[{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},{"_account_id":1000110,"name":"Simon Hauser","email":"simon.hauser@helsinki-systems.de","username":"conni2461"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-06-25 18:32:23.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"state":"REVIEWER"},{"updated":"2024-06-25 18:32:23.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000110,"name":"Simon Hauser","email":"simon.hauser@helsinki-systems.de","username":"conni2461"},"state":"REVIEWER"},{"updated":"2024-06-25 18:32:23.000000000","updated_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"reviewer":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"state":"REVIEWER"},{"updated":"2024-06-25 18:32:25.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2024-06-25 18:44:07.000000000","updated_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"reviewer":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7575bc8ed5e2d733c9bec316ec14376bed3c63b3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-06-25 18:32:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0d36d8ffa4e866346b3bd3429df83299a43e761e","tag":"autogenerated:buildkite~trigger","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-06-25 18:32:25.000000000","message":"Patch Set 1:\n\nStarted build for patchset #1 on: https://buildkite.com/tvl/depot/builds/34789","accounts_in_message":[],"_revision_number":1},{"id":"784cab830608e4356ca6a41f87c14c519d683140","tag":"autogenerated:buildkite~result","author":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]},"date":"2024-06-25 18:44:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild of patchset 1 passed: https://buildkite.com/tvl/depot/builds/34789","accounts_in_message":[],"_revision_number":1},{"id":"d61143f1668248be040cb2ae295d5661fa384ba3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-06-25 18:51:15.000000000","message":"Uploaded patch set 2: New patch set was added with same tree, parent tree, and commit message as Patch Set 1.\n\nCopied Votes:\n* Verified+1 (copy condition: \"(**is:ANY** AND **changekind:NO_CODE_CHANGE**) OR **changekind:NO_CHANGE**\")\n","accounts_in_message":[],"_revision_number":2},{"id":"bbe23394b0571f466306cec5de4c06c8d86c2beb","author":{"_account_id":1000090,"name":"Ilan Joselevich","email":"personal@ilanjoselevich.com","username":"kranzes"},"date":"2024-06-25 19:22:12.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"bce8fc802cbb385580555872df923d04cae7572d","author":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"},"date":"2024-06-25 22:36:13.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"9d4afbcceec4a0dd24aafeb2033cd7a6624951af","tag":"autogenerated:gerrit:merged","author":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"date":"2024-06-26 04:51:31.000000000","message":"Change has been successfully rebased and submitted as 78eb22c54d304715f527fa0e350f8056a3a354cf","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"78eb22c54d304715f527fa0e350f8056a3a354cf","revisions":{"8fda717e79351ec7b48e3dc6ddaaecb2be6a603c":{"kind":"REWORK","_number":1,"created":"2024-06-25 18:32:23.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/72/11872/1","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/72/11872/1","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/72/11872/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/72/11872/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/72/11872/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/72/11872/1"}}},"commit":{"parents":[{"commit":"81775eb47575e6075e10a289938adc8ad83b8a09","subject":"feat(tvix/eval): add file_type method","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d81775eb47575e6075e10a289938adc8ad83b8a09"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-06-25 16:40:55.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-06-25 18:32:00.000000000","tz":180},"subject":"feat(tvix/glue): handle regular file at builtins.path import","message":"feat(tvix/glue): handle regular file at builtins.path import\n\nIf builtins.path is passed a regular file, no filtering is applied.\nWe use the just-introduced file_type function in the EvalIO trait for\nthat.\n\nThis means, we don\u0027t need to pass through filtered_ingest, and can\nassemble the FileNode directly in that specific match case.\n\nThis also means, we can explicitly calculate the sha256 flat digest,\nand avoid having to pipe through the file contents again (via\nblob_to_sha256_hash) to construct the sha256 digest.\n\nChange-Id: I500b19dd9e4b7cc897d88b44547e7851559e5a4e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8fda717e79351ec7b48e3dc6ddaaecb2be6a603c"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d8fda717e79351ec7b48e3dc6ddaaecb2be6a603c"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"81775eb47575e6075e10a289938adc8ad83b8a09","is_merged_in_target_branch":false,"change_id":"Ib002da3194a3546ca286de49aac8d1022ec5560f","change_number":11871,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"3010c666ad2fe9ba4db08660486b32b923ac1a9d":{"kind":"NO_CHANGE","_number":2,"created":"2024-06-25 18:51:15.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/72/11872/2","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/72/11872/2","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/72/11872/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/72/11872/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/72/11872/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/72/11872/2"}}},"commit":{"parents":[{"commit":"81775eb47575e6075e10a289938adc8ad83b8a09","subject":"feat(tvix/eval): add file_type method","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d81775eb47575e6075e10a289938adc8ad83b8a09"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-06-25 16:40:55.000000000","tz":180},"committer":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-06-25 18:32:56.000000000","tz":180},"subject":"feat(tvix/glue): handle regular file at builtins.path import","message":"feat(tvix/glue): handle regular file at builtins.path import\n\nIf builtins.path is passed a regular file, no filtering is applied.\nWe use the just-introduced file_type function in the EvalIO trait for\nthat.\n\nThis means, we don\u0027t need to pass through filtered_ingest, and can\nassemble the FileNode directly in that specific match case.\n\nThis also means, we can explicitly calculate the sha256 flat digest,\nand avoid having to pipe through the file contents again (via\nblob_to_sha256_hash) to construct the sha256 digest.\n\nChange-Id: I500b19dd9e4b7cc897d88b44547e7851559e5a4e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3010c666ad2fe9ba4db08660486b32b923ac1a9d"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d3010c666ad2fe9ba4db08660486b32b923ac1a9d"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"81775eb47575e6075e10a289938adc8ad83b8a09","is_merged_in_target_branch":false,"change_id":"Ib002da3194a3546ca286de49aac8d1022ec5560f","change_number":11871,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/canon"},"78eb22c54d304715f527fa0e350f8056a3a354cf":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2024-06-26 04:51:31.000000000","uploader":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"},"ref":"refs/changes/72/11872/3","fetch":{"anonymous http":{"url":"https://cl.tvl.fyi/depot","ref":"refs/changes/72/11872/3","commands":{"Checkout":"git fetch https://cl.tvl.fyi/depot refs/changes/72/11872/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://cl.tvl.fyi/depot refs/changes/72/11872/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://cl.tvl.fyi/depot refs/changes/72/11872/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://cl.tvl.fyi/depot refs/changes/72/11872/3"}}},"commit":{"parents":[{"commit":"080654aaf9bd2f94d634008afd1dc26c74752eec","subject":"feat(tvix/eval): add file_type method","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d080654aaf9bd2f94d634008afd1dc26c74752eec"}]}],"author":{"name":"Florian Klink","email":"flokli@flokli.de","date":"2024-06-25 16:40:55.000000000","tz":180},"committer":{"name":"flokli","email":"flokli@flokli.de","date":"2024-06-26 04:51:31.000000000","tz":0},"subject":"feat(tvix/glue): handle regular file at builtins.path import","message":"feat(tvix/glue): handle regular file at builtins.path import\n\nIf builtins.path is passed a regular file, no filtering is applied.\nWe use the just-introduced file_type function in the EvalIO trait for\nthat.\n\nThis means, we don\u0027t need to pass through filtered_ingest, and can\nassemble the FileNode directly in that specific match case.\n\nThis also means, we can explicitly calculate the sha256 flat digest,\nand avoid having to pipe through the file contents again (via\nblob_to_sha256_hash) to construct the sha256 digest.\n\nChange-Id: I500b19dd9e4b7cc897d88b44547e7851559e5a4e\nReviewed-on: https://cl.tvl.fyi/c/depot/+/11872\nTested-by: BuildkiteCI\nReviewed-by: Ilan Joselevich \u003cpersonal@ilanjoselevich.com\u003e\nReviewed-by: Connor Brewster \u003ccbrewster@hey.com\u003e\n","web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d78eb22c54d304715f527fa0e350f8056a3a354cf"}],"resolve_conflicts_web_links":[{"name":"cgit","tooltip":"Open in GitWeb","url":"https://code.tvl.fyi/commit/?id\u003d78eb22c54d304715f527fa0e350f8056a3a354cf"}]},"parents_data":[{"branch_name":"refs/heads/canon","commit_id":"080654aaf9bd2f94d634008afd1dc26c74752eec","is_merged_in_target_branch":true,"change_id":"Ib002da3194a3546ca286de49aac8d1022ec5560f","change_number":11871,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/canon","description":"Rebase"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~PrologRule","status":"CLOSED","labels":[{"label":"Autosubmit","status":"MAY"},{"label":"Conformant-Commit-Message","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"All-Comments-Resolved","status":"OK","applied_by":{"_account_id":1000036,"name":"flokli","email":"flokli@flokli.de","username":"flokli"}},{"label":"Verified","status":"OK","applied_by":{"_account_id":1000014,"name":"BuildkiteCI","username":"buildkite","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1000085,"name":"Connor Brewster","display_name":"cbrewster","email":"cbrewster@hey.com","username":"cbrewster"}}]},{"rule_name":"Code-Owners","status":"CLOSED"}],"submit_requirements":[{"name":"All-Comments-Resolved","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:All-Comments-Resolved\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:All-Comments-Resolved\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Owners","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"rule:Code-Owners","fulfilled":true,"status":"PASS","passing_atoms":["Code-Owners"],"failing_atoms":[]}},{"name":"Conformant-Commit-Message","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Conformant-Commit-Message\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Conformant-Commit-Message\u003dgerrit~PrologRule"],"failing_atoms":[]}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dgerrit~PrologRule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dgerrit~PrologRule"],"failing_atoms":[]}}]}
